)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"829b290170aa8da4f2290cc531d276388a9e5006","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DNM: Remove PING type from HM options list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PING is a trap. There is no real-world scenario where PING is the option"},{"line_number":10,"context_line":"that makes the most sense, but people are familiar with it, and it seems"},{"line_number":11,"context_line":"\"simple\", so they pick it. This needs to stop."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_1053f66c","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":47},"updated":"2017-12-19 10:40:24.000000000","message":"You may be right, but I think there are still vendors[1] that support such type of health monitor.\n\n[1] https://support.f5.com/kb/en-us/products/big-ip_gtm/manuals/product/gtm-monitors-reference-11-2-0/3.html","commit_id":"626ddd541b1bd73124e1b419bbb9c7cf178bb13a"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"fd015f41116709fbb8c0c429c87ee581ea02d63e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DNM: Remove PING type from HM options list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PING is a trap. There is no real-world scenario where PING is the option"},{"line_number":10,"context_line":"that makes the most sense, but people are familiar with it, and it seems"},{"line_number":11,"context_line":"\"simple\", so they pick it. This needs to stop."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf8cb3f7_f1ba8edc","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":47},"in_reply_to":"df87a7cf_1053f66c","updated":"2017-12-21 20:27:11.000000000","message":"Even if they support them (heck, *we* support them) doesn\u0027t mean they\u0027re a good idea.","commit_id":"626ddd541b1bd73124e1b419bbb9c7cf178bb13a"}],"octavia/tests/functional/api/v2/test_health_monitor.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bbcf8ca08cae8ddacfe0a3f75a29698891a656f6","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            1, 1, 1, 1).get(self.root_tag)"},{"line_number":193,"context_line":"        self.set_lb_status(lb1_id)"},{"line_number":194,"context_line":"        hm2 \u003d self.create_health_monitor("},{"line_number":195,"context_line":"            pool2.get(\u0027id\u0027), constants.HEALTH_MONITOR_TCP,"},{"line_number":196,"context_line":"            1, 1, 1, 1).get(self.root_tag)"},{"line_number":197,"context_line":"        self.set_lb_status(lb1_id)"},{"line_number":198,"context_line":"        hm3 \u003d self.create_health_monitor("}],"source_content_type":"text/x-python","patch_set":16,"id":"bf659307_6042916a","line":195,"updated":"2018-04-12 15:36:10.000000000","message":"Why did you change these? It\u0027s a functional test and PING is enabled by default.\nThis just seems opinionated and unnecessary change.","commit_id":"74b53c7c0d22d61be8c67cdbae75fd7365bd8750"}],"octavia/tests/functional/api/v2/test_load_balancer.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bbcf8ca08cae8ddacfe0a3f75a29698891a656f6","unresolved":false,"context_lines":[{"line_number":2019,"context_line":""},{"line_number":2020,"context_line":"    def _get_hm_bodies(self):"},{"line_number":2021,"context_line":"        create_hm \u003d {"},{"line_number":2022,"context_line":"            \u0027type\u0027: constants.HEALTH_MONITOR_TCP,"},{"line_number":2023,"context_line":"            \u0027delay\u0027: 1,"},{"line_number":2024,"context_line":"            \u0027timeout\u0027: 1,"},{"line_number":2025,"context_line":"            \u0027max_retries_down\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":16,"id":"bf659307_6037f1ff","line":2022,"updated":"2018-04-12 15:36:10.000000000","message":"Why?","commit_id":"74b53c7c0d22d61be8c67cdbae75fd7365bd8750"}],"releasenotes/notes/allow-operators-to-disable-ping-healthchecks-42fd8c3b88edaf35.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bbcf8ca08cae8ddacfe0a3f75a29698891a656f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Cloud deployers can set `api_settings.allow_ping_health_monitors \u003d False`"},{"line_number":5,"context_line":"    in `octavia.conf` to disable the ability to create PING health monitors."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bf659307_00f7155b","line":2,"updated":"2018-04-12 15:36:10.000000000","message":"nit: This is a feature","commit_id":"74b53c7c0d22d61be8c67cdbae75fd7365bd8750"}]}
