)]}'
{"elements/keepalived-octavia/post-install.d/20-keepalived-lvs-tune-kernel":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"62d6b3ac0be7be675f9f36ca1544895951e536d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"5f7c97a3_1c05397a","updated":"2018-07-06 23:34:34.000000000","message":"We really only want these settings in the amphora-haproxy namespace. I think we should add them in a different location.\nWe would add the lines after this one:\nhttps://github.com/openstack/octavia/blob/master/octavia/amphorae/backends/agent/api_server/templates/amphora-netns.systemd.j2#L12\nand after this:\nhttps://github.com/openstack/octavia/blob/master/octavia/amphorae/backends/agent/api_server/plug.py#L126","commit_id":"2243f0f305e5e884f0b9dc562e2e4a2adbf42d15"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"c63ead7d9961a73499fc1cddfd1ed524a7a64862","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"5f7c97a3_20823f00","in_reply_to":"5f7c97a3_1c05397a","updated":"2018-07-09 02:46:51.000000000","message":"Oh, that\u0027s right. Michael, thanks for this suggest. It\u0027s much easier that current one.","commit_id":"2243f0f305e5e884f0b9dc562e2e4a2adbf42d15"}],"octavia/amphorae/backends/agent/agent_jinja_cfg.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cbdff5dbed44a60d456c05e2c8e9cac047380e83","unresolved":false,"context_lines":[{"line_number":61,"context_line":"             \u0027use_upstart\u0027: CONF.haproxy_amphora.use_upstart,"},{"line_number":62,"context_line":"             \u0027respawn_count\u0027: CONF.haproxy_amphora.respawn_count,"},{"line_number":63,"context_line":"             \u0027respawn_interval\u0027: CONF.haproxy_amphora.respawn_interval,"},{"line_number":64,"context_line":"             \u0027extend_configurations\u0027: utils.get_all_amp_agent_ext_conf()})"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_c8e71612","line":64,"range":{"start_line":64,"start_character":14,"end_line":64,"end_character":35},"updated":"2018-05-11 23:11:23.000000000","message":"I would prefer we just add the \"amphora_udp_driver\" directly here.  Having a generic \"extend_configurations\" makes the code harder to read.  It is ok to pass in None.","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"22f377361c3bb357c8770ff42fc8dace7edf6da7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"             \u0027use_upstart\u0027: CONF.haproxy_amphora.use_upstart,"},{"line_number":62,"context_line":"             \u0027respawn_count\u0027: CONF.haproxy_amphora.respawn_count,"},{"line_number":63,"context_line":"             \u0027respawn_interval\u0027: CONF.haproxy_amphora.respawn_interval,"},{"line_number":64,"context_line":"             \u0027extend_configurations\u0027: utils.get_all_amp_agent_ext_conf()})"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_1929d4e4","line":64,"range":{"start_line":64,"start_character":14,"end_line":64,"end_character":35},"in_reply_to":"5f7c97a3_c8e71612","updated":"2018-05-14 11:10:06.000000000","message":"Yeah, but I remember the reason why I introduced \u0027extend_configurations\u0027 here, I found the haproxy part registered the configure option like cfg.controller_worker.amphora_driver . Towards udp agent driver, they look like be in the same configuration namespace, but there is no named \u0027controller_worker\u0027 title in current agent_jinja_template. The most options are from \u0027amphora_agent\u0027 ,\u0027haproxy_amphora\u0027 and \u0027health_manager\u0027, all of them are not suitable for this option, as the agent side need to load the udp driver through the defined configuration namespace, so that\u0027s why I introduce a generic option for meeting.","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"}],"octavia/amphorae/backends/agent/api_server/keepalivedlvs.py":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import logging"},{"line_number":2,"context_line":"import os"},{"line_number":3,"context_line":"import stat"},{"line_number":4,"context_line":"import subprocess"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_4e9aa814","line":1,"updated":"2018-01-26 07:11:16.000000000","message":"H102  Apache 2.0 license header not found","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import logging"},{"line_number":2,"context_line":"import os"},{"line_number":3,"context_line":"import stat"},{"line_number":4,"context_line":"import subprocess"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_0cd10855","line":1,"in_reply_to":"5f93b717_4e9aa814","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":4,"context_line":"import subprocess"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"import hashlib"},{"line_number":8,"context_line":"import flask"},{"line_number":9,"context_line":"import jinja2"},{"line_number":10,"context_line":"import webob"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_0ea4a056","line":7,"updated":"2018-01-26 07:11:16.000000000","message":"F401 \u0027hashlib\u0027 imported but unused","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":4,"context_line":"import subprocess"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"import hashlib"},{"line_number":8,"context_line":"import flask"},{"line_number":9,"context_line":"import jinja2"},{"line_number":10,"context_line":"import webob"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_acc57490","line":7,"in_reply_to":"5f93b717_0ea4a056","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"import hashlib"},{"line_number":8,"context_line":"import flask"},{"line_number":9,"context_line":"import jinja2"},{"line_number":10,"context_line":"import webob"},{"line_number":11,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ae880cc6","line":8,"updated":"2018-01-26 07:11:16.000000000","message":"H306  imports not in alphabetical order (hashlib, flask)\nI201 Missing newline before sections or imports.","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"import hashlib"},{"line_number":8,"context_line":"import flask"},{"line_number":9,"context_line":"import jinja2"},{"line_number":10,"context_line":"import webob"},{"line_number":11,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_6cbf6cfb","line":8,"in_reply_to":"5f93b717_ae880cc6","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":8,"context_line":"import flask"},{"line_number":9,"context_line":"import jinja2"},{"line_number":10,"context_line":"import webob"},{"line_number":11,"context_line":"import six"},{"line_number":12,"context_line":"import re"},{"line_number":13,"context_line":"from werkzeug import exceptions"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_4ec388ee","line":11,"updated":"2018-01-26 07:11:16.000000000","message":"F401 \u0027six\u0027 imported but unused","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":8,"context_line":"import flask"},{"line_number":9,"context_line":"import jinja2"},{"line_number":10,"context_line":"import webob"},{"line_number":11,"context_line":"import six"},{"line_number":12,"context_line":"import re"},{"line_number":13,"context_line":"from werkzeug import exceptions"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_8cbc3806","line":11,"in_reply_to":"5f93b717_4ec388ee","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":9,"context_line":"import jinja2"},{"line_number":10,"context_line":"import webob"},{"line_number":11,"context_line":"import six"},{"line_number":12,"context_line":"import re"},{"line_number":13,"context_line":"from werkzeug import exceptions"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from octavia.amphorae.backends.agent.api_server import listener"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_8ea8b01f","line":12,"updated":"2018-01-26 07:11:16.000000000","message":"H306  imports not in alphabetical order (webob, six)\nH306  imports not in alphabetical order (six, re)\nI100 Import statements are in the wrong order. import re should be before import six\nI201 Missing newline before sections or imports.","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":9,"context_line":"import jinja2"},{"line_number":10,"context_line":"import webob"},{"line_number":11,"context_line":"import six"},{"line_number":12,"context_line":"import re"},{"line_number":13,"context_line":"from werkzeug import exceptions"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from octavia.amphorae.backends.agent.api_server import listener"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_2c3724b3","line":12,"in_reply_to":"5f93b717_8ea8b01f","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":10,"context_line":"import webob"},{"line_number":11,"context_line":"import six"},{"line_number":12,"context_line":"import re"},{"line_number":13,"context_line":"from werkzeug import exceptions"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from octavia.amphorae.backends.agent.api_server import listener"},{"line_number":16,"context_line":"from octavia.amphorae.backends.agent.api_server import util"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_4e6868f4","line":13,"updated":"2018-01-26 07:11:16.000000000","message":"I201 Missing newline before sections or imports.","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":10,"context_line":"import webob"},{"line_number":11,"context_line":"import six"},{"line_number":12,"context_line":"import re"},{"line_number":13,"context_line":"from werkzeug import exceptions"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from octavia.amphorae.backends.agent.api_server import listener"},{"line_number":16,"context_line":"from octavia.amphorae.backends.agent.api_server import util"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_4c3cf092","line":13,"in_reply_to":"5f93b717_4e6868f4","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":29,"context_line":"SYSTEMD_TEMPLATE \u003d j2_env.get_template(consts.KEEPALIVED_JINJA2_SYSTEMD)"},{"line_number":30,"context_line":"check_script_file_template \u003d j2_env.get_template("},{"line_number":31,"context_line":"    consts.KEEPALIVED_CHECK_SCRIPT)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class KeepalivedLvs(object):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def upload_keepalived_config(self, listener_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_0e7260e6","line":32,"updated":"2018-01-26 07:11:16.000000000","message":"E302 expected 2 blank lines, found 1","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":29,"context_line":"SYSTEMD_TEMPLATE \u003d j2_env.get_template(consts.KEEPALIVED_JINJA2_SYSTEMD)"},{"line_number":30,"context_line":"check_script_file_template \u003d j2_env.get_template("},{"line_number":31,"context_line":"    consts.KEEPALIVED_CHECK_SCRIPT)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class KeepalivedLvs(object):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def upload_keepalived_config(self, listener_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_cc47a01d","line":32,"in_reply_to":"5f93b717_0e7260e6","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        if not os.path.exists(util.keepalived_lvs_dir()):"},{"line_number":39,"context_line":"            os.makedirs(util.keepalived_lvs_dir())"},{"line_number":40,"context_line":"        if not os.path.exists(util.keepalived_check_scripts_dir()):"},{"line_number":41,"context_line":"            NEED_CHECK \u003d False"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        conf_file \u003d util.keepalived_lvs_cfg_path(listener_id)"},{"line_number":44,"context_line":"        flags \u003d os.O_WRONLY | os.O_CREAT | os.O_TRUNC"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ce7318e7","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":30},"updated":"2018-01-26 07:11:16.000000000","message":"F841 local variable \u0027NEED_CHECK\u0027 is assigned to but never used","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        if not os.path.exists(util.keepalived_lvs_dir()):"},{"line_number":39,"context_line":"            os.makedirs(util.keepalived_lvs_dir())"},{"line_number":40,"context_line":"        if not os.path.exists(util.keepalived_check_scripts_dir()):"},{"line_number":41,"context_line":"            NEED_CHECK \u003d False"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        conf_file \u003d util.keepalived_lvs_cfg_path(listener_id)"},{"line_number":44,"context_line":"        flags \u003d os.O_WRONLY | os.O_CREAT | os.O_TRUNC"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_2c6084a5","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":30},"in_reply_to":"5f93b717_ce7318e7","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        with open(util.keepalived_lvs_cfg_path(listener_id), \u0027r\u0027) as file:"},{"line_number":139,"context_line":"            cfg \u003d file.read()"},{"line_number":140,"context_line":"            resp \u003d webob.Response(cfg, content_type\u003d\u0027text/plain\u0027)"},{"line_number":141,"context_line":"##            resp.headers[\u0027ETag\u0027] \u003d hashlib.md5(six.b(cfg)).hexdigest()  # nosec"},{"line_number":142,"context_line":"            return resp"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def manage_keepalivedlvs_listener(self, listener_id, action):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_2e4cfc9c","line":141,"updated":"2018-01-26 07:11:16.000000000","message":"E266 too many leading \u0027#\u0027 for block comment\nE501 line too long (81 \u003e 79 characters)","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        with open(util.keepalived_lvs_cfg_path(listener_id), \u0027r\u0027) as file:"},{"line_number":139,"context_line":"            cfg \u003d file.read()"},{"line_number":140,"context_line":"            resp \u003d webob.Response(cfg, content_type\u003d\u0027text/plain\u0027)"},{"line_number":141,"context_line":"##            resp.headers[\u0027ETag\u0027] \u003d hashlib.md5(six.b(cfg)).hexdigest()  # nosec"},{"line_number":142,"context_line":"            return resp"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def manage_keepalivedlvs_listener(self, listener_id, action):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_0c5fc8e2","line":141,"in_reply_to":"5f93b717_2e4cfc9c","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self._check_udp_listener_exists(listener_id)"},{"line_number":154,"context_line":"        cmd \u003d (\"/usr/sbin/service \""},{"line_number":155,"context_line":"               \"octavia-keepalivedlvs-{listener_id} {action}\".format("},{"line_number":156,"context_line":"            listener_id\u003dlistener_id, action\u003daction))"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        try:"},{"line_number":159,"context_line":"            subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ee45b471","line":156,"range":{"start_line":156,"start_character":12,"end_line":156,"end_character":52},"updated":"2018-01-26 07:11:16.000000000","message":"E122 continuation line missing indentation or outdented","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self._check_udp_listener_exists(listener_id)"},{"line_number":154,"context_line":"        cmd \u003d (\"/usr/sbin/service \""},{"line_number":155,"context_line":"               \"octavia-keepalivedlvs-{listener_id} {action}\".format("},{"line_number":156,"context_line":"            listener_id\u003dlistener_id, action\u003daction))"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        try:"},{"line_number":159,"context_line":"            subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ac733480","line":156,"range":{"start_line":156,"start_character":12,"end_line":156,"end_character":52},"in_reply_to":"5f93b717_ee45b471","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        listeners \u003d list()"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        for listener in util.get_udp_listeners():"},{"line_number":203,"context_line":"            status \u003d self._check_udp_listener_status(listener)"},{"line_number":204,"context_line":"            listeners.append({"},{"line_number":205,"context_line":"                \u0027status\u0027: status,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ae5fac3f","line":202,"range":{"start_line":202,"start_character":8,"end_line":202,"end_character":49},"updated":"2018-01-26 07:11:16.000000000","message":"F402 import \u0027listener\u0027 from line 15 shadowed by loop variable","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        listeners \u003d list()"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        for listener in util.get_udp_listeners():"},{"line_number":203,"context_line":"            status \u003d self._check_udp_listener_status(listener)"},{"line_number":204,"context_line":"            listeners.append({"},{"line_number":205,"context_line":"                \u0027status\u0027: status,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_2c05e4c2","line":202,"range":{"start_line":202,"start_character":8,"end_line":202,"end_character":49},"in_reply_to":"5f93b717_ae5fac3f","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                member_list.append("},{"line_number":251,"context_line":"                    {ip_port[0] + \u0027:\u0027 + ip_port[1]: \u0027no check\u0027})"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        pool \u003d {\u0027UDP-Listener-%s-pool\u0027% listener_id:"},{"line_number":254,"context_line":"                     {"},{"line_number":255,"context_line":"                         \u0027status\u0027: \u0027UP\u0027,"},{"line_number":256,"context_line":"                         \u0027members\u0027: member_list"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ce5c784d","line":253,"range":{"start_line":253,"start_character":38,"end_line":253,"end_character":39},"updated":"2018-01-26 07:11:16.000000000","message":"E225 missing whitespace around operator","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                member_list.append("},{"line_number":251,"context_line":"                    {ip_port[0] + \u0027:\u0027 + ip_port[1]: \u0027no check\u0027})"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        pool \u003d {\u0027UDP-Listener-%s-pool\u0027% listener_id:"},{"line_number":254,"context_line":"                     {"},{"line_number":255,"context_line":"                         \u0027status\u0027: \u0027UP\u0027,"},{"line_number":256,"context_line":"                         \u0027members\u0027: member_list"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_4c0ab0d2","line":253,"range":{"start_line":253,"start_character":38,"end_line":253,"end_character":39},"in_reply_to":"5f93b717_ce5c784d","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                    {ip_port[0] + \u0027:\u0027 + ip_port[1]: \u0027no check\u0027})"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        pool \u003d {\u0027UDP-Listener-%s-pool\u0027% listener_id:"},{"line_number":254,"context_line":"                     {"},{"line_number":255,"context_line":"                         \u0027status\u0027: \u0027UP\u0027,"},{"line_number":256,"context_line":"                         \u0027members\u0027: member_list"},{"line_number":257,"context_line":"                     }"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_2e315c0c","line":254,"range":{"start_line":254,"start_character":16,"end_line":254,"end_character":21},"updated":"2018-01-26 07:11:16.000000000","message":"E127 continuation line over-indented for visual indent","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                    {ip_port[0] + \u0027:\u0027 + ip_port[1]: \u0027no check\u0027})"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        pool \u003d {\u0027UDP-Listener-%s-pool\u0027% listener_id:"},{"line_number":254,"context_line":"                     {"},{"line_number":255,"context_line":"                         \u0027status\u0027: \u0027UP\u0027,"},{"line_number":256,"context_line":"                         \u0027members\u0027: member_list"},{"line_number":257,"context_line":"                     }"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ec0e1ce4","line":254,"range":{"start_line":254,"start_character":16,"end_line":254,"end_character":21},"in_reply_to":"5f93b717_2e315c0c","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                         \u0027status\u0027: \u0027UP\u0027,"},{"line_number":256,"context_line":"                         \u0027members\u0027: member_list"},{"line_number":257,"context_line":"                     }"},{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":"        stats[\u0027pools\u0027] \u003d list(pool)"},{"line_number":260,"context_line":"        return webob.Response(json\u003dstats)"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ee3a94e5","line":258,"range":{"start_line":258,"start_character":7,"end_line":258,"end_character":9},"updated":"2018-01-26 07:11:16.000000000","message":"E124 closing bracket does not match visual indentation","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                         \u0027status\u0027: \u0027UP\u0027,"},{"line_number":256,"context_line":"                         \u0027members\u0027: member_list"},{"line_number":257,"context_line":"                     }"},{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":"        stats[\u0027pools\u0027] \u003d list(pool)"},{"line_number":260,"context_line":"        return webob.Response(json\u003dstats)"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_acf814c4","line":258,"range":{"start_line":258,"start_character":7,"end_line":258,"end_character":9},"in_reply_to":"5f93b717_ee3a94e5","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        if os.path.exists(keepalived_pid) and os.path.exists("},{"line_number":272,"context_line":"                os.path.join(\u0027/proc\u0027,"},{"line_number":273,"context_line":"                             util.get_keepalivedlvs_pid(listener_id))):"},{"line_number":274,"context_line":"            cmd \u003d \"/usr/sbin/service \" \\"},{"line_number":275,"context_line":"                  \"octavia-keepalivedlvs-{0} stop\".format(listener_id)"},{"line_number":276,"context_line":"            try:"},{"line_number":277,"context_line":"                subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ce21d8b6","line":274,"range":{"start_line":274,"start_character":11,"end_line":274,"end_character":40},"updated":"2018-01-26 07:11:16.000000000","message":"O346 Backslash line continuations not allowed","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        if os.path.exists(keepalived_pid) and os.path.exists("},{"line_number":272,"context_line":"                os.path.join(\u0027/proc\u0027,"},{"line_number":273,"context_line":"                             util.get_keepalivedlvs_pid(listener_id))):"},{"line_number":274,"context_line":"            cmd \u003d \"/usr/sbin/service \" \\"},{"line_number":275,"context_line":"                  \"octavia-keepalivedlvs-{0} stop\".format(listener_id)"},{"line_number":276,"context_line":"            try:"},{"line_number":277,"context_line":"                subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_6c020cb7","line":274,"range":{"start_line":274,"start_character":11,"end_line":274,"end_character":40},"in_reply_to":"5f93b717_ce21d8b6","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        init_path \u003d util.keepalived_lvs_init_path(listener_id, init_system)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if init_system \u003d\u003d consts.INIT_SYSTEMD:"},{"line_number":298,"context_line":"            init_disable_cmd \u003d \"systemctl disable \" \\"},{"line_number":299,"context_line":"                               \"octavia-keepalivedlvs-{list}\".format("},{"line_number":300,"context_line":"                list\u003dlistener_id)"},{"line_number":301,"context_line":"        elif init_system \u003d\u003d consts.INIT_SYSVINIT:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_8e2bd092","line":298,"range":{"start_line":298,"start_character":12,"end_line":298,"end_character":53},"updated":"2018-01-26 07:11:16.000000000","message":"O346 Backslash line continuations not allowed","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        init_path \u003d util.keepalived_lvs_init_path(listener_id, init_system)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if init_system \u003d\u003d consts.INIT_SYSTEMD:"},{"line_number":298,"context_line":"            init_disable_cmd \u003d \"systemctl disable \" \\"},{"line_number":299,"context_line":"                               \"octavia-keepalivedlvs-{list}\".format("},{"line_number":300,"context_line":"                list\u003dlistener_id)"},{"line_number":301,"context_line":"        elif init_system \u003d\u003d consts.INIT_SYSVINIT:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_8cff58a9","line":298,"range":{"start_line":298,"start_character":12,"end_line":298,"end_character":53},"in_reply_to":"5f93b717_8e2bd092","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        if init_system \u003d\u003d consts.INIT_SYSTEMD:"},{"line_number":298,"context_line":"            init_disable_cmd \u003d \"systemctl disable \" \\"},{"line_number":299,"context_line":"                               \"octavia-keepalivedlvs-{list}\".format("},{"line_number":300,"context_line":"                list\u003dlistener_id)"},{"line_number":301,"context_line":"        elif init_system \u003d\u003d consts.INIT_SYSVINIT:"},{"line_number":302,"context_line":"            init_disable_cmd \u003d \"insserv -r {file}\".format(file\u003dinit_path)"},{"line_number":303,"context_line":"        elif init_system !\u003d consts.INIT_UPSTART:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_0e190084","line":300,"range":{"start_line":300,"start_character":8,"end_line":300,"end_character":16},"updated":"2018-01-26 07:11:16.000000000","message":"E122 continuation line missing indentation or outdented","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        if init_system \u003d\u003d consts.INIT_SYSTEMD:"},{"line_number":298,"context_line":"            init_disable_cmd \u003d \"systemctl disable \" \\"},{"line_number":299,"context_line":"                               \"octavia-keepalivedlvs-{list}\".format("},{"line_number":300,"context_line":"                list\u003dlistener_id)"},{"line_number":301,"context_line":"        elif init_system \u003d\u003d consts.INIT_SYSVINIT:"},{"line_number":302,"context_line":"            init_disable_cmd \u003d \"insserv -r {file}\".format(file\u003dinit_path)"},{"line_number":303,"context_line":"        elif init_system !\u003d consts.INIT_UPSTART:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_2c2e4443","line":300,"range":{"start_line":300,"start_character":8,"end_line":300,"end_character":16},"in_reply_to":"5f93b717_0e190084","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                return webob.Response(json\u003ddict("},{"line_number":315,"context_line":"                    message\u003d\"Error disabling \""},{"line_number":316,"context_line":"                            \"octavia-keepalivedlvs-{0} service\".format("},{"line_number":317,"context_line":"                        listener_id), details\u003de.output), status\u003d500)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        # delete init script ,config file and log file for that listener"},{"line_number":320,"context_line":"        if os.path.exists(init_path):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ae0d6c3f","line":317,"range":{"start_line":317,"start_character":16,"end_line":317,"end_character":24},"updated":"2018-01-26 07:11:16.000000000","message":"E122 continuation line missing indentation or outdented","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                return webob.Response(json\u003ddict("},{"line_number":315,"context_line":"                    message\u003d\"Error disabling \""},{"line_number":316,"context_line":"                            \"octavia-keepalivedlvs-{0} service\".format("},{"line_number":317,"context_line":"                        listener_id), details\u003de.output), status\u003d500)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        # delete init script ,config file and log file for that listener"},{"line_number":320,"context_line":"        if os.path.exists(init_path):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_4c3390ac","line":317,"range":{"start_line":317,"start_character":16,"end_line":317,"end_character":24},"in_reply_to":"5f93b717_ae0d6c3f","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cbdff5dbed44a60d456c05e2c8e9cac047380e83","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            os.makedirs(util.keepalived_backend_check_script_dir())"},{"line_number":60,"context_line":"            script_dir \u003d os.path.abspath(\u0027./octavia/amphorae/\u0027"},{"line_number":61,"context_line":"                                         \u0027backends/utils/\u0027)"},{"line_number":62,"context_line":"            shutil.copy2(os.path.join(script_dir, \u0027udp_check.sh\u0027),"},{"line_number":63,"context_line":"                         util.keepalived_backend_check_script_path())"},{"line_number":64,"context_line":"            os.chmod(util.keepalived_backend_check_script_path(), stat.S_IEXEC)"},{"line_number":65,"context_line":"        # Based on current topology setting, only the amphora instances in"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_ab709409","line":62,"updated":"2018-05-11 23:11:23.000000000","message":"This fails for me.\n[2018-05-11 23:08:44,096] ERROR in app: Exception on /0.5/listeners/94bc479b-ccec-45ac-ae0d-e5050756736d/3856c981-0b0f-488c-855c-54022c42717e/udp_listener [PUT]\nTraceback (most recent call last):\n  File \"/opt/amphora-agent-venv/lib/python3.5/site-packages/flask/app.py\", line 1982, in wsgi_app\n    response \u003d self.full_dispatch_request()\n  File \"/opt/amphora-agent-venv/lib/python3.5/site-packages/flask/app.py\", line 1614, in full_dispatch_request\n    rv \u003d self.handle_user_exception(e)\n  File \"/opt/amphora-agent-venv/lib/python3.5/site-packages/flask/app.py\", line 1517, in handle_user_exception\n    reraise(exc_type, exc_value, tb)\n  File \"/opt/amphora-agent-venv/lib/python3.5/site-packages/flask/_compat.py\", line 33, in reraise\n    raise value\n  File \"/opt/amphora-agent-venv/lib/python3.5/site-packages/flask/app.py\", line 1612, in full_dispatch_request\n    rv \u003d self.dispatch_request()\n  File \"/opt/amphora-agent-venv/lib/python3.5/site-packages/flask/app.py\", line 1598, in dispatch_request\n    return self.view_functions[rule.endpoint](**req.view_args)\n  File \"/opt/amphora-agent-venv/lib/python3.5/site-packages/octavia/amphorae/backends/agent/api_server/server.py\", line 129, in upload_udp_listener_config\n    return self._udp_listener.upload_udp_listener_config(listener_id)\n  File \"/opt/amphora-agent-venv/lib/python3.5/site-packages/octavia/amphorae/backends/agent/api_server/keepalivedlvs.py\", line 63, in upload_udp_listener_config\n    util.keepalived_backend_check_script_path())\n  File \"/opt/amphora-agent-venv/lib/python3.5/shutil.py\", line 251, in copy2\n    copyfile(src, dst, follow_symlinks\u003dfollow_symlinks)\n  File \"/opt/amphora-agent-venv/lib/python3.5/shutil.py\", line 114, in copyfile\n    with open(src, \u0027rb\u0027) as fsrc:\nFileNotFoundError: [Errno 2] No such file or directory: \u0027/octavia/amphorae/backends/utils/udp_check.sh\u0027\n\nThat path is not right.","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"22f377361c3bb357c8770ff42fc8dace7edf6da7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            os.makedirs(util.keepalived_backend_check_script_dir())"},{"line_number":60,"context_line":"            script_dir \u003d os.path.abspath(\u0027./octavia/amphorae/\u0027"},{"line_number":61,"context_line":"                                         \u0027backends/utils/\u0027)"},{"line_number":62,"context_line":"            shutil.copy2(os.path.join(script_dir, \u0027udp_check.sh\u0027),"},{"line_number":63,"context_line":"                         util.keepalived_backend_check_script_path())"},{"line_number":64,"context_line":"            os.chmod(util.keepalived_backend_check_script_path(), stat.S_IEXEC)"},{"line_number":65,"context_line":"        # Based on current topology setting, only the amphora instances in"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_997ac4ee","line":62,"in_reply_to":"5f7c97a3_ab709409","updated":"2018-05-14 11:10:06.000000000","message":"Oh, let me check again.","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cbdff5dbed44a60d456c05e2c8e9cac047380e83","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                r\u0027real_server\\s([\\d+\\.]+\\b)\\s(\\d{1,5})\u0027, cfg)"},{"line_number":278,"context_line":"            for ip_port in ip_port_lists:"},{"line_number":279,"context_line":"                member_list.append("},{"line_number":280,"context_line":"                    {ip_port[0] + \u0027:\u0027 + ip_port[1]: \u0027no check\u0027})"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        pool \u003d {"},{"line_number":283,"context_line":"            \u0027UDP-Listener-%s-pool\u0027 % listener_id:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_ebc9ac58","line":280,"updated":"2018-05-11 23:11:23.000000000","message":"This doesn\u0027t accurately show the status of the member. We should fix this to get the health from lvs.","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e1107b1a5d799b3b96b35405e91e8d7e147af7d4","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                r\u0027real_server\\s([\\d+\\.]+\\b)\\s(\\d{1,5})\u0027, cfg)"},{"line_number":278,"context_line":"            for ip_port in ip_port_lists:"},{"line_number":279,"context_line":"                member_list.append("},{"line_number":280,"context_line":"                    {ip_port[0] + \u0027:\u0027 + ip_port[1]: \u0027no check\u0027})"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        pool \u003d {"},{"line_number":283,"context_line":"            \u0027UDP-Listener-%s-pool\u0027 % listener_id:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_5966ba2b","line":280,"in_reply_to":"5f7c97a3_85d49321","updated":"2018-05-23 15:47:04.000000000","message":"Ah, I\u0027m afraid that I can not google a good way to do. Let me try to search again.","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"22f377361c3bb357c8770ff42fc8dace7edf6da7","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                r\u0027real_server\\s([\\d+\\.]+\\b)\\s(\\d{1,5})\u0027, cfg)"},{"line_number":278,"context_line":"            for ip_port in ip_port_lists:"},{"line_number":279,"context_line":"                member_list.append("},{"line_number":280,"context_line":"                    {ip_port[0] + \u0027:\u0027 + ip_port[1]: \u0027no check\u0027})"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        pool \u003d {"},{"line_number":283,"context_line":"            \u0027UDP-Listener-%s-pool\u0027 % listener_id:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_85d49321","line":280,"in_reply_to":"5f7c97a3_ebc9ac58","updated":"2018-05-14 11:10:06.000000000","message":"Yeah, you are right. In this current code, I do nothing for checking the member status. Michael, do you mean that check the whole lvs status with some console cli for checking whether the lvs is working, then set UP for cmd sucess, Down for failure.","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e5cf2b5b50b95c55a8e00fd0223593c0b033815a","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    def get_all_udp_listeners_status(self):"},{"line_number":233,"context_line":"        \"\"\"Gets the status of all UDP listeners"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        This method will not consult the stats socket"},{"line_number":236,"context_line":"        so a listener might show as ACTIVE but still be"},{"line_number":237,"context_line":"        in ERROR"},{"line_number":238,"context_line":"        \"\"\""},{"line_number":239,"context_line":"        listeners \u003d list()"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"5f7c97a3_af6fe55f","line":237,"range":{"start_line":235,"start_character":0,"end_line":237,"end_character":16},"updated":"2018-08-02 23:31:49.000000000","message":"This comment is invalid here. There is not stats socket for UDP.\nFixing in follow up patch","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e5cf2b5b50b95c55a8e00fd0223593c0b033815a","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            listeners.append({"},{"line_number":244,"context_line":"                \u0027status\u0027: status,"},{"line_number":245,"context_line":"                \u0027uuid\u0027: udp_listener,"},{"line_number":246,"context_line":"                \u0027type\u0027: \u0027lvs\u0027,"},{"line_number":247,"context_line":"            })"},{"line_number":248,"context_line":"        return listeners"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"5f7c97a3_8fb549d2","line":246,"range":{"start_line":246,"start_character":24,"end_line":246,"end_character":29},"updated":"2018-08-02 23:31:49.000000000","message":"This should be UDP per the API spec here:\nhttps://docs.openstack.org/octavia/latest/contributor/api/haproxy-amphora-api.html#get-all-listeners-statuses\nFixing in follow up","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e5cf2b5b50b95c55a8e00fd0223593c0b033815a","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    def get_udp_listener_status(self, listener_id):"},{"line_number":251,"context_line":"        \"\"\"Gets the status of a UDP listener"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        This method will consult the stats socket"},{"line_number":254,"context_line":"        so calling this method will interfere with"},{"line_number":255,"context_line":"        the health daemon with the risk of the amphora"},{"line_number":256,"context_line":"        shut down"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        :param listener_id: The id of the listener"},{"line_number":259,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":59,"id":"5f7c97a3_4f8171fa","line":256,"range":{"start_line":253,"start_character":8,"end_line":256,"end_character":17},"updated":"2018-08-02 23:31:49.000000000","message":"This comment is invalid here. There is not stats socket for UDP.\nFixing in follow up patch","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e5cf2b5b50b95c55a8e00fd0223593c0b033815a","unresolved":false,"context_lines":[{"line_number":265,"context_line":"            stats \u003d dict("},{"line_number":266,"context_line":"                status\u003dstatus,"},{"line_number":267,"context_line":"                uuid\u003dlistener_id,"},{"line_number":268,"context_line":"                type\u003d\u0027\u0027"},{"line_number":269,"context_line":"            )"},{"line_number":270,"context_line":"            return webob.Response(json\u003dstats)"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"5f7c97a3_cfba61b9","line":268,"range":{"start_line":268,"start_character":21,"end_line":268,"end_character":23},"updated":"2018-08-02 23:31:49.000000000","message":"This should be UDP per the API spec here:\nhttps://docs.openstack.org/octavia/latest/contributor/api/haproxy-amphora-api.html#get-a-listener-s-status\nFixing in follow up","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e5cf2b5b50b95c55a8e00fd0223593c0b033815a","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        stats \u003d dict("},{"line_number":273,"context_line":"            status\u003dstatus,"},{"line_number":274,"context_line":"            uuid\u003dlistener_id,"},{"line_number":275,"context_line":"            type\u003d\u0027lvs\u0027"},{"line_number":276,"context_line":"        )"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":59,"id":"5f7c97a3_efc39d39","line":275,"range":{"start_line":275,"start_character":0,"end_line":275,"end_character":22},"updated":"2018-08-02 23:31:49.000000000","message":"This should be UDP per the API spec here:\nhttps://docs.openstack.org/octavia/latest/contributor/api/haproxy-amphora-api.html#get-a-listener-s-status\nFixing in follow up","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e5cf2b5b50b95c55a8e00fd0223593c0b033815a","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                listener_id)"},{"line_number":281,"context_line":"        except subprocess.CalledProcessError as e:"},{"line_number":282,"context_line":"            return webob.Response(json\u003ddict("},{"line_number":283,"context_line":"                message\u003d\"Error get kernel lvs status for udp listener\","},{"line_number":284,"context_line":"                details\u003de.output), status\u003d500)"},{"line_number":285,"context_line":"        stats[\u0027pools\u0027] \u003d [pool]"},{"line_number":286,"context_line":"        return webob.Response(json\u003dstats)"}],"source_content_type":"text/x-python","patch_set":59,"id":"5f7c97a3_6f230d14","line":283,"range":{"start_line":283,"start_character":31,"end_line":283,"end_character":34},"updated":"2018-08-02 23:31:49.000000000","message":"nit: getting\nFixed in follow up","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"}],"octavia/amphorae/backends/agent/api_server/plug.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"b13a08bbbe271033196a366bfe840fb5fedeadba","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        sysctl.wait()"},{"line_number":133,"context_line":"        sysctl.release()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        cmd_list \u003d [[\u0027modprobe\u0027, \u0027ip_vs\u0027],"},{"line_number":136,"context_line":"                    [consts.SYSCTL_CMD, \u0027-w\u0027, \u0027net.ipv4.vs.conntrack\u003d1\u0027]]"},{"line_number":137,"context_line":"        if ip.version \u003d\u003d 4:"},{"line_number":138,"context_line":"            # For lvs function, enable ip_vs kernel module, enable ip_forward"}],"source_content_type":"text/x-python","patch_set":55,"id":"5f7c97a3_fa85bcab","line":135,"updated":"2018-08-01 16:18:05.000000000","message":"systemd script runs those commands as well. Duplicate?","commit_id":"75dddf4726839c1f05dfc7c9dbaff2cdd8e9e986"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"04126e711e1076ebed5e5f96350d949321907a89","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        sysctl.wait()"},{"line_number":133,"context_line":"        sysctl.release()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        cmd_list \u003d [[\u0027modprobe\u0027, \u0027ip_vs\u0027],"},{"line_number":136,"context_line":"                    [consts.SYSCTL_CMD, \u0027-w\u0027, \u0027net.ipv4.vs.conntrack\u003d1\u0027]]"},{"line_number":137,"context_line":"        if ip.version \u003d\u003d 4:"},{"line_number":138,"context_line":"            # For lvs function, enable ip_vs kernel module, enable ip_forward"}],"source_content_type":"text/x-python","patch_set":55,"id":"5f7c97a3_1d9f5251","line":135,"in_reply_to":"5f7c97a3_fa85bcab","updated":"2018-08-01 16:42:16.000000000","message":"Thanks, german, the sysctl --system just load the /etc/sysctl.conf and /etc/sysctl.d/*, but the default value which we want to configure below is 0, it default not to enable it. Also the kernel module, so I add them here.","commit_id":"75dddf4726839c1f05dfc7c9dbaff2cdd8e9e986"}],"octavia/amphorae/backends/agent/api_server/server.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8351562842dd8a253112bce692984d77cdbec9a4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self._osutils \u003d osutils.BaseOS.get_os_util()"},{"line_number":50,"context_line":"        self._keepalived \u003d keepalived.Keepalived()"},{"line_number":51,"context_line":"        self._listener \u003d listener.Listener()"},{"line_number":52,"context_line":"        self._udp_listener \u003d keepalivedlvs.KeepalivedLvs()"},{"line_number":53,"context_line":"        self._plug \u003d plug.Plug(self._osutils)"},{"line_number":54,"context_line":"        self._amphora_info \u003d amphora_info.AmphoraInfo(self._osutils)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_7b1ba81a","line":52,"range":{"start_line":52,"start_character":29,"end_line":52,"end_character":56},"updated":"2018-01-26 06:32:12.000000000","message":"For this API, can we make it more generic for UDP?\n\nWhat if we change the load balancing engine inside the amphora?  The API should still work/abstract this.\n\nFor example, if we swap haproxy out for nginix we would still support UDP via this API, just the amphora-agent and haproxy would need to change.","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"38c844838250556382d8fd9690da28de5c310f0e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self._osutils \u003d osutils.BaseOS.get_os_util()"},{"line_number":50,"context_line":"        self._keepalived \u003d keepalived.Keepalived()"},{"line_number":51,"context_line":"        self._listener \u003d listener.Listener()"},{"line_number":52,"context_line":"        self._udp_listener \u003d keepalivedlvs.KeepalivedLvs()"},{"line_number":53,"context_line":"        self._plug \u003d plug.Plug(self._osutils)"},{"line_number":54,"context_line":"        self._amphora_info \u003d amphora_info.AmphoraInfo(self._osutils)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ee137465","line":52,"range":{"start_line":52,"start_character":29,"end_line":52,"end_character":56},"in_reply_to":"5f93b717_7b1ba81a","updated":"2018-01-26 07:07:49.000000000","message":"Yeah, I know the your point. I will change the all API later. And make it more generic. Thanks for suggest, micheal.","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8351562842dd8a253112bce692984d77cdbec9a4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                              view_func\u003dself.upload_haproxy_config,"},{"line_number":61,"context_line":"                              methods\u003d[\u0027PUT\u0027])"},{"line_number":62,"context_line":"        self.app.add_url_rule(rule\u003dPATH_PREFIX +"},{"line_number":63,"context_line":"                              \u0027/listeners/\u003camphora_id\u003e/\u003clistener_id\u003e/keepalivedlvs\u0027,"},{"line_number":64,"context_line":"                              view_func\u003dself.upload_keepalivedlvs_config,"},{"line_number":65,"context_line":"                              methods\u003d[\u0027PUT\u0027])"},{"line_number":66,"context_line":"        self.app.add_url_rule(rule\u003dPATH_PREFIX +"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_5bd82c52","line":63,"range":{"start_line":63,"start_character":69,"end_line":63,"end_character":82},"updated":"2018-01-26 06:32:12.000000000","message":"Same here, can we make this more generic like UDP_listener?\n\nWe haven\u0027t always done a good job at this, but we shouldn\u0027t make more mistakes.","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                              view_func\u003dself.upload_haproxy_config,"},{"line_number":61,"context_line":"                              methods\u003d[\u0027PUT\u0027])"},{"line_number":62,"context_line":"        self.app.add_url_rule(rule\u003dPATH_PREFIX +"},{"line_number":63,"context_line":"                              \u0027/listeners/\u003camphora_id\u003e/\u003clistener_id\u003e/keepalivedlvs\u0027,"},{"line_number":64,"context_line":"                              view_func\u003dself.upload_keepalivedlvs_config,"},{"line_number":65,"context_line":"                              methods\u003d[\u0027PUT\u0027])"},{"line_number":66,"context_line":"        self.app.add_url_rule(rule\u003dPATH_PREFIX +"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ec27fc63","line":63,"range":{"start_line":63,"start_character":69,"end_line":63,"end_character":82},"in_reply_to":"5f93b717_51048d15","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                              view_func\u003dself.upload_haproxy_config,"},{"line_number":61,"context_line":"                              methods\u003d[\u0027PUT\u0027])"},{"line_number":62,"context_line":"        self.app.add_url_rule(rule\u003dPATH_PREFIX +"},{"line_number":63,"context_line":"                              \u0027/listeners/\u003camphora_id\u003e/\u003clistener_id\u003e/keepalivedlvs\u0027,"},{"line_number":64,"context_line":"                              view_func\u003dself.upload_keepalivedlvs_config,"},{"line_number":65,"context_line":"                              methods\u003d[\u0027PUT\u0027])"},{"line_number":66,"context_line":"        self.app.add_url_rule(rule\u003dPATH_PREFIX +"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_51048d15","line":63,"range":{"start_line":63,"start_character":69,"end_line":63,"end_character":82},"in_reply_to":"5f93b717_5bd82c52","updated":"2018-01-26 07:11:16.000000000","message":"E501 line too long (84 \u003e 79 characters)","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def delete_listener(self, listener_id):"},{"line_number":143,"context_line":"        if flask.request.data \u003d\u003d \u0027UDP\u0027:"},{"line_number":144,"context_line":"            return self._udp_listener.delete_keepalivedlvs_listener(listener_id)"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            return self._listener.delete_listener(listener_id)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_711c296a","line":144,"updated":"2018-01-26 07:11:16.000000000","message":"E501 line too long (80 \u003e 79 characters)","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cbdff5dbed44a60d456c05e2c8e9cac047380e83","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            extend_udp_driver\u003dself._udp_listener)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def get_info(self):"},{"line_number":155,"context_line":"        return self._amphora_info.compile_amphora_info()"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def get_all_listeners_status(self):"},{"line_number":158,"context_line":"        udp_listeners \u003d self._udp_listener.get_all_udp_listeners_status()"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_2bb804e3","line":155,"updated":"2018-05-11 23:11:23.000000000","message":"This is missing UDP driver param","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"22f377361c3bb357c8770ff42fc8dace7edf6da7","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            extend_udp_driver\u003dself._udp_listener)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def get_info(self):"},{"line_number":155,"context_line":"        return self._amphora_info.compile_amphora_info()"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def get_all_listeners_status(self):"},{"line_number":158,"context_line":"        udp_listeners \u003d self._udp_listener.get_all_udp_listeners_status()"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_79800847","line":155,"in_reply_to":"5f7c97a3_2bb804e3","updated":"2018-05-14 11:10:06.000000000","message":"Oh, yes, I miss it. Thanks for correcting.","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"}],"octavia/amphorae/backends/agent/api_server/templates/keepalived_lvs_check_script.sh.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8351562842dd8a253112bce692984d77cdbec9a4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      *) continue;;"},{"line_number":13,"context_line":"  esac"},{"line_number":14,"context_line":"  {% if init_system \u003d\u003d consts.INIT_SYSTEMD %}"},{"line_number":15,"context_line":"  systemctl status ${file%.pid} | grep \u0027Active: active (running)\u0027"},{"line_number":16,"context_line":"  {% elif init_system in (consts.INIT_UPSTART, consts.INIT_SYSVINIT) %}"},{"line_number":17,"context_line":"  kill -0 `cat $file`"},{"line_number":18,"context_line":"  {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f93b717_9bbc7406","line":15,"range":{"start_line":15,"start_character":34,"end_line":15,"end_character":65},"updated":"2018-01-26 06:32:12.000000000","message":"This grep string makes me nervous as it would break if they change any one of these strings.\nThe exit code reflects the status, should we use that?","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"38c844838250556382d8fd9690da28de5c310f0e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      *) continue;;"},{"line_number":13,"context_line":"  esac"},{"line_number":14,"context_line":"  {% if init_system \u003d\u003d consts.INIT_SYSTEMD %}"},{"line_number":15,"context_line":"  systemctl status ${file%.pid} | grep \u0027Active: active (running)\u0027"},{"line_number":16,"context_line":"  {% elif init_system in (consts.INIT_UPSTART, consts.INIT_SYSVINIT) %}"},{"line_number":17,"context_line":"  kill -0 `cat $file`"},{"line_number":18,"context_line":"  {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f93b717_2e62bc3f","line":15,"range":{"start_line":15,"start_character":34,"end_line":15,"end_character":65},"in_reply_to":"5f93b717_9bbc7406","updated":"2018-01-26 07:07:49.000000000","message":"Yeah, the exit code will reflect the service status. Thanks, micheal for help this. I just test with the whole patch. Most of part worked as wish. I will change this sh.","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"}],"octavia/amphorae/backends/agent/api_server/templates/plug_port_ethX.conf.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"043d418371c38970b2c6bac494c408395803d1e5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"up route add -net {{ hr.network }} gw {{ hr.gw }} dev {{ interface }}"},{"line_number":28,"context_line":"down route del -net {{ hr.network }} gw {{ hr.gw }} dev {{ interface }}"},{"line_number":29,"context_line":"{%- endfor %}"},{"line_number":30,"context_line":"{%- if not ipv6 %}"},{"line_number":31,"context_line":"post-up /sbin/iptables -t nat -A POSTROUTING -p udp -o {{ interface }} -j MASQUERADE"},{"line_number":32,"context_line":"post-down /sbin/iptables -t nat -D POSTROUTING -p udp -o {{ interface }} -j MASQUERADE"},{"line_number":33,"context_line":"{%- endif %}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"5f7c97a3_aadef3d8","line":30,"updated":"2018-07-11 03:59:41.000000000","message":"We support IPv6, so we should have the have the same for IPv6","commit_id":"27f2b61127c84bfa0c4a100d402fc65cf56917da"}],"octavia/amphorae/backends/agent/api_server/templates/plug_vip_ethX.conf.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"043d418371c38970b2c6bac494c408395803d1e5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{%- endfor %}"},{"line_number":54,"context_line":"post-up /sbin/ip {{ \u0027-6 \u0027 if vip_ipv6 }}rule add from {{ vip }}/32 table 1 priority 100"},{"line_number":55,"context_line":"post-down /sbin/ip {{ \u0027-6 \u0027 if vip_ipv6 }}rule del from {{ vip }}/32 table 1 priority 100"},{"line_number":56,"context_line":"{%- if not vip_ipv6 %}"},{"line_number":57,"context_line":"post-up /sbin/iptables -t nat -A POSTROUTING -p udp -o {{ interface }} -j MASQUERADE"},{"line_number":58,"context_line":"post-down /sbin/iptables -t nat -D POSTROUTING -p udp -o {{ interface }} -j MASQUERADE"},{"line_number":59,"context_line":"{%- endif %}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"5f7c97a3_ea82aba6","line":56,"updated":"2018-07-11 03:59:41.000000000","message":"Same, we need to support IPv6, it is the future!","commit_id":"27f2b61127c84bfa0c4a100d402fc65cf56917da"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e5cf2b5b50b95c55a8e00fd0223593c0b033815a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{%- endfor %}"},{"line_number":54,"context_line":"post-up /sbin/ip {{ \u0027-6 \u0027 if vip_ipv6 }}rule add from {{ vip }}/32 table 1 priority 100"},{"line_number":55,"context_line":"post-down /sbin/ip {{ \u0027-6 \u0027 if vip_ipv6 }}rule del from {{ vip }}/32 table 1 priority 100"},{"line_number":56,"context_line":"post-up /sbin/ip{{ \u00276\u0027 if vip_ipv6 }}tables -t nat -A POSTROUTING -p udp -o {{ interface }} -j MASQUERADE"},{"line_number":57,"context_line":"post-down /sbin/ip{{ \u00276\u0027 if vip_ipv6 }}tables -t nat -D POSTROUTING -p udp -o {{ interface }} -j MASQUERADE"}],"source_content_type":"text/x-jinja2","patch_set":59,"id":"5f7c97a3_6843fe6c","line":56,"updated":"2018-08-02 23:31:49.000000000","message":"This was a concern as we have both VRRP and stick table synchronization over the base interface listed here, but both are not using UDP so this is ok.","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e60a7670cc1a9befbe48e79d0cd2d533be28cff7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{%- endfor %}"},{"line_number":54,"context_line":"post-up /sbin/ip {{ \u0027-6 \u0027 if vip_ipv6 }}rule add from {{ vip }}/32 table 1 priority 100"},{"line_number":55,"context_line":"post-down /sbin/ip {{ \u0027-6 \u0027 if vip_ipv6 }}rule del from {{ vip }}/32 table 1 priority 100"},{"line_number":56,"context_line":"post-up /sbin/ip{{ \u00276\u0027 if vip_ipv6 }}tables -t nat -A POSTROUTING -p udp -o {{ interface }} -j MASQUERADE"},{"line_number":57,"context_line":"post-down /sbin/ip{{ \u00276\u0027 if vip_ipv6 }}tables -t nat -D POSTROUTING -p udp -o {{ interface }} -j MASQUERADE"}],"source_content_type":"text/x-jinja2","patch_set":59,"id":"5f7c97a3_c65d62ec","line":56,"in_reply_to":"5f7c97a3_6843fe6c","updated":"2018-08-03 00:05:16.000000000","message":"Yes, that also my concerned, if we introduce more function in the future, we need to specific as much the rule.","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"}],"octavia/amphorae/backends/agent/api_server/util.py":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                            \u0027haproxy-{0}\u0027.format(listener_id))"},{"line_number":40,"context_line":"    else:"},{"line_number":41,"context_line":"        raise UnknownInitError()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def keepalived_lvs_dir():"},{"line_number":44,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path, \u0027lvs\u0027)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_f12119a1","line":42,"updated":"2018-01-26 07:11:16.000000000","message":"E302 expected 2 blank lines, found 1","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                            \u0027haproxy-{0}\u0027.format(listener_id))"},{"line_number":40,"context_line":"    else:"},{"line_number":41,"context_line":"        raise UnknownInitError()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def keepalived_lvs_dir():"},{"line_number":44,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path, \u0027lvs\u0027)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_0c2d8842","line":42,"in_reply_to":"5f93b717_f12119a1","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def keepalived_lvs_dir():"},{"line_number":44,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path, \u0027lvs\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def keepalived_lvs_init_path(init_system, listener_id):"},{"line_number":47,"context_line":"    if init_system \u003d\u003d consts.INIT_SYSTEMD:"},{"line_number":48,"context_line":"        return os.path.join(consts.SYSTEMD_DIR,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_b13b91cf","line":45,"updated":"2018-01-26 07:11:16.000000000","message":"E302 expected 2 blank lines, found 1","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def keepalived_lvs_dir():"},{"line_number":44,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path, \u0027lvs\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def keepalived_lvs_init_path(init_system, listener_id):"},{"line_number":47,"context_line":"    if init_system \u003d\u003d consts.INIT_SYSTEMD:"},{"line_number":48,"context_line":"        return os.path.join(consts.SYSTEMD_DIR,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ac21f44f","line":45,"in_reply_to":"5f93b717_b13b91cf","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                            str(listener_id))"},{"line_number":59,"context_line":"    else:"},{"line_number":60,"context_line":"        raise UnknownInitError()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def keepalived_lvs_pids_path(listener_id):"},{"line_number":63,"context_line":"    pids_path \u003d []"},{"line_number":64,"context_line":"    for file_ext in [\u0027pid\u0027, \u0027vrrp.pid\u0027, \u0027check.pid\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_713509da","line":61,"updated":"2018-01-26 07:11:16.000000000","message":"E302 expected 2 blank lines, found 1","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                            str(listener_id))"},{"line_number":59,"context_line":"    else:"},{"line_number":60,"context_line":"        raise UnknownInitError()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def keepalived_lvs_pids_path(listener_id):"},{"line_number":63,"context_line":"    pids_path \u003d []"},{"line_number":64,"context_line":"    for file_ext in [\u0027pid\u0027, \u0027vrrp.pid\u0027, \u0027check.pid\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_cc1ec00b","line":61,"in_reply_to":"5f93b717_713509da","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                      (\u0027lvs/octavia-keepalivedlvs-%s.%s\u0027) %"},{"line_number":67,"context_line":"                                      (str(listener_id), file_ext)))"},{"line_number":68,"context_line":"    return tuple(pids_path)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def keepalived_lvs_cfg_path(listener_id):"},{"line_number":71,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path,"},{"line_number":72,"context_line":"                        (\u0027lvs/octavia-keepalivedlvs-%s.conf\u0027) %"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_913215f1","line":69,"updated":"2018-01-26 07:11:16.000000000","message":"E302 expected 2 blank lines, found 1","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                      (\u0027lvs/octavia-keepalivedlvs-%s.%s\u0027) %"},{"line_number":67,"context_line":"                                      (str(listener_id), file_ext)))"},{"line_number":68,"context_line":"    return tuple(pids_path)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def keepalived_lvs_cfg_path(listener_id):"},{"line_number":71,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path,"},{"line_number":72,"context_line":"                        (\u0027lvs/octavia-keepalivedlvs-%s.conf\u0027) %"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_6c1bec1a","line":69,"in_reply_to":"5f93b717_913215f1","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path,"},{"line_number":72,"context_line":"                        (\u0027lvs/octavia-keepalivedlvs-%s.conf\u0027) %"},{"line_number":73,"context_line":"                        str(listener_id))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def keepalived_lvs_log_path(listener_id):"},{"line_number":76,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path,"},{"line_number":77,"context_line":"                        (\u0027lvs/octavia-keepalivedlvs-%s.log\u0027) %"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_314d4172","line":74,"updated":"2018-01-26 07:11:16.000000000","message":"E302 expected 2 blank lines, found 1","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path,"},{"line_number":72,"context_line":"                        (\u0027lvs/octavia-keepalivedlvs-%s.conf\u0027) %"},{"line_number":73,"context_line":"                        str(listener_id))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def keepalived_lvs_log_path(listener_id):"},{"line_number":76,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path,"},{"line_number":77,"context_line":"                        (\u0027lvs/octavia-keepalivedlvs-%s.log\u0027) %"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_8c18b81d","line":74,"in_reply_to":"5f93b717_314d4172","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path,"},{"line_number":77,"context_line":"                        (\u0027lvs/octavia-keepalivedlvs-%s.log\u0027) %"},{"line_number":78,"context_line":"                        str(listener_id))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def haproxy_dir(listener_id):"},{"line_number":81,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path, listener_id)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_f156f906","line":79,"updated":"2018-01-26 07:11:16.000000000","message":"E302 expected 2 blank lines, found 1","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path,"},{"line_number":77,"context_line":"                        (\u0027lvs/octavia-keepalivedlvs-%s.log\u0027) %"},{"line_number":78,"context_line":"                        str(listener_id))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def haproxy_dir(listener_id):"},{"line_number":81,"context_line":"    return os.path.join(CONF.haproxy_amphora.base_path, listener_id)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_2cd3a43a","line":79,"in_reply_to":"5f93b717_f156f906","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e5cf2b5b50b95c55a8e00fd0223593c0b033815a","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    return result"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def is_udp_listener_running(listener_id):"},{"line_number":198,"context_line":"    pid_file, _, _ \u003d keepalived_lvs_pids_path(listener_id)"},{"line_number":199,"context_line":"    return os.path.exists(pid_file) and os.path.exists("},{"line_number":200,"context_line":"        os.path.join(\u0027/proc\u0027, get_keepalivedlvs_pid(listener_id)))"}],"source_content_type":"text/x-python","patch_set":59,"id":"5f7c97a3_43c4e594","line":197,"updated":"2018-08-02 23:31:49.000000000","message":"Technically this is seeing if keepalived is running vs. the actual LVS","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e60a7670cc1a9befbe48e79d0cd2d533be28cff7","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    return result"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def is_udp_listener_running(listener_id):"},{"line_number":198,"context_line":"    pid_file, _, _ \u003d keepalived_lvs_pids_path(listener_id)"},{"line_number":199,"context_line":"    return os.path.exists(pid_file) and os.path.exists("},{"line_number":200,"context_line":"        os.path.join(\u0027/proc\u0027, get_keepalivedlvs_pid(listener_id)))"}],"source_content_type":"text/x-python","patch_set":59,"id":"5f7c97a3_c69802cd","line":197,"in_reply_to":"5f7c97a3_43c4e594","updated":"2018-08-03 00:05:16.000000000","message":"Yes, I default to consider the keepalived must configure the lvs, as keepalived brings the lvs cfg, if we shutdown the keepalived, the lvs will lose the cfg part which is from keepalived","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"}],"octavia/amphorae/backends/health_daemon/health_daemon.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"106e5c38ad50b39a2a20c0f95bc30aa3a945b2d4","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"            # if can not get stats info, skip it as it\u0027s meaningless to send"},{"line_number":157,"context_line":"            # out a udp heartbeat for it."},{"line_number":158,"context_line":"            if not listener_stats:"},{"line_number":159,"context_line":"                continue"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            pool_status \u003d keepalivedlvs_query.get_udp_listener_pool_status("}],"source_content_type":"text/x-python","patch_set":26,"id":"5f7c97a3_86947437","line":158,"updated":"2018-06-26 16:22:36.000000000","message":"Hmm, I need to look at this. We need to send heartbeats to make sure the health manager doesn\u0027t failover the amphora.\nSo, we need to make sure that a load balancer with just a UDP listener still sends heartbeats and doesn\u0027t just failover.","commit_id":"2b4be64d9679644cf5c96459800f7a6707f77467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a13ea1f654e19d3001f53f2974cb8ccda5aadb09","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"            # if can not get stats info, skip it as it\u0027s meaningless to send"},{"line_number":157,"context_line":"            # out a udp heartbeat for it."},{"line_number":158,"context_line":"            if not listener_stats:"},{"line_number":159,"context_line":"                continue"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            pool_status \u003d keepalivedlvs_query.get_udp_listener_pool_status("}],"source_content_type":"text/x-python","patch_set":26,"id":"5f7c97a3_3a8fb42e","line":158,"in_reply_to":"5f7c97a3_86947437","updated":"2018-06-26 17:04:39.000000000","message":"Yeah, I also think about it, if there is no other non-UDP lisnter in amp which is a STANDALONE topology,  and late create a member for it, the configuration won\u0027t upload until fit that demand, it will be marked as a stale one, could we send full 0 stats when just udp listener created, but no pool part(even the pool/healthmonitor had been created in server side), and update the listener provision status first, once the member enable, we fresh them all.","commit_id":"2b4be64d9679644cf5c96459800f7a6707f77467"}],"octavia/amphorae/backends/utils/keepalivedlvs_query.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9ae7a67ea3c2749be661e0f20a1b0a50f5edbf8c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    return pool"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"def get_udp_listener_stats(listener_id):"},{"line_number":222,"context_line":"    # We support listenr(haproxy) stats fields contain"},{"line_number":223,"context_line":"    # bout, bin, scur, stot, ereq, status"},{"line_number":224,"context_line":"    # But for udp(lvs) case, some fields can not support for now."}],"source_content_type":"text/x-python","patch_set":33,"id":"5f7c97a3_d45fda72","line":221,"updated":"2018-07-04 03:03:32.000000000","message":"I think we need to install and use ipvsadm to get the detailed stats for each listener. Currently both listeners show the same stats.\nWith ipvsadm I can get:\n# ipvsadm --list --stats\nIP Virtual Server version 1.2.1 (size\u003d4096)\nProt LocalAddress:Port               Conns   InPkts  OutPkts  InBytes OutBytes\n  -\u003e RemoteAddress:Port\nUDP  172.21.1.13:17                     31  1175116       21    5827M    16388\n  -\u003e 10.0.0.12:17                       31  1175116       21    5827M    16388\nUDP  172.21.1.13:msp                     8    75390        2    2472M     1152\n  -\u003e 10.0.0.12:17                        8    75390        2    2472M     1152\n\nI\u0027m not sure if this is available via proc or not.","commit_id":"59a5cfc227a9007a3fc07952d8ea52089be8d084"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"83e5eee173fc7c3dcf6c579156b4774ef7696e6a","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    return pool"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"def get_udp_listener_stats(listener_id):"},{"line_number":222,"context_line":"    # We support listenr(haproxy) stats fields contain"},{"line_number":223,"context_line":"    # bout, bin, scur, stot, ereq, status"},{"line_number":224,"context_line":"    # But for udp(lvs) case, some fields can not support for now."}],"source_content_type":"text/x-python","patch_set":33,"id":"5f7c97a3_44b6b327","line":221,"in_reply_to":"5f7c97a3_d45fda72","updated":"2018-07-04 08:22:57.000000000","message":"Hi Michael, Yeah, the udp listeners would own the same stats info. As it just can get the total stats in ip_vs_stats file. But the connectioncount can get for a single listener.\n\nI test in my env. Please see the console log:\nhttp://paste.openstack.org/show/724954/\n\nAlso, read the file directlly may be have a good performance, if there are so much VS/RS deployed in the amp instance.\n\nAnd I found german had post a patch for ipvsadm, https://review.openstack.org/#/c/499807/\n\n:)","commit_id":"59a5cfc227a9007a3fc07952d8ea52089be8d084"}],"octavia/amphorae/backends/utils/lvs_iptables_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"62d6b3ac0be7be675f9f36ca1544895951e536d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"5f7c97a3_1c13f9b9","updated":"2018-07-06 23:34:34.000000000","message":"This seems pretty heavy handed for what we need.\nI think it would be best to just add post-up rules to the interface configuration files.\nThey would be added here:\nhttps://github.com/openstack/octavia/blob/master/octavia/amphorae/backends/agent/api_server/templates/plug_port_ethX.conf.j2#L35\nExample:\npost-up /sbin/iptables -t nat -A POSTROUTING -p udp -o {{ interface }} -j MASQUERADE\npost-down /sbin/iptables -t nat -D POSTROUTING -p udp -o {{ interface }} -j MASQUERADE\nThis way it will persist across reboots and be added/removed with the interface coming up and down.\n\nHowever, I do not know how to add this to the RedHat network scripts. nmagnezi or cgoncalves might know.","commit_id":"2243f0f305e5e884f0b9dc562e2e4a2adbf42d15"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"c63ead7d9961a73499fc1cddfd1ed524a7a64862","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"5f7c97a3_1b7c566f","in_reply_to":"5f7c97a3_05095582","updated":"2018-07-09 02:46:51.000000000","message":"Thanks for this. Very good suggest. :), But I have a question here, does each interface would add them? As maybe the interface would be only used for non-udp traffic.If we think that\u0027s OK,I will change this. If we need to care about the taffic running on this interface, that means we need to add the check logic or some thing into the plug module for the real interface file genaration support.","commit_id":"2243f0f305e5e884f0b9dc562e2e4a2adbf42d15"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"d582300770ea7bdbbc937164a8c8183253d9d950","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"5f7c97a3_2fda27e5","in_reply_to":"5f7c97a3_1b7c566f","updated":"2018-07-09 09:43:13.000000000","message":"I test in centos7, I found the default ifup/ifdown call chain, like:\nifup -\u003e ifup-pre-local -\u003e ifup-eth -\u003e ifup-post -\u003e ifup-local\nifdown -\u003e ifdown-pre-local -\u003e ifdown-eth -\u003e ifdown-post -\u003e ifdown-local\n\nThe \"*-local\" must be located in /sbin/ and executable scripts. So I plan to add the iptables into if**-local, it looks like a post scrpt. But I have not test on Redhat, I can not get the image. :(","commit_id":"2243f0f305e5e884f0b9dc562e2e4a2adbf42d15"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"81cc81f5c1b8ac02f7e12508065f090f9057d2bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"5f7c97a3_05095582","in_reply_to":"5f7c97a3_1c13f9b9","updated":"2018-07-08 22:24:09.000000000","message":"I agree with Michael here.\nAs for how the CentOS/RHEL equivalent, I browsed through some docs.\nI was able to find:\n1. https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/networking_guide/sec-NetworkManager_and_the_Network_Scripts see: Custom Commands and the Network Scripts\n\nSince #1 requires a subscription to Redhat, I tried to find some other references:\n2. https://stackoverflow.com/questions/37795538/centos-network-interface-post-up-script-not-executing\n\n3. check the last part of the answer here (also refers to the same Red hat doc I proposed above: https://serverfault.com/questions/798405/how-to-make-ip-route-settings-persistent-in-centos\n\n4. Nearly identical \u0027Custom Commands and the Network Scripts\u0027 section in Fefora docs: https://jfearn.fedorapeople.org/fdocs/en-US/Fedora/20/html/Networking_Guide/sec-NetworkManager_and_the_Network_Scripts.html\n\n5. this one seems to capture this in an easy and short way:https://www.vmotionhost.com/client-area/knowledgebase.php?action\u003ddisplayarticle\u0026id\u003d163","commit_id":"2243f0f305e5e884f0b9dc562e2e4a2adbf42d15"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"8008890ed1cf1154f3d493c8c860cadd339fd096","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"5f7c97a3_8a09e9dc","in_reply_to":"5f7c97a3_2fda27e5","updated":"2018-07-09 10:08:18.000000000","message":"if you get it working on CentOS, it will work in RHEL. Don\u0027t worry about it.","commit_id":"2243f0f305e5e884f0b9dc562e2e4a2adbf42d15"}],"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"class IntegratedLvsAmphoraLoadBalancerDriver("},{"line_number":207,"context_line":"    HaproxyAmphoraLoadBalancerDriver):"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def __init__(self):"},{"line_number":210,"context_line":"        super(IntegratedLvsAmphoraLoadBalancerDriver, self).__init__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_f16fd9c2","line":207,"range":{"start_line":207,"start_character":0,"end_line":207,"end_character":4},"updated":"2018-01-26 07:11:16.000000000","message":"E125 continuation line with same indent as next logical line","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"class IntegratedLvsAmphoraLoadBalancerDriver("},{"line_number":207,"context_line":"    HaproxyAmphoraLoadBalancerDriver):"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def __init__(self):"},{"line_number":210,"context_line":"        super(IntegratedLvsAmphoraLoadBalancerDriver, self).__init__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_4cd87052","line":207,"range":{"start_line":207,"start_character":0,"end_line":207,"end_character":4},"in_reply_to":"5f93b717_f16fd9c2","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"6d427689858aeae61ba97c211671b977c05c0d43","unresolved":false,"context_lines":[{"line_number":389,"context_line":"    def delete_listener(self, amp, listener_id, protocol):"},{"line_number":390,"context_line":"        r \u003d self.delete("},{"line_number":391,"context_line":"            amp, \u0027listeners/{listener_id}\u0027.format(listener_id\u003dlistener_id),"},{"line_number":392,"context_line":"        data\u003dprotocol)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        return exc.check_exception(r, (404,))"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_319b01ca","line":392,"range":{"start_line":392,"start_character":4,"end_line":392,"end_character":8},"updated":"2018-01-26 07:11:16.000000000","message":"E122 continuation line missing indentation or outdented","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"254141da959a9f0592c34ee85716d61a845d6995","unresolved":false,"context_lines":[{"line_number":389,"context_line":"    def delete_listener(self, amp, listener_id, protocol):"},{"line_number":390,"context_line":"        r \u003d self.delete("},{"line_number":391,"context_line":"            amp, \u0027listeners/{listener_id}\u0027.format(listener_id\u003dlistener_id),"},{"line_number":392,"context_line":"        data\u003dprotocol)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        return exc.check_exception(r, (404,))"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ecdcdc47","line":392,"range":{"start_line":392,"start_character":4,"end_line":392,"end_character":8},"in_reply_to":"5f93b717_319b01ca","updated":"2018-01-26 08:02:13.000000000","message":"Done","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e5cf2b5b50b95c55a8e00fd0223593c0b033815a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            base_crt_dir\u003dCONF.haproxy_amphora.base_cert_dir,"},{"line_number":61,"context_line":"            haproxy_template\u003dCONF.haproxy_amphora.haproxy_template,"},{"line_number":62,"context_line":"            connection_logging\u003dCONF.haproxy_amphora.connection_logging)"},{"line_number":63,"context_line":"        self.udp_jinja \u003d jinja_udp_cfg.LvsJinjaTemplater()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def update_amphora_listeners(self, listeners, amphora_index,"},{"line_number":66,"context_line":"                                 amphorae, timeout_dict\u003dNone):"}],"source_content_type":"text/x-python","patch_set":52,"id":"5f7c97a3_60c36d8d","line":63,"range":{"start_line":63,"start_character":40,"end_line":63,"end_character":42},"updated":"2018-08-02 23:31:49.000000000","message":"nit: LVS is an abbreviation and should be LVS","commit_id":"28c11cfb4286e356b98612f36c3fd809575f12a7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73f09f45ae7c6d33194c57931146ee204ebcf504","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                    func(amp, listener.id, *args)"},{"line_number":157,"context_line":"        else:"},{"line_number":158,"context_line":"            if amphora.status !\u003d consts.DELETED:"},{"line_number":159,"context_line":"                if func.__name__.find(\u0027cert\u0027) \u003c 0:"},{"line_number":160,"context_line":"                    _list \u003d list(args)"},{"line_number":161,"context_line":"                    _list.append(listener.protocol)"},{"line_number":162,"context_line":"                    args \u003d _list"}],"source_content_type":"text/x-python","patch_set":52,"id":"5f7c97a3_6075ad85","line":159,"updated":"2018-07-30 22:56:34.000000000","message":"When running in active/standby mode, I \"openstack server delete\" the master amphora (the one passing traffic).\nWhen the heath manager tries to rebuild the failed amphora I get:\nTraceback (most recent call last):\nFile \"/usr/local/lib/python2.7/dist-packages/taskflow/engines/action_engine/executor.py\", line 53, in _execute_task\nresult \u003d task.execute(**arguments)\nFile \"/opt/stack/octavia/octavia/controller/worker/tasks/amphora_driver_tasks.py\", line 130, in execute\nself.amphora_driver.start(listener, loadbalancer.vip, amphora)\nFile \"/opt/stack/octavia/octavia/amphorae/drivers/haproxy/rest_api_driver.py\", line 169, in start\nself._apply(self.client.start_listener, listener, amphora)\nFile \"/opt/stack/octavia/octavia/amphorae/drivers/haproxy/rest_api_driver.py\", line 159, in _apply\nif func.__name__.find(\u0027cert\u0027) \u003c 0:\nAttributeError: \u0027functools.partial\u0027 object has no attribute \u0027__name__\u0027","commit_id":"28c11cfb4286e356b98612f36c3fd809575f12a7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e2ab1c5105d0a6811efa6170f62c10484c159823","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                    func(amp, listener.id, *args)"},{"line_number":157,"context_line":"        else:"},{"line_number":158,"context_line":"            if amphora.status !\u003d consts.DELETED:"},{"line_number":159,"context_line":"                if func.__name__.find(\u0027cert\u0027) \u003c 0:"},{"line_number":160,"context_line":"                    _list \u003d list(args)"},{"line_number":161,"context_line":"                    _list.append(listener.protocol)"},{"line_number":162,"context_line":"                    args \u003d _list"}],"source_content_type":"text/x-python","patch_set":52,"id":"5f7c97a3_b9bea061","line":159,"in_reply_to":"5f7c97a3_6075ad85","updated":"2018-07-31 03:53:48.000000000","message":"Hmmm, I\u0027m trying to think if there is a issue in L152-155 above. Let me do more test to figure out all the places call it. Thanks for test, Micheal.","commit_id":"28c11cfb4286e356b98612f36c3fd809575f12a7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"04126e711e1076ebed5e5f96350d949321907a89","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                    func(amp, listener.id, *args)"},{"line_number":157,"context_line":"        else:"},{"line_number":158,"context_line":"            if amphora.status !\u003d consts.DELETED:"},{"line_number":159,"context_line":"                if func.__name__.find(\u0027cert\u0027) \u003c 0:"},{"line_number":160,"context_line":"                    _list \u003d list(args)"},{"line_number":161,"context_line":"                    _list.append(listener.protocol)"},{"line_number":162,"context_line":"                    args \u003d _list"}],"source_content_type":"text/x-python","patch_set":52,"id":"5f7c97a3_4fea1a0d","line":159,"in_reply_to":"5f7c97a3_b9bea061","updated":"2018-08-01 16:42:16.000000000","message":"Hmmm, it looks odd, why task \"ListenerStart\" no issue, but task \"ListenersStart\" hits. create_listener flow use \"ListenersUpdate\", failover flow use \"ListenersStart\". In \"update\" func wo call upload_udp_config and reload_listener directly.. Oh, that\u0027s it. The difference is call it directly or call it through _apply, such as HaproxyAmphoraLoadBalancerDriver.start/stop/delete ..","commit_id":"28c11cfb4286e356b98612f36c3fd809575f12a7"}],"octavia/common/utils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cbdff5dbed44a60d456c05e2c8e9cac047380e83","unresolved":false,"context_lines":[{"line_number":81,"context_line":"def get_amp_agent_ext_udp_conf():"},{"line_number":82,"context_line":"    # register on octavia services side, as this option could be configured in"},{"line_number":83,"context_line":"    # agent side."},{"line_number":84,"context_line":"    opt \u003d cfg.StrOpt(\u0027amphora_udp_driver\u0027,"},{"line_number":85,"context_line":"                     default\u003d\u0027keepalived_lvs\u0027,"},{"line_number":86,"context_line":"                     help\u003d\u0027The UDP API backend for amphora agent.\u0027)"},{"line_number":87,"context_line":"    CONF.register_opt(opt, group\u003d\u0027controller_worker\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_087bce7a","line":84,"updated":"2018-05-11 23:11:23.000000000","message":"We centralize all configuration settings in octavia/common/config, including the amphora-agent config \"amphora_agent_opts\" https://github.com/openstack/octavia/blob/master/octavia/common/config.py#L106\nThis allows it to be documented and easy to find. Can we move this?","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"22f377361c3bb357c8770ff42fc8dace7edf6da7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"def get_amp_agent_ext_udp_conf():"},{"line_number":82,"context_line":"    # register on octavia services side, as this option could be configured in"},{"line_number":83,"context_line":"    # agent side."},{"line_number":84,"context_line":"    opt \u003d cfg.StrOpt(\u0027amphora_udp_driver\u0027,"},{"line_number":85,"context_line":"                     default\u003d\u0027keepalived_lvs\u0027,"},{"line_number":86,"context_line":"                     help\u003d\u0027The UDP API backend for amphora agent.\u0027)"},{"line_number":87,"context_line":"    CONF.register_opt(opt, group\u003d\u0027controller_worker\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_85a253ad","line":84,"in_reply_to":"5f7c97a3_087bce7a","updated":"2018-05-14 11:10:06.000000000","message":"Sure, I think it\u0027s good to move.","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cbdff5dbed44a60d456c05e2c8e9cac047380e83","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    opt \u003d cfg.StrOpt(\u0027amphora_udp_driver\u0027,"},{"line_number":85,"context_line":"                     default\u003d\u0027keepalived_lvs\u0027,"},{"line_number":86,"context_line":"                     help\u003d\u0027The UDP API backend for amphora agent.\u0027)"},{"line_number":87,"context_line":"    CONF.register_opt(opt, group\u003d\u0027controller_worker\u0027)"},{"line_number":88,"context_line":"    return {"},{"line_number":89,"context_line":"        \u0027controller_worker\u0027: {"},{"line_number":90,"context_line":"            \u0027amphora_udp_driver\u0027: CONF.controller_worker.amphora_udp_driver"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_888efe76","line":87,"range":{"start_line":87,"start_character":34,"end_line":87,"end_character":51},"updated":"2018-05-11 23:11:23.000000000","message":"This should be under the \"amphora_agent\" section which is already being registered","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"22f377361c3bb357c8770ff42fc8dace7edf6da7","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    opt \u003d cfg.StrOpt(\u0027amphora_udp_driver\u0027,"},{"line_number":85,"context_line":"                     default\u003d\u0027keepalived_lvs\u0027,"},{"line_number":86,"context_line":"                     help\u003d\u0027The UDP API backend for amphora agent.\u0027)"},{"line_number":87,"context_line":"    CONF.register_opt(opt, group\u003d\u0027controller_worker\u0027)"},{"line_number":88,"context_line":"    return {"},{"line_number":89,"context_line":"        \u0027controller_worker\u0027: {"},{"line_number":90,"context_line":"            \u0027amphora_udp_driver\u0027: CONF.controller_worker.amphora_udp_driver"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_05d16323","line":87,"range":{"start_line":87,"start_character":34,"end_line":87,"end_character":51},"in_reply_to":"5f7c97a3_888efe76","updated":"2018-05-14 11:10:06.000000000","message":"OK. Thank you for suggestion, I will move it. The group is the key point I write like this. :) Thank you for clear","commit_id":"8178f29e8199da0ee5a7e0f56c422e4eb9e46612"}],"octavia/controller/worker/flows/amphora_flows.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e5cf2b5b50b95c55a8e00fd0223593c0b033815a","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        # The reason for moving these steps here is the udp listeners want to"},{"line_number":389,"context_line":"        # do some kernel configuration before Listener update for forbidding"},{"line_number":390,"context_line":"        # failure during rebuild amphora."},{"line_number":391,"context_line":"        failover_amphora_flow.add(network_tasks.PlugVIPPort("},{"line_number":392,"context_line":"            requires\u003d(constants.AMPHORA, constants.AMPHORAE_NETWORK_CONFIG)))"},{"line_number":393,"context_line":"        failover_amphora_flow.add(amphora_driver_tasks.AmphoraPostVIPPlug("},{"line_number":394,"context_line":"            requires\u003d(constants.AMPHORA, constants.LOADBALANCER,"}],"source_content_type":"text/x-python","patch_set":59,"id":"5f7c97a3_e32650cd","line":391,"updated":"2018-08-02 23:31:49.000000000","message":"The initial issue I see in moving this is that users will get REJECT ICMP as the port is now open on the security group but there is potentially no service listening on the port.\nDo you have log output of what the issue was with having this where it was?","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e60a7670cc1a9befbe48e79d0cd2d533be28cff7","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        # The reason for moving these steps here is the udp listeners want to"},{"line_number":389,"context_line":"        # do some kernel configuration before Listener update for forbidding"},{"line_number":390,"context_line":"        # failure during rebuild amphora."},{"line_number":391,"context_line":"        failover_amphora_flow.add(network_tasks.PlugVIPPort("},{"line_number":392,"context_line":"            requires\u003d(constants.AMPHORA, constants.AMPHORAE_NETWORK_CONFIG)))"},{"line_number":393,"context_line":"        failover_amphora_flow.add(amphora_driver_tasks.AmphoraPostVIPPlug("},{"line_number":394,"context_line":"            requires\u003d(constants.AMPHORA, constants.LOADBALANCER,"}],"source_content_type":"text/x-python","patch_set":59,"id":"5f7c97a3_a65866fc","line":391,"in_reply_to":"5f7c97a3_e32650cd","updated":"2018-08-03 00:05:16.000000000","message":"I remember this issue, I will show you a brief for it. And the log I will show you later.\n1. Deploy Active-Standby mode.\n2. When all amp instance become Active, I create the necessary UDP resources, listener, pool, member. And run a iperf to test they are OK.\n3. Then I use \"openstack server delete\" the MASTER amp, and during the failover not begin, I run a iperf to check whether it can connect to member.\n4. Failover begin, but we first update UpdateListeners in L418, then the failover failed with agent side error 500, the log is \"start udp listener XXXXXXXX failed\", as it need the kernel configuration and some loaded kernel modules towards this new amp instance. This part process will happen in real PostVIPplug which call agent side to run sysctl -system/some basic things.","commit_id":"4788e2b58e1413e57aa5a161a7e5fca73e453da6"}],"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e0d0f53db046d40bc1e568b72016b101f58e1933","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            if listener.provisioning_status !\u003d constants.PENDING_DELETE and"},{"line_number":142,"context_line":"            listener.provisioning_status !\u003d constants.DELETED]"},{"line_number":143,"context_line":"        peer_ports \u003d ["},{"line_number":144,"context_line":"            (listener.peer_port,"},{"line_number":145,"context_line":"             constants.PROTOCOL_TCP"},{"line_number":146,"context_line":"             if listener.protocol !\u003d constants.PROTOCOL_UDP else"},{"line_number":147,"context_line":"             constants.PROTOCOL_UDP) for listener in load_balancer.listeners"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f7c97a3_26f9e0c3","line":144,"updated":"2018-06-26 16:16:47.000000000","message":"This cannot change to UDP. The peer port is used for TCP keepalived and haproxy session synchronization. It will always be TCP. This likely doesn\u0027t matter for UDP since it has not session to sync, but we should still not change this.","commit_id":"2b4be64d9679644cf5c96459800f7a6707f77467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a13ea1f654e19d3001f53f2974cb8ccda5aadb09","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            if listener.provisioning_status !\u003d constants.PENDING_DELETE and"},{"line_number":142,"context_line":"            listener.provisioning_status !\u003d constants.DELETED]"},{"line_number":143,"context_line":"        peer_ports \u003d ["},{"line_number":144,"context_line":"            (listener.peer_port,"},{"line_number":145,"context_line":"             constants.PROTOCOL_TCP"},{"line_number":146,"context_line":"             if listener.protocol !\u003d constants.PROTOCOL_UDP else"},{"line_number":147,"context_line":"             constants.PROTOCOL_UDP) for listener in load_balancer.listeners"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f7c97a3_46dadce8","line":144,"in_reply_to":"5f7c97a3_26f9e0c3","updated":"2018-06-26 17:04:39.000000000","message":"Oh, yeah. Thanks. You are right. My head is reeling. :)","commit_id":"2b4be64d9679644cf5c96459800f7a6707f77467"}],"setup.cfg":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8351562842dd8a253112bce692984d77cdbec9a4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"octavia.amphora.drivers \u003d"},{"line_number":76,"context_line":"    amphora_noop_driver \u003d octavia.amphorae.drivers.noop_driver.driver:NoopAmphoraLoadBalancerDriver"},{"line_number":77,"context_line":"    amphora_haproxy_rest_driver \u003d octavia.amphorae.drivers.haproxy.rest_api_driver:HaproxyAmphoraLoadBalancerDriver"},{"line_number":78,"context_line":"    amphora_haproxy_lvs_rest_driver \u003d octavia.amphorae.drivers.haproxy.rest_api_driver.IntegratedLvsAmphoraLoadBalancerDriver"},{"line_number":79,"context_line":"octavia.controller.queues \u003d"},{"line_number":80,"context_line":"    noop_event_streamer \u003d octavia.controller.queue.event_queue:EventStreamerNoop"},{"line_number":81,"context_line":"    queue_event_streamer \u003d octavia.controller.queue.event_queue:EventStreamerNeutron"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"5f93b717_f8b57eef","line":78,"updated":"2018-01-26 06:32:12.000000000","message":"Do we need to do this?  Can we just extend the current HaproxyAmphoraLoadBalancerDriver?","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"38c844838250556382d8fd9690da28de5c310f0e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"octavia.amphora.drivers \u003d"},{"line_number":76,"context_line":"    amphora_noop_driver \u003d octavia.amphorae.drivers.noop_driver.driver:NoopAmphoraLoadBalancerDriver"},{"line_number":77,"context_line":"    amphora_haproxy_rest_driver \u003d octavia.amphorae.drivers.haproxy.rest_api_driver:HaproxyAmphoraLoadBalancerDriver"},{"line_number":78,"context_line":"    amphora_haproxy_lvs_rest_driver \u003d octavia.amphorae.drivers.haproxy.rest_api_driver.IntegratedLvsAmphoraLoadBalancerDriver"},{"line_number":79,"context_line":"octavia.controller.queues \u003d"},{"line_number":80,"context_line":"    noop_event_streamer \u003d octavia.controller.queue.event_queue:EventStreamerNoop"},{"line_number":81,"context_line":"    queue_event_streamer \u003d octavia.controller.queue.event_queue:EventStreamerNeutron"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"5f93b717_eefff464","line":78,"in_reply_to":"5f93b717_f8b57eef","updated":"2018-01-26 07:07:49.000000000","message":"Hmmm, my initial thought is not much impact on the existing code. So I try the best to split the new code from octavia core code. Created a new subclass to combine the Haproxy part and Lvs part. Of course, I can change this as wish. Move to extend HaproxyAmphoraLoadBlancerDriver.","commit_id":"99a5958997b852282e9cf11c5e30717305b3eab7"}]}
