)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"d4a10ef73390824b011c295c455fb1d240770ca2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update configuration samples"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable QoS support by:"},{"line_number":10,"context_line":"* enable Neutron plugin"},{"line_number":11,"context_line":"* enable q-qos service"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idd99af81cafd4c8fc541ca8664c844b5473bb39a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7f96bb07_4c7dc01a","line":10,"updated":"2018-01-23 01:53:06.000000000","message":"If neutron plugin is enabled by default, this seems not required, also should we enable neutron-qos?","commit_id":"806683b0dee7e0dd471ad716f2a0cf0f0c671aeb"}],"devstack/contrib/new-octavia-devstack.sh":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"4ed780e8360a5a369c72801f89b6c6ec35d3b3ba","unresolved":false,"context_lines":[{"line_number":11,"context_line":"INSTALLERS_ARRAY \u003d (apt apt-get dnf yum)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"for installer in ${INSTALLERS_ARRAY[@]}; do"},{"line_number":14,"context_line":"\tif [[ -z `command -v ${installer} ]]; then"},{"line_number":15,"context_line":"\t\t${installer} -y update"},{"line_number":16,"context_line":"\t\t${installer} -y install git vim"},{"line_number":17,"context_line":"\t\tbreak"},{"line_number":18,"context_line":"\tfi"},{"line_number":19,"context_line":"\tif [[ ${installer} \u003d ${INSTALLERS_ARRAY[-1]} ]]; then"},{"line_number":20,"context_line":"\t\techo \"No compatible installer was found. Aborting.\" \u003e\u00262"},{"line_number":21,"context_line":"\t\texit 1"},{"line_number":22,"context_line":"\tfi"},{"line_number":23,"context_line":"done"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# TODO(sbalukoff): Add prerequisites for other distributions."}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf8cb3f7_5809052a","line":22,"range":{"start_line":14,"start_character":0,"end_line":22,"end_character":3},"updated":"2017-12-23 14:03:20.000000000","message":"Can we change these tabs to space?","commit_id":"ae7515e89905ac9f2d91caf24a0ed9fb4d1a3a80"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"b908bf052294a8ce639dccbe3cdf562daec6cbe0","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Set up the packages we need."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# order matters"},{"line_number":11,"context_line":"INSTALLERS_ARRAY \u003d (apt apt-get dnf yum)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"for installer in ${INSTALLERS_ARRAY[@]}; do"},{"line_number":14,"context_line":"    if [[ -z `command -v ${installer} ]]; then"},{"line_number":15,"context_line":"        ${installer} -y update"},{"line_number":16,"context_line":"        ${installer} -y install git vim"},{"line_number":17,"context_line":"        break"},{"line_number":18,"context_line":"    fi"},{"line_number":19,"context_line":"    if [[ ${installer} \u003d ${INSTALLERS_ARRAY[-1]} ]]; then"},{"line_number":20,"context_line":"        echo \"No compatible installer was found. Aborting.\" \u003e\u00262"},{"line_number":21,"context_line":"        exit 1"},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":"done"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# TODO(sbalukoff): Add prerequisites for other distributions."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"bf8cb3f7_15449bb6","line":23,"range":{"start_line":10,"start_character":0,"end_line":23,"end_character":4},"updated":"2017-12-25 09:06:52.000000000","message":"This is not needed.\nJust use the install_package wrapper from devstack.\n\nExamples:\nhttps://github.com/openstack/octavia/blob/32206f77f6428d24bb27a72e05130a183acedd6b/devstack/plugin.sh#L15\nhttps://github.com/openstack/octavia/blob/32206f77f6428d24bb27a72e05130a183acedd6b/devstack/plugin.sh#L17\nhttps://github.com/openstack/octavia/blob/32206f77f6428d24bb27a72e05130a183acedd6b/devstack/plugin.sh#L401","commit_id":"2f3d9e73f12811e8edeb84cbbb4d78240661f8b5"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"12c96536adfbb395c6399d3a4e4b7f12a0b1a249","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Set up the packages we need."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# order matters"},{"line_number":11,"context_line":"INSTALLERS_ARRAY \u003d (apt apt-get dnf yum)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"for installer in ${INSTALLERS_ARRAY[@]}; do"},{"line_number":14,"context_line":"    if [[ -z `command -v ${installer} ]]; then"},{"line_number":15,"context_line":"        ${installer} -y update"},{"line_number":16,"context_line":"        ${installer} -y install git vim"},{"line_number":17,"context_line":"        break"},{"line_number":18,"context_line":"    fi"},{"line_number":19,"context_line":"    if [[ ${installer} \u003d ${INSTALLERS_ARRAY[-1]} ]]; then"},{"line_number":20,"context_line":"        echo \"No compatible installer was found. Aborting.\" \u003e\u00262"},{"line_number":21,"context_line":"        exit 1"},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":"done"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# TODO(sbalukoff): Add prerequisites for other distributions."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"bf8cb3f7_6a1421a1","line":23,"range":{"start_line":10,"start_character":0,"end_line":23,"end_character":4},"in_reply_to":"bf8cb3f7_15449bb6","updated":"2017-12-26 03:53:31.000000000","message":"+1","commit_id":"2f3d9e73f12811e8edeb84cbbb4d78240661f8b5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c102b865aefb025b4765448c065de391c931ec09","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Set up the packages we need."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# order matters"},{"line_number":11,"context_line":"INSTALLERS_ARRAY \u003d (apt apt-get dnf yum)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"for installer in ${INSTALLERS_ARRAY[@]}; do"},{"line_number":14,"context_line":"    if [[ -z `command -v ${installer} ]]; then"},{"line_number":15,"context_line":"        ${installer} -y update"},{"line_number":16,"context_line":"        ${installer} -y install git vim"},{"line_number":17,"context_line":"        break"},{"line_number":18,"context_line":"    fi"},{"line_number":19,"context_line":"    if [[ ${installer} \u003d ${INSTALLERS_ARRAY[-1]} ]]; then"},{"line_number":20,"context_line":"        echo \"No compatible installer was found. Aborting.\" \u003e\u00262"},{"line_number":21,"context_line":"        exit 1"},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":"done"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# TODO(sbalukoff): Add prerequisites for other distributions."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"5f93b717_4ae1469a","line":23,"range":{"start_line":10,"start_character":0,"end_line":23,"end_character":4},"in_reply_to":"bf8cb3f7_15449bb6","updated":"2018-01-25 16:54:12.000000000","message":"Agreed. It would make the distro specific issues easier.","commit_id":"2f3d9e73f12811e8edeb84cbbb4d78240661f8b5"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"abeaf9b519cd8cf6b4887811cc8b731c1c45b9aa","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Set up the packages we need."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# order matters"},{"line_number":11,"context_line":"INSTALLERS_ARRAY \u003d (apt apt-get dnf yum)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"for installer in ${INSTALLERS_ARRAY[@]}; do"},{"line_number":14,"context_line":"    if [[ -z `command -v ${installer} ]]; then"},{"line_number":15,"context_line":"        ${installer} -y update"},{"line_number":16,"context_line":"        ${installer} -y install git vim"},{"line_number":17,"context_line":"        break"},{"line_number":18,"context_line":"    elif [[ ${installer} \u003d ${INSTALLERS_ARRAY[-1]} ]]; then"},{"line_number":19,"context_line":"        echo \"No compatible installer was found. Aborting.\" \u003e\u00262"},{"line_number":20,"context_line":"        exit 1"},{"line_number":21,"context_line":"    fi"},{"line_number":22,"context_line":"done"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(sbalukoff): Add prerequisites for other distributions."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"7f96bb07_abe0e0cd","line":22,"range":{"start_line":11,"start_character":0,"end_line":22,"end_character":4},"updated":"2018-01-14 13:47:09.000000000","message":"See my comment about install_package in PS#4","commit_id":"d472e33ea5efb5b20678bddb6942aa8404a8c261"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"7baba1ab2528c5b4636a5c4eb6254005f68c97bd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# that the underlying hardware have nested virtualization enabled or you will"},{"line_number":6,"context_line":"# experience very poor amphora performance."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Set up the packages we need. Ubuntu package manager is assumed."},{"line_number":9,"context_line":"apt-get update"},{"line_number":10,"context_line":"apt-get install git vim -y"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f96bb07_d69cb60f","line":8,"range":{"start_line":8,"start_character":31,"end_line":8,"end_character":65},"updated":"2018-01-16 14:37:13.000000000","message":"why?\nwhat about install_package?","commit_id":"c05b1078a8b004b52e6ccbfdb50456dd1471c897"},{"author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"change_message_id":"d4414d5c00a7407420b28c94ac7c198b182a6f0d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# that the underlying hardware have nested virtualization enabled or you will"},{"line_number":6,"context_line":"# experience very poor amphora performance."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Set up the packages we need. Ubuntu package manager is assumed."},{"line_number":9,"context_line":"apt-get update"},{"line_number":10,"context_line":"apt-get install git vim -y"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f96bb07_114ea896","line":8,"range":{"start_line":8,"start_character":31,"end_line":8,"end_character":65},"in_reply_to":"7f96bb07_d69cb60f","updated":"2018-01-16 15:07:43.000000000","message":"I thought it makes sense to leave this comment as it is, since this script stands on its own merit.\nFeel free to submit another patch set, if you like.","commit_id":"c05b1078a8b004b52e6ccbfdb50456dd1471c897"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"efe1aa963f56247af801b4fc6f70fee77223b397","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"cat \u003c\u003cEOF \u003e $HOME/devstack/localrc"},{"line_number":18,"context_line":"enable_plugin barbican https://review.openstack.org/openstack/barbican"},{"line_number":19,"context_line":"enable_plugin neutron https://review.openstack.org/openstack/neutron"},{"line_number":20,"context_line":"enable_plugin octavia https://review.openstack.org/openstack/octavia"},{"line_number":21,"context_line":"LIBS_FROM_GIT+\u003dpython-octaviaclient"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f96bb07_3d73c882","line":19,"updated":"2018-01-22 22:26:41.000000000","message":"We typically don\u0027t do this as it is a required base service for devstack, it will always be enabled.","commit_id":"c05b1078a8b004b52e6ccbfdb50456dd1471c897"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c45bb41d6ead1b204e503ad4c2bf2d04bafd620d","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"cat \u003c\u003cEOF \u003e $HOME/devstack/localrc"},{"line_number":18,"context_line":"enable_plugin barbican https://review.openstack.org/openstack/barbican"},{"line_number":19,"context_line":"enable_plugin neutron https://review.openstack.org/openstack/neutron"},{"line_number":20,"context_line":"enable_plugin octavia https://review.openstack.org/openstack/octavia"},{"line_number":21,"context_line":"LIBS_FROM_GIT+\u003dpython-octaviaclient"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f96bb07_9198c36a","line":19,"in_reply_to":"7f96bb07_00da1f16","updated":"2018-01-23 01:10:24.000000000","message":"It should not be required, devstack always runs the neutron plugin.","commit_id":"c05b1078a8b004b52e6ccbfdb50456dd1471c897"},{"author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"change_message_id":"410335f6663bd4d706f825c617f3cb5bdc8997cc","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"cat \u003c\u003cEOF \u003e $HOME/devstack/localrc"},{"line_number":18,"context_line":"enable_plugin barbican https://review.openstack.org/openstack/barbican"},{"line_number":19,"context_line":"enable_plugin neutron https://review.openstack.org/openstack/neutron"},{"line_number":20,"context_line":"enable_plugin octavia https://review.openstack.org/openstack/octavia"},{"line_number":21,"context_line":"LIBS_FROM_GIT+\u003dpython-octaviaclient"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f96bb07_00da1f16","line":19,"in_reply_to":"7f96bb07_3d73c882","updated":"2018-01-22 23:31:06.000000000","message":"I understand it is atypical, however, - and correct me if I\u0027m wrong here, but - I think it is required in order to access these bits: https://github.com/openstack/neutron/blob/master/devstack/plugin.sh#L34-L36\nThe neutron devstack code configures the relevant parameters for QoS, so I can get up\u0026running with a clean machine. This way, I avoided cloning the code onto Octavia.","commit_id":"c05b1078a8b004b52e6ccbfdb50456dd1471c897"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"bac7fb5dbec9b4cadf4e8dcaf00699763f688c7b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# Glance"},{"line_number":40,"context_line":"ENABLED_SERVICES+\u003d,g-api,g-reg"},{"line_number":41,"context_line":"# Neutron"},{"line_number":42,"context_line":"ENABLED_SERVICES+\u003d,neutron,q-agt,q-dhcp,q-l3,q-meta,q-qos,q-svc"},{"line_number":43,"context_line":"# Tempest (optional)"},{"line_number":44,"context_line":"#ENABLED_SERVICES+\u003d,tempest"},{"line_number":45,"context_line":"# Octavia"}],"source_content_type":"text/x-sh","patch_set":8,"id":"7f96bb07_acf564ef","line":42,"updated":"2018-01-23 01:44:48.000000000","message":"Should we enable neutron-qos here also?","commit_id":"806683b0dee7e0dd471ad716f2a0cf0f0c671aeb"}],"devstack/samples/multinode/local.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"efe1aa963f56247af801b4fc6f70fee77223b397","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Load the external Octavia plugin."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"enable_plugin barbican https://git.openstack.org/openstack/barbican"},{"line_number":11,"context_line":"enable_plugin neutron https://git.openstack.org/openstack/neutron"},{"line_number":12,"context_line":"enable_plugin octavia-dashboard https://git.openstack.org/openstack/octavia-dashboard"},{"line_number":13,"context_line":"enable_plugin octavia https://git.openstack.org/openstack/octavia"},{"line_number":14,"context_line":""}],"source_content_type":"text/plain","patch_set":6,"id":"7f96bb07_5d6ed496","line":11,"updated":"2018-01-22 22:26:41.000000000","message":"We typically don\u0027t do this as neutron is a required base service for devstack, it will always be enabled.","commit_id":"c05b1078a8b004b52e6ccbfdb50456dd1471c897"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"bac7fb5dbec9b4cadf4e8dcaf00699763f688c7b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"enable_service q-dhcp"},{"line_number":52,"context_line":"enable_service q-l3"},{"line_number":53,"context_line":"enable_service q-meta"},{"line_number":54,"context_line":"enable_service q-qos"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Octavia"},{"line_number":57,"context_line":"enable_service octavia"}],"source_content_type":"text/plain","patch_set":8,"id":"7f96bb07_0ce6d845","line":54,"updated":"2018-01-23 01:44:48.000000000","message":"Should we enable neutron-qos here also?","commit_id":"806683b0dee7e0dd471ad716f2a0cf0f0c671aeb"}],"devstack/samples/singlenode/local.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"efe1aa963f56247af801b4fc6f70fee77223b397","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Load the external Octavia plugin."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"enable_plugin barbican https://git.openstack.org/openstack/barbican"},{"line_number":24,"context_line":"enable_plugin neutron https://git.openstack.org/openstack/neutron"},{"line_number":25,"context_line":"enable_plugin octavia https://git.openstack.org/openstack/octavia"},{"line_number":26,"context_line":"enable_plugin octavia-dashboard https://git.openstack.org/openstack/octavia-dashboard"},{"line_number":27,"context_line":""}],"source_content_type":"text/plain","patch_set":6,"id":"7f96bb07_fd6c809d","line":24,"updated":"2018-01-22 22:26:41.000000000","message":"We typically don\u0027t do this as neutron is a required base service for devstack, it will always be enabled.","commit_id":"c05b1078a8b004b52e6ccbfdb50456dd1471c897"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"bac7fb5dbec9b4cadf4e8dcaf00699763f688c7b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"enable_service q-dhcp"},{"line_number":65,"context_line":"enable_service q-l3"},{"line_number":66,"context_line":"enable_service q-meta"},{"line_number":67,"context_line":"enable_service q-qos"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Octavia"},{"line_number":70,"context_line":"enable_service octavia"}],"source_content_type":"text/plain","patch_set":8,"id":"7f96bb07_ccd1d059","line":67,"updated":"2018-01-23 01:44:48.000000000","message":"Should we enable neutron-qos here also?","commit_id":"806683b0dee7e0dd471ad716f2a0cf0f0c671aeb"}]}