)]}'
{"octavia/controller/healthmanager/update_db.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"70eb107916e4a623122a571fa536483283faab2a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            proc_delay \u003d time.time() - health[\u0027recv_time\u0027]"},{"line_number":121,"context_line":"            hb_interval \u003d CONF.health_manager.heartbeat_interval"},{"line_number":122,"context_line":"            if proc_delay \u003e\u003d hb_interval:"},{"line_number":123,"context_line":"                LOG.warning(\u0027Amphora %(id)s health message was processed too \u0027"},{"line_number":124,"context_line":"                            \u0027slowly: %(delay)ss! The system may be overloaded \u0027"},{"line_number":125,"context_line":"                            \u0027or otherwise malfunctioning. THIS IS NOT GOOD.\u0027,"},{"line_number":126,"context_line":"                            {\u0027id\u0027: health[\u0027id\u0027], \u0027delay\u0027: proc_delay})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_e0e05bcf","line":123,"updated":"2018-01-03 20:58:46.000000000","message":"shouldn\u0027t we advise operators to start more hm processes?","commit_id":"72fbea4cdb9d84cd7ccd0e048d338a27307bc6fd"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"70a871e8e63026e7861f6cc26e925ee6c9f33e83","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            proc_delay \u003d time.time() - health[\u0027recv_time\u0027]"},{"line_number":121,"context_line":"            hb_interval \u003d CONF.health_manager.heartbeat_interval"},{"line_number":122,"context_line":"            if proc_delay \u003e\u003d hb_interval:"},{"line_number":123,"context_line":"                LOG.warning(\u0027Amphora %(id)s health message was processed too \u0027"},{"line_number":124,"context_line":"                            \u0027slowly: %(delay)ss! The system may be overloaded \u0027"},{"line_number":125,"context_line":"                            \u0027or otherwise malfunctioning. THIS IS NOT GOOD.\u0027,"},{"line_number":126,"context_line":"                            {\u0027id\u0027: health[\u0027id\u0027], \u0027delay\u0027: proc_delay})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_547785d5","line":123,"in_reply_to":"9f91af0f_e0e05bcf","updated":"2018-01-04 01:28:26.000000000","message":"Yeah, given my experience, it\u0027s \"not that simple\". What exactly to do in this case is not really in the scope of a log warning message anyway.","commit_id":"72fbea4cdb9d84cd7ccd0e048d338a27307bc6fd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"337478086db204950cdda29ae05a907e549a761e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            if proc_delay \u003e\u003d hb_interval:"},{"line_number":123,"context_line":"                LOG.warning(\u0027Amphora %(id)s health message was processed too \u0027"},{"line_number":124,"context_line":"                            \u0027slowly: %(delay)ss! The system may be overloaded \u0027"},{"line_number":125,"context_line":"                            \u0027or otherwise malfunctioning. THIS IS NOT GOOD.\u0027,"},{"line_number":126,"context_line":"                            {\u0027id\u0027: health[\u0027id\u0027], \u0027delay\u0027: proc_delay})"},{"line_number":127,"context_line":"                return"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_e0661b2a","line":125,"range":{"start_line":125,"start_character":58,"end_line":125,"end_character":74},"updated":"2018-01-03 21:20:20.000000000","message":"I don\u0027t know about advising *how* to solve the problem as German mentioned, but I think we do need to be explicit that we are dropping this heartbeat on the floor.","commit_id":"72fbea4cdb9d84cd7ccd0e048d338a27307bc6fd"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"70a871e8e63026e7861f6cc26e925ee6c9f33e83","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            if proc_delay \u003e\u003d hb_interval:"},{"line_number":123,"context_line":"                LOG.warning(\u0027Amphora %(id)s health message was processed too \u0027"},{"line_number":124,"context_line":"                            \u0027slowly: %(delay)ss! The system may be overloaded \u0027"},{"line_number":125,"context_line":"                            \u0027or otherwise malfunctioning. THIS IS NOT GOOD.\u0027,"},{"line_number":126,"context_line":"                            {\u0027id\u0027: health[\u0027id\u0027], \u0027delay\u0027: proc_delay})"},{"line_number":127,"context_line":"                return"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_d4639519","line":125,"range":{"start_line":125,"start_character":58,"end_line":125,"end_character":74},"in_reply_to":"9f91af0f_e0661b2a","updated":"2018-01-04 01:28:26.000000000","message":"Ah, true.","commit_id":"72fbea4cdb9d84cd7ccd0e048d338a27307bc6fd"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"76f6576b82179f26349b64f0eabf400244029b94","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            proc_delay \u003d time.time() - health[\u0027recv_time\u0027]"},{"line_number":121,"context_line":"            hb_interval \u003d CONF.health_manager.heartbeat_interval"},{"line_number":122,"context_line":"            if proc_delay \u003e\u003d hb_interval:"},{"line_number":123,"context_line":"                LOG.warning(\u0027Amphora %(id)s health message was processed too \u0027"},{"line_number":124,"context_line":"                            \u0027slowly: %(delay)ss! The system may be overloaded \u0027"},{"line_number":125,"context_line":"                            \u0027or otherwise malfunctioning. This heartbeat has \u0027"},{"line_number":126,"context_line":"                            \u0027been ignored and no update was made to the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_ea027209","line":123,"updated":"2018-01-04 02:41:00.000000000","message":"I am on the fence on this: I think we should log at the ERROR level since we likely need them to address that somehow and at the off chance they misconfigured their NTP or have time drift they need to know about this. Thoughts?","commit_id":"61e0c14f48130d1d0519fa5527d2712ba6ce504f"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"1b07cafd54c05a759a951d386d3d9b46d50f7fd1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            proc_delay \u003d time.time() - health[\u0027recv_time\u0027]"},{"line_number":121,"context_line":"            hb_interval \u003d CONF.health_manager.heartbeat_interval"},{"line_number":122,"context_line":"            if proc_delay \u003e\u003d hb_interval:"},{"line_number":123,"context_line":"                LOG.warning(\u0027Amphora %(id)s health message was processed too \u0027"},{"line_number":124,"context_line":"                            \u0027slowly: %(delay)ss! The system may be overloaded \u0027"},{"line_number":125,"context_line":"                            \u0027or otherwise malfunctioning. This heartbeat has \u0027"},{"line_number":126,"context_line":"                            \u0027been ignored and no update was made to the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_ea17d2a2","line":123,"in_reply_to":"9f91af0f_ea027209","updated":"2018-01-04 03:34:25.000000000","message":"Unrelated to NTP or how their time is set at all -- it\u0027s local time on the same box both times, so if there\u0027s drift it won\u0027t matter.","commit_id":"61e0c14f48130d1d0519fa5527d2712ba6ce504f"}]}