)]}'
{"devstack/contrib/new-octavia-devstack.sh":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"3a66270b42ced2b8db0e71e1175cad754307c305","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# that the underlying hardware have nested virtualization enabled or you will"},{"line_number":5,"context_line":"# experience very poor amphora performance."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# order matters"},{"line_number":8,"context_line":"INSTALLERS_ARRAY \u003d (apt apt-get dnf yum)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"for installer in ${INSTALLERS_ARRAY[@]}; do"},{"line_number":11,"context_line":"    if [[ -z `command -v ${installer} ]]; then"},{"line_number":12,"context_line":"        ${installer} -y update"},{"line_number":13,"context_line":"        ${installer} -y install git vim"},{"line_number":14,"context_line":"        break"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"    if [[ ${installer} \u003d ${INSTALLERS_ARRAY[-1]} ]]; then"},{"line_number":17,"context_line":"        echo \"No compatible installer was found. Aborting.\" \u003e\u00262"},{"line_number":18,"context_line":"        exit 1"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"done"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# TODO(sbalukoff): Add prerequisites for other distributions."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f96bb07_6f102058","line":20,"range":{"start_line":7,"start_character":0,"end_line":20,"end_character":4},"updated":"2018-01-18 09:11:18.000000000","message":"see my comment from: https://review.openstack.org/#/c/529861/4/devstack/contrib/new-octavia-devstack.sh","commit_id":"d6ea355a636a5fe91dcdeb924f67dcd73db32414"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a95e194b6aa629366ba63338d50a985aa8a1d17f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# experience very poor amphora performance."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# order matters"},{"line_number":8,"context_line":"INSTALLERS_ARRAY \u003d (apt apt-get dnf yum)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"for installer in ${INSTALLERS_ARRAY[@]}; do"},{"line_number":11,"context_line":"    if [[ -z `command -v ${installer} ]]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f93b717_190abad1","line":8,"updated":"2018-01-25 20:01:34.000000000","message":"Can we use the devstack function for this and not have to deal with distro specific upgrade processes?","commit_id":"191accf0920ee22a96c19b8a96647663c0c9854f"},{"author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"change_message_id":"4e67d855c605206f544c81f610e29d28ed7dff5d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# experience very poor amphora performance."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# order matters"},{"line_number":8,"context_line":"INSTALLERS_ARRAY \u003d (apt apt-get dnf yum)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"for installer in ${INSTALLERS_ARRAY[@]}; do"},{"line_number":11,"context_line":"    if [[ -z `command -v ${installer} ]]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f93b717_39ac568b","line":8,"in_reply_to":"5f93b717_190abad1","updated":"2018-01-25 20:09:28.000000000","message":"Not really, because I haven\u0027t cloned devstack yet.\nTo clone it, I need git installed.\nSo essentially, I cannot use any installer-functionality that is implemented within a repo for that matter.","commit_id":"191accf0920ee22a96c19b8a96647663c0c9854f"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"8b31c64b2534670a2ba519860b2c5b09ec0d5699","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"done"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# TODO(sbalukoff): Add prerequisites for other distributions."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Clone the devstack repo"},{"line_number":21,"context_line":"git clone https://github.com/openstack-dev/devstack.git $HOME/devstack"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5f93b717_09dd7f41","line":18,"updated":"2018-01-26 02:56:41.000000000","message":"Should this be removed also if this patch is landed?","commit_id":"72984c13b5c0f424f4cb5fbf4825f9176ca0aa41"},{"author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"change_message_id":"ac26514cb332bd59e26aac5ad2657e456e2472f9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"done"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# TODO(sbalukoff): Add prerequisites for other distributions."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Clone the devstack repo"},{"line_number":21,"context_line":"git clone https://github.com/openstack-dev/devstack.git $HOME/devstack"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5f93b717_27b89fc6","line":18,"in_reply_to":"5f93b717_09dd7f41","updated":"2018-01-26 08:55:49.000000000","message":"good idea","commit_id":"72984c13b5c0f424f4cb5fbf4825f9176ca0aa41"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"8b31c64b2534670a2ba519860b2c5b09ec0d5699","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Clone the devstack repo"},{"line_number":21,"context_line":"git clone https://github.com/openstack-dev/devstack.git $HOME/devstack"},{"line_number":22,"context_line":"if [[ \"$?\" \u003d \"0\" ]]; then"},{"line_number":23,"context_line":"    echo \"Failed to clone devstack repo. Aborting.\" \u003e\u00262"},{"line_number":24,"context_line":"    exit 1"},{"line_number":25,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5f93b717_a9180b1d","line":22,"updated":"2018-01-26 02:56:41.000000000","message":"If it fails, the $? should be non zero.\nzero mean success in bash.","commit_id":"72984c13b5c0f424f4cb5fbf4825f9176ca0aa41"},{"author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"change_message_id":"ac26514cb332bd59e26aac5ad2657e456e2472f9","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Clone the devstack repo"},{"line_number":21,"context_line":"git clone https://github.com/openstack-dev/devstack.git $HOME/devstack"},{"line_number":22,"context_line":"if [[ \"$?\" \u003d \"0\" ]]; then"},{"line_number":23,"context_line":"    echo \"Failed to clone devstack repo. Aborting.\" \u003e\u00262"},{"line_number":24,"context_line":"    exit 1"},{"line_number":25,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5f93b717_47bdabb5","line":22,"in_reply_to":"5f93b717_a9180b1d","updated":"2018-01-26 08:55:49.000000000","message":"Done","commit_id":"72984c13b5c0f424f4cb5fbf4825f9176ca0aa41"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"424eb5d191f2a02b0d9256402484b312e0e9f638","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Please note that if you are running this in a VM, it is vitally important"},{"line_number":4,"context_line":"# that the underlying hardware have nested virtualization enabled or you will"}],"source_content_type":"text/x-sh","patch_set":9,"id":"5f7c97a3_e354decc","line":1,"updated":"2018-05-07 19:24:04.000000000","message":"possibly just set -xe here?","commit_id":"25fa4c26462fa0103d9c54ab8704949bf9ef4188"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"7e7851ef5b625208341a2483ab0c9fff0f784692","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# experience very poor amphora performance."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# order matters"},{"line_number":8,"context_line":"INSTALLERS_ARRAY \u003d (apt apt-get dnf yum)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"for installer in ${INSTALLERS_ARRAY[@]}; do"},{"line_number":11,"context_line":"    if [[ -z `command -v ${installer}` ]]; then"},{"line_number":12,"context_line":"        ${installer} -y update"},{"line_number":13,"context_line":"        ${installer} -y install git"},{"line_number":14,"context_line":"        break"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"done"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Clone the devstack repo"},{"line_number":19,"context_line":"git clone https://github.com/openstack-dev/devstack.git $HOME/devstack"}],"source_content_type":"text/x-sh","patch_set":9,"id":"5f7c97a3_ffbe6fb2","line":16,"range":{"start_line":8,"start_character":0,"end_line":16,"end_character":4},"updated":"2018-05-10 10:29:16.000000000","message":"My comment from PS#1 is still not addressed. So I\u0027ll submit it again:\n\nThis is not needed.\nJust use the install_package wrapper from devstack.\n \nExamples:\nhttps://github.com/openstack/octavia/blob/32206f77f6428d24bb27a72e05130a183acedd6b/devstack/plugin.sh#L15\nhttps://github.com/openstack/octavia/blob/32206f77f6428d24bb27a72e05130a183acedd6b/devstack/plugin.sh#L17\nhttps://github.com/openstack/octavia/blob/32206f77f6428d24bb27a72e05130a183acedd6b/devstack/plugin.sh#L401","commit_id":"25fa4c26462fa0103d9c54ab8704949bf9ef4188"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"424eb5d191f2a02b0d9256402484b312e0e9f638","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Clone the devstack repo"},{"line_number":19,"context_line":"git clone https://github.com/openstack-dev/devstack.git $HOME/devstack"},{"line_number":20,"context_line":"if [[ \"$?\" \u003d \"1\" ]]; then"},{"line_number":21,"context_line":"    echo \"Failed to clone devstack repo. Aborting.\" \u003e\u00262"},{"line_number":22,"context_line":"    exit 1"},{"line_number":23,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"5f7c97a3_83440a1d","line":20,"updated":"2018-05-07 19:24:04.000000000","message":"Should we just be running this whole script with -xe?","commit_id":"25fa4c26462fa0103d9c54ab8704949bf9ef4188"}]}