)]}'
{"octavia/amphorae/drivers/health/heartbeat_udp.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ce335eaffbf4c443ca5603308b12213789158194","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def update_health(obj):"},{"line_number":33,"context_line":"    handler \u003d stevedore_driver.DriverManager("},{"line_number":34,"context_line":"        namespace\u003d\u0027octavia.amphora.health_update_plugins\u0027,"},{"line_number":35,"context_line":"        name\u003dCONF.health_manager.health_update_plugin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_a9375afe","line":32,"updated":"2018-02-21 00:43:58.000000000","message":"No unit coverage here.","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b428cc118e23701d07f3cc4325ef8b031e8a11c4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def update_health(obj):"},{"line_number":33,"context_line":"    handler \u003d stevedore_driver.DriverManager("},{"line_number":34,"context_line":"        namespace\u003d\u0027octavia.amphora.health_update_plugins\u0027,"},{"line_number":35,"context_line":"        name\u003dCONF.health_manager.health_update_plugin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_a7922156","line":32,"in_reply_to":"3fa0c359_a9375afe","updated":"2018-02-21 01:56:52.000000000","message":"Done","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ce335eaffbf4c443ca5603308b12213789158194","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def update_health(obj):"},{"line_number":33,"context_line":"    handler \u003d stevedore_driver.DriverManager("},{"line_number":34,"context_line":"        namespace\u003d\u0027octavia.amphora.health_update_plugins\u0027,"},{"line_number":35,"context_line":"        name\u003dCONF.health_manager.health_update_plugin,"},{"line_number":36,"context_line":"        invoke_on_load\u003dTrue"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_89d85eef","line":33,"updated":"2018-02-21 00:43:58.000000000","message":"Do we really need to load the driver for each heartbeat?\nCan\u0027t we just move the driver selection down into init?\nI *think* HUP will reload it? (not sure on HM)","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"dcfa12f171430ac7f0174dcbc49b1110c21de1f8","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def update_health(obj):"},{"line_number":33,"context_line":"    handler \u003d stevedore_driver.DriverManager("},{"line_number":34,"context_line":"        namespace\u003d\u0027octavia.amphora.health_update_plugins\u0027,"},{"line_number":35,"context_line":"        name\u003dCONF.health_manager.health_update_plugin,"},{"line_number":36,"context_line":"        invoke_on_load\u003dTrue"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_ac952834","line":33,"in_reply_to":"3fa0c359_89d85eef","updated":"2018-02-21 01:01:40.000000000","message":"Yes, unfortunately. It has to be loaded at a very specific place/time -- AFTER the oslo_config stuff is loaded (so I can\u0027t just throw it out in the main space) but completely outside of a class (because the function has to be pickleable to pass to multiprocess).\nIf someone knows a way to get both of those things to be true without loading it here, we should go with that. But, I think it gets cached as a singleton anyway by stevedore?","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ce335eaffbf4c443ca5603308b12213789158194","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    handler.update_health(obj)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def update_stats(obj):"},{"line_number":42,"context_line":"    handler \u003d stevedore_driver.DriverManager("},{"line_number":43,"context_line":"        namespace\u003d\u0027octavia.amphora.stats_update_plugins\u0027,"},{"line_number":44,"context_line":"        name\u003dCONF.health_manager.stats_update_plugin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_6925d2c1","line":41,"updated":"2018-02-21 00:43:58.000000000","message":"No unit coverage here.","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b428cc118e23701d07f3cc4325ef8b031e8a11c4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    handler.update_health(obj)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def update_stats(obj):"},{"line_number":42,"context_line":"    handler \u003d stevedore_driver.DriverManager("},{"line_number":43,"context_line":"        namespace\u003d\u0027octavia.amphora.stats_update_plugins\u0027,"},{"line_number":44,"context_line":"        name\u003dCONF.health_manager.stats_update_plugin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_8795a542","line":41,"in_reply_to":"3fa0c359_6925d2c1","updated":"2018-02-21 01:56:52.000000000","message":"Done","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ce335eaffbf4c443ca5603308b12213789158194","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def update_stats(obj):"},{"line_number":42,"context_line":"    handler \u003d stevedore_driver.DriverManager("},{"line_number":43,"context_line":"        namespace\u003d\u0027octavia.amphora.stats_update_plugins\u0027,"},{"line_number":44,"context_line":"        name\u003dCONF.health_manager.stats_update_plugin,"},{"line_number":45,"context_line":"        invoke_on_load\u003dTrue"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_29e10a9c","line":42,"updated":"2018-02-21 00:43:58.000000000","message":"Same","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b428cc118e23701d07f3cc4325ef8b031e8a11c4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def update_stats(obj):"},{"line_number":42,"context_line":"    handler \u003d stevedore_driver.DriverManager("},{"line_number":43,"context_line":"        namespace\u003d\u0027octavia.amphora.stats_update_plugins\u0027,"},{"line_number":44,"context_line":"        name\u003dCONF.health_manager.stats_update_plugin,"},{"line_number":45,"context_line":"        invoke_on_load\u003dTrue"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_67989974","line":42,"in_reply_to":"3fa0c359_29e10a9c","updated":"2018-02-21 01:56:52.000000000","message":"Same","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"}],"octavia/common/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ce335eaffbf4c443ca5603308b12213789158194","unresolved":false,"context_lines":[{"line_number":172,"context_line":"               help\u003d_(\u0027 sets the value of the heartbeat recv buffer\u0027)),"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Used for updating health and stats"},{"line_number":175,"context_line":"    cfg.StrOpt(\u0027health_update_plugin\u0027, default\u003d\u0027health_db\u0027,"},{"line_number":176,"context_line":"               help\u003d_(\u0027Driver for updating amphora health system.\u0027)),"},{"line_number":177,"context_line":"    cfg.StrOpt(\u0027stats_update_plugin\u0027, default\u003d\u0027stats_db\u0027,"},{"line_number":178,"context_line":"               help\u003d_(\u0027Driver for updating amphora statistics.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_091a0ecb","line":175,"updated":"2018-02-21 00:43:58.000000000","message":"We need to add these to our sample octavia.conf too","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b428cc118e23701d07f3cc4325ef8b031e8a11c4","unresolved":false,"context_lines":[{"line_number":172,"context_line":"               help\u003d_(\u0027 sets the value of the heartbeat recv buffer\u0027)),"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Used for updating health and stats"},{"line_number":175,"context_line":"    cfg.StrOpt(\u0027health_update_plugin\u0027, default\u003d\u0027health_db\u0027,"},{"line_number":176,"context_line":"               help\u003d_(\u0027Driver for updating amphora health system.\u0027)),"},{"line_number":177,"context_line":"    cfg.StrOpt(\u0027stats_update_plugin\u0027, default\u003d\u0027stats_db\u0027,"},{"line_number":178,"context_line":"               help\u003d_(\u0027Driver for updating amphora statistics.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_67e09927","line":175,"in_reply_to":"3fa0c359_091a0ecb","updated":"2018-02-21 01:56:52.000000000","message":"Done","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"}],"octavia/controller/healthmanager/health_drivers/update_logging.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ce335eaffbf4c443ca5603308b12213789158194","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa0c359_0920ceab","updated":"2018-02-21 00:43:58.000000000","message":"zero unit coverage here.","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b428cc118e23701d07f3cc4325ef8b031e8a11c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa0c359_2768511b","in_reply_to":"3fa0c359_0920ceab","updated":"2018-02-21 01:56:52.000000000","message":"Done","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"}],"octavia/controller/healthmanager/update_base.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ce335eaffbf4c443ca5603308b12213789158194","unresolved":false,"context_lines":[{"line_number":18,"context_line":"class HealthUpdateBase(object):"},{"line_number":19,"context_line":"    @abc.abstractmethod"},{"line_number":20,"context_line":"    def update_health(self, health):"},{"line_number":21,"context_line":"        raise NotImplementedError()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class StatsUpdateBase(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_ac6c48d0","line":21,"updated":"2018-02-21 00:43:58.000000000","message":"No unit coverage here.","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b428cc118e23701d07f3cc4325ef8b031e8a11c4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"class HealthUpdateBase(object):"},{"line_number":19,"context_line":"    @abc.abstractmethod"},{"line_number":20,"context_line":"    def update_health(self, health):"},{"line_number":21,"context_line":"        raise NotImplementedError()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class StatsUpdateBase(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_477d5db0","line":21,"in_reply_to":"3fa0c359_ac6c48d0","updated":"2018-02-21 01:56:52.000000000","message":"Done","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ce335eaffbf4c443ca5603308b12213789158194","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class StatsUpdateBase(object):"},{"line_number":25,"context_line":"    @abc.abstractmethod"},{"line_number":26,"context_line":"    def update_stats(self, health_message):"},{"line_number":27,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_0ca1bcf8","line":27,"updated":"2018-02-21 00:43:58.000000000","message":"No unit coverage here.","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b428cc118e23701d07f3cc4325ef8b031e8a11c4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class StatsUpdateBase(object):"},{"line_number":25,"context_line":"    @abc.abstractmethod"},{"line_number":26,"context_line":"    def update_stats(self, health_message):"},{"line_number":27,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_677ad9ba","line":27,"in_reply_to":"3fa0c359_0ca1bcf8","updated":"2018-02-21 01:56:52.000000000","message":"Done","commit_id":"21117d1053580723daa1b1ba9e18901814f7e3ab"}]}
