)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"df747aed24f4f8810c7d708bae03009a8ffd6017","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sapd \u003csaphi070@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-01 09:21:48 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support create amphora instance volume based"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1ebe781671c05ee23b7170901d3be66b8b580fd1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf659307_231f586d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":44},"updated":"2018-03-26 08:35:29.000000000","message":"Please, add more information about this change. Add some detail, add a link to the story (Story: 2001594). See guideline https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"25ba450dfab95cf81b47e9a71db5e804bfdcd7f7"}],"etc/octavia.conf":[{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"df747aed24f4f8810c7d708bae03009a8ffd6017","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"# Timeout When volume is not create success"},{"line_number":390,"context_line":"# volume_create_timeout \u003d 300"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"[neutron]"},{"line_number":393,"context_line":"# The name of the neutron service in the keystone catalog"},{"line_number":394,"context_line":"# service_name \u003d"}],"source_content_type":"text/plain","patch_set":6,"id":"bf659307_a30a8823","line":391,"updated":"2018-03-26 08:35:29.000000000","message":"Where max_retries option?","commit_id":"25ba450dfab95cf81b47e9a71db5e804bfdcd7f7"}],"octavia/common/clients.py":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"22900bbf6b75abd623dd8d71028d0c3a4d4873b1","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from glanceclient import client as glance_client"},{"line_number":14,"context_line":"from neutronclient.neutron import client as neutron_client"},{"line_number":15,"context_line":"from cinderclient import client as cinder_client"},{"line_number":16,"context_line":"from novaclient import api_versions"},{"line_number":17,"context_line":"from novaclient import client as nova_client"},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_08fb93bd","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":48},"updated":"2018-02-24 13:07:56.000000000","message":"this line may need to be put on top","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"22900bbf6b75abd623dd8d71028d0c3a4d4873b1","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        :param cacert: CA Cert file path"},{"line_number":164,"context_line":"        :return: a Cinder Client object"},{"line_number":165,"context_line":"        :raise Exception: if the client cannot be created"},{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        ksession \u003d keystone.KeystoneSession()"},{"line_number":168,"context_line":"        if not cls.cinder_client:"},{"line_number":169,"context_line":"            kwargs \u003d {\u0027region_name\u0027: region,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_880fa3de","line":166,"updated":"2018-02-24 13:07:56.000000000","message":"missing newline before \"\"\"","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"22900bbf6b75abd623dd8d71028d0c3a4d4873b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa0c359_680c97eb","line":187,"updated":"2018-02-24 13:07:56.000000000","message":"no newline at end of file","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"df747aed24f4f8810c7d708bae03009a8ffd6017","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                )"},{"line_number":184,"context_line":"            except Exception:"},{"line_number":185,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":186,"context_line":"                    LOG.exception(\"\")"},{"line_number":187,"context_line":"        return cls.cinder_client"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_c359bcfe","line":186,"range":{"start_line":186,"start_character":34,"end_line":186,"end_character":36},"updated":"2018-03-26 08:35:29.000000000","message":"May It be worth adding more information to log message?","commit_id":"25ba450dfab95cf81b47e9a71db5e804bfdcd7f7"}],"octavia/common/config.py":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"22900bbf6b75abd623dd8d71028d0c3a4d4873b1","unresolved":false,"context_lines":[{"line_number":491,"context_line":"]"},{"line_number":492,"context_line":"cinder_opts \u003d ["},{"line_number":493,"context_line":"    cfg.StrOpt(\u0027service_name\u0027,"},{"line_number":494,"context_line":"               help\u003d_(\u0027The name of the cinder service in the keystone catalog\u0027)),"},{"line_number":495,"context_line":"    cfg.StrOpt(\u0027endpoint\u0027, help\u003d_(\u0027A new endpoint to override the endpoint \u0027"},{"line_number":496,"context_line":"                                  \u0027in the keystone catalog.\u0027)),"},{"line_number":497,"context_line":"    cfg.StrOpt(\u0027region_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_c8328ba7","line":494,"updated":"2018-02-24 13:07:56.000000000","message":"line too long (81 \u003e 79 characters)","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"df747aed24f4f8810c7d708bae03009a8ffd6017","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                help\u003d_(\u0027Disable certificate validation on SSL connections\u0027)),"},{"line_number":509,"context_line":"    cfg.StrOpt(\u0027availability_zone\u0027, default\u003dNone,"},{"line_number":510,"context_line":"               help\u003d_(\u0027Availability zone to use for creating Amphorae\u0027)),"},{"line_number":511,"context_line":"    cfg.IntOpt(\u0027volume_size\u0027, default\u003d16,"},{"line_number":512,"context_line":"               help\u003d_(\u0027Size of volume for Amphorae instance\u0027)),"},{"line_number":513,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027, default\u003d5,"},{"line_number":514,"context_line":"               help\u003d_(\u0027Interval time to wait volume is created in available\u0027"},{"line_number":515,"context_line":"                      \u0027state\u0027)),"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_431b6c1a","line":512,"range":{"start_line":511,"start_character":0,"end_line":512,"end_character":63},"updated":"2018-03-26 08:35:29.000000000","message":"How about different volume types? Can you add this setting to config? In many cases, cinder has more than one a volume type.","commit_id":"25ba450dfab95cf81b47e9a71db5e804bfdcd7f7"}],"octavia/compute/drivers/nova_driver.py":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"880271e0552c4bde90781b8a5cd0e76cd4a53602","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    return _extract_amp_image_id_by_tag(client, image_tag, image_owner)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def _create_cinder_volume(client, image_id,"},{"line_number":71,"context_line":"                          vol_size, availability_zone):"},{"line_number":72,"context_line":"    \"\"\"Create cinder volume"},{"line_number":73,"context_line":"    :param image_id: ID of amphorae image"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_9cd121cf","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":25},"updated":"2018-02-25 11:50:02.000000000","message":"there are many issues I see here (see my comments below).\nI would advise you to use tools like http://codesearch.openstack.org/ and see how similar flows are implemented in other projects.\n\nFor the waiter, might be worth to look at places like: https://github.com/openstack/tempest/blob/2caf87c2e3620eb4ca2b02b19fc80c4606ce7903/tempest/common/waiters.py#L182-L213","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"22900bbf6b75abd623dd8d71028d0c3a4d4873b1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    :param vol_size: Size of volume"},{"line_number":75,"context_line":"    :param availability_zone: Avaialability Zone of Cinder"},{"line_number":76,"context_line":"    :return volume id"},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":"    vol \u003d client.volumes.create(size\u003dvol_size,"},{"line_number":79,"context_line":"                                availability_zone\u003davailability_zone,"},{"line_number":80,"context_line":"                                imageRef\u003dimage_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_6825775b","line":77,"updated":"2018-02-24 13:07:56.000000000","message":"needs newline before \"\"\"","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"880271e0552c4bde90781b8a5cd0e76cd4a53602","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    :param availability_zone: Avaialability Zone of Cinder"},{"line_number":76,"context_line":"    :return volume id"},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":"    vol \u003d client.volumes.create(size\u003dvol_size,"},{"line_number":79,"context_line":"                                availability_zone\u003davailability_zone,"},{"line_number":80,"context_line":"                                imageRef\u003dimage_id)"},{"line_number":81,"context_line":"    while True:"},{"line_number":82,"context_line":"        if client.volumes.get(vol.id).status \u003d\u003d \u0027available\u0027:"},{"line_number":83,"context_line":"            vol.bootable \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_3c57ad5a","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":50},"updated":"2018-02-25 11:50:02.000000000","message":"we assume that volume creation will always succeed?\nwhat happens if creation fails?\n\nworth thinking about this and perhaps nesting under try+except clause (for better logging and possibly additional actions).","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":27488,"name":"sapd","email":"saphi070@gmail.com","username":"sapd"},"change_message_id":"de50f9311a604c2afdb6c58688113595fe9e22ac","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    :param availability_zone: Avaialability Zone of Cinder"},{"line_number":76,"context_line":"    :return volume id"},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":"    vol \u003d client.volumes.create(size\u003dvol_size,"},{"line_number":79,"context_line":"                                availability_zone\u003davailability_zone,"},{"line_number":80,"context_line":"                                imageRef\u003dimage_id)"},{"line_number":81,"context_line":"    while True:"},{"line_number":82,"context_line":"        if client.volumes.get(vol.id).status \u003d\u003d \u0027available\u0027:"},{"line_number":83,"context_line":"            vol.bootable \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_5d5cf349","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":50},"in_reply_to":"3fa0c359_3c57ad5a","updated":"2018-02-26 01:58:14.000000000","message":"I think I should use timeout option.","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"880271e0552c4bde90781b8a5cd0e76cd4a53602","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    vol \u003d client.volumes.create(size\u003dvol_size,"},{"line_number":79,"context_line":"                                availability_zone\u003davailability_zone,"},{"line_number":80,"context_line":"                                imageRef\u003dimage_id)"},{"line_number":81,"context_line":"    while True:"},{"line_number":82,"context_line":"        if client.volumes.get(vol.id).status \u003d\u003d \u0027available\u0027:"},{"line_number":83,"context_line":"            vol.bootable \u003d True"},{"line_number":84,"context_line":"            return vol.id"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_1c48b1b0","line":81,"range":{"start_line":81,"start_character":4,"end_line":81,"end_character":14},"updated":"2018-02-25 11:50:02.000000000","message":"in a case where status does not turn to \u0027available\u0027, won\u0027t it wait forever?","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":27488,"name":"sapd","email":"saphi070@gmail.com","username":"sapd"},"change_message_id":"de50f9311a604c2afdb6c58688113595fe9e22ac","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    vol \u003d client.volumes.create(size\u003dvol_size,"},{"line_number":79,"context_line":"                                availability_zone\u003davailability_zone,"},{"line_number":80,"context_line":"                                imageRef\u003dimage_id)"},{"line_number":81,"context_line":"    while True:"},{"line_number":82,"context_line":"        if client.volumes.get(vol.id).status \u003d\u003d \u0027available\u0027:"},{"line_number":83,"context_line":"            vol.bootable \u003d True"},{"line_number":84,"context_line":"            return vol.id"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_9d46fb7a","line":81,"range":{"start_line":81,"start_character":4,"end_line":81,"end_character":14},"in_reply_to":"3fa0c359_1c48b1b0","updated":"2018-02-26 01:58:14.000000000","message":"I will use timeout options.","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"880271e0552c4bde90781b8a5cd0e76cd4a53602","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if client.volumes.get(vol.id).status \u003d\u003d \u0027available\u0027:"},{"line_number":83,"context_line":"            vol.bootable \u003d True"},{"line_number":84,"context_line":"            return vol.id"},{"line_number":85,"context_line":"        time.sleep(5)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class VirtualMachineManager(compute_base.ComputeBase):"},{"line_number":88,"context_line":"    \u0027\u0027\u0027Compute implementation of virtual machines via nova.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_bcc89d21","line":85,"range":{"start_line":85,"start_character":19,"end_line":85,"end_character":20},"updated":"2018-02-25 11:50:02.000000000","message":"can you explain why you chose specifically 5 seconds (which is a significant amount of time)","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":27488,"name":"sapd","email":"saphi070@gmail.com","username":"sapd"},"change_message_id":"de50f9311a604c2afdb6c58688113595fe9e22ac","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if client.volumes.get(vol.id).status \u003d\u003d \u0027available\u0027:"},{"line_number":83,"context_line":"            vol.bootable \u003d True"},{"line_number":84,"context_line":"            return vol.id"},{"line_number":85,"context_line":"        time.sleep(5)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class VirtualMachineManager(compute_base.ComputeBase):"},{"line_number":88,"context_line":"    \u0027\u0027\u0027Compute implementation of virtual machines via nova.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_3d61e705","line":85,"range":{"start_line":85,"start_character":19,"end_line":85,"end_character":20},"in_reply_to":"3fa0c359_bcc89d21","updated":"2018-02-26 01:58:14.000000000","message":"Because 5 seconds is not long or short. I think we should use option for this parameter.","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"22900bbf6b75abd623dd8d71028d0c3a4d4873b1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            vol.bootable \u003d True"},{"line_number":84,"context_line":"            return vol.id"},{"line_number":85,"context_line":"        time.sleep(5)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class VirtualMachineManager(compute_base.ComputeBase):"},{"line_number":88,"context_line":"    \u0027\u0027\u0027Compute implementation of virtual machines via nova.\u0027\u0027\u0027"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_481e7b0c","line":86,"updated":"2018-02-24 13:07:56.000000000","message":"need and extra newline","commit_id":"da89318a5f517030b7c5a480f77422a9ad4c7fe9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"2d7cceae0898395fd40bd2ff82d2ad183f447cb9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    start \u003d int(time.time())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    while resource_status !\u003d \u0027available\u0027:"},{"line_number":89,"context_line":"        time.sleep(CONF.cinder.retry_interval)"},{"line_number":90,"context_line":"        resource_status \u003d client.volumes.get(vol.id).status"},{"line_number":91,"context_line":"        if resource_status \u003d\u003d \u0027error\u0027 and resource_status !\u003d status:"},{"line_number":92,"context_line":"            raise cinder_exceptions.ResourceInErrorState(obj\u003dvol,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_3424990c","line":89,"updated":"2018-02-26 09:43:22.000000000","message":"For retries, we might want to start using a real retry lib like \"retrying\"?","commit_id":"1a47332cfef7fc03ea85704c44902307aba54ed0"},{"author":{"_account_id":27488,"name":"sapd","email":"saphi070@gmail.com","username":"sapd"},"change_message_id":"ce35158ef1607c4fac4df4623319be8bfd86b1f6","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    start \u003d int(time.time())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    while resource_status !\u003d \u0027available\u0027:"},{"line_number":89,"context_line":"        time.sleep(CONF.cinder.retry_interval)"},{"line_number":90,"context_line":"        resource_status \u003d client.volumes.get(vol.id).status"},{"line_number":91,"context_line":"        if resource_status \u003d\u003d \u0027error\u0027 and resource_status !\u003d status:"},{"line_number":92,"context_line":"            raise cinder_exceptions.ResourceInErrorState(obj\u003dvol,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_a866dbec","line":89,"in_reply_to":"1f9dbf25_c2b1c8e3","updated":"2018-03-01 02:12:33.000000000","message":"Let me explain my work, I would like to check status of this volume, if this volume is \"available\", it has to set can be bootable (bootable\u003dTrue). if volume is available, We can boot from this volume. \"Retry\" in here is check status of volume.\n\nI think I have to implement retry create an other volume if volume create failed.","commit_id":"1a47332cfef7fc03ea85704c44902307aba54ed0"},{"author":{"_account_id":27488,"name":"sapd","email":"saphi070@gmail.com","username":"sapd"},"change_message_id":"ab76aa18064a1260594e6cfd8744ebbef693ff73","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    start \u003d int(time.time())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    while resource_status !\u003d \u0027available\u0027:"},{"line_number":89,"context_line":"        time.sleep(CONF.cinder.retry_interval)"},{"line_number":90,"context_line":"        resource_status \u003d client.volumes.get(vol.id).status"},{"line_number":91,"context_line":"        if resource_status \u003d\u003d \u0027error\u0027 and resource_status !\u003d status:"},{"line_number":92,"context_line":"            raise cinder_exceptions.ResourceInErrorState(obj\u003dvol,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_ae3295f0","line":89,"in_reply_to":"3fa0c359_3424990c","updated":"2018-02-26 13:00:16.000000000","message":"I think in this case we don\u0027t have to install any lib.","commit_id":"1a47332cfef7fc03ea85704c44902307aba54ed0"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"c53c4de5cdec5e6421a313ce3a27044ee98e6306","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    start \u003d int(time.time())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    while resource_status !\u003d \u0027available\u0027:"},{"line_number":89,"context_line":"        time.sleep(CONF.cinder.retry_interval)"},{"line_number":90,"context_line":"        resource_status \u003d client.volumes.get(vol.id).status"},{"line_number":91,"context_line":"        if resource_status \u003d\u003d \u0027error\u0027 and resource_status !\u003d status:"},{"line_number":92,"context_line":"            raise cinder_exceptions.ResourceInErrorState(obj\u003dvol,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_c2b1c8e3","line":89,"in_reply_to":"3fa0c359_ae3295f0","updated":"2018-02-28 22:27:02.000000000","message":"I personally didn\u0027t get to play with it, so I can\u0027t express an opinion here.\n\nsapd: In some cases, leveraging external libs is a good thing. That by itself should not prevent you from using it.\n\nI see that this lib is being used by other openstack projects: http://codesearch.openstack.org/?q\u003dfrom%20retrying\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"1a47332cfef7fc03ea85704c44902307aba54ed0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"2d7cceae0898395fd40bd2ff82d2ad183f447cb9","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                    CONF.cinder.volume_size, CONF.cinder.availability_zone"},{"line_number":195,"context_line":"                )"},{"line_number":196,"context_line":"                # If use volume based, does not require image ID anymore"},{"line_number":197,"context_line":"                image_id \u003d \"\""},{"line_number":198,"context_line":"                block_device_mapping \u003d {\u0027vda\u0027: \u0027%s:::true\u0027 % cinder_id}"},{"line_number":199,"context_line":"            amphora \u003d self.manager.create("},{"line_number":200,"context_line":"                name\u003dname, image\u003dimage_id, flavor\u003damphora_flavor,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_146e3d2e","line":197,"updated":"2018-02-26 09:43:22.000000000","message":"Should this actually be None?","commit_id":"1a47332cfef7fc03ea85704c44902307aba54ed0"},{"author":{"_account_id":27488,"name":"sapd","email":"saphi070@gmail.com","username":"sapd"},"change_message_id":"ab76aa18064a1260594e6cfd8744ebbef693ff73","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                    CONF.cinder.volume_size, CONF.cinder.availability_zone"},{"line_number":195,"context_line":"                )"},{"line_number":196,"context_line":"                # If use volume based, does not require image ID anymore"},{"line_number":197,"context_line":"                image_id \u003d \"\""},{"line_number":198,"context_line":"                block_device_mapping \u003d {\u0027vda\u0027: \u0027%s:::true\u0027 % cinder_id}"},{"line_number":199,"context_line":"            amphora \u003d self.manager.create("},{"line_number":200,"context_line":"                name\u003dname, image\u003dimage_id, flavor\u003damphora_flavor,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_4e575102","line":197,"in_reply_to":"3fa0c359_146e3d2e","updated":"2018-02-26 13:00:16.000000000","message":"If this is not None, It will be boot from localdisk.","commit_id":"1a47332cfef7fc03ea85704c44902307aba54ed0"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"c53c4de5cdec5e6421a313ce3a27044ee98e6306","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    :param availability_zone: Avaialability Zone of Cinder"},{"line_number":78,"context_line":"    :return volume id"},{"line_number":79,"context_line":"    \"\"\""},{"line_number":80,"context_line":"    vol \u003d client.volumes.create(size\u003dvol_size,"},{"line_number":81,"context_line":"                                availability_zone\u003davailability_zone,"},{"line_number":82,"context_line":"                                imageRef\u003dimage_id)"},{"line_number":83,"context_line":"    resource_status \u003d client.volumes.get(vol.id).status"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    status \u003d \u0027available\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f9dbf25_02a1f0a9","line":82,"range":{"start_line":80,"start_character":0,"end_line":82,"end_character":50},"updated":"2018-02-28 22:27:02.000000000","message":"my comment from PS#1 remains.","commit_id":"15841f6cc36fa2e9b406e07e4ccd3f0e1561af17"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"c53c4de5cdec5e6421a313ce3a27044ee98e6306","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    status \u003d \u0027available\u0027"},{"line_number":86,"context_line":"    start \u003d int(time.time())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    while resource_status !\u003d \u0027available\u0027:"},{"line_number":89,"context_line":"        time.sleep(CONF.cinder.retry_interval)"},{"line_number":90,"context_line":"        resource_status \u003d client.volumes.get(vol.id).status"},{"line_number":91,"context_line":"        if resource_status \u003d\u003d \u0027error\u0027 and resource_status !\u003d status:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f9dbf25_82942046","line":88,"range":{"start_line":88,"start_character":29,"end_line":88,"end_character":40},"updated":"2018-02-28 22:27:02.000000000","message":"this should probably be: status","commit_id":"15841f6cc36fa2e9b406e07e4ccd3f0e1561af17"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"c53c4de5cdec5e6421a313ce3a27044ee98e6306","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    while resource_status !\u003d \u0027available\u0027:"},{"line_number":89,"context_line":"        time.sleep(CONF.cinder.retry_interval)"},{"line_number":90,"context_line":"        resource_status \u003d client.volumes.get(vol.id).status"},{"line_number":91,"context_line":"        if resource_status \u003d\u003d \u0027error\u0027 and resource_status !\u003d status:"},{"line_number":92,"context_line":"            raise cinder_exceptions.ResourceInErrorState(obj\u003dvol,"},{"line_number":93,"context_line":"                                                         fault_msg\u003d\u0027Cannot \u0027"},{"line_number":94,"context_line":"                                                         \u0027create volume\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f9dbf25_228f4c2b","line":91,"range":{"start_line":91,"start_character":42,"end_line":91,"end_character":68},"updated":"2018-02-28 22:27:02.000000000","message":"in a case where resource_status \u003d\u003d \u0027error\u0027, why do we also need to ask if it\u0027s !\u003d status ?","commit_id":"15841f6cc36fa2e9b406e07e4ccd3f0e1561af17"},{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"df747aed24f4f8810c7d708bae03009a8ffd6017","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    return _extract_amp_image_id_by_tag(client, image_tag, image_owner)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"@retry(stop_max_attempt_number\u003dCONF.cinder.max_retries)"},{"line_number":72,"context_line":"def _create_cinder_volume(client, image_id,"},{"line_number":73,"context_line":"                          vol_size, availability_zone):"},{"line_number":74,"context_line":"    \"\"\"Create cinder volume"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_c3d0dccc","line":71,"range":{"start_line":71,"start_character":43,"end_line":71,"end_character":54},"updated":"2018-03-26 08:35:29.000000000","message":"Could you make this name more informative? For example: `volume_create_max_retries`","commit_id":"25ba450dfab95cf81b47e9a71db5e804bfdcd7f7"},{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"df747aed24f4f8810c7d708bae03009a8ffd6017","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    start \u003d int(time.time())"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    while resource_status !\u003d status:"},{"line_number":90,"context_line":"        time.sleep(CONF.cinder.retry_interval)"},{"line_number":91,"context_line":"        resource_status \u003d client.volumes.get(vol.id).status"},{"line_number":92,"context_line":"        if resource_status \u003d\u003d \u0027error\u0027:"},{"line_number":93,"context_line":"            raise cinder_exceptions.ResourceInErrorState(obj\u003dvol,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_634550b3","line":90,"range":{"start_line":90,"start_character":31,"end_line":90,"end_character":45},"updated":"2018-03-26 08:35:29.000000000","message":"Could you make this name more informative? For example: `volume_create_retry_interval` or `volume_create_wait_sec` (like an option amp_active_wait_sec)","commit_id":"25ba450dfab95cf81b47e9a71db5e804bfdcd7f7"}],"octavia/tests/unit/compute/drivers/test_nova_driver.py":[{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"df747aed24f4f8810c7d708bae03009a8ffd6017","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        super(TestNovaClient, self).setUp()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_build_without_volume(self):"},{"line_number":148,"context_line":"        amphora_id \u003d self.manager.build(amphora_flavor\u003d1, image_id\u003d1,"},{"line_number":149,"context_line":"                                        key_name\u003d1,"},{"line_number":150,"context_line":"                                        sec_groups\u003d1,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_63731017","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":33},"updated":"2018-03-26 08:35:29.000000000","message":"How about testing with a volume?","commit_id":"25ba450dfab95cf81b47e9a71db5e804bfdcd7f7"}]}
