)]}'
{"octavia/amphorae/backends/agent/api_server/osutils.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f9ff4df3b100f7fa341c90f1434f2dd813b406ec","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                                                    mtu, template_port)"},{"line_number":129,"context_line":"            text_file.write(text)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _generate_network_file_text(self, netns_interface, fixed_ips, mtu,"},{"line_number":132,"context_line":"                                    template_port):"},{"line_number":133,"context_line":"        text \u003d \u0027\u0027"},{"line_number":134,"context_line":"        if fixed_ips is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"df7087c5_749a9c6e","side":"PARENT","line":131,"updated":"2018-03-12 14:56:50.000000000","message":"Removing this here means this test needs to change:\n\noctavia.tests.unit.amphorae.backends.agent.api_server.test_plug.TestPlugNetwork:test__generate_network_file_text_static_ip_ubuntu","commit_id":"0e54dce5f57ea7017094d73bafa829bbfa3d7bab"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f9ff4df3b100f7fa341c90f1434f2dd813b406ec","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return os.path.join(network_dir, interface)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def create_netns_dir(self, network_dir, netns_network_dir, ignore\u003dNone):"},{"line_number":66,"context_line":"            file.create_netns_dir(network_dir, netns_network_dir, ignore)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def write_vip_interface_file(self, interface_file_path,"},{"line_number":69,"context_line":"                                 primary_interface, vip, ip, broadcast,"}],"source_content_type":"text/x-python","patch_set":10,"id":"df7087c5_3488a46f","line":66,"updated":"2018-03-12 14:56:50.000000000","message":"Overindented","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"5e81681413759b642bb7a5b818673ace5ff1d186","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return os.path.join(network_dir, interface)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def create_netns_dir(self, network_dir, netns_network_dir, ignore\u003dNone):"},{"line_number":66,"context_line":"            file.create_netns_dir(network_dir, netns_network_dir, ignore)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def write_vip_interface_file(self, interface_file_path,"},{"line_number":69,"context_line":"                                 primary_interface, vip, ip, broadcast,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_48532f6d","line":66,"in_reply_to":"df7087c5_3488a46f","updated":"2018-07-03 21:33:50.000000000","message":"Done","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f9ff4df3b100f7fa341c90f1434f2dd813b406ec","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def write_port_interface_file(self, netns_interface, fixed_ips, mtu,"},{"line_number":84,"context_line":"                                  interface_file_path, template_port):"},{"line_number":85,"context_line":"        try:"},{"line_number":86,"context_line":"            file.write_port_interface_file(self, netns_interface, fixed_ips,"},{"line_number":87,"context_line":"                                           mtu,"},{"line_number":88,"context_line":"                                           interface_file_path, template_port)"},{"line_number":89,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":10,"id":"df7087c5_f4f6acf9","line":86,"updated":"2018-03-12 14:56:50.000000000","message":"I don\u0027t think this is supposed to take \"self\"?","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"5e81681413759b642bb7a5b818673ace5ff1d186","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def write_port_interface_file(self, netns_interface, fixed_ips, mtu,"},{"line_number":84,"context_line":"                                  interface_file_path, template_port):"},{"line_number":85,"context_line":"        try:"},{"line_number":86,"context_line":"            file.write_port_interface_file(self, netns_interface, fixed_ips,"},{"line_number":87,"context_line":"                                           mtu,"},{"line_number":88,"context_line":"                                           interface_file_path, template_port)"},{"line_number":89,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_68506b5f","line":86,"in_reply_to":"df7087c5_f4f6acf9","updated":"2018-07-03 21:33:50.000000000","message":"Done","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"}],"octavia/amphorae/backends/agent/api_server/privileged/file.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f9ff4df3b100f7fa341c90f1434f2dd813b406ec","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"@privileged.default.entrypoint"},{"line_number":136,"context_line":"def write_static_routes_interface_file(self, interface_file_path,"},{"line_number":137,"context_line":"                                       interface, host_routes,"},{"line_number":138,"context_line":"                                       template_routes, gateway, vip):"},{"line_number":139,"context_line":"    # write static routes interface file"}],"source_content_type":"text/x-python","patch_set":10,"id":"df7087c5_340984dc","line":136,"updated":"2018-03-12 14:56:50.000000000","message":"I don\u0027t think you meant to copy \"self\" here as the first arg.\nThis is causing your other attempted calls to fail in osutils.py","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"5e81681413759b642bb7a5b818673ace5ff1d186","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"@privileged.default.entrypoint"},{"line_number":136,"context_line":"def write_static_routes_interface_file(self, interface_file_path,"},{"line_number":137,"context_line":"                                       interface, host_routes,"},{"line_number":138,"context_line":"                                       template_routes, gateway, vip):"},{"line_number":139,"context_line":"    # write static routes interface file"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_286d932e","line":136,"in_reply_to":"df7087c5_340984dc","updated":"2018-07-03 21:33:50.000000000","message":"Done","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f9ff4df3b100f7fa341c90f1434f2dd813b406ec","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        text_file.write(text)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"def _generate_network_file_text(self, netns_interface, fixed_ips, mtu,"},{"line_number":285,"context_line":"                                template_port):"},{"line_number":286,"context_line":"    text \u003d \u0027\u0027"},{"line_number":287,"context_line":"    if fixed_ips is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"df7087c5_d4dda842","line":284,"updated":"2018-03-12 14:56:50.000000000","message":"I don\u0027t think this is supposed to have \"self\" either, and is causing the call above to fail.","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"5e81681413759b642bb7a5b818673ace5ff1d186","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        text_file.write(text)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"def _generate_network_file_text(self, netns_interface, fixed_ips, mtu,"},{"line_number":285,"context_line":"                                template_port):"},{"line_number":286,"context_line":"    text \u003d \u0027\u0027"},{"line_number":287,"context_line":"    if fixed_ips is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_8855c754","line":284,"in_reply_to":"df7087c5_d4dda842","updated":"2018-07-03 21:33:50.000000000","message":"Done","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"}],"requirements.txt":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f9ff4df3b100f7fa341c90f1434f2dd813b406ec","unresolved":false,"context_lines":[{"line_number":19,"context_line":"oslo.config\u003e\u003d5.1.0 # Apache-2.0"},{"line_number":20,"context_line":"oslo.context\u003e\u003d2.19.2 # Apache-2.0"},{"line_number":21,"context_line":"oslo.db\u003e\u003d4.27.0 # Apache-2.0"},{"line_number":22,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0x`"},{"line_number":23,"context_line":"oslo.log\u003e\u003d3.36.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.messaging\u003e\u003d5.29.0 # Apache-2.0"},{"line_number":25,"context_line":"oslo.middleware\u003e\u003d3.31.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":10,"id":"df7087c5_144ec06e","line":22,"updated":"2018-03-12 14:56:50.000000000","message":"This is causing reqs gate to fail, I think? Regardless, typo","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f9ff4df3b100f7fa341c90f1434f2dd813b406ec","unresolved":false,"context_lines":[{"line_number":48,"context_line":"pyroute2\u003e\u003d0.4.21;sys_platform!\u003d\u0027win32\u0027 # Apache-2.0 (+ dual licensed GPL2)"},{"line_number":49,"context_line":"gunicorn\u003e\u003d19.0.0 # MIT"},{"line_number":50,"context_line":"oslo.privsep\u003e\u003d1.23.0"},{"line_number":51,"context_line":"oslo.rootwrap\u003e\u003d5.8.0"},{"line_number":52,"context_line":"# to work around an error in privsep"},{"line_number":53,"context_line":"msgpack\u003d\u003d0.5.3"}],"source_content_type":"text/plain","patch_set":10,"id":"df7087c5_546438e4","line":51,"updated":"2018-03-12 14:56:50.000000000","message":"I thought we weren\u0027t supposed to use rootwrap anymore? Maybe I am mis-remembering what I heard, but I thought someone said that during the PTG.","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f9ff4df3b100f7fa341c90f1434f2dd813b406ec","unresolved":false,"context_lines":[{"line_number":50,"context_line":"oslo.privsep\u003e\u003d1.23.0"},{"line_number":51,"context_line":"oslo.rootwrap\u003e\u003d5.8.0"},{"line_number":52,"context_line":"# to work around an error in privsep"},{"line_number":53,"context_line":"msgpack\u003d\u003d0.5.3"}],"source_content_type":"text/plain","patch_set":10,"id":"df7087c5_d47048a8","line":53,"updated":"2018-03-12 14:56:50.000000000","message":"So, requirements has this listed as (and we need to write it as):\n\nmsgpack\u003e\u003d0.4.0  # Apache-2.0\n\nBut, what will be installed via upper-constraints is:\n\nmsgpack\u003d\u003d\u003d0.5.6\n\nIs there something that broke in 0.5.4+?","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"34cca5fad70b5f3db31d189e0a588934d174d5ed","unresolved":false,"context_lines":[{"line_number":50,"context_line":"oslo.privsep\u003e\u003d1.23.0"},{"line_number":51,"context_line":"oslo.rootwrap\u003e\u003d5.8.0"},{"line_number":52,"context_line":"# to work around an error in privsep"},{"line_number":53,"context_line":"msgpack\u003d\u003d0.5.3"}],"source_content_type":"text/plain","patch_set":10,"id":"df7087c5_e55a7428","line":53,"in_reply_to":"df7087c5_d47048a8","updated":"2018-03-12 16:09:23.000000000","message":"According to harlowja we need to go back to pre-0.5 for it to work. Everything \u003e0.5 are pre-releases which have bugs. No idea how privsep works for other people...","commit_id":"cfda76690846bf222bfd972cffa1dd0e5fbe9f4c"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"1527c34fca0e41f1552809774cbfbfa7fce802c2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":20,"context_line":"oslo.context\u003e\u003d2.19.2 # Apache-2.0"},{"line_number":21,"context_line":"oslo.db\u003e\u003d4.27.0 # Apache-2.0"},{"line_number":22,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0x`"},{"line_number":23,"context_line":"oslo.log\u003e\u003d3.36.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.messaging\u003e\u003d5.29.0 # Apache-2.0"},{"line_number":25,"context_line":"oslo.middleware\u003e\u003d3.31.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":12,"id":"5f7c97a3_2f36b0b5","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":32},"updated":"2018-07-08 09:12:54.000000000","message":"typo? :)","commit_id":"15e9eace58a49a57d3f7399ff44f1300f70ebb77"}]}