)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"c29a712825192064e54178e7a0aafcb74d373068","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adam Harwell \u003cflux.adam@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-27 05:47:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow members to be set as \"backup\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Setting a member as \"backup\" means no traffic will be sent to it unless"},{"line_number":10,"context_line":"all non-backup members are marked as down."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This should be essentially the same in every backend provider AFAIU."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I953abe71a0988da78efc6b3961f7518c81c2a06d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_5ac3e338","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":68},"updated":"2018-03-29 08:36:58.000000000","message":"Please add some information about why it important. Maybe add link to a story or a mail thread.","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"25d88eddf8b94c0c9911859d19b9f993dcf84cbd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adam Harwell \u003cflux.adam@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-27 05:47:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow members to be set as \"backup\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Setting a member as \"backup\" means no traffic will be sent to it unless"},{"line_number":10,"context_line":"all non-backup members are marked as down."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This should be essentially the same in every backend provider AFAIU."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I953abe71a0988da78efc6b3961f7518c81c2a06d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_ba2f8286","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":68},"in_reply_to":"bf659307_24b3660c","updated":"2018-03-30 11:01:09.000000000","message":"I don\u0027t understand, how will other contributors (who did not participate in the person during the last PTG) understand the reason for this decision from current short comment? Maybe can you add some details about your personal case?","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"6a4c2eb3cccfd156fed5d18179f72a89e4022b79","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adam Harwell \u003cflux.adam@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-27 05:47:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow members to be set as \"backup\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Setting a member as \"backup\" means no traffic will be sent to it unless"},{"line_number":10,"context_line":"all non-backup members are marked as down."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This should be essentially the same in every backend provider AFAIU."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I953abe71a0988da78efc6b3961f7518c81c2a06d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_24b3660c","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":68},"in_reply_to":"bf659307_5ac3e338","updated":"2018-03-29 20:15:53.000000000","message":"Actually it\u0027s not ... specifically important? Just a feature I personally want to see and that we agreed would add value (in person during the last PTG, so not really anything written). I don\u0027t think everything needs an RFE or something of that nature.","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"1f2efbcbe5a49c84901278e92adaae34a2c962d5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adam Harwell \u003cflux.adam@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-27 05:47:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow members to be set as \"backup\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Setting a member as \"backup\" means no traffic will be sent to it unless"},{"line_number":10,"context_line":"all non-backup members are marked as down."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This should be essentially the same in every backend provider AFAIU."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I953abe71a0988da78efc6b3961f7518c81c2a06d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_6a3ef58b","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":68},"in_reply_to":"bf659307_ba2f8286","updated":"2018-03-30 19:22:57.000000000","message":"I\u0027m not sure I follow why it matters. This is just \"an additional feature\". Whether or not we discussed this as a group isn\u0027t even relevant. When I say \"we agreed would add value\", I mean that I said \"I would like this thing, I believe it adds value\" and people in the room mostly said \"yeah sure I guess\".\n\nThis is not a major architectural change. This is just a feature I\u0027d like to see. THIS REVIEW is actually the perfect place to debate whether it\u0027s something we want or not. I can\u0027t add more information about why it\u0027s important, because it *isn\u0027t* important. ;)","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"}],"api-ref/source/v2/member.inc":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5e24b2ec676f1768018c66a74d6266f1585c802e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"   - subnet_id: subnet_id"},{"line_number":61,"context_line":"   - updated_at: updated_at"},{"line_number":62,"context_line":"   - weight: weight"},{"line_number":63,"context_line":"   - backup: backup"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Response Example"},{"line_number":66,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_85494cd1","line":63,"updated":"2018-03-28 00:05:50.000000000","message":"Super hate to be picky, but this list was alpha sorted before.  Can you move it up?\nI think this makes it easier for people to find fields they care about in the long lists of params.","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7050af4ddfb59aa611773293ce92731e2860f5d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"   - subnet_id: subnet_id"},{"line_number":61,"context_line":"   - updated_at: updated_at"},{"line_number":62,"context_line":"   - weight: weight"},{"line_number":63,"context_line":"   - backup: backup"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Response Example"},{"line_number":66,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_26084d90","line":63,"in_reply_to":"bf659307_85494cd1","updated":"2018-03-29 20:14:17.000000000","message":"Done","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7050af4ddfb59aa611773293ce92731e2860f5d","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"- ``weight``. Default is ``1``."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"- ``backup``. Default is ``false``."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"If you omit the ``subnet_id`` parameter, the ``vip_subnet_id`` for the parent"},{"line_number":114,"context_line":"load balancer will be used for the member subnet UUID."}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_e6fd756e","line":111,"updated":"2018-03-29 20:14:17.000000000","message":"Done even though you didn\u0027t mark it. ;P","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5e24b2ec676f1768018c66a74d6266f1585c802e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"   - protocol_port: protocol_port"},{"line_number":157,"context_line":"   - subnet_id: subnet_id-optional"},{"line_number":158,"context_line":"   - weight: weight-optional"},{"line_number":159,"context_line":"   - backup: backup-optional"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Request Example"},{"line_number":162,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_6518b8d2","line":159,"updated":"2018-03-28 00:05:50.000000000","message":"Can you move it up?","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7050af4ddfb59aa611773293ce92731e2860f5d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"   - protocol_port: protocol_port"},{"line_number":157,"context_line":"   - subnet_id: subnet_id-optional"},{"line_number":158,"context_line":"   - weight: weight-optional"},{"line_number":159,"context_line":"   - backup: backup-optional"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Request Example"},{"line_number":162,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_a6fbfd76","line":159,"in_reply_to":"bf659307_6518b8d2","updated":"2018-03-29 20:14:17.000000000","message":"Done","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5e24b2ec676f1768018c66a74d6266f1585c802e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"   - subnet_id: subnet_id"},{"line_number":190,"context_line":"   - updated_at: updated_at"},{"line_number":191,"context_line":"   - weight: weight"},{"line_number":192,"context_line":"   - backup: backup"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Response Example"},{"line_number":195,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_050f7c89","line":192,"updated":"2018-03-28 00:05:50.000000000","message":"Can you move it up?","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7050af4ddfb59aa611773293ce92731e2860f5d","unresolved":false,"context_lines":[{"line_number":189,"context_line":"   - subnet_id: subnet_id"},{"line_number":190,"context_line":"   - updated_at: updated_at"},{"line_number":191,"context_line":"   - weight: weight"},{"line_number":192,"context_line":"   - backup: backup"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Response Example"},{"line_number":195,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_c6f8717c","line":192,"in_reply_to":"bf659307_050f7c89","updated":"2018-03-29 20:14:17.000000000","message":"Done","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5e24b2ec676f1768018c66a74d6266f1585c802e","unresolved":false,"context_lines":[{"line_number":255,"context_line":"   - subnet_id: subnet_id"},{"line_number":256,"context_line":"   - updated_at: updated_at"},{"line_number":257,"context_line":"   - weight: weight"},{"line_number":258,"context_line":"   - backup: backup"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Response Example"},{"line_number":261,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_2512c0b2","line":258,"updated":"2018-03-28 00:05:50.000000000","message":"Can you move it up?","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7050af4ddfb59aa611773293ce92731e2860f5d","unresolved":false,"context_lines":[{"line_number":255,"context_line":"   - subnet_id: subnet_id"},{"line_number":256,"context_line":"   - updated_at: updated_at"},{"line_number":257,"context_line":"   - weight: weight"},{"line_number":258,"context_line":"   - backup: backup"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Response Example"},{"line_number":261,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_86eef9b1","line":258,"in_reply_to":"bf659307_2512c0b2","updated":"2018-03-29 20:14:17.000000000","message":"Done","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5e24b2ec676f1768018c66a74d6266f1585c802e","unresolved":false,"context_lines":[{"line_number":307,"context_line":"   - name: name-optional"},{"line_number":308,"context_line":"   - pool_id: path-pool-id"},{"line_number":309,"context_line":"   - weight: weight-optional"},{"line_number":310,"context_line":"   - backup: backup-optional"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Request Example"},{"line_number":313,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_e5236804","line":310,"updated":"2018-03-28 00:05:50.000000000","message":"Can you move it up?","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7050af4ddfb59aa611773293ce92731e2860f5d","unresolved":false,"context_lines":[{"line_number":307,"context_line":"   - name: name-optional"},{"line_number":308,"context_line":"   - pool_id: path-pool-id"},{"line_number":309,"context_line":"   - weight: weight-optional"},{"line_number":310,"context_line":"   - backup: backup-optional"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Request Example"},{"line_number":313,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_66f16595","line":310,"in_reply_to":"bf659307_e5236804","updated":"2018-03-29 20:14:17.000000000","message":"Done","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5e24b2ec676f1768018c66a74d6266f1585c802e","unresolved":false,"context_lines":[{"line_number":340,"context_line":"   - subnet_id: subnet_id"},{"line_number":341,"context_line":"   - updated_at: updated_at"},{"line_number":342,"context_line":"   - weight: weight"},{"line_number":343,"context_line":"   - backup: backup"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"Response Example"},{"line_number":346,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_8522acff","line":343,"updated":"2018-03-28 00:05:50.000000000","message":"Can you move it up?","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7050af4ddfb59aa611773293ce92731e2860f5d","unresolved":false,"context_lines":[{"line_number":340,"context_line":"   - subnet_id: subnet_id"},{"line_number":341,"context_line":"   - updated_at: updated_at"},{"line_number":342,"context_line":"   - weight: weight"},{"line_number":343,"context_line":"   - backup: backup"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"Response Example"},{"line_number":346,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_262dadfd","line":343,"in_reply_to":"bf659307_8522acff","updated":"2018-03-29 20:14:17.000000000","message":"Done","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5e24b2ec676f1768018c66a74d6266f1585c802e","unresolved":false,"context_lines":[{"line_number":401,"context_line":"   - protocol_port: protocol_port"},{"line_number":402,"context_line":"   - subnet_id: subnet_id-optional"},{"line_number":403,"context_line":"   - weight: weight-optional"},{"line_number":404,"context_line":"   - backup: backup-optional"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"Request Example"},{"line_number":407,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_a51d70be","line":404,"updated":"2018-03-28 00:05:50.000000000","message":"Can you move it up?","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7050af4ddfb59aa611773293ce92731e2860f5d","unresolved":false,"context_lines":[{"line_number":401,"context_line":"   - protocol_port: protocol_port"},{"line_number":402,"context_line":"   - subnet_id: subnet_id-optional"},{"line_number":403,"context_line":"   - weight: weight-optional"},{"line_number":404,"context_line":"   - backup: backup-optional"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"Request Example"},{"line_number":407,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_e632555e","line":404,"in_reply_to":"bf659307_a51d70be","updated":"2018-03-29 20:14:17.000000000","message":"Done","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"}],"octavia/common/jinja/haproxy/templates/macros.j2":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"2006a0e10e5e0408c8d8e68ba937c84dead62a4a","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    {% if listener.connection_limit is defined %}"},{"line_number":251,"context_line":"    fullconn {{ listener.connection_limit }}"},{"line_number":252,"context_line":"    {% endif %}"},{"line_number":253,"context_line":"    option allbackups"},{"line_number":254,"context_line":"    {% for member in pool.members if member.enabled %}"},{"line_number":255,"context_line":"        {{- member_macro(constants, pool, member) -}}"},{"line_number":256,"context_line":"    {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_68544255","line":253,"updated":"2018-03-19 22:32:20.000000000","message":"does this work if we don\u0027;t have any backups?","commit_id":"59da8fdc35628e765622e9f8ac702643a8a23a5c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"145fd695e057e589cd78a1da620dc70dcfd5109b","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    {% if listener.connection_limit is defined %}"},{"line_number":251,"context_line":"    fullconn {{ listener.connection_limit }}"},{"line_number":252,"context_line":"    {% endif %}"},{"line_number":253,"context_line":"    option allbackups"},{"line_number":254,"context_line":"    {% for member in pool.members if member.enabled %}"},{"line_number":255,"context_line":"        {{- member_macro(constants, pool, member) -}}"},{"line_number":256,"context_line":"    {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_48a7fe50","line":253,"in_reply_to":"df7087c5_68544255","updated":"2018-03-19 22:35:21.000000000","message":"I COULD make it only show up if there are backups, but it\u0027s a no-op if there aren\u0027t any, so I figured this was much simpler.","commit_id":"59da8fdc35628e765622e9f8ac702643a8a23a5c"}],"octavia/db/migration/alembic_migrations/versions/ba35e0fb88e1_add_backup_field_to_member.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"2006a0e10e5e0408c8d8e68ba937c84dead62a4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df7087c5_68d9a2f2","line":35,"updated":"2018-03-19 22:32:20.000000000","message":"missing some way where we set the existing members in DB to backup\u003dFalse (after all nullable\u003dFalse). Did we test an upgrade with that?","commit_id":"59da8fdc35628e765622e9f8ac702643a8a23a5c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"2140fbb583fe764e25a23aaef7775beb3f333feb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df7087c5_6108ce27","line":35,"in_reply_to":"df7087c5_488e1ed1","updated":"2018-03-20 13:12:59.000000000","message":"Verified: http://paste.openstack.org/show/706043/\nDefault works as expected, this will migrate just fine with existing members.","commit_id":"59da8fdc35628e765622e9f8ac702643a8a23a5c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"145fd695e057e589cd78a1da620dc70dcfd5109b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df7087c5_488e1ed1","line":35,"in_reply_to":"df7087c5_68d9a2f2","updated":"2018-03-19 22:35:21.000000000","message":"That\u0027s what the default SHOULD do, I believe, but yes we should test to make sure that works. I\u0027ll see what I can do.","commit_id":"59da8fdc35628e765622e9f8ac702643a8a23a5c"}],"octavia/db/prepare.py":[{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"c29a712825192064e54178e7a0aafcb74d373068","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    else:"},{"line_number":171,"context_line":"        member_dict[\u0027operating_status\u0027] \u003d constants.NO_MONITOR"},{"line_number":172,"context_line":"    if \u0027backup\u0027 not in member_dict:"},{"line_number":173,"context_line":"        member_dict[\u0027backup\u0027] \u003d False"},{"line_number":174,"context_line":"    return member_dict"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_7a682786","line":173,"range":{"start_line":173,"start_character":32,"end_line":173,"end_character":37},"updated":"2018-03-29 08:36:58.000000000","message":"nit: Could you move this value to the constants module? As well as that do in previous parameters.","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"25d88eddf8b94c0c9911859d19b9f993dcf84cbd","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    else:"},{"line_number":171,"context_line":"        member_dict[\u0027operating_status\u0027] \u003d constants.NO_MONITOR"},{"line_number":172,"context_line":"    if \u0027backup\u0027 not in member_dict:"},{"line_number":173,"context_line":"        member_dict[\u0027backup\u0027] \u003d False"},{"line_number":174,"context_line":"    return member_dict"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_df0ee839","line":173,"range":{"start_line":173,"start_character":32,"end_line":173,"end_character":37},"in_reply_to":"bf659307_46cea12e","updated":"2018-03-30 11:01:09.000000000","message":"Hm, ok, I agree","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7050af4ddfb59aa611773293ce92731e2860f5d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    else:"},{"line_number":171,"context_line":"        member_dict[\u0027operating_status\u0027] \u003d constants.NO_MONITOR"},{"line_number":172,"context_line":"    if \u0027backup\u0027 not in member_dict:"},{"line_number":173,"context_line":"        member_dict[\u0027backup\u0027] \u003d False"},{"line_number":174,"context_line":"    return member_dict"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_46cea12e","line":173,"range":{"start_line":173,"start_character":32,"end_line":173,"end_character":37},"in_reply_to":"bf659307_7a682786","updated":"2018-03-29 20:14:17.000000000","message":"I\u0027m not ... 100% sure what you mean. There\u0027s some things I can do this for, and I will, because that makes sense. But, if you mean the value \"False\", no. It doesn\u0027t have any real constant meaning in this case.\nThe best I can think of would be like:\nconstants.MEMBER_IS_BACKUP \u003d True\nconstants.MEMBER_IS_NOT_BACKUP \u003d False\n\n... but that\u0027s ridiculous. So, in this case, no.","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"}],"octavia/tests/functional/api/v2/test_member.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5e24b2ec676f1768018c66a74d6266f1585c802e","unresolved":false,"context_lines":[{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def test_create_backup(self):"},{"line_number":411,"context_line":"        api_member \u003d self.create_member("},{"line_number":412,"context_line":"            self.pool_id, \u002710.0.0.1\u0027, 80, backup\u003dTrue).get(self.root_tag)"},{"line_number":413,"context_line":"        self.assertTrue(api_member[\u0027backup\u0027])"},{"line_number":414,"context_line":"        self.set_lb_status(self.lb_id)"},{"line_number":415,"context_line":"        api_member \u003d self.create_member("}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_45325412","line":412,"range":{"start_line":412,"start_character":27,"end_line":412,"end_character":35},"updated":"2018-03-28 00:05:50.000000000","message":"nit: Please use TEST-NET addresses in tests that are not \"live\".\n192.0.2.0/24\n198.51.100.0/24\n203.0.113.0/24\nhttp://www.iana.org/go/rfc5737","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7050af4ddfb59aa611773293ce92731e2860f5d","unresolved":false,"context_lines":[{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def test_create_backup(self):"},{"line_number":411,"context_line":"        api_member \u003d self.create_member("},{"line_number":412,"context_line":"            self.pool_id, \u002710.0.0.1\u0027, 80, backup\u003dTrue).get(self.root_tag)"},{"line_number":413,"context_line":"        self.assertTrue(api_member[\u0027backup\u0027])"},{"line_number":414,"context_line":"        self.set_lb_status(self.lb_id)"},{"line_number":415,"context_line":"        api_member \u003d self.create_member("}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_a640dda6","line":412,"range":{"start_line":412,"start_character":27,"end_line":412,"end_character":35},"in_reply_to":"bf659307_45325412","updated":"2018-03-29 20:14:17.000000000","message":"This is copy/pasted from all the other tests in this file. I guess I get to fix ALL of them! :)\nDone.","commit_id":"cced6345cc5c67d8c66e4bd7a13e18ebcf0fbee9"}]}