)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3bb26dccc85366f633b4bfaf5e7937d7e7bb6b03","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"  type: uuid"},{"line_number":1032,"context_line":"timeout_client_data:"},{"line_number":1033,"context_line":"  description: |"},{"line_number":1034,"context_line":"    ??? what do I put here ???"},{"line_number":1035,"context_line":"  in: body"},{"line_number":1036,"context_line":"  required: true"},{"line_number":1037,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_5bd29736","line":1034,"updated":"2018-03-23 17:43:37.000000000","message":"How about something like:\nFrontend client inactivity timeout in milliseconds.","commit_id":"7599549aa728900ba4f3f50106a6dbb1a3dd8d7b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3bb26dccc85366f633b4bfaf5e7937d7e7bb6b03","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"  type: integer"},{"line_number":1038,"context_line":"timeout_client_data-optional:"},{"line_number":1039,"context_line":"  description: |"},{"line_number":1040,"context_line":"    ??? what do I put here ???"},{"line_number":1041,"context_line":"  in: body"},{"line_number":1042,"context_line":"  required: false"},{"line_number":1043,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_db93075c","line":1040,"updated":"2018-03-23 17:43:37.000000000","message":"How about something like:\nFrontend client inactivity timeout in milliseconds.","commit_id":"7599549aa728900ba4f3f50106a6dbb1a3dd8d7b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3bb26dccc85366f633b4bfaf5e7937d7e7bb6b03","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"  type: integer"},{"line_number":1044,"context_line":"timeout_member_connect:"},{"line_number":1045,"context_line":"  description: |"},{"line_number":1046,"context_line":"    ??? what do I put here ???"},{"line_number":1047,"context_line":"  in: body"},{"line_number":1048,"context_line":"  required: true"},{"line_number":1049,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_fbc7eb44","line":1046,"updated":"2018-03-23 17:43:37.000000000","message":"How about something like:\nBackend member connection timeout in milliseconds.","commit_id":"7599549aa728900ba4f3f50106a6dbb1a3dd8d7b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3bb26dccc85366f633b4bfaf5e7937d7e7bb6b03","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"  type: integer"},{"line_number":1050,"context_line":"timeout_member_connect-optional:"},{"line_number":1051,"context_line":"  description: |"},{"line_number":1052,"context_line":"    ??? what do I put here ???"},{"line_number":1053,"context_line":"  in: body"},{"line_number":1054,"context_line":"  required: false"},{"line_number":1055,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_9bc4af42","line":1052,"updated":"2018-03-23 17:43:37.000000000","message":"How about something like:\nBackend member connection timeout in milliseconds.","commit_id":"7599549aa728900ba4f3f50106a6dbb1a3dd8d7b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3bb26dccc85366f633b4bfaf5e7937d7e7bb6b03","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"  type: integer"},{"line_number":1056,"context_line":"timeout_member_data:"},{"line_number":1057,"context_line":"  description: |"},{"line_number":1058,"context_line":"    ??? what do I put here ???"},{"line_number":1059,"context_line":"  in: body"},{"line_number":1060,"context_line":"  required: true"},{"line_number":1061,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_1b989f68","line":1058,"updated":"2018-03-23 17:43:37.000000000","message":"How about something like:\nBackend member inactivity timeout in milliseconds.","commit_id":"7599549aa728900ba4f3f50106a6dbb1a3dd8d7b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3bb26dccc85366f633b4bfaf5e7937d7e7bb6b03","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"  type: integer"},{"line_number":1062,"context_line":"timeout_member_data-optional:"},{"line_number":1063,"context_line":"  description: |"},{"line_number":1064,"context_line":"    ??? what do I put here ???"},{"line_number":1065,"context_line":"  in: body"},{"line_number":1066,"context_line":"  required: false"},{"line_number":1067,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_3b9d6359","line":1064,"updated":"2018-03-23 17:43:37.000000000","message":"How about something like:\nBackend member inactivity timeout in milliseconds.","commit_id":"7599549aa728900ba4f3f50106a6dbb1a3dd8d7b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3bb26dccc85366f633b4bfaf5e7937d7e7bb6b03","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"  type: integer"},{"line_number":1068,"context_line":"timeout_tcp_inspect:"},{"line_number":1069,"context_line":"  description: |"},{"line_number":1070,"context_line":"    ??? what do I put here ???"},{"line_number":1071,"context_line":"  in: body"},{"line_number":1072,"context_line":"  required: true"},{"line_number":1073,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_41baa8de","line":1070,"updated":"2018-03-23 17:43:37.000000000","message":"How about something like:\nTime, in milliseconds, to wait for additional TCP packets for content inspection.","commit_id":"7599549aa728900ba4f3f50106a6dbb1a3dd8d7b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3bb26dccc85366f633b4bfaf5e7937d7e7bb6b03","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"  type: integer"},{"line_number":1074,"context_line":"timeout_tcp_inspect-optional:"},{"line_number":1075,"context_line":"  description: |"},{"line_number":1076,"context_line":"    ??? what do I put here ???"},{"line_number":1077,"context_line":"  in: body"},{"line_number":1078,"context_line":"  required: false"},{"line_number":1079,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_e1ce5c82","line":1076,"updated":"2018-03-23 17:43:37.000000000","message":"How about something like:\nTime, in milliseconds, to wait for additional TCP packets for content inspection.","commit_id":"7599549aa728900ba4f3f50106a6dbb1a3dd8d7b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"  type: uuid"},{"line_number":1032,"context_line":"timeout_client_data:"},{"line_number":1033,"context_line":"  description: |"},{"line_number":1034,"context_line":"    Frontend client inactivity timeout in milliseconds."},{"line_number":1035,"context_line":"  in: body"},{"line_number":1036,"context_line":"  required: true"},{"line_number":1037,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_d041403b","line":1034,"updated":"2018-03-28 00:38:46.000000000","message":"These should include the default value since one is set.\n\" Default ###.\"","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"  type: integer"},{"line_number":1038,"context_line":"timeout_client_data-optional:"},{"line_number":1039,"context_line":"  description: |"},{"line_number":1040,"context_line":"    Frontend client inactivity timeout in milliseconds."},{"line_number":1041,"context_line":"  in: body"},{"line_number":1042,"context_line":"  required: false"},{"line_number":1043,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_f03c84c0","line":1040,"updated":"2018-03-28 00:38:46.000000000","message":"These should include the default value since one is set.\n\" Default ###.\"","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"82fe5d17044e642fa4271d43d936ea38b0bef4c9","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"  type: integer"},{"line_number":1038,"context_line":"timeout_client_data-optional:"},{"line_number":1039,"context_line":"  description: |"},{"line_number":1040,"context_line":"    Frontend client inactivity timeout in milliseconds."},{"line_number":1041,"context_line":"  in: body"},{"line_number":1042,"context_line":"  required: false"},{"line_number":1043,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_04d982f1","line":1040,"in_reply_to":"bf659307_f03c84c0","updated":"2018-03-29 21:08:03.000000000","message":"Done","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"  type: integer"},{"line_number":1044,"context_line":"timeout_member_connect:"},{"line_number":1045,"context_line":"  description: |"},{"line_number":1046,"context_line":"    Backend member connection timeout in milliseconds."},{"line_number":1047,"context_line":"  in: body"},{"line_number":1048,"context_line":"  required: true"},{"line_number":1049,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_904bc857","line":1046,"updated":"2018-03-28 00:38:46.000000000","message":"These should include the default value since one is set.\n\" Default ###.\"","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"  type: integer"},{"line_number":1050,"context_line":"timeout_member_connect-optional:"},{"line_number":1051,"context_line":"  description: |"},{"line_number":1052,"context_line":"    Backend member connection timeout in milliseconds."},{"line_number":1053,"context_line":"  in: body"},{"line_number":1054,"context_line":"  required: false"},{"line_number":1055,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_b0460c4f","line":1052,"updated":"2018-03-28 00:38:46.000000000","message":"These should include the default value since one is set.\n\" Default ###.\"","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"  type: integer"},{"line_number":1056,"context_line":"timeout_member_data:"},{"line_number":1057,"context_line":"  description: |"},{"line_number":1058,"context_line":"    Backend member inactivity timeout in milliseconds."},{"line_number":1059,"context_line":"  in: body"},{"line_number":1060,"context_line":"  required: true"},{"line_number":1061,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_507770a1","line":1058,"updated":"2018-03-28 00:38:46.000000000","message":"These should include the default value since one is set.\n\" Default ###.\"","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"  type: integer"},{"line_number":1062,"context_line":"timeout_member_data-optional:"},{"line_number":1063,"context_line":"  description: |"},{"line_number":1064,"context_line":"    Backend member inactivity timeout in milliseconds."},{"line_number":1065,"context_line":"  in: body"},{"line_number":1066,"context_line":"  required: false"},{"line_number":1067,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_707ab488","line":1064,"updated":"2018-03-28 00:38:46.000000000","message":"These should include the default value since one is set.\n\" Default ###.\"","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"  type: integer"},{"line_number":1068,"context_line":"timeout_tcp_inspect:"},{"line_number":1069,"context_line":"  description: |"},{"line_number":1070,"context_line":"    Time, in milliseconds, to wait for additional TCP packets for content inspection."},{"line_number":1071,"context_line":"  in: body"},{"line_number":1072,"context_line":"  required: true"},{"line_number":1073,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_1071f8a9","line":1070,"updated":"2018-03-28 00:38:46.000000000","message":"These should include the default value since one is set.\n\" Default ###.\"","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"  type: integer"},{"line_number":1074,"context_line":"timeout_tcp_inspect-optional:"},{"line_number":1075,"context_line":"  description: |"},{"line_number":1076,"context_line":"    Time, in milliseconds, to wait for additional TCP packets for content inspection."},{"line_number":1077,"context_line":"  in: body"},{"line_number":1078,"context_line":"  required: false"},{"line_number":1079,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_30743c99","line":1076,"updated":"2018-03-28 00:38:46.000000000","message":"These should include the default value since one is set.\n\" Default ###.\"","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"626ba425c4ec06244e33afee4244af5c8f351ae7","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"  type: integer"},{"line_number":1038,"context_line":"timeout_client_data-optional:"},{"line_number":1039,"context_line":"  description: |"},{"line_number":1040,"context_line":"    Frontend client inactivity timeout in milliseconds. Default: 50000."},{"line_number":1041,"context_line":"  in: body"},{"line_number":1042,"context_line":"  required: false"},{"line_number":1043,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf659307_c2b90c79","line":1040,"updated":"2018-04-02 22:36:11.000000000","message":"do they do the same?","commit_id":"fbb8a583720ac080192f91fdbe8f492914285a21"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cd5893c4cd6ad7646246376b193e4bbb2256a38a","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"  type: integer"},{"line_number":1038,"context_line":"timeout_client_data-optional:"},{"line_number":1039,"context_line":"  description: |"},{"line_number":1040,"context_line":"    Frontend client inactivity timeout in milliseconds. Default: 50000."},{"line_number":1041,"context_line":"  in: body"},{"line_number":1042,"context_line":"  required: false"},{"line_number":1043,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf659307_7d5be4f4","line":1040,"in_reply_to":"bf659307_c2b90c79","updated":"2018-04-04 00:10:52.000000000","message":"Yes, this is purely for the API-REF rendering. Note the difference is the \"required\" param. This is how the api-ref rendering theme likes to see the optional/required parameters.","commit_id":"fbb8a583720ac080192f91fdbe8f492914285a21"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"626ba425c4ec06244e33afee4244af5c8f351ae7","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"  type: integer"},{"line_number":1050,"context_line":"timeout_member_connect-optional:"},{"line_number":1051,"context_line":"  description: |"},{"line_number":1052,"context_line":"    Backend member connection timeout in milliseconds. Default: 5000."},{"line_number":1053,"context_line":"  in: body"},{"line_number":1054,"context_line":"  required: false"},{"line_number":1055,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf659307_22aa4818","line":1052,"updated":"2018-04-02 22:36:11.000000000","message":"not getting from your description what -optional means?","commit_id":"fbb8a583720ac080192f91fdbe8f492914285a21"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b0b66bb6ff6e254f25cc9ee8f855d37960b4545d","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"  type: integer"},{"line_number":1050,"context_line":"timeout_member_connect-optional:"},{"line_number":1051,"context_line":"  description: |"},{"line_number":1052,"context_line":"    Backend member connection timeout in milliseconds. Default: 5000."},{"line_number":1053,"context_line":"  in: body"},{"line_number":1054,"context_line":"  required: false"},{"line_number":1055,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf659307_8139bcf2","line":1052,"in_reply_to":"bf659307_22aa4818","updated":"2018-04-03 18:01:30.000000000","message":"Right, I think you figured this out, but it\u0027s a quirk of the display code in the api-ref. Almost everything we have is duplicated so we can control whether it prints the little \"(optional)\" flag, which is for most inputs but not results (as we guarantee that fields will be present in our return structures).","commit_id":"fbb8a583720ac080192f91fdbe8f492914285a21"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cd5893c4cd6ad7646246376b193e4bbb2256a38a","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"  type: integer"},{"line_number":1050,"context_line":"timeout_member_connect-optional:"},{"line_number":1051,"context_line":"  description: |"},{"line_number":1052,"context_line":"    Backend member connection timeout in milliseconds. Default: 5000."},{"line_number":1053,"context_line":"  in: body"},{"line_number":1054,"context_line":"  required: false"},{"line_number":1055,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf659307_3d71ec76","line":1052,"in_reply_to":"bf659307_8139bcf2","updated":"2018-04-04 00:10:52.000000000","message":"Yep","commit_id":"fbb8a583720ac080192f91fdbe8f492914285a21"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"626ba425c4ec06244e33afee4244af5c8f351ae7","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"  type: integer"},{"line_number":1068,"context_line":"timeout_tcp_inspect:"},{"line_number":1069,"context_line":"  description: |"},{"line_number":1070,"context_line":"    Time, in milliseconds, to wait for additional TCP packets for content"},{"line_number":1071,"context_line":"    inspection. Default: 0."},{"line_number":1072,"context_line":"  in: body"},{"line_number":1073,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf659307_a26bb8ee","line":1070,"updated":"2018-04-02 22:36:11.000000000","message":"we should explain what content inspection is for the causal lb user","commit_id":"fbb8a583720ac080192f91fdbe8f492914285a21"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cd5893c4cd6ad7646246376b193e4bbb2256a38a","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"  type: integer"},{"line_number":1068,"context_line":"timeout_tcp_inspect:"},{"line_number":1069,"context_line":"  description: |"},{"line_number":1070,"context_line":"    Time, in milliseconds, to wait for additional TCP packets for content"},{"line_number":1071,"context_line":"    inspection. Default: 0."},{"line_number":1072,"context_line":"  in: body"},{"line_number":1073,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf659307_9d3038a1","line":1070,"in_reply_to":"bf659307_2128f094","updated":"2018-04-04 00:10:52.000000000","message":"This should be a short description as it goes in the fields box. We should call these out in the API-REF text section however (not that far in the review yet).","commit_id":"fbb8a583720ac080192f91fdbe8f492914285a21"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b0b66bb6ff6e254f25cc9ee8f855d37960b4545d","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"  type: integer"},{"line_number":1068,"context_line":"timeout_tcp_inspect:"},{"line_number":1069,"context_line":"  description: |"},{"line_number":1070,"context_line":"    Time, in milliseconds, to wait for additional TCP packets for content"},{"line_number":1071,"context_line":"    inspection. Default: 0."},{"line_number":1072,"context_line":"  in: body"},{"line_number":1073,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf659307_2128f094","line":1070,"in_reply_to":"bf659307_a26bb8ee","updated":"2018-04-03 18:01:30.000000000","message":"I\u0027m honestly not sure how to explain this better. This wording came from Michael, who maybe understands it best. For most people, the default of 0 is the best setting, and people who need it should know what it is.\nIf you can think of better wording, I\u0027ll update it.","commit_id":"fbb8a583720ac080192f91fdbe8f492914285a21"}],"api-ref/source/v2/listener.inc":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   - protocol_port: protocol_port"},{"line_number":64,"context_line":"   - provisioning_status: provisioning_status"},{"line_number":65,"context_line":"   - sni_container_refs: sni_container_refs"},{"line_number":66,"context_line":"   - updated_at: updated_at"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Response Example"},{"line_number":69,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_f037a4e2","line":66,"updated":"2018-03-28 00:38:46.000000000","message":"Missed adding them here.","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"82fe5d17044e642fa4271d43d936ea38b0bef4c9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   - protocol_port: protocol_port"},{"line_number":64,"context_line":"   - provisioning_status: provisioning_status"},{"line_number":65,"context_line":"   - sni_container_refs: sni_container_refs"},{"line_number":66,"context_line":"   - updated_at: updated_at"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Response Example"},{"line_number":69,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_849b5216","line":66,"in_reply_to":"bf659307_f037a4e2","updated":"2018-03-29 21:08:03.000000000","message":"Done","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":211,"context_line":"   - provisioning_status: provisioning_status"},{"line_number":212,"context_line":"   - sni_container_refs: sni_container_refs"},{"line_number":213,"context_line":"   - updated_at: updated_at"},{"line_number":214,"context_line":"   - timeout_client_data: timeout_client_data"},{"line_number":215,"context_line":"   - timeout_member_connect: timeout_member_connect"},{"line_number":216,"context_line":"   - timeout_member_data: timeout_member_data"},{"line_number":217,"context_line":"   - timeout_tcp_inspect: timeout_tcp_inspect"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_f00ec430","line":214,"updated":"2018-03-28 00:38:46.000000000","message":"Can we move these up a line so the sort remains?","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"82fe5d17044e642fa4271d43d936ea38b0bef4c9","unresolved":false,"context_lines":[{"line_number":211,"context_line":"   - provisioning_status: provisioning_status"},{"line_number":212,"context_line":"   - sni_container_refs: sni_container_refs"},{"line_number":213,"context_line":"   - updated_at: updated_at"},{"line_number":214,"context_line":"   - timeout_client_data: timeout_client_data"},{"line_number":215,"context_line":"   - timeout_member_connect: timeout_member_connect"},{"line_number":216,"context_line":"   - timeout_member_data: timeout_member_data"},{"line_number":217,"context_line":"   - timeout_tcp_inspect: timeout_tcp_inspect"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_44a1ba45","line":214,"in_reply_to":"bf659307_f00ec430","updated":"2018-03-29 21:08:03.000000000","message":"Done","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":284,"context_line":"   - provisioning_status: provisioning_status"},{"line_number":285,"context_line":"   - sni_container_refs: sni_container_refs"},{"line_number":286,"context_line":"   - updated_at: updated_at"},{"line_number":287,"context_line":"   - timeout_client_data: timeout_client_data"},{"line_number":288,"context_line":"   - timeout_member_connect: timeout_member_connect"},{"line_number":289,"context_line":"   - timeout_member_data: timeout_member_data"},{"line_number":290,"context_line":"   - timeout_tcp_inspect: timeout_tcp_inspect"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_901d0868","line":287,"updated":"2018-03-28 00:38:46.000000000","message":"Can we move these up a line so the sort remains?","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"82fe5d17044e642fa4271d43d936ea38b0bef4c9","unresolved":false,"context_lines":[{"line_number":284,"context_line":"   - provisioning_status: provisioning_status"},{"line_number":285,"context_line":"   - sni_container_refs: sni_container_refs"},{"line_number":286,"context_line":"   - updated_at: updated_at"},{"line_number":287,"context_line":"   - timeout_client_data: timeout_client_data"},{"line_number":288,"context_line":"   - timeout_member_connect: timeout_member_connect"},{"line_number":289,"context_line":"   - timeout_member_data: timeout_member_data"},{"line_number":290,"context_line":"   - timeout_tcp_inspect: timeout_tcp_inspect"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_048742b7","line":287,"in_reply_to":"bf659307_901d0868","updated":"2018-03-29 21:08:03.000000000","message":"Done","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":378,"context_line":"   - provisioning_status: provisioning_status"},{"line_number":379,"context_line":"   - sni_container_refs: sni_container_refs"},{"line_number":380,"context_line":"   - updated_at: updated_at"},{"line_number":381,"context_line":"   - timeout_client_data: timeout_client_data"},{"line_number":382,"context_line":"   - timeout_member_connect: timeout_member_connect"},{"line_number":383,"context_line":"   - timeout_member_data: timeout_member_data"},{"line_number":384,"context_line":"   - timeout_tcp_inspect: timeout_tcp_inspect"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_5029b087","line":381,"updated":"2018-03-28 00:38:46.000000000","message":"Can we move these up a line so the sort remains?","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"82fe5d17044e642fa4271d43d936ea38b0bef4c9","unresolved":false,"context_lines":[{"line_number":378,"context_line":"   - provisioning_status: provisioning_status"},{"line_number":379,"context_line":"   - sni_container_refs: sni_container_refs"},{"line_number":380,"context_line":"   - updated_at: updated_at"},{"line_number":381,"context_line":"   - timeout_client_data: timeout_client_data"},{"line_number":382,"context_line":"   - timeout_member_connect: timeout_member_connect"},{"line_number":383,"context_line":"   - timeout_member_data: timeout_member_data"},{"line_number":384,"context_line":"   - timeout_tcp_inspect: timeout_tcp_inspect"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bf659307_a48f76cb","line":381,"in_reply_to":"bf659307_5029b087","updated":"2018-03-29 21:08:03.000000000","message":"Done","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cd5893c4cd6ad7646246376b193e4bbb2256a38a","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Specifying a project_id is deprecated.  The listener will inherit"},{"line_number":110,"context_line":"the project_id of the parent load balancer."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"You can configure all documented features of the listener at creation time by"},{"line_number":113,"context_line":"specifying the additional elements or attributes in the request."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"bf659307_5db4e0f1","line":111,"updated":"2018-04-04 00:10:52.000000000","message":"We should put a better description of the timeouts here.","commit_id":"fbb8a583720ac080192f91fdbe8f492914285a21"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f95ea5276ebf75a63796e56516dd2cff8a061bc8","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Specifying a project_id is deprecated.  The listener will inherit"},{"line_number":110,"context_line":"the project_id of the parent load balancer."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"You can configure all documented features of the listener at creation time by"},{"line_number":113,"context_line":"specifying the additional elements or attributes in the request."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"bf659307_8401c007","line":111,"in_reply_to":"bf659307_5db4e0f1","updated":"2018-04-04 04:03:59.000000000","message":"Umm... I don\u0027t suppose I could copy/paste what HAProxy says, with some very minor edits? Is there such a thing as docs plagiarism?","commit_id":"fbb8a583720ac080192f91fdbe8f492914285a21"}],"octavia/common/jinja/haproxy/jinja_cfg.py":[{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"04efd80774ac61fdc1acd35abb653944c78e1b5a","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            \u0027topology\u0027: listener.load_balancer.topology,"},{"line_number":190,"context_line":"            \u0027amphorae\u0027: listener.load_balancer.amphorae,"},{"line_number":191,"context_line":"            \u0027enabled\u0027: listener.enabled,"},{"line_number":192,"context_line":"            \u0027timeout_client_data\u0027: (listener.timeout_client_data or"},{"line_number":193,"context_line":"                                    constants.DEFAULT_TIMEOUT_CLIENT_DATA),"},{"line_number":194,"context_line":"            \u0027timeout_member_connect\u0027: (listener.timeout_member_connect or"},{"line_number":195,"context_line":"                                       constants.DEFAULT_TIMEOUT_MEMBER_CONNECT"},{"line_number":196,"context_line":"                                       ),"},{"line_number":197,"context_line":"            \u0027timeout_member_data\u0027: (listener.timeout_member_data or"},{"line_number":198,"context_line":"                                    constants.DEFAULT_TIMEOUT_MEMBER_DATA),"},{"line_number":199,"context_line":"            \u0027timeout_tcp_inspect\u0027: (listener.timeout_tcp_inspect or"},{"line_number":200,"context_line":"                                    constants.DEFAULT_TIMEOUT_TCP_INSPECT),"},{"line_number":201,"context_line":"        }"},{"line_number":202,"context_line":"        if listener.connection_limit and listener.connection_limit \u003e -1:"},{"line_number":203,"context_line":"            ret_value[\u0027connection_limit\u0027] \u003d listener.connection_limit"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_9d141546","line":200,"range":{"start_line":192,"start_character":0,"end_line":200,"end_character":74},"updated":"2018-03-29 09:48:35.000000000","message":"Why do you set default value here? I think this is best done when we create the data model object (file: octavia/common/data_models.py). I think it will be more understandable for other developers.","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"82fe5d17044e642fa4271d43d936ea38b0bef4c9","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            \u0027topology\u0027: listener.load_balancer.topology,"},{"line_number":190,"context_line":"            \u0027amphorae\u0027: listener.load_balancer.amphorae,"},{"line_number":191,"context_line":"            \u0027enabled\u0027: listener.enabled,"},{"line_number":192,"context_line":"            \u0027timeout_client_data\u0027: (listener.timeout_client_data or"},{"line_number":193,"context_line":"                                    constants.DEFAULT_TIMEOUT_CLIENT_DATA),"},{"line_number":194,"context_line":"            \u0027timeout_member_connect\u0027: (listener.timeout_member_connect or"},{"line_number":195,"context_line":"                                       constants.DEFAULT_TIMEOUT_MEMBER_CONNECT"},{"line_number":196,"context_line":"                                       ),"},{"line_number":197,"context_line":"            \u0027timeout_member_data\u0027: (listener.timeout_member_data or"},{"line_number":198,"context_line":"                                    constants.DEFAULT_TIMEOUT_MEMBER_DATA),"},{"line_number":199,"context_line":"            \u0027timeout_tcp_inspect\u0027: (listener.timeout_tcp_inspect or"},{"line_number":200,"context_line":"                                    constants.DEFAULT_TIMEOUT_TCP_INSPECT),"},{"line_number":201,"context_line":"        }"},{"line_number":202,"context_line":"        if listener.connection_limit and listener.connection_limit \u003e -1:"},{"line_number":203,"context_line":"            ret_value[\u0027connection_limit\u0027] \u003d listener.connection_limit"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_a7bc5806","line":200,"range":{"start_line":192,"start_character":0,"end_line":200,"end_character":74},"in_reply_to":"bf659307_9d141546","updated":"2018-03-29 21:08:03.000000000","message":"Hmm... There isn\u0027t really a convention for setting defaults there either...\nMichael, thoughts?","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"}],"octavia/db/migration/alembic_migrations/versions/0fd2c131923f_add_timeout_fields_to_listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"882d74f9ccf3df458f1eba4677d1cf2a9467cb15","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    op.add_column(\u0027listener\u0027,"},{"line_number":36,"context_line":"                  sa.Column(\u0027timeout_client_data\u0027,"},{"line_number":37,"context_line":"                            sa.Integer(), nullable\u003dTrue),"},{"line_number":38,"context_line":"                  default\u003dconstants.DEFAULT_TIMEOUT_CLIENT_DATA)"},{"line_number":39,"context_line":"    op.add_column(\u0027listener\u0027,"},{"line_number":40,"context_line":"                  sa.Column(\u0027timeout_member_connect\u0027,"},{"line_number":41,"context_line":"                            sa.Integer(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_325900fe","line":38,"range":{"start_line":38,"start_character":18,"end_line":38,"end_character":63},"updated":"2018-03-23 19:49:18.000000000","message":"This needs to be inside the sa.Column()","commit_id":"151af53345b2e64ac915de1e86eb2b9c32a00785"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    op.add_column(\u0027listener\u0027,"},{"line_number":36,"context_line":"                  sa.Column(\u0027timeout_client_data\u0027,"},{"line_number":37,"context_line":"                            sa.Integer(), nullable\u003dTrue,"},{"line_number":38,"context_line":"                            default\u003dconstants.DEFAULT_TIMEOUT_CLIENT_DATA))"},{"line_number":39,"context_line":"    op.add_column(\u0027listener\u0027,"},{"line_number":40,"context_line":"                  sa.Column(\u0027timeout_member_connect\u0027,"},{"line_number":41,"context_line":"                            sa.Integer(), nullable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_305e7ce6","line":38,"updated":"2018-03-28 00:38:46.000000000","message":"This enforces our defaults on all of the drivers.\nWhich could be a good thing (clear to the user, well documented, etc.) but might also be annoying if one driver ALWAYS needs a different default.\nI lean towards leaving this, but interested in others thoughts.","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"82fe5d17044e642fa4271d43d936ea38b0bef4c9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    op.add_column(\u0027listener\u0027,"},{"line_number":36,"context_line":"                  sa.Column(\u0027timeout_client_data\u0027,"},{"line_number":37,"context_line":"                            sa.Integer(), nullable\u003dTrue,"},{"line_number":38,"context_line":"                            default\u003dconstants.DEFAULT_TIMEOUT_CLIENT_DATA))"},{"line_number":39,"context_line":"    op.add_column(\u0027listener\u0027,"},{"line_number":40,"context_line":"                  sa.Column(\u0027timeout_member_connect\u0027,"},{"line_number":41,"context_line":"                            sa.Integer(), nullable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_243846ec","line":38,"in_reply_to":"bf659307_1d1c8576","updated":"2018-03-29 21:08:03.000000000","message":"Does setting a default here affect providers any more than setting it in the API layer does? Since they won\u0027t be changing the defaults in the API layer either, I see no functional difference...\n\nBut, the real point of this was just to keep existing entries in the DB from having nulls, so:\n\nI think I can immediately remove the default after this line, so that it just uses it for the upgrade and then doesn\u0027t stick (the assumption being that when this is run, everyone will still be using our default provider, because this will merge before provider support).\nOr, we could just let them remain in the DB with nulls... But, I am not a huge fan of that.","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"04efd80774ac61fdc1acd35abb653944c78e1b5a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    op.add_column(\u0027listener\u0027,"},{"line_number":36,"context_line":"                  sa.Column(\u0027timeout_client_data\u0027,"},{"line_number":37,"context_line":"                            sa.Integer(), nullable\u003dTrue,"},{"line_number":38,"context_line":"                            default\u003dconstants.DEFAULT_TIMEOUT_CLIENT_DATA))"},{"line_number":39,"context_line":"    op.add_column(\u0027listener\u0027,"},{"line_number":40,"context_line":"                  sa.Column(\u0027timeout_member_connect\u0027,"},{"line_number":41,"context_line":"                            sa.Integer(), nullable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_1d1c8576","line":38,"in_reply_to":"bf659307_305e7ce6","updated":"2018-03-29 09:48:35.000000000","message":"I agree with Michael, it\u0027s might be annoying. I think the best way is set the default value when we processing API request (file octavia/api/v2/types/listener.py) and when we creating new the listener object (file octavia/common/data_models.py) and this will be enough. here it is better to use null value.","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"}],"octavia/tests/functional/api/v2/test_listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    def test_create_with_timeouts(self):"},{"line_number":466,"context_line":"        optionals \u003d {"},{"line_number":467,"context_line":"            \u0027timeout_client_data\u0027: 1,"},{"line_number":468,"context_line":"            \u0027timeout_member_connect\u0027: 2,"},{"line_number":469,"context_line":"            \u0027timeout_member_data\u0027: 3,"},{"line_number":470,"context_line":"            \u0027timeout_tcp_inspect\u0027: 4,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_b017eced","line":467,"updated":"2018-03-28 00:38:46.000000000","message":"Consider one of these using your minimum constant and another using the maximum constant.","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"82fe5d17044e642fa4271d43d936ea38b0bef4c9","unresolved":false,"context_lines":[{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    def test_create_with_timeouts(self):"},{"line_number":466,"context_line":"        optionals \u003d {"},{"line_number":467,"context_line":"            \u0027timeout_client_data\u0027: 1,"},{"line_number":468,"context_line":"            \u0027timeout_member_connect\u0027: 2,"},{"line_number":469,"context_line":"            \u0027timeout_member_data\u0027: 3,"},{"line_number":470,"context_line":"            \u0027timeout_tcp_inspect\u0027: 4,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_c4286a98","line":467,"in_reply_to":"bf659307_b017eced","updated":"2018-03-29 21:08:03.000000000","message":"Good call.","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"}],"octavia/tests/functional/db/test_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def test_create_with_timeouts(self):"},{"line_number":339,"context_line":"        timeouts \u003d {"},{"line_number":340,"context_line":"            \u0027timeout_client_data\u0027: 1,"},{"line_number":341,"context_line":"            \u0027timeout_member_connect\u0027: 2,"},{"line_number":342,"context_line":"            \u0027timeout_member_data\u0027: 3,"},{"line_number":343,"context_line":"            \u0027timeout_tcp_inspect\u0027: 4,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_f0cc8462","line":340,"updated":"2018-03-28 00:38:46.000000000","message":"Same here, consider doing one with minimum, one with max","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"82fe5d17044e642fa4271d43d936ea38b0bef4c9","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def test_create_with_timeouts(self):"},{"line_number":339,"context_line":"        timeouts \u003d {"},{"line_number":340,"context_line":"            \u0027timeout_client_data\u0027: 1,"},{"line_number":341,"context_line":"            \u0027timeout_member_connect\u0027: 2,"},{"line_number":342,"context_line":"            \u0027timeout_member_data\u0027: 3,"},{"line_number":343,"context_line":"            \u0027timeout_tcp_inspect\u0027: 4,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_47721caf","line":340,"in_reply_to":"bf659307_f0cc8462","updated":"2018-03-29 21:08:03.000000000","message":"Done","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"}],"releasenotes/notes/Allow-configuration-of-listener-timeout-values-9a7600c4e21364e3.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa5b88c1188219f3f5187d0c57d0a6d928c8cc7d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Listeners have four new timeout settings:"},{"line_number":5,"context_line":"    `timeout_client_data`: Frontend client inactivity timeout"},{"line_number":6,"context_line":"    `timeout_member_connect`: Backend member connection timeout"},{"line_number":7,"context_line":"    `timeout_member_data`: Backend member inactivity timeout"},{"line_number":8,"context_line":"    `timeout_tcp_inspect`: Time to wait for TCP packets for content inspection"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_90c66848","line":5,"updated":"2018-03-28 00:38:46.000000000","message":"This doesn\u0027t render in a list. It is squished.\nMaybe make each one it\u0027s own - bullet?","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"82fe5d17044e642fa4271d43d936ea38b0bef4c9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Listeners have four new timeout settings:"},{"line_number":5,"context_line":"    `timeout_client_data`: Frontend client inactivity timeout"},{"line_number":6,"context_line":"    `timeout_member_connect`: Backend member connection timeout"},{"line_number":7,"context_line":"    `timeout_member_data`: Backend member inactivity timeout"},{"line_number":8,"context_line":"    `timeout_tcp_inspect`: Time to wait for TCP packets for content inspection"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_c7e06c29","line":5,"in_reply_to":"bf659307_90c66848","updated":"2018-03-29 21:08:03.000000000","message":"Done (I hope)","commit_id":"ea48099e37fa5d1f0aab08463178465caed3b128"}]}