)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"bb6ae4ef61fb5dd0aa0a757c47ac2d73bbb2f47f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update API-REF for x-forwarded-port is boolean"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The API reference document had a typo where the \"X-Forwarded-Port\" parameter"},{"line_number":10,"context_line":"for the HTTP header insertions was listed as an integer instead of as a"},{"line_number":11,"context_line":"boolean."},{"line_number":12,"context_line":"This patch corrects that mistake."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf659307_82000503","line":9,"range":{"start_line":9,"start_character":67,"end_line":9,"end_character":76},"updated":"2018-04-01 13:40:06.000000000","message":"nit (not sure if we care): this line is over 73 chars","commit_id":"4fb68047c9c326bf0da2623bec45c4350b605a7a"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"bb6ae4ef61fb5dd0aa0a757c47ac2d73bbb2f47f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The API reference document had a typo where the \"X-Forwarded-Port\" parameter"},{"line_number":10,"context_line":"for the HTTP header insertions was listed as an integer instead of as a"},{"line_number":11,"context_line":"boolean."},{"line_number":12,"context_line":"This patch corrects that mistake."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3996d5e1950f8d979eb1c354dfac70a0ddefdca2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf659307_a2050913","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"updated":"2018-04-01 13:40:06.000000000","message":"as a follow-up to Adam\u0027s comments, this is now \u0027string\u0027.\nAlso worth mentioning X-Forwarded-For while we are at it since we changed that as well.","commit_id":"4fb68047c9c326bf0da2623bec45c4350b605a7a"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"346f857a84d3966be87ca055926aea812f3713b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Johnson \u003cjohnsomor@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-01 17:50:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update API-REF for x-forwarded-port is boolean"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The API reference document had a typo where the \"X-Forwarded-Port\""},{"line_number":10,"context_line":"parameter for the HTTP header insertions was listed as an integer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf659307_93ce1661","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":46},"updated":"2018-04-02 02:17:04.000000000","message":"string","commit_id":"31390ccfb789b6a05bea6513edd902d02b6e2912"}],"api-ref/source/v2/listener.inc":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"1a5b8c8d7aced81b0456aa744991fdc34e2b4f4f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"|                  |         | ``member`` that specifies the client IP        |"},{"line_number":165,"context_line":"|                  |         | address.                                       |"},{"line_number":166,"context_line":"+------------------+---------+------------------------------------------------+"},{"line_number":167,"context_line":"| X-Forwarded-Port | boolean | A ``X-Forwarded-Port`` header is inserted into |"},{"line_number":168,"context_line":"|                  |         | the request to the backend ``member`` that     |"},{"line_number":169,"context_line":"|                  |         | specifies the listener port.                   |"},{"line_number":170,"context_line":"+------------------+---------+------------------------------------------------+"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"bf659307_ca0b81d3","line":167,"updated":"2018-03-30 19:26:42.000000000","message":"Technically I think the bug may be that BOTH are listed incorrectly, as they really need to be passed as Strings, not boolean or Integer. :(\nDue to the way we genericized the insert_header code, you need to pass a boolean-compatible value as a string.\nSee: https://github.com/openstack/oslo.utils/blob/master/oslo_utils/strutils.py#L50-L51","commit_id":"28a7bba5f34540aa880f6a39094353ee98582c35"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f586b662cd8cc450b6a472fa752236d9b8699c9f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"|                  |         | ``member`` that specifies the client IP        |"},{"line_number":165,"context_line":"|                  |         | address.                                       |"},{"line_number":166,"context_line":"+------------------+---------+------------------------------------------------+"},{"line_number":167,"context_line":"| X-Forwarded-Port | boolean | A ``X-Forwarded-Port`` header is inserted into |"},{"line_number":168,"context_line":"|                  |         | the request to the backend ``member`` that     |"},{"line_number":169,"context_line":"|                  |         | specifies the listener port.                   |"},{"line_number":170,"context_line":"+------------------+---------+------------------------------------------------+"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"bf659307_8a2a6929","line":167,"in_reply_to":"bf659307_ca0b81d3","updated":"2018-03-30 19:30:53.000000000","message":"Hmm, actually I thought we were passing things through bool_from_string() but I can\u0027t actually find where we\u0027d do that, and I suppose since they are supposed to be generic, doing that for all of these wouldn\u0027t make sense.\n\nSo, I guess that means the format may be much more specific? Like, only \"true\" works? In which case, we need to document that very well. :/","commit_id":"28a7bba5f34540aa880f6a39094353ee98582c35"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"bb6ae4ef61fb5dd0aa0a757c47ac2d73bbb2f47f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"|                  |        | ``member`` that specifies the client IP        |"},{"line_number":165,"context_line":"|                  |        | address.                                       |"},{"line_number":166,"context_line":"+------------------+--------+------------------------------------------------+"},{"line_number":167,"context_line":"| X-Forwarded-Port | srting | When \"``true``\" a ``X-Forwarded-Port`` header  |"},{"line_number":168,"context_line":"|                  |        | is inserted into the request to the backend    |"},{"line_number":169,"context_line":"|                  |        | ``member`` that specifies the listener port.   |"},{"line_number":170,"context_line":"+------------------+--------+------------------------------------------------+"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"bf659307_e701d307","line":167,"range":{"start_line":167,"start_character":21,"end_line":167,"end_character":27},"updated":"2018-04-01 13:40:06.000000000","message":"string","commit_id":"4fb68047c9c326bf0da2623bec45c4350b605a7a"}]}