)]}'
{"octavia/controller/healthmanager/health_drivers/update_db.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"039f26ba52bafc3ca6269ef3a8eef59898bff86a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # so we need to wrap it and log the unhandled exception"},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            self._update_health(health, srcaddr)"},{"line_number":83,"context_line":"        except Exception:"},{"line_number":84,"context_line":"            LOG.exception(\u0027update_health encountered an unknown error \u0027"},{"line_number":85,"context_line":"                          \u0027processing health message for amphora {0} with IP \u0027"},{"line_number":86,"context_line":"                          \u0027{1}\u0027.format(health[\u0027id\u0027], srcaddr))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_6c416439","line":83,"updated":"2018-05-09 23:06:15.000000000","message":"When we log \"unknown errors\" it would be useful to actually see the exception that happened, and the stacktrace, so we can have SOME idea what\u0027s going on (even if just as a debug message)","commit_id":"e868b8a015b4dbd3f90a35243c4ed75a42106506"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ad42320acbb28063e215b20cfa1fdbbd260ea93c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # so we need to wrap it and log the unhandled exception"},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            self._update_health(health, srcaddr)"},{"line_number":83,"context_line":"        except Exception:"},{"line_number":84,"context_line":"            LOG.exception(\u0027update_health encountered an unknown error \u0027"},{"line_number":85,"context_line":"                          \u0027processing health message for amphora {0} with IP \u0027"},{"line_number":86,"context_line":"                          \u0027{1}\u0027.format(health[\u0027id\u0027], srcaddr))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c08c9437","line":83,"in_reply_to":"5f7c97a3_6c416439","updated":"2018-05-15 22:24:55.000000000","message":"I thought LOG.exception added that automagically:\nhttps://docs.python.org/3/library/logging.html#logging.Logger.exception","commit_id":"e868b8a015b4dbd3f90a35243c4ed75a42106506"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a272f55c7a22a35072f67497a3ce85a27596e592","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # so we need to wrap it and log the unhandled exception"},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            self._update_health(health, srcaddr)"},{"line_number":83,"context_line":"        except Exception:"},{"line_number":84,"context_line":"            LOG.exception(\u0027update_health encountered an unknown error \u0027"},{"line_number":85,"context_line":"                          \u0027processing health message for amphora {0} with IP \u0027"},{"line_number":86,"context_line":"                          \u0027{1}\u0027.format(health[\u0027id\u0027], srcaddr))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c45ec811","line":83,"in_reply_to":"5f7c97a3_c08c9437","updated":"2018-05-16 22:45:40.000000000","message":"Oh, interesting. Didn\u0027t actually catch that, just noticed it didn\u0027t have an `as e` or anything. Alright.","commit_id":"e868b8a015b4dbd3f90a35243c4ed75a42106506"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"039f26ba52bafc3ca6269ef3a8eef59898bff86a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                      \u0027will only see this message a few times. However if \u0027"},{"line_number":128,"context_line":"                      \u0027it is repeating this amphora should be manually \u0027"},{"line_number":129,"context_line":"                      \u0027deleted.\u0027.format(health[\u0027id\u0027], srcaddr))"},{"line_number":130,"context_line":"            return"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # We need to loop over the lbs here to make sure we update the"},{"line_number":133,"context_line":"        # amphora_health record as soon as possible to prevent unnecessary"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ac70dca6","line":130,"updated":"2018-05-09 23:06:15.000000000","message":"We return here? So this blocks health messages from updating the DB entirely if they don\u0027t have a LB?\nOriginally I was thinking this would be problematic for zombie amps (which was the whole purpose of this patch) because it would make them less visible in the DB, but actually I think keying off db_lbs_on_amp means that zombie amps will still update, but *spares* won\u0027t? Which ... is not good.","commit_id":"e868b8a015b4dbd3f90a35243c4ed75a42106506"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ad42320acbb28063e215b20cfa1fdbbd260ea93c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                      \u0027will only see this message a few times. However if \u0027"},{"line_number":128,"context_line":"                      \u0027it is repeating this amphora should be manually \u0027"},{"line_number":129,"context_line":"                      \u0027deleted.\u0027.format(health[\u0027id\u0027], srcaddr))"},{"line_number":130,"context_line":"            return"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # We need to loop over the lbs here to make sure we update the"},{"line_number":133,"context_line":"        # amphora_health record as soon as possible to prevent unnecessary"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ee1ada6c","line":130,"in_reply_to":"5f7c97a3_ac70dca6","updated":"2018-05-15 22:24:55.000000000","message":"Right, good point. This will sweep up spares....\nhmmm.","commit_id":"e868b8a015b4dbd3f90a35243c4ed75a42106506"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"26a5404c739d16bfae31b6c6e8acc46fd7d85f9d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        listeners \u003d health[\u0027listeners\u0027]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        if not db_lbs_on_amp:"},{"line_number":122,"context_line":"            # If this is not a spare amp, log and skip it."},{"line_number":123,"context_line":"            amp \u003d self.amphora_repo.get(session, id\u003dhealth[\u0027id\u0027])"},{"line_number":124,"context_line":"            if amp.load_balancer_id:"},{"line_number":125,"context_line":"                # This is debug and not warning because this can happen under"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_d4006c05","line":122,"updated":"2018-06-06 22:35:43.000000000","message":"Note: now there could be amps sticking around in the amp table with status DELETED, which have lb_ids. So, you may also want to add some checking around the status?","commit_id":"18648c8fddf37d8db2bb6a54518c020a27d6d678"}]}
