)]}'
{"octavia/api/v2/controllers/base.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4c1e8b544dac4a72253e6bf1ea9d220e8ede6db4","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                              show_deleted\u003dshow_deleted)"},{"line_number":132,"context_line":"        # Defaulting to \"amphora\" here as any lbs in the octavia database"},{"line_number":133,"context_line":"        # with a blank provider had to be of type amphora."},{"line_number":134,"context_line":"        provider \u003d getattr(lb, \u0027provider\u0027, \u0027amphora\u0027)"},{"line_number":135,"context_line":"        return lb.project_id, provider"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _get_l7policy_project_id(self, session, id, show_deleted\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ecb0c6df","line":134,"updated":"2018-05-14 18:44:57.000000000","message":"Is this the second place we\u0027re defaulting this? Can\u0027t we let the None fall through and be handled by the driver loader?","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"00883dcdeac243ed3a512783e198face68f68527","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                              show_deleted\u003dshow_deleted)"},{"line_number":132,"context_line":"        # Defaulting to \"amphora\" here as any lbs in the octavia database"},{"line_number":133,"context_line":"        # with a blank provider had to be of type amphora."},{"line_number":134,"context_line":"        provider \u003d getattr(lb, \u0027provider\u0027, \u0027amphora\u0027)"},{"line_number":135,"context_line":"        return lb.project_id, provider"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _get_l7policy_project_id(self, session, id, show_deleted\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_8e8486d4","line":134,"in_reply_to":"5f7c97a3_ecb0c6df","updated":"2018-05-15 23:14:13.000000000","message":"Done","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"}],"octavia/api/v2/controllers/listener.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4c1e8b544dac4a72253e6bf1ea9d220e8ede6db4","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"            # Dispatch to the driver"},{"line_number":237,"context_line":"            LOG.info(\"Sending create Listener %s to provider %s\","},{"line_number":238,"context_line":"                     db_listener.id, provider)"},{"line_number":239,"context_line":"            driver_utils.call_provider("},{"line_number":240,"context_line":"                provider, driver.listener_create, provider_listener)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ecfe8669","line":238,"updated":"2018-05-14 18:44:57.000000000","message":"I think we want `provider` to actually be `driver.name`","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"00883dcdeac243ed3a512783e198face68f68527","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"            # Dispatch to the driver"},{"line_number":237,"context_line":"            LOG.info(\"Sending create Listener %s to provider %s\","},{"line_number":238,"context_line":"                     db_listener.id, provider)"},{"line_number":239,"context_line":"            driver_utils.call_provider("},{"line_number":240,"context_line":"                provider, driver.listener_create, provider_listener)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ae64e24a","line":238,"in_reply_to":"5f7c97a3_ecfe8669","updated":"2018-05-15 23:14:13.000000000","message":"Done","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4c1e8b544dac4a72253e6bf1ea9d220e8ede6db4","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            LOG.info(\"Sending create Listener %s to provider %s\","},{"line_number":238,"context_line":"                     db_listener.id, provider)"},{"line_number":239,"context_line":"            driver_utils.call_provider("},{"line_number":240,"context_line":"                provider, driver.listener_create, provider_listener)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"            lock_session.commit()"},{"line_number":243,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ccce2a59","line":240,"updated":"2018-05-14 18:44:57.000000000","message":"I think we want `provider` to actually be `driver.name`","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"00883dcdeac243ed3a512783e198face68f68527","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            LOG.info(\"Sending create Listener %s to provider %s\","},{"line_number":238,"context_line":"                     db_listener.id, provider)"},{"line_number":239,"context_line":"            driver_utils.call_provider("},{"line_number":240,"context_line":"                provider, driver.listener_create, provider_listener)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"            lock_session.commit()"},{"line_number":243,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ce67de4c","line":240,"in_reply_to":"5f7c97a3_ccce2a59","updated":"2018-05-15 23:14:13.000000000","message":"Done","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4c1e8b544dac4a72253e6bf1ea9d220e8ede6db4","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                driver_utils.listener_dict_to_provider_dict(listener_dict))"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"            # Dispatch to the driver"},{"line_number":328,"context_line":"            LOG.info(\"Sending update Listener %s to provider %s\", id, provider)"},{"line_number":329,"context_line":"            driver_utils.call_provider("},{"line_number":330,"context_line":"                provider, driver.listener_update,"},{"line_number":331,"context_line":"                driver_dm.Listener.from_dict(provider_listener_dict))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_6cd91620","line":328,"updated":"2018-05-14 18:44:57.000000000","message":"I think we want `provider` to actually be `driver.name`","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"00883dcdeac243ed3a512783e198face68f68527","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                driver_utils.listener_dict_to_provider_dict(listener_dict))"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"            # Dispatch to the driver"},{"line_number":328,"context_line":"            LOG.info(\"Sending update Listener %s to provider %s\", id, provider)"},{"line_number":329,"context_line":"            driver_utils.call_provider("},{"line_number":330,"context_line":"                provider, driver.listener_update,"},{"line_number":331,"context_line":"                driver_dm.Listener.from_dict(provider_listener_dict))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_8e5d667a","line":328,"in_reply_to":"5f7c97a3_6cd91620","updated":"2018-05-15 23:14:13.000000000","message":"Done","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4c1e8b544dac4a72253e6bf1ea9d220e8ede6db4","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            # Dispatch to the driver"},{"line_number":328,"context_line":"            LOG.info(\"Sending update Listener %s to provider %s\", id, provider)"},{"line_number":329,"context_line":"            driver_utils.call_provider("},{"line_number":330,"context_line":"                provider, driver.listener_update,"},{"line_number":331,"context_line":"                driver_dm.Listener.from_dict(provider_listener_dict))"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            # Update the database to reflect what the driver just accepted"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_4c0c5aa4","line":330,"updated":"2018-05-14 18:44:57.000000000","message":"I think we want `provider` to actually be `driver.name`","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"00883dcdeac243ed3a512783e198face68f68527","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            # Dispatch to the driver"},{"line_number":328,"context_line":"            LOG.info(\"Sending update Listener %s to provider %s\", id, provider)"},{"line_number":329,"context_line":"            driver_utils.call_provider("},{"line_number":330,"context_line":"                provider, driver.listener_update,"},{"line_number":331,"context_line":"                driver_dm.Listener.from_dict(provider_listener_dict))"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            # Update the database to reflect what the driver just accepted"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_2e58d285","line":330,"in_reply_to":"5f7c97a3_4c0c5aa4","updated":"2018-05-15 23:14:13.000000000","message":"Done","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4c1e8b544dac4a72253e6bf1ea9d220e8ede6db4","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                lock_session, load_balancer_id,"},{"line_number":365,"context_line":"                id\u003did, listener_status\u003dconstants.PENDING_DELETE)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            LOG.info(\"Sending delete Listener %s to provider %s\", id, provider)"},{"line_number":368,"context_line":"            driver_utils.call_provider(provider, driver.listener_delete, id)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @pecan.expose()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_6cf2769c","line":367,"updated":"2018-05-14 18:44:57.000000000","message":"I think we want `provider` to actually be `driver.name`","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"00883dcdeac243ed3a512783e198face68f68527","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                lock_session, load_balancer_id,"},{"line_number":365,"context_line":"                id\u003did, listener_status\u003dconstants.PENDING_DELETE)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            LOG.info(\"Sending delete Listener %s to provider %s\", id, provider)"},{"line_number":368,"context_line":"            driver_utils.call_provider(provider, driver.listener_delete, id)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @pecan.expose()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_0e4956b5","line":367,"in_reply_to":"5f7c97a3_6cf2769c","updated":"2018-05-15 23:14:13.000000000","message":"Done","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4c1e8b544dac4a72253e6bf1ea9d220e8ede6db4","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                id\u003did, listener_status\u003dconstants.PENDING_DELETE)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            LOG.info(\"Sending delete Listener %s to provider %s\", id, provider)"},{"line_number":368,"context_line":"            driver_utils.call_provider(provider, driver.listener_delete, id)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @pecan.expose()"},{"line_number":371,"context_line":"    def _lookup(self, id, *remainder):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_2c2ebefa","line":368,"updated":"2018-05-14 18:44:57.000000000","message":"I think we want `provider` to actually be `driver.name`","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"00883dcdeac243ed3a512783e198face68f68527","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                id\u003did, listener_status\u003dconstants.PENDING_DELETE)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            LOG.info(\"Sending delete Listener %s to provider %s\", id, provider)"},{"line_number":368,"context_line":"            driver_utils.call_provider(provider, driver.listener_delete, id)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @pecan.expose()"},{"line_number":371,"context_line":"    def _lookup(self, id, *remainder):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_aec94226","line":368,"in_reply_to":"5f7c97a3_2c2ebefa","updated":"2018-05-15 23:14:13.000000000","message":"Done","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"}],"specs/version1.1/enable-provider-driver.rst":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4c1e8b544dac4a72253e6bf1ea9d220e8ede6db4","unresolved":false,"context_lines":[{"line_number":409,"context_line":"  +---------------+--------+------------------------------------------------+"},{"line_number":410,"context_line":"  | intermediates | List   | A list of intermediate PEM certificates.       |"},{"line_number":411,"context_line":"  +---------------+--------+------------------------------------------------+"},{"line_number":412,"context_line":"  | passphrase    | string | The private_key passphrase.                    |"},{"line_number":413,"context_line":"  +---------------+--------+------------------------------------------------+"},{"line_number":414,"context_line":"  | primary_cn    | string | The primary common name of the certificate.    |"},{"line_number":415,"context_line":"  +---------------+--------+------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f7c97a3_4c68da1b","line":412,"updated":"2018-05-14 18:44:57.000000000","message":"Do we need to pass this through? I think by the time we have the certificate data, our cert reading code has already decrypted the data (and would most vendor appliances be able to handle this)? At least, we should check to make sure.","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"00883dcdeac243ed3a512783e198face68f68527","unresolved":false,"context_lines":[{"line_number":409,"context_line":"  +---------------+--------+------------------------------------------------+"},{"line_number":410,"context_line":"  | intermediates | List   | A list of intermediate PEM certificates.       |"},{"line_number":411,"context_line":"  +---------------+--------+------------------------------------------------+"},{"line_number":412,"context_line":"  | passphrase    | string | The private_key passphrase.                    |"},{"line_number":413,"context_line":"  +---------------+--------+------------------------------------------------+"},{"line_number":414,"context_line":"  | primary_cn    | string | The primary common name of the certificate.    |"},{"line_number":415,"context_line":"  +---------------+--------+------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f7c97a3_ae8ce235","line":412,"in_reply_to":"5f7c97a3_4c68da1b","updated":"2018-05-15 23:14:13.000000000","message":"Yeah, this was a mistake on my part, the data handed back does not contain this and the key is already decrypted.","commit_id":"388af3197676304d07c6bf13c9f9937ffc859d61"}]}
