)]}'
{"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8eafe9f7a61f532fd1ef590ec68777f0a5958b4a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            log_device \u003d None"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            # Send logs to /dev/null so there isn\u0027t any logging"},{"line_number":61,"context_line":"            log_device \u003d NULL_DEVICE"},{"line_number":62,"context_line":"        self.jinja \u003d jinja_cfg.JinjaTemplater("},{"line_number":63,"context_line":"            base_amp_path\u003dCONF.haproxy_amphora.base_path,"},{"line_number":64,"context_line":"            base_crt_dir\u003dCONF.haproxy_amphora.base_cert_dir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_971af17a","line":61,"updated":"2018-05-08 18:22:43.000000000","message":"This will still incur a performance penalty. Instead we should just set the following in the HAProxy config:\ndefaults\n\"log global\" -\u003e \"no log\"","commit_id":"8aa3e576aecb2796fa881495ef58f13b23ed8673"}],"octavia/common/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8eafe9f7a61f532fd1ef590ec68777f0a5958b4a","unresolved":false,"context_lines":[{"line_number":217,"context_line":"               default\u003d\u0027/var/lib/octavia/certs\u0027,"},{"line_number":218,"context_line":"               help\u003d_(\u0027Base directory for cert storage.\u0027)),"},{"line_number":219,"context_line":"    cfg.StrOpt(\u0027haproxy_template\u0027, help\u003d_(\u0027Custom haproxy template.\u0027)),"},{"line_number":220,"context_line":"    cfg.BoolOpt(\u0027log_haproxy\u0027, default\u003dTrue,"},{"line_number":221,"context_line":"                help\u003d_(\"If False, write logs to /dev/null\")),"},{"line_number":222,"context_line":"    cfg.IntOpt(\u0027connection_max_retries\u0027,"},{"line_number":223,"context_line":"               default\u003d300,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d7ab891a","line":220,"range":{"start_line":220,"start_character":17,"end_line":220,"end_character":28},"updated":"2018-05-08 18:22:43.000000000","message":"Can we make this more clear?\n\"connection_logging\"?","commit_id":"8aa3e576aecb2796fa881495ef58f13b23ed8673"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"72dc8b61fcbc4ea0e6f4a55f271d2c1289ec1c46","unresolved":false,"context_lines":[{"line_number":218,"context_line":"               help\u003d_(\u0027Base directory for cert storage.\u0027)),"},{"line_number":219,"context_line":"    cfg.StrOpt(\u0027haproxy_template\u0027, help\u003d_(\u0027Custom haproxy template.\u0027)),"},{"line_number":220,"context_line":"    cfg.BoolOpt(\u0027connection_logging\u0027, default\u003dTrue,"},{"line_number":221,"context_line":"                help\u003d_(\u0027Set this to False to disable connection logging.\u0027)),"},{"line_number":222,"context_line":"    cfg.IntOpt(\u0027connection_max_retries\u0027,"},{"line_number":223,"context_line":"               default\u003d300,"},{"line_number":224,"context_line":"               help\u003d_(\u0027Retry threshold for connecting to amphorae.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9229e4f3","line":221,"range":{"start_line":221,"start_character":53,"end_line":221,"end_character":71},"updated":"2018-05-17 15:07:59.000000000","message":"This help message also add the haproxy connection logging, it gonna be better, I think. :)","commit_id":"b4a2a6dd784318f29f19df16a4f0736f5e289537"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"02e499d63952edd9ea38e5b441330dde273efda0","unresolved":false,"context_lines":[{"line_number":218,"context_line":"               help\u003d_(\u0027Base directory for cert storage.\u0027)),"},{"line_number":219,"context_line":"    cfg.StrOpt(\u0027haproxy_template\u0027, help\u003d_(\u0027Custom haproxy template.\u0027)),"},{"line_number":220,"context_line":"    cfg.BoolOpt(\u0027connection_logging\u0027, default\u003dTrue,"},{"line_number":221,"context_line":"                help\u003d_(\u0027Set this to False to disable connection logging.\u0027)),"},{"line_number":222,"context_line":"    cfg.IntOpt(\u0027connection_max_retries\u0027,"},{"line_number":223,"context_line":"               default\u003d300,"},{"line_number":224,"context_line":"               help\u003d_(\u0027Retry threshold for connecting to amphorae.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_fe753acd","line":221,"range":{"start_line":221,"start_character":53,"end_line":221,"end_character":71},"in_reply_to":"5f7c97a3_9229e4f3","updated":"2018-05-22 17:17:19.000000000","message":"changed into positive","commit_id":"b4a2a6dd784318f29f19df16a4f0736f5e289537"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7d3032cdc725294d8b5262c33cc50b1794263962","unresolved":false,"context_lines":[{"line_number":218,"context_line":"               help\u003d_(\u0027Base directory for cert storage.\u0027)),"},{"line_number":219,"context_line":"    cfg.StrOpt(\u0027haproxy_template\u0027, help\u003d_(\u0027Custom haproxy template.\u0027)),"},{"line_number":220,"context_line":"    cfg.BoolOpt(\u0027connection_logging\u0027, default\u003dTrue,"},{"line_number":221,"context_line":"                help\u003d_(\u0027Set this to True to enable connection logging.\u0027)),"},{"line_number":222,"context_line":"    cfg.IntOpt(\u0027connection_max_retries\u0027,"},{"line_number":223,"context_line":"               default\u003d300,"},{"line_number":224,"context_line":"               help\u003d_(\u0027Retry threshold for connecting to amphorae.\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_3b823fc9","line":221,"updated":"2018-07-10 22:28:36.000000000","message":"If the default is True, maybe this should read \"set this to False\". Also, it\u0027s nice to note the default in the help string","commit_id":"691ebd8c37fdc68fd177532c1253075caa78be61"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"d879a3ccc51a42dd084c8cf6392eb43d17cc3487","unresolved":false,"context_lines":[{"line_number":218,"context_line":"               help\u003d_(\u0027Base directory for cert storage.\u0027)),"},{"line_number":219,"context_line":"    cfg.StrOpt(\u0027haproxy_template\u0027, help\u003d_(\u0027Custom haproxy template.\u0027)),"},{"line_number":220,"context_line":"    cfg.BoolOpt(\u0027connection_logging\u0027, default\u003dTrue,"},{"line_number":221,"context_line":"                help\u003d_(\u0027Set this to True to enable connection logging.\u0027)),"},{"line_number":222,"context_line":"    cfg.IntOpt(\u0027connection_max_retries\u0027,"},{"line_number":223,"context_line":"               default\u003d300,"},{"line_number":224,"context_line":"               help\u003d_(\u0027Retry threshold for connecting to amphorae.\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_dbd46bbf","line":221,"in_reply_to":"5f7c97a3_3b823fc9","updated":"2018-07-10 22:39:23.000000000","message":"+1","commit_id":"691ebd8c37fdc68fd177532c1253075caa78be61"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9bbe3265a3371bcfd4409470e7b28d92fc0d2c4d","unresolved":false,"context_lines":[{"line_number":218,"context_line":"               help\u003d_(\u0027Base directory for cert storage.\u0027)),"},{"line_number":219,"context_line":"    cfg.StrOpt(\u0027haproxy_template\u0027, help\u003d_(\u0027Custom haproxy template.\u0027)),"},{"line_number":220,"context_line":"    cfg.BoolOpt(\u0027connection_logging\u0027, default\u003dTrue,"},{"line_number":221,"context_line":"                help\u003d_(\u0027Set this to True to enable connection logging.\u0027)),"},{"line_number":222,"context_line":"    cfg.IntOpt(\u0027connection_max_retries\u0027,"},{"line_number":223,"context_line":"               default\u003d300,"},{"line_number":224,"context_line":"               help\u003d_(\u0027Retry threshold for connecting to amphorae.\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_fba84722","line":221,"in_reply_to":"5f7c97a3_3b823fc9","updated":"2018-07-10 22:44:06.000000000","message":"Done","commit_id":"691ebd8c37fdc68fd177532c1253075caa78be61"}],"octavia/common/jinja/haproxy/jinja_cfg.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"bf0966c441652896b0d5830842fa0c23172c3ce3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        :param haproxy_template: Absolute path to Jinja template"},{"line_number":68,"context_line":"        :param log_http: Haproxy HTTP logging path"},{"line_number":69,"context_line":"        :param log_server: Haproxy Server logging path"},{"line_number":70,"context_line":"        :param connection_logging: disable logging connections in haproxy"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self.base_amp_path \u003d base_amp_path or BASE_PATH"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_247c5c71","line":70,"updated":"2018-05-16 22:51:05.000000000","message":"nit: That\u0027s a weird description -- it\u0027s in the negative, but actually this variable is positive.\n\n\"Enable HAProxy connection logging\"","commit_id":"b4a2a6dd784318f29f19df16a4f0736f5e289537"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"72dc8b61fcbc4ea0e6f4a55f271d2c1289ec1c46","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        :param haproxy_template: Absolute path to Jinja template"},{"line_number":68,"context_line":"        :param log_http: Haproxy HTTP logging path"},{"line_number":69,"context_line":"        :param log_server: Haproxy Server logging path"},{"line_number":70,"context_line":"        :param connection_logging: disable logging connections in haproxy"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self.base_amp_path \u003d base_amp_path or BASE_PATH"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_7203e874","line":70,"in_reply_to":"5f7c97a3_247c5c71","updated":"2018-05-17 15:07:59.000000000","message":"+1","commit_id":"b4a2a6dd784318f29f19df16a4f0736f5e289537"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"02e499d63952edd9ea38e5b441330dde273efda0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        :param haproxy_template: Absolute path to Jinja template"},{"line_number":68,"context_line":"        :param log_http: Haproxy HTTP logging path"},{"line_number":69,"context_line":"        :param log_server: Haproxy Server logging path"},{"line_number":70,"context_line":"        :param connection_logging: disable logging connections in haproxy"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self.base_amp_path \u003d base_amp_path or BASE_PATH"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_3e45f270","line":70,"in_reply_to":"5f7c97a3_247c5c71","updated":"2018-05-22 17:17:19.000000000","message":"Done","commit_id":"b4a2a6dd784318f29f19df16a4f0736f5e289537"}],"releasenotes/notes/disable_logging-3b50f388ee2b8127.yaml":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"bf0966c441652896b0d5830842fa0c23172c3ce3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new flag `connection_logging` will disable logging of connection data"},{"line_number":5,"context_line":"    if set to False which can improve performance of the laod balancer and"},{"line_number":6,"context_line":"    might aid compliance."},{"line_number":7,"context_line":"security:"},{"line_number":8,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_e495048a","line":5,"updated":"2018-05-16 22:51:05.000000000","message":"nit: laod balancer","commit_id":"b4a2a6dd784318f29f19df16a4f0736f5e289537"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"d879a3ccc51a42dd084c8cf6392eb43d17cc3487","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new flag `connection_logging` will disable logging of connection data"},{"line_number":5,"context_line":"    if set to False which can improve performance of the laod balancer and"},{"line_number":6,"context_line":"    might aid compliance."},{"line_number":7,"context_line":"security:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_db66ab57","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":36},"updated":"2018-07-10 22:39:23.000000000","message":"nit: [haproxy_amphora]/connection_logging\n\nAlso, s/flag/option/ ?","commit_id":"691ebd8c37fdc68fd177532c1253075caa78be61"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9bbe3265a3371bcfd4409470e7b28d92fc0d2c4d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new flag `connection_logging` will disable logging of connection data"},{"line_number":5,"context_line":"    if set to False which can improve performance of the laod balancer and"},{"line_number":6,"context_line":"    might aid compliance."},{"line_number":7,"context_line":"security:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_de0c593c","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":36},"in_reply_to":"5f7c97a3_db66ab57","updated":"2018-07-10 22:44:06.000000000","message":"Done","commit_id":"691ebd8c37fdc68fd177532c1253075caa78be61"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"f7d6aa2ae0f7c0b17b399cdec4a854421505605e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new flag `connection_logging` will disable logging of connection data"},{"line_number":5,"context_line":"    if set to False which can improve performance of the laod balancer and"},{"line_number":6,"context_line":"    might aid compliance."},{"line_number":7,"context_line":"security:"},{"line_number":8,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_ae40cb07","line":5,"range":{"start_line":5,"start_character":57,"end_line":5,"end_character":61},"updated":"2018-06-21 02:01:26.000000000","message":"nit: loadbalancer","commit_id":"691ebd8c37fdc68fd177532c1253075caa78be61"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9bbe3265a3371bcfd4409470e7b28d92fc0d2c4d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new flag `connection_logging` will disable logging of connection data"},{"line_number":5,"context_line":"    if set to False which can improve performance of the laod balancer and"},{"line_number":6,"context_line":"    might aid compliance."},{"line_number":7,"context_line":"security:"},{"line_number":8,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_3b6c7f06","line":5,"range":{"start_line":5,"start_character":57,"end_line":5,"end_character":61},"in_reply_to":"5f7c97a3_ae40cb07","updated":"2018-07-10 22:44:06.000000000","message":"Done","commit_id":"691ebd8c37fdc68fd177532c1253075caa78be61"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"d879a3ccc51a42dd084c8cf6392eb43d17cc3487","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    personal data and might need to follow specific data retention policies."},{"line_number":16,"context_line":"    Disabling connection logging might aid in making Octavia compliant by"},{"line_number":17,"context_line":"    preventing the output of such data. As always, consult with an expert"},{"line_number":18,"context_line":"    on compiance prior to making changes."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_3b0d5f8f","line":18,"range":{"start_line":18,"start_character":7,"end_line":18,"end_character":16},"updated":"2018-07-10 22:39:23.000000000","message":"nit: compliance","commit_id":"691ebd8c37fdc68fd177532c1253075caa78be61"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9bbe3265a3371bcfd4409470e7b28d92fc0d2c4d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    personal data and might need to follow specific data retention policies."},{"line_number":16,"context_line":"    Disabling connection logging might aid in making Octavia compliant by"},{"line_number":17,"context_line":"    preventing the output of such data. As always, consult with an expert"},{"line_number":18,"context_line":"    on compiance prior to making changes."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_be139d59","line":18,"range":{"start_line":18,"start_character":7,"end_line":18,"end_character":16},"in_reply_to":"5f7c97a3_3b0d5f8f","updated":"2018-07-10 22:44:06.000000000","message":"Done","commit_id":"691ebd8c37fdc68fd177532c1253075caa78be61"}]}