)]}'
{"octavia/api/v2/controllers/health_monitor.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"602baf8ce1f7949195f1581e72d8ee2d12f98321","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            db_hm \u003d self._validate_create_hm(lock_session, hm_dict)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"            # Prepare the data for the driver data model"},{"line_number":173,"context_line":"            provider_healthmon \u003d (driver_utils.db_HM_to_provider_HM(db_hm))"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"            # Dispatch to the driver"},{"line_number":176,"context_line":"            LOG.info(\"Sending create Health Monitor %s to provider %s\","}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_bd339113","line":173,"updated":"2018-06-04 19:54:02.000000000","message":"What\u0027s with the extra parens? how is this not a linter error?\nCan you get this in the cleanup patch if you didn\u0027t already?","commit_id":"ef7a56d2586beb9f416710cfb7b1387d4b51d6e9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"602baf8ce1f7949195f1581e72d8ee2d12f98321","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            LOG.info(\"Sending delete Health Monitor %s to provider %s\","},{"line_number":276,"context_line":"                     id, driver.name)"},{"line_number":277,"context_line":"            driver_utils.call_provider("},{"line_number":278,"context_line":"                driver.name, driver.health_monitor_delete, id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_780bc723","line":278,"updated":"2018-06-04 19:54:02.000000000","message":"So I assume this is what is changed with the delete-object-spec thing? It looks like right now the DRIVER would have to actually mark this deleted, which is impossible, and doesn\u0027t match the pattern used elsewhere... Will also take a look in the cleanup and see if this is dealt with, but I assume it\u0027s the delete-change.","commit_id":"ef7a56d2586beb9f416710cfb7b1387d4b51d6e9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"cac68d1c1cd3852cd2b8206e76cfe7b88aeaf283","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            LOG.info(\"Sending delete Health Monitor %s to provider %s\","},{"line_number":276,"context_line":"                     id, driver.name)"},{"line_number":277,"context_line":"            driver_utils.call_provider("},{"line_number":278,"context_line":"                driver.name, driver.health_monitor_delete, id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_3871cfdf","line":278,"in_reply_to":"5f7c97a3_780bc723","updated":"2018-06-04 20:46:02.000000000","message":"Oh, right, they WOULD be able to set this after by using the status update API thing. Got it.\nBut, can it no longer go to ERROR now, if the provider call fails? I guess maybe this is what we want? It would just roll back to ACTIVE the way this is set up, I think, as it would raise out of the session, causing it to roll back, right?","commit_id":"ef7a56d2586beb9f416710cfb7b1387d4b51d6e9"}]}
