)]}'
{"octavia/controller/healthmanager/health_drivers/update_db.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ae1bd541fff3222bb216211c4d03f1a4642a9714","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                member_db_status \u003d db_member.operating_status"},{"line_number":266,"context_line":"                member_id \u003d db_member.id"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"                if member_db_status \u003d\u003d constants.NO_MONITOR:"},{"line_number":269,"context_line":"                    pass  # This really isn\u0027t deserving of a log message"},{"line_number":270,"context_line":"                elif member_id not in members:"},{"line_number":271,"context_line":"                    member_status \u003d constants.OFFLINE"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bb2258a3","line":268,"updated":"2018-05-09 21:01:57.000000000","message":"I don\u0027t like overriding the observed status. What if an operator changed the templates to always have a monitor?\nWhy can\u0027t this just be a part of the case where no health was reported for the member?","commit_id":"af3377a0670e8b2df61d7d9ca1fa231e053aacb4"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"6986b2e86f423435bf8057b7128cd3e4608ae8fc","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                member_db_status \u003d db_member.operating_status"},{"line_number":266,"context_line":"                member_id \u003d db_member.id"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"                if member_db_status \u003d\u003d constants.NO_MONITOR:"},{"line_number":269,"context_line":"                    pass  # This really isn\u0027t deserving of a log message"},{"line_number":270,"context_line":"                elif member_id not in members:"},{"line_number":271,"context_line":"                    member_status \u003d constants.OFFLINE"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_db12b409","line":268,"in_reply_to":"5f7c97a3_bb2258a3","updated":"2018-05-09 21:14:25.000000000","message":"What would we check on? We don\u0027t want to blindly skip updates when members are missing, I think... It\u0027s probably GOOD for members to be OFFLINE if they\u0027re missing, and it would otherwise be possible for them to switch statuses... No?","commit_id":"af3377a0670e8b2df61d7d9ca1fa231e053aacb4"}]}
