)]}'
{"octavia/amphorae/backends/health_daemon/status_message.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"48b0a84fa785d8dca0e28799038c579b8bfb9a11","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    return envelope"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_package_data(envelope, key):"},{"line_number":57,"context_line":"    \"\"\"A backward-compatible way to get data."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    We may still receive package from amphorae that are using digest() instead"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ea1e660a","line":56,"updated":"2018-05-30 23:55:04.000000000","message":"Might be less impact on other code to call this method unwrap_envelope and rename the old one.","commit_id":"8879eb17b6a81a68c31bcbbb1396f6d68c480df6"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"6359b8b76de4579f168bfd8425d88ef8cd489375","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    return envelope"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_package_data(envelope, key):"},{"line_number":57,"context_line":"    \"\"\"A backward-compatible way to get data."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    We may still receive package from amphorae that are using digest() instead"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_aae94ee3","line":56,"in_reply_to":"5f7c97a3_ea1e660a","updated":"2018-05-30 23:57:34.000000000","message":"Yeah, good suggestion","commit_id":"8879eb17b6a81a68c31bcbbb1396f6d68c480df6"}],"octavia/tests/unit/amphorae/backends/health_daemon/test_health_sender.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e2fdeeac3bc8d5991032a146129befd74f9bae55","unresolved":false,"context_lines":[{"line_number":28,"context_line":"KEY \u003d \u0027TEST\u0027"},{"line_number":29,"context_line":"PORT \u003d random.randrange(1, 9000)"},{"line_number":30,"context_line":"SAMPLE_MSG \u003d {\u0027testkey\u0027: \u0027TEST\u0027}"},{"line_number":31,"context_line":"SAMPLE_MSG_BIN \u003d binascii.unhexlify(\u002778daab562a492d2ec94ead54b252500a710d0e51a\u0027"},{"line_number":32,"context_line":"                                    \u0027a050041b506243538303665356331393731653739\u0027"},{"line_number":33,"context_line":"                                    \u002739353138313833393465613665373161643938396\u0027"},{"line_number":34,"context_line":"                                    \u002766639353039343566393537336634616236663833\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_bf1e4e6d","line":31,"updated":"2018-06-01 15:37:53.000000000","message":"Couldn\u0027t we keep the old message bin and use that to validate that the old message format is still being handled?","commit_id":"fdc96d9d9e334c501c1a6b168cacd8e4ca2702a4"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"ade0a94963da5de21802aa652005a45b2ec552e2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"KEY \u003d \u0027TEST\u0027"},{"line_number":29,"context_line":"PORT \u003d random.randrange(1, 9000)"},{"line_number":30,"context_line":"SAMPLE_MSG \u003d {\u0027testkey\u0027: \u0027TEST\u0027}"},{"line_number":31,"context_line":"SAMPLE_MSG_BIN \u003d binascii.unhexlify(\u002778daab562a492d2ec94ead54b252500a710d0e51a\u0027"},{"line_number":32,"context_line":"                                    \u0027a050041b506243538303665356331393731653739\u0027"},{"line_number":33,"context_line":"                                    \u002739353138313833393465613665373161643938396\u0027"},{"line_number":34,"context_line":"                                    \u002766639353039343566393537336634616236663833\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_2e38c9eb","line":31,"in_reply_to":"5f7c97a3_bf1e4e6d","updated":"2018-06-01 21:11:59.000000000","message":"The following test class is testing \u0027sender.dosend\u0027 which invokes \u0027status_message.wrap_envelope\u0027, it\u0027s not for receiving the package. The backward compatibility test locates in https://review.openstack.org/#/c/571333/9/octavia/tests/unit/amphorae/backends/health_daemon/test_envelope.py","commit_id":"fdc96d9d9e334c501c1a6b168cacd8e4ca2702a4"}]}