)]}'
{"octavia/amphorae/backends/agent/api_server/amphora_info.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d561c38ba048508c9fddbf67afb39138836aa01d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":"import webob"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import netifaces"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from octavia.amphorae.backends.agent import api_server"},{"line_number":28,"context_line":"from octavia.amphorae.backends.agent.api_server import util"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_37cb87a4","line":25,"updated":"2018-06-22 20:58:08.000000000","message":"Is this right? That makes the octavia imports be the 4th block?","commit_id":"51ffe706c7504370c16673b2958f6d6693bc418d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"79d664ea787389917c0e37613ee66b72a791841b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":"import webob"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import netifaces"},{"line_number":26,"context_line":"from octavia.amphorae.backends.agent import api_server"},{"line_number":27,"context_line":"from octavia.amphorae.backends.agent.api_server import util"},{"line_number":28,"context_line":"from octavia.common import constants as consts"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_980d0c37","line":25,"range":{"start_line":25,"start_character":7,"end_line":25,"end_character":16},"updated":"2018-07-04 11:50:38.000000000","message":"Why was this moved?","commit_id":"0322cbc5c38838648253827610d44e71162978e5"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"c3d18ca1741bc99f75d6e4d8f8771235c5fd69fb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":"import webob"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import netifaces"},{"line_number":26,"context_line":"from octavia.amphorae.backends.agent import api_server"},{"line_number":27,"context_line":"from octavia.amphorae.backends.agent.api_server import util"},{"line_number":28,"context_line":"from octavia.common import constants as consts"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_b81471eb","line":25,"range":{"start_line":25,"start_character":7,"end_line":25,"end_character":16},"in_reply_to":"5f7c97a3_980d0c37","updated":"2018-07-05 14:12:23.000000000","message":"There was an error in pylint, so this can\u0027t be placed on the first and second block.\n\nAnd adam does not want a fourth block, so it ends up here.","commit_id":"0322cbc5c38838648253827610d44e71162978e5"}],"octavia/amphorae/backends/agent/api_server/plug.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d561c38ba048508c9fddbf67afb39138836aa01d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import webob"},{"line_number":28,"context_line":"from werkzeug import exceptions"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import netifaces"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from octavia.common import constants as consts"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_97b93b17","line":30,"updated":"2018-06-22 20:58:08.000000000","message":"Again, not sure I understand making this a third block?","commit_id":"51ffe706c7504370c16673b2958f6d6693bc418d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"79d664ea787389917c0e37613ee66b72a791841b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import webob"},{"line_number":28,"context_line":"from werkzeug import exceptions"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import netifaces"},{"line_number":31,"context_line":"from octavia.common import constants as consts"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_d8a384fe","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":16},"updated":"2018-07-04 11:50:38.000000000","message":"same question, why was this moved here?","commit_id":"0322cbc5c38838648253827610d44e71162978e5"}],"octavia/amphorae/drivers/haproxy/data_models.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d561c38ba048508c9fddbf67afb39138836aa01d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                 active\u003dNone, haproxy_count\u003dNone, cpu\u003dNone, memory\u003dNone,"},{"line_number":45,"context_line":"                 disk\u003dNone, load\u003dNone, listeners\u003dNone, packages\u003dNone):"},{"line_number":46,"context_line":"        self.hostname \u003d hostname"},{"line_number":47,"context_line":"        self.uuid \u003d uuid"},{"line_number":48,"context_line":"        self.version \u003d version"},{"line_number":49,"context_line":"        self.api_version \u003d api_version"},{"line_number":50,"context_line":"        self.network_tx \u003d network_tx"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_d748132f","line":47,"updated":"2018-06-22 20:58:08.000000000","message":"!!! how did this work -- this would have been a tuple?","commit_id":"51ffe706c7504370c16673b2958f6d6693bc418d"}],"octavia/api/handlers/controller_simulator/handler.py":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"c3d18ca1741bc99f75d6e4d8f8771235c5fd69fb","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \"\"\""},{"line_number":49,"context_line":"    repo \u003d repos.Repositories()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def member_controller(member, delete\u003dFalse, update\u003dFalse, create\u003dFalse,"},{"line_number":52,"context_line":"                          batch_update\u003dFalse):"},{"line_number":53,"context_line":"        time.sleep(ASYNC_TIME)"},{"line_number":54,"context_line":"        LOG.info(\"Simulating controller operation for member...\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_58dbdd4c","line":51,"range":{"start_line":51,"start_character":26,"end_line":51,"end_character":32},"updated":"2018-07-05 14:12:23.000000000","message":"member was defined here","commit_id":"0322cbc5c38838648253827610d44e71162978e5"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"79d664ea787389917c0e37613ee66b72a791841b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                               operating_status\u003dconstants.ONLINE)"},{"line_number":68,"context_line":"        elif batch_update:"},{"line_number":69,"context_line":"            members \u003d member"},{"line_number":70,"context_line":"            for m in members:"},{"line_number":71,"context_line":"                repo.member.update(db_api.get_session(), m.id,"},{"line_number":72,"context_line":"                                   operating_status\u003dconstants.ONLINE)"},{"line_number":73,"context_line":"        listeners \u003d []"},{"line_number":74,"context_line":"        if db_mem:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_3842b8ad","line":71,"range":{"start_line":70,"start_character":12,"end_line":71,"end_character":62},"updated":"2018-07-04 11:50:38.000000000","message":"why should we change \u0027memeber\u0027 to \u0027m\u0027 here?","commit_id":"0322cbc5c38838648253827610d44e71162978e5"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"c3d18ca1741bc99f75d6e4d8f8771235c5fd69fb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                               operating_status\u003dconstants.ONLINE)"},{"line_number":68,"context_line":"        elif batch_update:"},{"line_number":69,"context_line":"            members \u003d member"},{"line_number":70,"context_line":"            for m in members:"},{"line_number":71,"context_line":"                repo.member.update(db_api.get_session(), m.id,"},{"line_number":72,"context_line":"                                   operating_status\u003dconstants.ONLINE)"},{"line_number":73,"context_line":"        listeners \u003d []"},{"line_number":74,"context_line":"        if db_mem:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_78b9f9e9","line":71,"range":{"start_line":70,"start_character":12,"end_line":71,"end_character":62},"in_reply_to":"5f7c97a3_3842b8ad","updated":"2018-07-05 14:12:23.000000000","message":"Member was defined in the same function which generates some pylint errors.","commit_id":"0322cbc5c38838648253827610d44e71162978e5"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"19923e11fcfc709c5a1f8971a4b1f9ab8ff8fc50","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                               operating_status\u003dconstants.ONLINE)"},{"line_number":68,"context_line":"        elif batch_update:"},{"line_number":69,"context_line":"            members \u003d member"},{"line_number":70,"context_line":"            for m in members:"},{"line_number":71,"context_line":"                repo.member.update(db_api.get_session(), m.id,"},{"line_number":72,"context_line":"                                   operating_status\u003dconstants.ONLINE)"},{"line_number":73,"context_line":"        listeners \u003d []"},{"line_number":74,"context_line":"        if db_mem:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_1ce0f0ca","line":71,"range":{"start_line":70,"start_character":12,"end_line":71,"end_character":62},"in_reply_to":"5f7c97a3_78b9f9e9","updated":"2018-07-05 21:29:19.000000000","message":"ack","commit_id":"0322cbc5c38838648253827610d44e71162978e5"}],"octavia/common/keystone.py":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"79d664ea787389917c0e37613ee66b72a791841b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":16,"context_line":"from keystonemiddleware import auth_token"},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from octavia.common import constants"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_f8b520d1","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":35},"updated":"2018-07-04 11:50:38.000000000","message":"shouldn\u0027t these two be a single block?","commit_id":"0322cbc5c38838648253827610d44e71162978e5"}],"octavia/controller/worker/tasks/network_tasks.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d561c38ba048508c9fddbf67afb39138836aa01d","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if not delta:"},{"line_number":147,"context_line":"            LOG.debug(\"No network deltas for amphora id: %s\", amphora.id)"},{"line_number":148,"context_line":"            return"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # add nics"},{"line_number":151,"context_line":"        for nic in delta.add_nics:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_f7e18ffd","line":148,"updated":"2018-06-22 20:58:08.000000000","message":"It seemed like a bunch of other files got \"return None\" added, and here we already had that but it needs to be just \"return\"? Weird?","commit_id":"51ffe706c7504370c16673b2958f6d6693bc418d"}],"octavia/db/repositories.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d561c38ba048508c9fddbf67afb39138836aa01d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        model \u003d model.first()"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if not model:"},{"line_number":117,"context_line":"            return None"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        return model.to_data_model()"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_b7e7970f","line":117,"updated":"2018-06-22 20:58:08.000000000","message":"And here we flipped from the existing \"return\" to \"return None\"... The opposite of the last file...","commit_id":"51ffe706c7504370c16673b2958f6d6693bc418d"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d561c38ba048508c9fddbf67afb39138836aa01d","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                    self.session_persistence.create(session, **sp_dict)"},{"line_number":247,"context_line":"            # If only the session_persistence is being updated, this will be"},{"line_number":248,"context_line":"            # empty"},{"line_number":249,"context_line":"            if pool_dict.keys():"},{"line_number":250,"context_line":"                self.pool.update(session, pool_id, **pool_dict)"},{"line_number":251,"context_line":"        return self.pool.get(session, id\u003dpool_id)"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_77bfbfcf","line":249,"updated":"2018-06-22 20:58:08.000000000","message":"Is this necessary, or could we JUST do \"if pool_dict\"? does .keys() add anything?","commit_id":"51ffe706c7504370c16673b2958f6d6693bc418d"}]}