)]}'
{"octavia/controller/worker/controller_worker.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c0b71cb6b6223d73043262de50fef1395e247d8f","unresolved":false,"context_lines":[{"line_number":810,"context_line":"                # Note: this amp may not currently be the backup"},{"line_number":811,"context_line":"                # TODO(johnsom) Change this to query the amp state"},{"line_number":812,"context_line":"                #               once the amp API supports it."},{"line_number":813,"context_line":"                if amp.status !\u003d constants.AMPHORA_ALLOCATED:"},{"line_number":814,"context_line":"                    continue"},{"line_number":815,"context_line":"                if amp.role \u003d\u003d constants.ROLE_BACKUP:"},{"line_number":816,"context_line":"                    self._perform_amphora_failover("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5968d586","line":813,"updated":"2018-06-21 15:17:32.000000000","message":"This would stop failover from attempting to resolve ERROR amphora. I don\u0027t think we want to do that.\nMaybe you just want to exclude \"DELETED\"?","commit_id":"036df83d7ec06654ba6b535d63b3362ac29a2945"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c0b71cb6b6223d73043262de50fef1395e247d8f","unresolved":false,"context_lines":[{"line_number":817,"context_line":"                        amp, constants.LB_CREATE_ADMIN_FAILOVER_PRIORITY)"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"            for amp in amps:"},{"line_number":820,"context_line":"                if amp.status !\u003d constants.AMPHORA_ALLOCATED:"},{"line_number":821,"context_line":"                    continue"},{"line_number":822,"context_line":"                # failover everyhting else"},{"line_number":823,"context_line":"                if amp.role !\u003d constants.ROLE_BACKUP:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b9f489d0","line":820,"updated":"2018-06-21 15:17:32.000000000","message":"Same, this would stop failover from attempting to resolve ERROR amphora. I don\u0027t think we want to do that.\nMaybe you just want to exclude \"DELETED\"?","commit_id":"036df83d7ec06654ba6b535d63b3362ac29a2945"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"28d3443e56f7a110cb277c947eccc6478c6b4d91","unresolved":false,"context_lines":[{"line_number":812,"context_line":"                #               once the amp API supports it."},{"line_number":813,"context_line":"                if amp.status \u003d\u003d constants.AMPHORA_DELETED:"},{"line_number":814,"context_line":"                    continue"},{"line_number":815,"context_line":"                if amp.role \u003d\u003d constants.ROLE_BACKUP:"},{"line_number":816,"context_line":"                    self._perform_amphora_failover("},{"line_number":817,"context_line":"                        amp, constants.LB_CREATE_ADMIN_FAILOVER_PRIORITY)"},{"line_number":818,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9f65e8b1","line":815,"updated":"2018-06-21 21:15:34.000000000","message":"nit: I would just make it an `and amp.status !\u003d` here","commit_id":"95a4239fe456250afc34a4f0752dc4808efcd774"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"28d3443e56f7a110cb277c947eccc6478c6b4d91","unresolved":false,"context_lines":[{"line_number":820,"context_line":"                if amp.status \u003d\u003d constants.AMPHORA_DELETED:"},{"line_number":821,"context_line":"                    continue"},{"line_number":822,"context_line":"                # failover everyhting else"},{"line_number":823,"context_line":"                if amp.role !\u003d constants.ROLE_BACKUP:"},{"line_number":824,"context_line":"                    self._perform_amphora_failover("},{"line_number":825,"context_line":"                        amp, constants.LB_CREATE_ADMIN_FAILOVER_PRIORITY)"},{"line_number":826,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_bff784d4","line":823,"updated":"2018-06-21 21:15:34.000000000","message":"same","commit_id":"95a4239fe456250afc34a4f0752dc4808efcd774"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7f61090a1c7622ba1f1d5d6c1ab22e25afda7756","unresolved":false,"context_lines":[{"line_number":813,"context_line":"                if ("},{"line_number":814,"context_line":"                    amp.role \u003d\u003d constants.ROLE_BACKUP"},{"line_number":815,"context_line":"                    and"},{"line_number":816,"context_line":"                    amp.status !\u003d constants.AMPHORA_DELETED"},{"line_number":817,"context_line":"                ):"},{"line_number":818,"context_line":"                    self._perform_amphora_failover("},{"line_number":819,"context_line":"                        amp, constants.LB_CREATE_ADMIN_FAILOVER_PRIORITY)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_a602193d","line":816,"updated":"2018-06-22 04:18:44.000000000","message":"nit: We already have a \"DELETED\" constant that could be used.","commit_id":"0b70b1535ec656912433c8c6adaedc19233117c9"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"c541e412589ac51719b907d3b00b0c4b48842048","unresolved":false,"context_lines":[{"line_number":825,"context_line":""},{"line_number":826,"context_line":"            for amp in amps:"},{"line_number":827,"context_line":"                # failover everyhting else"},{"line_number":828,"context_line":"                if not self._can_amphora_failover(amp):"},{"line_number":829,"context_line":"                    self._perform_amphora_failover("},{"line_number":830,"context_line":"                        amp, constants.LB_CREATE_ADMIN_FAILOVER_PRIORITY)"},{"line_number":831,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_fd4e4d37","line":828,"range":{"start_line":828,"start_character":19,"end_line":828,"end_character":54},"updated":"2018-06-23 02:45:07.000000000","message":"This does not look right,\nnot (is_amphora_backup and amp.status !\u003d constants.DELETED)\n\nequals to\n\nnot is_amphora_backup or amp.status \u003d\u003d constants.DELETED\n\nSo when the amp.status is DELETED, it would be fail over here.\n\nIsn\u0027t this the error this pr trying to solve?","commit_id":"ff2df86a5cf56ae3101683286b354cb753dc787d"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"07809184037e349a4c5b0fda8648af74dc888cac","unresolved":false,"context_lines":[{"line_number":804,"context_line":"            lb \u003d self._lb_repo.get(db_apis.get_session(),"},{"line_number":805,"context_line":"                                   id\u003dload_balancer_id)"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"            amps \u003d lb.amphorae"},{"line_number":808,"context_line":"            for amp in amps:"},{"line_number":809,"context_line":"                # failover amphora in backup role"},{"line_number":810,"context_line":"                # Note: this amp may not currently be the backup"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_0f6c1405","line":807,"updated":"2018-06-25 17:00:11.000000000","message":"You could do:\n\namps \u003d [a for a in lb.amphorae if a.status !\u003d constants.DELETED]","commit_id":"910bc48f7ee9869c26b2dcd655bb247032762d63"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"5a4420b4751cd0047af5fe4950daea9b6015dc7c","unresolved":false,"context_lines":[{"line_number":810,"context_line":"                # Note: this amp may not currently be the backup"},{"line_number":811,"context_line":"                # TODO(johnsom) Change this to query the amp state"},{"line_number":812,"context_line":"                #               once the amp API supports it."},{"line_number":813,"context_line":"                if amp.status \u003d\u003d constants.DELETED:"},{"line_number":814,"context_line":"                    continue"},{"line_number":815,"context_line":"                if amp.role \u003d\u003d constants.ROLE_BACKUP:"},{"line_number":816,"context_line":"                    self._perform_amphora_failover("}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_2696f295","line":813,"updated":"2018-06-23 22:41:04.000000000","message":"Why not instead of the \u0027if\u0027 conditions, exclude deleted amps from being fetched from DB?\n\n    lb \u003d self._lb_repo.get(db_apis.get_session(),\n                           id\u003dload_balancer_id.\n                           show_deleted\u003dFalse)","commit_id":"910bc48f7ee9869c26b2dcd655bb247032762d63"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"062c4304a78e2ad5c559c81aaf82cc3828e7461c","unresolved":false,"context_lines":[{"line_number":804,"context_line":"            lb \u003d self._lb_repo.get(db_apis.get_session(),"},{"line_number":805,"context_line":"                                   id\u003dload_balancer_id)"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"            amps \u003d lb.amphorae"},{"line_number":808,"context_line":"            for amp in amps:"},{"line_number":809,"context_line":"                # failover amphora in backup role"},{"line_number":810,"context_line":"                # Note: this amp may not currently be the backup"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_0f45f46e","line":807,"updated":"2018-06-25 17:00:47.000000000","message":"You could do:\n\namps \u003d [a for a in lb.amphorae if a.status !\u003d constants.DELETED]","commit_id":"7dc737c6a1419b8c936f24291ef3b0ff223dba18"}]}