)]}'
{"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"3e0b8f0b1cd8388500ade4a1d9ccb0a8898a9042","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        return self.client.get_info(amphora)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_diagnostics(self, amphora):"},{"line_number":147,"context_line":"        pass"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def finalize_amphora(self, amphora):"},{"line_number":150,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b8f38c09","line":147,"updated":"2018-06-28 21:26:28.000000000","message":"any reason we get rid of diagnostics? Since I don\u0027t see it removed I. the driver...","commit_id":"f70fdca9d8521ef38582ef4f74fe4d0d8008ae18"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"880c31ca573f0accfeb7b9c67bb6626740c30bc8","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        return self.client.get_info(amphora)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_diagnostics(self, amphora):"},{"line_number":147,"context_line":"        pass"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def finalize_amphora(self, amphora):"},{"line_number":150,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ccd22f34","line":147,"in_reply_to":"5f7c97a3_b8f38c09","updated":"2018-06-29 20:28:36.000000000","message":"There is no implementation for this in this driver, this the call to self.driver.get_diagnostics is bogus and goes nowhere.","commit_id":"f70fdca9d8521ef38582ef4f74fe4d0d8008ae18"}],"octavia/tests/unit/controller/worker/tasks/test_amphora_driver_tasks.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"3e0b8f0b1cd8388500ade4a1d9ccb0a8898a9042","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        mock_driver.update_amphora_listeners.assert_called_once_with("},{"line_number":86,"context_line":"            [_listener_mock], 0, [_amphora_mock], timeout_dict)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        mock_driver.update_amphora_listeners.side_effect \u003d Exception(\u0027boom\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        amp_list_update_obj.execute([_listener_mock], 0,"},{"line_number":91,"context_line":"                                    [_amphora_mock], timeout_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d800c8b4","line":88,"updated":"2018-06-28 21:26:28.000000000","message":"didn\u0027t we need a test with a timeout exception?","commit_id":"f70fdca9d8521ef38582ef4f74fe4d0d8008ae18"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"880c31ca573f0accfeb7b9c67bb6626740c30bc8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        mock_driver.update_amphora_listeners.assert_called_once_with("},{"line_number":86,"context_line":"            [_listener_mock], 0, [_amphora_mock], timeout_dict)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        mock_driver.update_amphora_listeners.side_effect \u003d Exception(\u0027boom\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        amp_list_update_obj.execute([_listener_mock], 0,"},{"line_number":91,"context_line":"                                    [_amphora_mock], timeout_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2c7ac324","line":88,"in_reply_to":"5f7c97a3_d800c8b4","updated":"2018-06-29 20:28:36.000000000","message":"No, the  AmpListenersUpdate method catches all exceptions, timeout shouldn\u0027t be special here.","commit_id":"f70fdca9d8521ef38582ef4f74fe4d0d8008ae18"}],"releasenotes/notes/fix-multi-amp-down-failover-952618fb8d3d8ae6.yaml":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"3e0b8f0b1cd8388500ade4a1d9ccb0a8898a9042","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where if more than one amphora is failed at the same time,"},{"line_number":5,"context_line":"    failover may fail to fully complete leaving the load balancer in ERROR."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_18fe40af","line":4,"updated":"2018-06-28 21:26:28.000000000","message":"s/is failed/fails/","commit_id":"f70fdca9d8521ef38582ef4f74fe4d0d8008ae18"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"880c31ca573f0accfeb7b9c67bb6626740c30bc8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where if more than one amphora is failed at the same time,"},{"line_number":5,"context_line":"    failover may fail to fully complete leaving the load balancer in ERROR."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_acb493d5","line":4,"in_reply_to":"5f7c97a3_18fe40af","updated":"2018-06-29 20:28:36.000000000","message":"Done","commit_id":"f70fdca9d8521ef38582ef4f74fe4d0d8008ae18"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"3e0b8f0b1cd8388500ade4a1d9ccb0a8898a9042","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where if more than one amphora is failed at the same time,"},{"line_number":5,"context_line":"    failover may fail to fully complete leaving the load balancer in ERROR."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_b8286c33","line":5,"updated":"2018-06-28 21:26:28.000000000","message":"failover might not fully","commit_id":"f70fdca9d8521ef38582ef4f74fe4d0d8008ae18"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"880c31ca573f0accfeb7b9c67bb6626740c30bc8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where if more than one amphora is failed at the same time,"},{"line_number":5,"context_line":"    failover may fail to fully complete leaving the load balancer in ERROR."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_0ca4a7a2","line":5,"in_reply_to":"5f7c97a3_b8286c33","updated":"2018-06-29 20:28:36.000000000","message":"Done","commit_id":"f70fdca9d8521ef38582ef4f74fe4d0d8008ae18"}]}