)]}'
{"octavia/api/drivers/driver_lib.py":[{"author":{"_account_id":13438,"name":"Kobi Samoray","email":"kobi.samoray@broadcom.com","username":"ksamoray"},"change_message_id":"34aedcc22669258107a76401812c51c5488d41a1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    repo.delete(self.db_session, id\u003drecord_id)"},{"line_number":62,"context_line":"                    return"},{"line_number":63,"context_line":"                else:"},{"line_number":64,"context_line":"                    record_kwargs[consts.PROVISIONING_STATUS] \u003d prov_status"},{"line_number":65,"context_line":"            op_status \u003d record.get(consts.OPERATING_STATUS, None)"},{"line_number":66,"context_line":"            if op_status:"},{"line_number":67,"context_line":"                record_kwargs[consts.OPERATING_STATUS] \u003d op_status"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_182d97ad","line":64,"updated":"2018-07-16 14:16:21.000000000","message":"This shouldn\u0027t be in else - or otherwise LB objects will remain in PENDING_DELETE forever.","commit_id":"8324c0536f048b55e2f219d8dbe26712391ecf3d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"75dd71f7f142008dddf3fb6de4c3c2a4f7526496","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    repo.delete(self.db_session, id\u003drecord_id)"},{"line_number":62,"context_line":"                    return"},{"line_number":63,"context_line":"                else:"},{"line_number":64,"context_line":"                    record_kwargs[consts.PROVISIONING_STATUS] \u003d prov_status"},{"line_number":65,"context_line":"            op_status \u003d record.get(consts.OPERATING_STATUS, None)"},{"line_number":66,"context_line":"            if op_status:"},{"line_number":67,"context_line":"                record_kwargs[consts.OPERATING_STATUS] \u003d op_status"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_94c96225","line":64,"in_reply_to":"5f7c97a3_182d97ad","updated":"2018-07-17 03:40:17.000000000","message":"ARgh, yes, you are completely right.\nFixed.","commit_id":"8324c0536f048b55e2f219d8dbe26712391ecf3d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"8cfe4a704b621e97be7494eab4df8cfff154eb2b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.db_session \u003d db_apis.get_session()"},{"line_number":35,"context_line":"        super(DriverLibrary, self).__init__(**kwargs)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _check_for_lb_vip_deallocate(self, repo, lb_id):"},{"line_number":38,"context_line":"        lb \u003d repo.get(self.db_session, id\u003dlb_id)"},{"line_number":39,"context_line":"        if lb.vip.octavia_owned:"},{"line_number":40,"context_line":"            vip \u003d lb.vip"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a75cd04b","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":36},"updated":"2018-08-06 21:42:04.000000000","message":"This function could have benefited from a debug-only log print that elaborate why we didn\u0027t delete the VIP.","commit_id":"5785b9755e76dbf3a8ff58b6c91a5c65400685ec"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"effa90622de0b02144f6c474a715e6f0f6755d25","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if lb.vip.octavia_owned:"},{"line_number":40,"context_line":"            vip \u003d lb.vip"},{"line_number":41,"context_line":"            # We need a backreference"},{"line_number":42,"context_line":"            vip.load_balancer \u003d lb"},{"line_number":43,"context_line":"            # Only lookup the network driver if we have a VIP to deallocate"},{"line_number":44,"context_line":"            network_driver \u003d utils.get_network_driver()"},{"line_number":45,"context_line":"            network_driver.deallocate_vip(vip)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_b30b4a20","line":42,"updated":"2018-07-27 19:53:12.000000000","message":"Our models don\u0027t already have this?","commit_id":"5785b9755e76dbf3a8ff58b6c91a5c65400685ec"}]}