)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"33595bfb6293e37fe88ae10c7eefd5b657aaedee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tatsuma Matsuki \u003cmatsuki.tatsuma@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-07 16:15:48 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Separate the thread pool for health and stats update."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When queue_event_streamer driver is used and RabbitMQ"},{"line_number":10,"context_line":"is down, stats update processes occupy the thread pool"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_2da41757","line":7,"range":{"start_line":7,"start_character":52,"end_line":7,"end_character":53},"updated":"2018-08-07 12:05:21.000000000","message":"nit: not necessary","commit_id":"89186ad351f2e33dfd9cbfccf824226ff1f91848"}],"etc/octavia.conf":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"ae4716c31e9cdbe6add8f09d64ce54146fdee6de","unresolved":false,"context_lines":[{"line_number":71,"context_line":"# controller_ip_port_list example: 127.0.0.1:5555, 127.0.0.1:5555"},{"line_number":72,"context_line":"# controller_ip_port_list \u003d"},{"line_number":73,"context_line":"# failover_threads \u003d 10"},{"line_number":74,"context_line":"# health_update_threads will default to the number of processors on the host"},{"line_number":75,"context_line":"# health_update_threads \u003d"},{"line_number":76,"context_line":"# stats_update_threads will default to the number of processors on the host"},{"line_number":77,"context_line":"# stats_update_threads \u003d"},{"line_number":78,"context_line":"# heartbeat_interval \u003d 10"},{"line_number":79,"context_line":"# heartbeat_key \u003d"},{"line_number":80,"context_line":"# heartbeat_timeout \u003d 60"}],"source_content_type":"text/plain","patch_set":5,"id":"3f79a3b5_ce5b202c","line":77,"range":{"start_line":74,"start_character":0,"end_line":77,"end_character":24},"updated":"2018-08-07 08:31:59.000000000","message":"We need to mark status_update_threads as deprecated and support it for a bit longer.\n\nhttps://governance.openstack.org/tc/reference/tags/assert_follows-standard-deprecation.html","commit_id":"89186ad351f2e33dfd9cbfccf824226ff1f91848"}],"octavia/amphorae/drivers/health/heartbeat_udp.py":[{"author":{"_account_id":11884,"name":"Masaki Kanno","email":"kanno.masaki@jp.fujitsu.com","username":"Kanno"},"change_message_id":"18d7ff373ca19f4fab447c56a92c952b6f14f34f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.update(self.key, self.ip, self.port)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.health_executor \u003d futures.ProcessPoolExecutor("},{"line_number":67,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":68,"context_line":"        self.stats_executor \u003d futures.ProcessPoolExecutor("},{"line_number":69,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":70,"context_line":"        self.repo \u003d repositories.Repositories().amphorahealth"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9bc44f62","line":67,"updated":"2018-07-26 08:05:14.000000000","message":"I think that you should change the parameter name: status_update_threads to another name for health_executor.\ne.g. healt_update_threads","commit_id":"0a00b4eb921ae3545316988df12b43f69388935a"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"4b739aa7c6d8c48fa73be8c2f8434de909bf06c4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.update(self.key, self.ip, self.port)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.health_executor \u003d futures.ProcessPoolExecutor("},{"line_number":67,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":68,"context_line":"        self.stats_executor \u003d futures.ProcessPoolExecutor("},{"line_number":69,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":70,"context_line":"        self.repo \u003d repositories.Repositories().amphorahealth"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_0acf8628","line":67,"range":{"start_line":67,"start_character":24,"end_line":67,"end_character":32},"updated":"2018-07-26 10:04:08.000000000","message":"Regarding #28, should it be CONF?","commit_id":"0a00b4eb921ae3545316988df12b43f69388935a"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"4b739aa7c6d8c48fa73be8c2f8434de909bf06c4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.update(self.key, self.ip, self.port)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.health_executor \u003d futures.ProcessPoolExecutor("},{"line_number":67,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":68,"context_line":"        self.stats_executor \u003d futures.ProcessPoolExecutor("},{"line_number":69,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":70,"context_line":"        self.repo \u003d repositories.Repositories().amphorahealth"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_aaca126c","line":67,"in_reply_to":"5f7c97a3_9bc44f62","updated":"2018-07-26 10:04:08.000000000","message":"+1.  If you add new parameter for thread, it\u0027s better to add document, sample config and reno.  Because this parameter affects external specification.","commit_id":"0a00b4eb921ae3545316988df12b43f69388935a"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"ce03b8c13f60a9ea072d57082bf87b97915c3ebf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.update(self.key, self.ip, self.port)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.health_executor \u003d futures.ProcessPoolExecutor("},{"line_number":67,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":68,"context_line":"        self.stats_executor \u003d futures.ProcessPoolExecutor("},{"line_number":69,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":70,"context_line":"        self.repo \u003d repositories.Repositories().amphorahealth"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ab0bddd1","line":67,"in_reply_to":"5f7c97a3_aaca126c","updated":"2018-07-27 08:38:59.000000000","message":"+1. I would also prefer renaming status_update_threads to health_update_threads.","commit_id":"0a00b4eb921ae3545316988df12b43f69388935a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"933af6cfb9b8d02aea262a24259f5962ee0e222f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.health_executor \u003d futures.ProcessPoolExecutor("},{"line_number":67,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":68,"context_line":"        self.stats_executor \u003d futures.ProcessPoolExecutor("},{"line_number":69,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":70,"context_line":"        self.repo \u003d repositories.Repositories().amphorahealth"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def update(self, key, ip, port):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_1885970a","line":69,"range":{"start_line":69,"start_character":24,"end_line":69,"end_character":69},"updated":"2018-07-26 16:15:52.000000000","message":"I would like to see the max threads for this broken out as it is now a separate thread pool.\nAnd yes, these should be just CONF","commit_id":"0a00b4eb921ae3545316988df12b43f69388935a"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"ce03b8c13f60a9ea072d57082bf87b97915c3ebf","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.health_executor \u003d futures.ProcessPoolExecutor("},{"line_number":67,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":68,"context_line":"        self.stats_executor \u003d futures.ProcessPoolExecutor("},{"line_number":69,"context_line":"            max_workers\u003dcfg.CONF.health_manager.status_update_threads)"},{"line_number":70,"context_line":"        self.repo \u003d repositories.Repositories().amphorahealth"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def update(self, key, ip, port):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_4bf489d0","line":69,"range":{"start_line":69,"start_character":24,"end_line":69,"end_character":69},"in_reply_to":"5f7c97a3_1885970a","updated":"2018-07-27 08:38:59.000000000","message":"+1","commit_id":"0a00b4eb921ae3545316988df12b43f69388935a"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"33595bfb6293e37fe88ae10c7eefd5b657aaedee","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.update(self.key, self.ip, self.port)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.health_executor \u003d futures.ProcessPoolExecutor("},{"line_number":67,"context_line":"            max_workers\u003dcfg.CONF.health_manager.health_update_threads)"},{"line_number":68,"context_line":"        self.stats_executor \u003d futures.ProcessPoolExecutor("},{"line_number":69,"context_line":"            max_workers\u003dcfg.CONF.health_manager.stats_update_threads)"},{"line_number":70,"context_line":"        self.repo \u003d repositories.Repositories().amphorahealth"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_6df52f57","line":67,"range":{"start_line":67,"start_character":24,"end_line":67,"end_character":33},"updated":"2018-08-07 12:05:21.000000000","message":"CONF  (It\u0027s better to use #28)","commit_id":"89186ad351f2e33dfd9cbfccf824226ff1f91848"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"33595bfb6293e37fe88ae10c7eefd5b657aaedee","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.health_executor \u003d futures.ProcessPoolExecutor("},{"line_number":67,"context_line":"            max_workers\u003dcfg.CONF.health_manager.health_update_threads)"},{"line_number":68,"context_line":"        self.stats_executor \u003d futures.ProcessPoolExecutor("},{"line_number":69,"context_line":"            max_workers\u003dcfg.CONF.health_manager.stats_update_threads)"},{"line_number":70,"context_line":"        self.repo \u003d repositories.Repositories().amphorahealth"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def update(self, key, ip, port):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_0dea7b74","line":69,"range":{"start_line":69,"start_character":24,"end_line":69,"end_character":32},"updated":"2018-08-07 12:05:21.000000000","message":"ditto","commit_id":"89186ad351f2e33dfd9cbfccf824226ff1f91848"}],"octavia/cmd/health_manager.py":[{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"9c61e7e4ef5c9dd7c80bb511db7215f65efd3971","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            LOG.error(\u0027Health Manager listener experienced unknown error: %s\u0027,"},{"line_number":51,"context_line":"                      e)"},{"line_number":52,"context_line":"    LOG.info(\u0027Waiting for executor to shutdown...\u0027)"},{"line_number":53,"context_line":"    udp_getter.health_executor.shutdown()"},{"line_number":54,"context_line":"    udp_getter.stats_executor.shutdown()"},{"line_number":55,"context_line":"    LOG.info(\u0027Executor shutdown finished.\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_aace6957","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":40},"updated":"2018-08-23 02:05:16.000000000","message":"Just a suggest here, if we slipt the check process, can we add some debug log between them?","commit_id":"ad69363fc753c0689214fcdc26d6ef6c90d0d520"}],"octavia/common/config.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"4c75868441d382b87e577e58ffbb44e88dcc2abf","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    cfg.IntOpt(\u0027failover_threads\u0027,"},{"line_number":170,"context_line":"               default\u003d10,"},{"line_number":171,"context_line":"               help\u003d_(\u0027Number of threads performing amphora failovers.\u0027)),"},{"line_number":172,"context_line":"    # TODO(tatsuma) Remove in or after \"R\" release"},{"line_number":173,"context_line":"    cfg.IntOpt(\u0027status_update_threads\u0027,"},{"line_number":174,"context_line":"               default\u003dNone,"},{"line_number":175,"context_line":"               help\u003d_(\u0027Number of processes for amphora status update.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_05748798","line":172,"range":{"start_line":172,"start_character":33,"end_line":172,"end_character":50},"updated":"2018-08-20 09:26:11.000000000","message":"Cannot be removed in Rocky release.\n\nIf this patch is accepted and backported for Rocky RC2, it could be removed in Stein. If merged in Stein, the earliest it can be removed is in T release.","commit_id":"8ad2d09bf0350436d28534f214868f9d6628cefb"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"4c75868441d382b87e577e58ffbb44e88dcc2abf","unresolved":false,"context_lines":[{"line_number":661,"context_line":"    if cfg.CONF.api_handler is not None:"},{"line_number":662,"context_line":"        cfg.CONF.set_default(\u0027api_handler\u0027, cfg.CONF.api_handler,"},{"line_number":663,"context_line":"                             group\u003d\u0027api_settings\u0027)"},{"line_number":664,"context_line":"    # TODO(tatsuma) Remove in or after \"R\" release"},{"line_number":665,"context_line":"    if cfg.CONF.health_manager.status_update_threads is not None:"},{"line_number":666,"context_line":"        cfg.CONF.set_default(\u0027health_update_threads\u0027,"},{"line_number":667,"context_line":"                             cfg.CONF.health_manager.status_update_threads,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_a56833ba","line":664,"range":{"start_line":664,"start_character":4,"end_line":664,"end_character":50},"updated":"2018-08-20 09:26:11.000000000","message":"ditto","commit_id":"8ad2d09bf0350436d28534f214868f9d6628cefb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dbbe86876ae40d73375a2cf30dfe80332eff6f1f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"               default\u003dNone,"},{"line_number":189,"context_line":"               help\u003d_(\u0027Number of processes for amphora status update.\u0027),"},{"line_number":190,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":191,"context_line":"               deprecated_reason\u003d_(\u0027This option is replaced as \u0027"},{"line_number":192,"context_line":"                                   \u0027health_update_threads and \u0027"},{"line_number":193,"context_line":"                                   \u0027stats_update_threads\u0027)),"},{"line_number":194,"context_line":"    cfg.IntOpt(\u0027health_update_threads\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_96fe8b37","line":191,"updated":"2018-10-08 16:40:10.000000000","message":"Should have probably split the deprecation out into a follow up change because we don\u0027t want to backport a change to stable branches that deprecates an option.","commit_id":"ad69363fc753c0689214fcdc26d6ef6c90d0d520"}],"releasenotes/notes/separate-thread-pool-for-health-stats-update-c263c844075a7721.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"ae4716c31e9cdbe6add8f09d64ce54146fdee6de","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    health and stats."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    `status_update_threads` config option for healthmanager is deplicated"},{"line_number":9,"context_line":"    because it is replaced as `health_update_threads` and"},{"line_number":10,"context_line":"    `stats_update_threads`."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_8e0f682d","line":8,"range":{"start_line":8,"start_character":63,"end_line":8,"end_character":73},"updated":"2018-08-07 08:31:59.000000000","message":"typo: deprecated","commit_id":"89186ad351f2e33dfd9cbfccf824226ff1f91848"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"789d26911dd3b2769f317fdb87f3845b1bbe8369","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new parameters to specify the number of threads for updating amphora"},{"line_number":5,"context_line":"    health and stats."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_b6f14799","line":4,"updated":"2018-10-08 16:29:48.000000000","message":"Is this really a feature? It\u0027s related to a bug fix correct?","commit_id":"ad69363fc753c0689214fcdc26d6ef6c90d0d520"}]}
