)]}'
{"octavia/amphorae/backends/agent/api_server/templates/keepalived.systemd.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7c174d589aa12ef1800ed9382e6f5d999bbe0dcc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Force context as we start keepalived under \"ip netns exec\""},{"line_number":8,"context_line":"SELinuxContext\u003dsystem_u:system_r:keepalived_t:s0"},{"line_number":9,"context_line":"Type\u003dforking"},{"line_number":10,"context_line":"KillMode\u003dmixed"},{"line_number":11,"context_line":"Restart\u003dalways"},{"line_number":12,"context_line":"ExecStart\u003d/sbin/ip netns exec {{ amphora_nsname }} {{ keepalived_cmd }} -D -d -f {{ keepalived_cfg }} -p {{ keepalived_pid }}"},{"line_number":13,"context_line":"ExecReload\u003d/bin/kill -HUP $MAINPID"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_97e1c901","line":10,"updated":"2018-08-06 15:01:07.000000000","message":"Why the switch from process?  Upstream they are using process.\nhttps://github.com/acassen/keepalived/blob/master/keepalived/keepalived.service.in","commit_id":"12f30f5d6ffd78ea1ec428c28657ef6ed196a8c6"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"cd96ce6468c77ae1c208d5ced6b76c969f548590","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Force context as we start keepalived under \"ip netns exec\""},{"line_number":8,"context_line":"SELinuxContext\u003dsystem_u:system_r:keepalived_t:s0"},{"line_number":9,"context_line":"Type\u003dforking"},{"line_number":10,"context_line":"KillMode\u003dmixed"},{"line_number":11,"context_line":"Restart\u003dalways"},{"line_number":12,"context_line":"ExecStart\u003d/sbin/ip netns exec {{ amphora_nsname }} {{ keepalived_cmd }} -D -d -f {{ keepalived_cfg }} -p {{ keepalived_pid }}"},{"line_number":13,"context_line":"ExecReload\u003d/bin/kill -HUP $MAINPID"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_ac527766","line":10,"in_reply_to":"3f79a3b5_97e1c901","updated":"2018-08-06 19:59:23.000000000","message":"True.\nBut they are not using Restart\u003d there.\n\nAt first, I tried to only add Restart\u003dalways and leave the above unchanged, but it didn\u0027t work for me.\n\nLooking at : https://www.freedesktop.org/software/systemd/man/systemd.kill.html#KillMode\u003d\n\nI think the explanation here  might be related to the fact that we have a keepalived process with two forks:\n\n[root@amphora-4696a4d2-c61a-471d-ab60-023a5852508c ~]# ps -ef | grep keep\nroot      1083     1  0 Aug05 ttyS0    00:00:00 /sbin/agetty --keep-baud 115200 38400 9600 ttyS0 vt220\nroot      1559     1  0 Aug05 ?        00:00:17 /usr/sbin/keepalived -D -d -f /var/lib/octavia/vrrp/octavia-keepalived.conf -p /var/lib/octavia/vrrp/octavia-keepalived.pid\nroot      1560  1559  0 Aug05 ?        00:00:16 /usr/sbin/keepalived -D -d -f /var/lib/octavia/vrrp/octavia-keepalived.conf -p /var/lib/octavia/vrrp/octavia-keepalived.pid\nroot      1561  1559  0 Aug05 ?        00:01:21 /usr/sbin/keepalived -D -d -f /var/lib/octavia/vrrp/octavia-keepalived.conf -p /var/lib/octavia/vrrp/octavia-keepalived.pid\nroot      3449  3431  0 19:58 pts/0    00:00:00 grep --color\u003dauto keep","commit_id":"12f30f5d6ffd78ea1ec428c28657ef6ed196a8c6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3b8042150c99453dca56ce59d98edf3226ede586","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Force context as we start keepalived under \"ip netns exec\""},{"line_number":9,"context_line":"SELinuxContext\u003dsystem_u:system_r:keepalived_t:s0"},{"line_number":10,"context_line":"Type\u003dforking"},{"line_number":11,"context_line":"KillMode\u003dmixed"},{"line_number":12,"context_line":"Restart\u003dalways"},{"line_number":13,"context_line":"{% if vrrp_pid and check_pid %}"},{"line_number":14,"context_line":"ExecStart\u003d/sbin/ip netns exec {{ amphora_nsname }} {{ keepalived_cmd }} -D -d -f {{ keepalived_cfg }} -p {{ keepalived_pid }} -r {{ vrrp_pid }} -c {{ check_pid }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f79a3b5_23f651d7","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":14},"updated":"2018-11-16 21:51:09.000000000","message":"I am still a bit concerned about this. Mix will politely SIGTERM the main process, but will SIGKILL the children. I\u0027m worried that since the upstream service definition uses process that killing the children could stop proper cleanup (remove interface files, etc.).\nCan we go into more detail of why process doesn\u0027t work here for a restart?","commit_id":"f2bc68cc9c4a5f7f2cc02825bfee49709df62308"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"8726dc563125ef51db93c13fa684e4e634aaa63b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SELinuxContext\u003dsystem_u:system_r:keepalived_t:s0"},{"line_number":10,"context_line":"Type\u003dforking"},{"line_number":11,"context_line":"KillMode\u003dmixed"},{"line_number":12,"context_line":"Restart\u003dalways"},{"line_number":13,"context_line":"{% if vrrp_pid and check_pid %}"},{"line_number":14,"context_line":"ExecStart\u003d/sbin/ip netns exec {{ amphora_nsname }} {{ keepalived_cmd }} -D -d -f {{ keepalived_cfg }} -p {{ keepalived_pid }} -r {{ vrrp_pid }} -c {{ check_pid }}"},{"line_number":15,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f79a3b5_760c0894","line":12,"updated":"2018-08-30 21:50:38.000000000","message":"The Internet where I get my wisdom from says: \"Setting this to on-failure is the recommended choice for long-running services, in order to increase reliability by attempting automatic recovery from errors. For services that shall be able to terminate on their own choice (and avoid immediate restarting), on-abnormal is an alternative choice.\" (https://www.freedesktop.org/software/systemd/man/systemd.service.html) -- so not convince that always is best, hence +1 only.","commit_id":"f2bc68cc9c4a5f7f2cc02825bfee49709df62308"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3b8042150c99453dca56ce59d98edf3226ede586","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SELinuxContext\u003dsystem_u:system_r:keepalived_t:s0"},{"line_number":10,"context_line":"Type\u003dforking"},{"line_number":11,"context_line":"KillMode\u003dmixed"},{"line_number":12,"context_line":"Restart\u003dalways"},{"line_number":13,"context_line":"{% if vrrp_pid and check_pid %}"},{"line_number":14,"context_line":"ExecStart\u003d/sbin/ip netns exec {{ amphora_nsname }} {{ keepalived_cmd }} -D -d -f {{ keepalived_cfg }} -p {{ keepalived_pid }} -r {{ vrrp_pid }} -c {{ check_pid }}"},{"line_number":15,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f79a3b5_c3cbdd7c","line":12,"in_reply_to":"3f79a3b5_69bad1c0","updated":"2018-11-16 21:51:09.000000000","message":"I am ok with always here.","commit_id":"f2bc68cc9c4a5f7f2cc02825bfee49709df62308"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"bc592b32d43f0bca392923c9e04700cc2948791f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SELinuxContext\u003dsystem_u:system_r:keepalived_t:s0"},{"line_number":10,"context_line":"Type\u003dforking"},{"line_number":11,"context_line":"KillMode\u003dmixed"},{"line_number":12,"context_line":"Restart\u003dalways"},{"line_number":13,"context_line":"{% if vrrp_pid and check_pid %}"},{"line_number":14,"context_line":"ExecStart\u003d/sbin/ip netns exec {{ amphora_nsname }} {{ keepalived_cmd }} -D -d -f {{ keepalived_cfg }} -p {{ keepalived_pid }} -r {{ vrrp_pid }} -c {{ check_pid }}"},{"line_number":15,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f79a3b5_69bad1c0","line":12,"in_reply_to":"3f79a3b5_760c0894","updated":"2018-08-31 21:06:02.000000000","message":"I think Nir\u0027s motivation for restart\u003dalways is when a user kills keepalived purposely or by accident.","commit_id":"f2bc68cc9c4a5f7f2cc02825bfee49709df62308"}]}