)]}'
{"octavia/api/root_controller.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"efabcf3ff090bea92147314d626c5d056f3c991d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                            \u00272020-03-10T00:00:00Z\u0027, host_url)"},{"line_number":115,"context_line":"        # Additional UDP Healthcheck Types (HTTP/TCP)"},{"line_number":116,"context_line":"        self._add_a_version(versions, \u0027v2.16\u0027, \u0027v2\u0027, \u0027CURRENT\u0027,"},{"line_number":117,"context_line":"                            \u00272019-03-10T00:00:01Z\u0027, host_url)"},{"line_number":118,"context_line":"        return {\u0027versions\u0027: versions}"}],"source_content_type":"text/x-python","patch_set":14,"id":"bf3833fe_207aaa87","line":117,"range":{"start_line":117,"start_character":29,"end_line":117,"end_character":33},"updated":"2020-04-10 17:27:08.000000000","message":"2020","commit_id":"77750d389bb576fad404463e18715d3dcd75d0fd"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a02ff347f84b3320e03f59e3187e04b425324622","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                            \u00272020-03-10T00:00:00Z\u0027, host_url)"},{"line_number":115,"context_line":"        # Additional UDP Healthcheck Types (HTTP/TCP)"},{"line_number":116,"context_line":"        self._add_a_version(versions, \u0027v2.16\u0027, \u0027v2\u0027, \u0027CURRENT\u0027,"},{"line_number":117,"context_line":"                            \u00272019-03-10T00:00:01Z\u0027, host_url)"},{"line_number":118,"context_line":"        return {\u0027versions\u0027: versions}"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f4c43b2_838f0022","line":117,"range":{"start_line":117,"start_character":29,"end_line":117,"end_character":33},"in_reply_to":"bf3833fe_207aaa87","updated":"2020-04-15 16:12:54.000000000","message":"whoops :D","commit_id":"77750d389bb576fad404463e18715d3dcd75d0fd"}],"octavia/api/v2/controllers/health_monitor.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f679a62c75e1366ab2bea38f93bc9728ba87d714","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            raise exceptions.InvalidOption(value\u003d\u0027\u0027, option\u003d\u0027\u0027)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _validate_healthmonitor_request_for_udp(self, request):"},{"line_number":168,"context_line":"        is_invalid \u003d (hasattr(request, \u0027type\u0027) and"},{"line_number":169,"context_line":"                      (request.type not in [consts.HEALTH_MONITOR_UDP_CONNECT,"},{"line_number":170,"context_line":"                                            consts.HEALTH_MONITOR_TCP,"},{"line_number":171,"context_line":"                                            consts.HEALTH_MONITOR_HTTP]))"},{"line_number":172,"context_line":"        if is_invalid:"},{"line_number":173,"context_line":"            raise exceptions.ValidationException(detail\u003d_("},{"line_number":174,"context_line":"                \"The associated pool protocol is %(pool_protocol)s, so only \""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_9439a5a3","line":171,"range":{"start_line":168,"start_character":8,"end_line":171,"end_character":73},"updated":"2020-02-03 12:49:24.000000000","message":"shouldn\u0027t we validate that method, url, and expected codes cannot be used for udp and tcp health monitor? and that method, url_path are correctly set for http health monitor?","commit_id":"657d11506d11043143a4e60f3adb0df7b09da6fc"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"42f37d17fef1231315cb85d8d4be91ee08305688","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            raise exceptions.InvalidOption(value\u003d\u0027\u0027, option\u003d\u0027\u0027)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _validate_healthmonitor_request_for_udp(self, request):"},{"line_number":168,"context_line":"        is_invalid \u003d (hasattr(request, \u0027type\u0027) and"},{"line_number":169,"context_line":"                      (request.type not in [consts.HEALTH_MONITOR_UDP_CONNECT,"},{"line_number":170,"context_line":"                                            consts.HEALTH_MONITOR_TCP,"},{"line_number":171,"context_line":"                                            consts.HEALTH_MONITOR_HTTP]))"},{"line_number":172,"context_line":"        if is_invalid:"},{"line_number":173,"context_line":"            raise exceptions.ValidationException(detail\u003d_("},{"line_number":174,"context_line":"                \"The associated pool protocol is %(pool_protocol)s, so only \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_fb07f8c8","line":171,"range":{"start_line":168,"start_character":8,"end_line":171,"end_character":73},"in_reply_to":"3fa7e38b_9439a5a3","updated":"2020-03-09 13:32:14.000000000","message":"All of that will actually get checked later on during the normal health check validation. See lines 120-133, which are executed later for ALL requests.","commit_id":"657d11506d11043143a4e60f3adb0df7b09da6fc"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f679a62c75e1366ab2bea38f93bc9728ba87d714","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                                   consts.HEALTH_MONITOR_TCP,"},{"line_number":179,"context_line":"                                   consts.HEALTH_MONITOR_HTTP])})"},{"line_number":180,"context_line":"        # if the logic arrives here, that means the validation of request above"},{"line_number":181,"context_line":"        # is OK. type is UDP-CONNECT, then here we check the healthmonitor"},{"line_number":182,"context_line":"        # delay value is matched."},{"line_number":183,"context_line":"        if request.delay:"},{"line_number":184,"context_line":"            conf_set \u003d (CONF.api_settings."}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_94c44596","line":181,"range":{"start_line":181,"start_character":17,"end_line":181,"end_character":36},"updated":"2020-02-03 12:49:24.000000000","message":"no longer true","commit_id":"657d11506d11043143a4e60f3adb0df7b09da6fc"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"42f37d17fef1231315cb85d8d4be91ee08305688","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                                   consts.HEALTH_MONITOR_TCP,"},{"line_number":179,"context_line":"                                   consts.HEALTH_MONITOR_HTTP])})"},{"line_number":180,"context_line":"        # if the logic arrives here, that means the validation of request above"},{"line_number":181,"context_line":"        # is OK. type is UDP-CONNECT, then here we check the healthmonitor"},{"line_number":182,"context_line":"        # delay value is matched."},{"line_number":183,"context_line":"        if request.delay:"},{"line_number":184,"context_line":"            conf_set \u003d (CONF.api_settings."}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_7bfb08c0","line":181,"range":{"start_line":181,"start_character":17,"end_line":181,"end_character":36},"in_reply_to":"3fa7e38b_94c44596","updated":"2020-03-09 13:32:14.000000000","message":"kk, redoing this section a bit.","commit_id":"657d11506d11043143a4e60f3adb0df7b09da6fc"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f679a62c75e1366ab2bea38f93bc9728ba87d714","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        # delay value is matched."},{"line_number":183,"context_line":"        if request.delay:"},{"line_number":184,"context_line":"            conf_set \u003d (CONF.api_settings."},{"line_number":185,"context_line":"                        udp_connect_min_interval_health_monitor)"},{"line_number":186,"context_line":"            if conf_set \u003c 0:"},{"line_number":187,"context_line":"                return"},{"line_number":188,"context_line":"            if request.delay \u003c conf_set:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_54432d13","line":185,"range":{"start_line":185,"start_character":24,"end_line":185,"end_character":63},"updated":"2020-02-03 12:49:24.000000000","message":"same here","commit_id":"657d11506d11043143a4e60f3adb0df7b09da6fc"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f679a62c75e1366ab2bea38f93bc9728ba87d714","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                    \"%(conf_set)s for %(type)s health monitor type.\") % {"},{"line_number":192,"context_line":"                    \u0027delay\u0027: request.delay,"},{"line_number":193,"context_line":"                    \u0027conf_set\u0027: conf_set,"},{"line_number":194,"context_line":"                    \u0027type\u0027: consts.HEALTH_MONITOR_UDP_CONNECT})"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @wsme_pecan.wsexpose(hm_types.HealthMonitorRootResponse,"},{"line_number":197,"context_line":"                         body\u003dhm_types.HealthMonitorRootPOST, status_code\u003d201)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_7440a905","line":194,"range":{"start_line":194,"start_character":35,"end_line":194,"end_character":61},"updated":"2020-02-03 12:49:24.000000000","message":"same","commit_id":"657d11506d11043143a4e60f3adb0df7b09da6fc"}],"octavia/common/jinja/lvs/jinja_cfg.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"cf7e286f92210f214d293b37525214d540b7bbbe","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        }"},{"line_number":210,"context_line":"        if monitor.type \u003d\u003d constants.HEALTH_MONITOR_HTTP:"},{"line_number":211,"context_line":"            return_val.update({"},{"line_number":212,"context_line":"                \u0027rise_threshold\u0027: monitor.rise_threshold,"},{"line_number":213,"context_line":"                \u0027url_path\u0027: monitor.url_path,"},{"line_number":214,"context_line":"                \u0027http_method\u0027: (monitor.http_method"},{"line_number":215,"context_line":"                                if monitor.http_method \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":14,"id":"df33271e_508a7e1a","line":212,"range":{"start_line":212,"start_character":17,"end_line":212,"end_character":31},"updated":"2020-04-10 05:31:54.000000000","message":"Hmm we don\u0027t technically use this...","commit_id":"77750d389bb576fad404463e18715d3dcd75d0fd"}],"octavia/common/jinja/lvs/templates/macros.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bcfad95e87243770670d2e38b157911ba593aa98","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            {% for status_code in health_monitor.expected_codes %}"},{"line_number":42,"context_line":"            {{ http_url_macro(health_monitor, status_code) -}}"},{"line_number":43,"context_line":"            {% endfor %}"},{"line_number":44,"context_line":"            connect_ip {{ member.address }}"},{"line_number":45,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":46,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":47,"context_line":"            nb_get_retry {{ health_monitor.rise_threshold }}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_6694a845","line":44,"updated":"2020-03-23 23:49:52.000000000","message":"What about the optional monitor_address?","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a238d9829ad45f1319d5888c3be476b6cc1d5d1c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            {% for status_code in health_monitor.expected_codes %}"},{"line_number":42,"context_line":"            {{ http_url_macro(health_monitor, status_code) -}}"},{"line_number":43,"context_line":"            {% endfor %}"},{"line_number":44,"context_line":"            connect_ip {{ member.address }}"},{"line_number":45,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":46,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":47,"context_line":"            nb_get_retry {{ health_monitor.rise_threshold }}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_6e09112b","line":44,"in_reply_to":"df33271e_6694a845","updated":"2020-03-24 18:56:57.000000000","message":"Done","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bcfad95e87243770670d2e38b157911ba593aa98","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            connect_ip {{ member.address }}"},{"line_number":45,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":46,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":47,"context_line":"            nb_get_retry {{ health_monitor.rise_threshold }}"},{"line_number":48,"context_line":"            delay_before_retry  {{ health_monitor.timeout }}"},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"{%- endmacro -%}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_6655c850","line":47,"range":{"start_line":47,"start_character":43,"end_line":47,"end_character":57},"updated":"2020-03-23 23:49:52.000000000","message":"Is this really the \"down\" one?","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bcfad95e87243770670d2e38b157911ba593aa98","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            connect_ip {{ member.address }}"},{"line_number":45,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":46,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":47,"context_line":"            nb_get_retry {{ health_monitor.rise_threshold }}"},{"line_number":48,"context_line":"            delay_before_retry  {{ health_monitor.timeout }}"},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"{%- endmacro -%}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_c60ad488","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":24},"updated":"2020-03-23 23:49:52.000000000","message":"nb_get_retry is deprecated, I think this should be retry.\nhttps://github.com/acassen/keepalived/commit/6754ffcdfa6a43557c5ed5777d4974099e75f6bc","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a238d9829ad45f1319d5888c3be476b6cc1d5d1c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            connect_ip {{ member.address }}"},{"line_number":45,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":46,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":47,"context_line":"            nb_get_retry {{ health_monitor.rise_threshold }}"},{"line_number":48,"context_line":"            delay_before_retry  {{ health_monitor.timeout }}"},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"{%- endmacro -%}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_6edd9141","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":24},"in_reply_to":"df33271e_c60ad488","updated":"2020-03-24 18:56:57.000000000","message":"So, I\u0027ll change it to fall_threshold, but since there\u0027s only one variable in keepalived, we\u0027re going to get it wrong one way or another. I think fall is more correct though, as this is explicitly for \"retries on failures\".\nFixed the name.","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a238d9829ad45f1319d5888c3be476b6cc1d5d1c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":46,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":47,"context_line":"            nb_get_retry {{ health_monitor.rise_threshold }}"},{"line_number":48,"context_line":"            delay_before_retry  {{ health_monitor.timeout }}"},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"{%- endmacro -%}"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_9400e836","line":48,"updated":"2020-03-24 18:56:57.000000000","message":"I believe this value is wrong, should mirror `delay` not `timeout`... will test","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bcfad95e87243770670d2e38b157911ba593aa98","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":47,"context_line":"            nb_get_retry {{ health_monitor.rise_threshold }}"},{"line_number":48,"context_line":"            delay_before_retry  {{ health_monitor.timeout }}"},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"{%- endmacro -%}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"{%- macro tcp_check_macro(pool, member, health_monitor) -%}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_e661d83b","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":9},"updated":"2020-03-23 23:49:52.000000000","message":"Shouldn\u0027t delay_loop be set for our \"delay\" value?","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a238d9829ad45f1319d5888c3be476b6cc1d5d1c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":47,"context_line":"            nb_get_retry {{ health_monitor.rise_threshold }}"},{"line_number":48,"context_line":"            delay_before_retry  {{ health_monitor.timeout }}"},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"{%- endmacro -%}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"{%- macro tcp_check_macro(pool, member, health_monitor) -%}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_8e38d5d3","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":9},"in_reply_to":"df33271e_e661d83b","updated":"2020-03-24 18:56:57.000000000","message":"So I think delay_loop is set at a higher level already and doesn\u0027t need to be in these...","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bcfad95e87243770670d2e38b157911ba593aa98","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"{%- macro tcp_check_macro(pool, member, health_monitor) -%}"},{"line_number":53,"context_line":"TCP_CHECK {"},{"line_number":54,"context_line":"            connect_ip {{ member.address }}"},{"line_number":55,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":56,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":57,"context_line":"        }"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_06615c37","line":54,"range":{"start_line":54,"start_character":33,"end_line":54,"end_character":41},"updated":"2020-03-23 23:49:52.000000000","message":"What about monitor_address?","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a238d9829ad45f1319d5888c3be476b6cc1d5d1c","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"{%- macro tcp_check_macro(pool, member, health_monitor) -%}"},{"line_number":53,"context_line":"TCP_CHECK {"},{"line_number":54,"context_line":"            connect_ip {{ member.address }}"},{"line_number":55,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":56,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":57,"context_line":"        }"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_4e0ecd34","line":54,"range":{"start_line":54,"start_character":33,"end_line":54,"end_character":41},"in_reply_to":"df33271e_06615c37","updated":"2020-03-24 18:56:57.000000000","message":"Done","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bcfad95e87243770670d2e38b157911ba593aa98","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            connect_ip {{ member.address }}"},{"line_number":55,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":56,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"{%- endmacro -%}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{% macro health_monitor_rs_macro(constants, pool, member) %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_46524469","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":9},"updated":"2020-03-23 23:49:52.000000000","message":"No retries for TCP?\nLooking at the docs, this should be very similar to the HTTP one.","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"ede564eaef55fde13ad0a25263fd22d08cf55609","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            connect_ip {{ member.address }}"},{"line_number":55,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":56,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"{%- endmacro -%}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{% macro health_monitor_rs_macro(constants, pool, member) %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3f4c43b2_43db381a","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":9},"in_reply_to":"3f4c43b2_03a3f09f","updated":"2020-04-15 16:16:29.000000000","message":"Ah, yes. I meant that line but referred another one in my comment.","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a02ff347f84b3320e03f59e3187e04b425324622","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            connect_ip {{ member.address }}"},{"line_number":55,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":56,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"{%- endmacro -%}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{% macro health_monitor_rs_macro(constants, pool, member) %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3f4c43b2_03a3f09f","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":9},"in_reply_to":"9f3d2ff0_5f26abb9","updated":"2020-04-15 16:12:54.000000000","message":"two lines down (retry 3)","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a238d9829ad45f1319d5888c3be476b6cc1d5d1c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            connect_ip {{ member.address }}"},{"line_number":55,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":56,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"{%- endmacro -%}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{% macro health_monitor_rs_macro(constants, pool, member) %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"df33271e_aee67915","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":9},"in_reply_to":"df33271e_46524469","updated":"2020-03-24 18:56:57.000000000","message":"Done","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"efabcf3ff090bea92147314d626c5d056f3c991d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            connect_ip {{ member.address }}"},{"line_number":55,"context_line":"            connect_port {{ member.monitor_port|default(member.protocol_port, true) }}"},{"line_number":56,"context_line":"            connect_timeout {{ health_monitor.timeout }}"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"{%- endmacro -%}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{% macro health_monitor_rs_macro(constants, pool, member) %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f3d2ff0_5f26abb9","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":9},"in_reply_to":"df33271e_aee67915","updated":"2020-04-10 17:27:08.000000000","message":"Where? Is it delay_ options in https://review.opendev.org/#/c/589180/11/octavia/tests/unit/common/jinja/lvs/test_lvs_jinja_cfg.py@325 ?","commit_id":"d991f6fe86052266a06fab5a419137a65a866d40"}],"releasenotes/notes/additional-udp-healthcheck-types-2414a5edee9f5110.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"7516081c1b10a488fd7370cc58fd8be45417c00d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Two new types of healthmonitoring are now valid for UDP listeners. Both"},{"line_number":5,"context_line":"    ``HTTP`` and ``TCP`` check types can now be used."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Delay between checks on UDP healthmonitors was using the incorrect config"},{"line_number":9,"context_line":"    value ``timeout``, when it should have been ``delay``."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df33271e_fba33cff","line":6,"updated":"2020-04-04 22:10:53.000000000","message":"I have not reviewed this patch thoroughly yet but I wonder if this patch should be split out in two: the fix (so that we can backport) and the new health types.","commit_id":"3515288ad9226afc395b74e006d73c6c39bc27f0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b48a73831a9358ff5f3dd83c1be1b9d4272c68ce","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Two new types of healthmonitoring are now valid for UDP listeners. Both"},{"line_number":5,"context_line":"    ``HTTP`` and ``TCP`` check types can now be used."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Delay between checks on UDP healthmonitors was using the incorrect config"},{"line_number":9,"context_line":"    value ``timeout``, when it should have been ``delay``."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df33271e_b25dd316","line":6,"in_reply_to":"df33271e_fba33cff","updated":"2020-04-10 01:03:44.000000000","message":"That\u0027s fair, I\u0027ll split it.","commit_id":"3515288ad9226afc395b74e006d73c6c39bc27f0"}]}