)]}'
{"elements/keepalived-octavia/post-install.d/11-ip6-tables":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"43c4983d19499f7a6bd36d45510338834ec11fea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# keepalived older than 1.3 will segfault when using IPv6 VIPs if the"},{"line_number":3,"context_line":"# ip6_tables module is not loaded. Make sure it is loaded on releases we"},{"line_number":4,"context_line":"# know have the older version."},{"line_number":5,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"3f79a3b5_82826201","line":2,"range":{"start_line":2,"start_character":13,"end_line":2,"end_character":28},"updated":"2018-12-06 20:11:18.000000000","message":"for other reviewers, I double checked that CentOS 7.6.1810 ship keepalived-1.3.5-6 , so no need to address CentOS releases here.","commit_id":"4e5780d3ab8535cfad8ba0b22e53ad01081f379d"}],"octavia/amphorae/backends/agent/api_server/plug.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"9d339f5801d41f6cd109e7f27244003c9d1989c7","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                     IFLA_IFNAME\u003dprimary_interface)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # In an ha amphora, keepalived should bring the VIP interface up"},{"line_number":141,"context_line":"        if (CONF.controller_worker.loadbalancer_topology \u003d\u003d"},{"line_number":142,"context_line":"                consts.TOPOLOGY_ACTIVE_STANDBY):"},{"line_number":143,"context_line":"            self._osutils._bring_if_down(primary_interface)"},{"line_number":144,"context_line":"            self._osutils._bring_if_up(primary_interface)"},{"line_number":145,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b3e96b81","line":142,"range":{"start_line":141,"start_character":12,"end_line":142,"end_character":46},"updated":"2018-08-07 08:13:08.000000000","message":"Topology set in configuration file may not match the running topology of a given amp, i.e. admins may have changed topology post-amphora creation.","commit_id":"bca220c69f354e2f38a644b208e2a289313b5b87"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"50b28d8efbd87f1166fe1742d9161c4157ee017f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                     IFLA_IFNAME\u003dprimary_interface)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # In an ha amphora, keepalived should bring the VIP interface up"},{"line_number":141,"context_line":"        if (CONF.controller_worker.loadbalancer_topology \u003d\u003d"},{"line_number":142,"context_line":"                consts.TOPOLOGY_ACTIVE_STANDBY):"},{"line_number":143,"context_line":"            self._osutils._bring_if_down(primary_interface)"},{"line_number":144,"context_line":"            self._osutils._bring_if_up(primary_interface)"},{"line_number":145,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4ec6306a","line":142,"range":{"start_line":141,"start_character":12,"end_line":142,"end_character":46},"in_reply_to":"3f79a3b5_b3e96b81","updated":"2018-08-07 08:49:02.000000000","message":"When I think about it, there\u0027s a different issue here.\n this is actually being read by the amphora-agent from /etc/octavia/amphora-agent.conf\nI should inject that value in that file and by that we\u0027ll have it placed per created amphora.","commit_id":"bca220c69f354e2f38a644b208e2a289313b5b87"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"9d339f5801d41f6cd109e7f27244003c9d1989c7","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # In an ha amphora, keepalived should bring the VIP interface up"},{"line_number":141,"context_line":"        if (CONF.controller_worker.loadbalancer_topology \u003d\u003d"},{"line_number":142,"context_line":"                consts.TOPOLOGY_ACTIVE_STANDBY):"},{"line_number":143,"context_line":"            self._osutils._bring_if_down(primary_interface)"},{"line_number":144,"context_line":"            self._osutils._bring_if_up(primary_interface)"},{"line_number":145,"context_line":"            return"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            # bring interfaces up"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_93854fb0","line":144,"range":{"start_line":143,"start_character":12,"end_line":144,"end_character":57},"updated":"2018-08-07 08:13:08.000000000","message":"What is the idea of setting IF down and immediately up again? To reset existing IF configs?","commit_id":"bca220c69f354e2f38a644b208e2a289313b5b87"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"50b28d8efbd87f1166fe1742d9161c4157ee017f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # In an ha amphora, keepalived should bring the VIP interface up"},{"line_number":141,"context_line":"        if (CONF.controller_worker.loadbalancer_topology \u003d\u003d"},{"line_number":142,"context_line":"                consts.TOPOLOGY_ACTIVE_STANDBY):"},{"line_number":143,"context_line":"            self._osutils._bring_if_down(primary_interface)"},{"line_number":144,"context_line":"            self._osutils._bring_if_up(primary_interface)"},{"line_number":145,"context_line":"            return"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            # bring interfaces up"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2e77343d","line":144,"range":{"start_line":143,"start_character":12,"end_line":144,"end_character":57},"in_reply_to":"3f79a3b5_93854fb0","updated":"2018-08-07 08:49:02.000000000","message":"this is a copy of how we currently do things currently (see osutils).\nThis is can probably there to avoid some corner cases , but maybe johnsom would know better.","commit_id":"bca220c69f354e2f38a644b208e2a289313b5b87"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"9680625ca8840cf8288be730a7e4d1e7f57f22aa","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            self._osutils.bring_interfaces_up("},{"line_number":165,"context_line":"                ip, primary_interface, secondary_interface)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            return webob.Response(json\u003ddict("},{"line_number":168,"context_line":"                message\u003d\"OK\","},{"line_number":169,"context_line":"                details\u003d\"VIP {vip} plugged on interface {interface}\".format("},{"line_number":170,"context_line":"                    vip\u003dvip, interface\u003dprimary_interface)), status\u003d202)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def _check_ip_addresses(self, fixed_ips):"},{"line_number":173,"context_line":"        if fixed_ips:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_592f583e","line":170,"range":{"start_line":167,"start_character":0,"end_line":170,"end_character":71},"updated":"2018-08-13 11:42:08.000000000","message":"not indented in future patch sets.","commit_id":"99dd0fca213ba655da878c7dc6865362f3f3ee1a"}]}
