)]}'
{"octavia/common/config.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d770d14987acc539d1f9712ae103c17367c8b101","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                      \"are located. If not set, it will default to \""},{"line_number":134,"context_line":"                      \"/etc/netns/{netns}/sysconfig/network-scripts/ (Red Hat \""},{"line_number":135,"context_line":"                      \"family) or /etc/netns/{netns}/network/interfaces.d/ \""},{"line_number":136,"context_line":"                      \"(Ubuntu family)\")),"},{"line_number":137,"context_line":"    cfg.StrOpt(\u0027agent_server_network_file\u0027,"},{"line_number":138,"context_line":"               help\u003d_(\"The file where the network interfaces are located. \""},{"line_number":139,"context_line":"                      \"Specifying this will override any value set for \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0be4350c","line":136,"updated":"2018-08-23 11:18:31.000000000","message":"I am not sure I\u0027m a fan of shoving a small novel into the help text here -- is it really necessary? Maybe just something like \"defaults will be chosen based on the amohora OS\"?\nI\u0027m still anticipating we will have more baseOS eventually (Suse / Gentoo) and we\u0027d have to add those as well...","commit_id":"64544c580aa105311bd61c36d368d471d299434c"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1458cfd6f54a2803afe9ba0da3a2f21bb4573474","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                      \"are located. If not set, it will default to \""},{"line_number":134,"context_line":"                      \"/etc/netns/{netns}/sysconfig/network-scripts/ (Red Hat \""},{"line_number":135,"context_line":"                      \"family) or /etc/netns/{netns}/network/interfaces.d/ \""},{"line_number":136,"context_line":"                      \"(Ubuntu family)\")),"},{"line_number":137,"context_line":"    cfg.StrOpt(\u0027agent_server_network_file\u0027,"},{"line_number":138,"context_line":"               help\u003d_(\"The file where the network interfaces are located. \""},{"line_number":139,"context_line":"                      \"Specifying this will override any value set for \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_51b73af6","line":136,"in_reply_to":"3f79a3b5_0be4350c","updated":"2018-08-23 12:28:40.000000000","message":"Agreed. Your suggestion of wording reads much better, thanks!","commit_id":"64544c580aa105311bd61c36d368d471d299434c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d770d14987acc539d1f9712ae103c17367c8b101","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                help\u003d_(\u0027List of controller ip and port pairs for the \u0027"},{"line_number":210,"context_line":"                       \u0027heartbeat receivers. Example 127.0.0.1:5555, \u0027"},{"line_number":211,"context_line":"                       \u0027192.168.0.1:5555\u0027),"},{"line_number":212,"context_line":"                required\u003dTrue),"},{"line_number":213,"context_line":"    cfg.IntOpt(\u0027heartbeat_interval\u0027,"},{"line_number":214,"context_line":"               default\u003d10,"},{"line_number":215,"context_line":"               help\u003d_(\u0027Sleep time between sending heartbeats.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0b92f557","line":212,"updated":"2018-08-23 11:18:31.000000000","message":"Technically if not using the healthmonitoring, this can be None I think? But, maybe it\u0027s best not to account for that case, as they can explicitly define it as an empty list in this case I believe.","commit_id":"64544c580aa105311bd61c36d368d471d299434c"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1458cfd6f54a2803afe9ba0da3a2f21bb4573474","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                help\u003d_(\u0027List of controller ip and port pairs for the \u0027"},{"line_number":210,"context_line":"                       \u0027heartbeat receivers. Example 127.0.0.1:5555, \u0027"},{"line_number":211,"context_line":"                       \u0027192.168.0.1:5555\u0027),"},{"line_number":212,"context_line":"                required\u003dTrue),"},{"line_number":213,"context_line":"    cfg.IntOpt(\u0027heartbeat_interval\u0027,"},{"line_number":214,"context_line":"               default\u003d10,"},{"line_number":215,"context_line":"               help\u003d_(\u0027Sleep time between sending heartbeats.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_31e39eda","line":212,"in_reply_to":"3f79a3b5_0b92f557","updated":"2018-08-23 12:28:40.000000000","message":"Most of the options we have apply to when loading the amphora driver only hence all services except octavia-api. If a different driver is set, I\u0027d expect not to load unnecessary configs, i.e. skip registration of opts (L593), which therefore would allow us to not set default opt values and mark them as required.","commit_id":"64544c580aa105311bd61c36d368d471d299434c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d770d14987acc539d1f9712ae103c17367c8b101","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    cfg.StrOpt(\u0027barbican_auth\u0027,"},{"line_number":419,"context_line":"               default\u003d\u0027barbican_acl_auth\u0027,"},{"line_number":420,"context_line":"               help\u003d\u0027Name of the Barbican authentication method to use\u0027),"},{"line_number":421,"context_line":"    # TODO(cgoncalves): is this option used somewhere?"},{"line_number":422,"context_line":"    cfg.StrOpt(\u0027service_name\u0027,"},{"line_number":423,"context_line":"               help\u003d_(\u0027The name of the certificate service in the keystone\u0027"},{"line_number":424,"context_line":"                      \u0027catalog\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2be331da","line":421,"updated":"2018-08-23 11:18:31.000000000","message":"https://github.com/openstack/octavia/blob/master/octavia/certificates/manager/barbican.py#L44 among other places","commit_id":"64544c580aa105311bd61c36d368d471d299434c"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1458cfd6f54a2803afe9ba0da3a2f21bb4573474","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    cfg.StrOpt(\u0027barbican_auth\u0027,"},{"line_number":419,"context_line":"               default\u003d\u0027barbican_acl_auth\u0027,"},{"line_number":420,"context_line":"               help\u003d\u0027Name of the Barbican authentication method to use\u0027),"},{"line_number":421,"context_line":"    # TODO(cgoncalves): is this option used somewhere?"},{"line_number":422,"context_line":"    cfg.StrOpt(\u0027service_name\u0027,"},{"line_number":423,"context_line":"               help\u003d_(\u0027The name of the certificate service in the keystone\u0027"},{"line_number":424,"context_line":"                      \u0027catalog\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f1f9a67f","line":421,"in_reply_to":"3f79a3b5_2be331da","updated":"2018-08-23 12:28:40.000000000","message":"My comment is with regard to CONF.certificates.service_name, not barbican_auth.","commit_id":"64544c580aa105311bd61c36d368d471d299434c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8840ec9230c155e0564c7717729b321e6ce158d0","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    cfg.StrOpt(\u0027barbican_auth\u0027,"},{"line_number":419,"context_line":"               default\u003d\u0027barbican_acl_auth\u0027,"},{"line_number":420,"context_line":"               help\u003d\u0027Name of the Barbican authentication method to use\u0027),"},{"line_number":421,"context_line":"    # TODO(cgoncalves): is this option used somewhere?"},{"line_number":422,"context_line":"    cfg.StrOpt(\u0027service_name\u0027,"},{"line_number":423,"context_line":"               help\u003d_(\u0027The name of the certificate service in the keystone\u0027"},{"line_number":424,"context_line":"                      \u0027catalog\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e869b424","line":421,"in_reply_to":"3f79a3b5_f1f9a67f","updated":"2018-08-23 17:37:18.000000000","message":"OH, you\u0027re putting the commends above, lol yeah ok makes sense. then the one below is for `endpoint` \u003c_\u003c and also i\u0027m not sure lol","commit_id":"64544c580aa105311bd61c36d368d471d299434c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d770d14987acc539d1f9712ae103c17367c8b101","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    cfg.StrOpt(\u0027service_name\u0027,"},{"line_number":423,"context_line":"               help\u003d_(\u0027The name of the certificate service in the keystone\u0027"},{"line_number":424,"context_line":"                      \u0027catalog\u0027)),"},{"line_number":425,"context_line":"    # TODO(cgoncalves): is this option used somewhere?"},{"line_number":426,"context_line":"    cfg.StrOpt(\u0027endpoint\u0027, help\u003d_(\u0027A new endpoint to override the endpoint \u0027"},{"line_number":427,"context_line":"                                  \u0027in the keystone catalog.\u0027)),"},{"line_number":428,"context_line":"    cfg.StrOpt(\u0027region_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0bce7559","line":425,"updated":"2018-08-23 11:18:31.000000000","message":"actually this one i\u0027m not sure :/","commit_id":"64544c580aa105311bd61c36d368d471d299434c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d770d14987acc539d1f9712ae103c17367c8b101","unresolved":false,"context_lines":[{"line_number":433,"context_line":"               help\u003d\u0027The endpoint_type to be used for barbican service.\u0027),"},{"line_number":434,"context_line":"    cfg.StrOpt(\u0027ca_certificates_file\u0027,"},{"line_number":435,"context_line":"               help\u003d_(\u0027CA certificates file path\u0027)),"},{"line_number":436,"context_line":"    # TODO(cgoncalves): is this option used somewhere?"},{"line_number":437,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":438,"context_line":"                default\u003dFalse,"},{"line_number":439,"context_line":"                help\u003d_(\u0027Disable certificate validation on SSL connections \u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8b0b658c","line":436,"updated":"2018-08-23 11:18:31.000000000","message":"I thought it was, but I can\u0027t find it. :/","commit_id":"64544c580aa105311bd61c36d368d471d299434c"}]}