)]}'
{"octavia/amphorae/backends/utils/keepalivedlvs_query.py":[{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"4547252dd16be516d89e6a035ba96e530b71b0bf","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    # So here, if we can not get any ipport_mapping,"},{"line_number":387,"context_line":"    # we do nothing, just return"},{"line_number":388,"context_line":"    if not ipport_mapping:"},{"line_number":389,"context_line":"        return listener_stats_res"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    # contains bout, bin, scur, stot, ereq, status"},{"line_number":392,"context_line":"    # bout(OutBytes), bin(InBytes), stot(Conns) from cmd ipvsadm -Ln --stats"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_66abf71d","line":389,"range":{"start_line":388,"start_character":0,"end_line":389,"end_character":33},"updated":"2018-08-31 02:11:58.000000000","message":"http://git.openstack.org/cgit/openstack/octavia/tree/octavia/controller/healthmanager/health_drivers/update_db.py#n122\n\nI also consider to remove that code, as that part skips the health update into db.","commit_id":"5008bf6e6c7a3bc167e8a19c3c82398b22502a33"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"21ad4bbd845baa5cd44d699f7c3bf692bc2bdda2","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    # So here, if we can not get any ipport_mapping,"},{"line_number":387,"context_line":"    # we do nothing, just return"},{"line_number":388,"context_line":"    if not ipport_mapping:"},{"line_number":389,"context_line":"        return listener_stats_res"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    # contains bout, bin, scur, stot, ereq, status"},{"line_number":392,"context_line":"    # bout(OutBytes), bin(InBytes), stot(Conns) from cmd ipvsadm -Ln --stats"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_19a624ad","line":389,"range":{"start_line":388,"start_character":0,"end_line":389,"end_character":33},"in_reply_to":"3f79a3b5_66abf71d","updated":"2018-08-31 03:53:20.000000000","message":"Yes, that is coming in a followup patch.\ngrin","commit_id":"5008bf6e6c7a3bc167e8a19c3c82398b22502a33"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"6befa05712cb90d9c4256ec11481767fc3a94c4d","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    scur_res \u003d get_ipvsadm_info(constants.AMPHORA_NAMESPACE)"},{"line_number":397,"context_line":"    stats_res \u003d get_ipvsadm_info(constants.AMPHORA_NAMESPACE,"},{"line_number":398,"context_line":"                                 is_stats_cmd\u003dTrue)"},{"line_number":399,"context_line":"    for listener_id, ipport in ipport_mapping.items():"},{"line_number":400,"context_line":"        listener_ipport \u003d ipport[\u0027Listener\u0027][\u0027ipport\u0027]"},{"line_number":401,"context_line":"        # This would be in Error, wait for the next loop to sync for the"},{"line_number":402,"context_line":"        # listener at this moment. Also this is for skip the case no enabled"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_146342df","line":399,"range":{"start_line":399,"start_character":0,"end_line":399,"end_character":54},"updated":"2018-08-31 10:42:21.000000000","message":"If there is no ipport_mapping, means we can only get the Listener, Pool, and we will return them in L389 with the info in L369-L377. It\u0027s OK for now.\n\nIf there are several listener_id in ipport_mapping, then the listeners which owned enabled members will process as below.","commit_id":"5008bf6e6c7a3bc167e8a19c3c82398b22502a33"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"6befa05712cb90d9c4256ec11481767fc3a94c4d","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        if listener_ipport not in scur_res or listener_ipport not in stats_res:"},{"line_number":405,"context_line":"            continue"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        scur, bout, bin, stot, ereq \u003d 0, 0, 0, 0, 0"},{"line_number":408,"context_line":"        # As all results contain this listener, so its status should be OPEN"},{"line_number":409,"context_line":"        status \u003d constants.OPEN"},{"line_number":410,"context_line":"        # Get scur"},{"line_number":411,"context_line":"        for m in scur_res[listener_ipport][\u0027Members\u0027]:"},{"line_number":412,"context_line":"            for item in m:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_396be01f","line":409,"range":{"start_line":407,"start_character":0,"end_line":409,"end_character":31},"updated":"2018-08-31 10:42:21.000000000","message":"same with these..Need to remove ;-)","commit_id":"5008bf6e6c7a3bc167e8a19c3c82398b22502a33"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"6befa05712cb90d9c4256ec11481767fc3a94c4d","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            elif item[0] \u003d\u003d \u0027InBytes\u0027:"},{"line_number":423,"context_line":"                bin \u003d int(item[1])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        listener_stats_res.update({"},{"line_number":426,"context_line":"            listener_id: {"},{"line_number":427,"context_line":"                \u0027stats\u0027: {"},{"line_number":428,"context_line":"                    \u0027bout\u0027: bout,"},{"line_number":429,"context_line":"                    \u0027bin\u0027: bin,"},{"line_number":430,"context_line":"                    \u0027scur\u0027: scur,"},{"line_number":431,"context_line":"                    \u0027stot\u0027: stot,"},{"line_number":432,"context_line":"                    \u0027ereq\u0027: ereq},"},{"line_number":433,"context_line":"                \u0027status\u0027: status}})"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    return listener_stats_res"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f9748800","line":433,"range":{"start_line":425,"start_character":0,"end_line":433,"end_character":35},"updated":"2018-08-31 10:42:21.000000000","message":"ditto","commit_id":"5008bf6e6c7a3bc167e8a19c3c82398b22502a33"}],"octavia/tests/unit/amphorae/backends/health_daemon/test_health_daemon.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"00b40c584fa9f321c6ad47886216f133c154e0ca","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    },"},{"line_number":130,"context_line":"    \u0027id\u0027: None,"},{"line_number":131,"context_line":"    \u0027seq\u0027: 0,"},{"line_number":132,"context_line":"    \u0027ver\u0027: 1"},{"line_number":133,"context_line":"}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_b68dc02b","line":132,"updated":"2018-08-30 21:44:08.000000000","message":"Why not use const MSG_VER introduced earlier in another file (and why is MSG_VER not in consts?)","commit_id":"5008bf6e6c7a3bc167e8a19c3c82398b22502a33"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2fa8e7f4336c4c005dabf18f20f85504773e628b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    },"},{"line_number":130,"context_line":"    \u0027id\u0027: None,"},{"line_number":131,"context_line":"    \u0027seq\u0027: 0,"},{"line_number":132,"context_line":"    \u0027ver\u0027: 1"},{"line_number":133,"context_line":"}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_83a96591","line":132,"in_reply_to":"3f79a3b5_b68dc02b","updated":"2018-08-30 23:46:11.000000000","message":"Ah, good point on the never ending update here, though I expect he schema will have to change for each version so this test will need touched each time.\nI guess we could put it in constants, but it\u0027s not really a constant.  Maybe we just need a versions file?","commit_id":"5008bf6e6c7a3bc167e8a19c3c82398b22502a33"}]}