)]}'
{"octavia/common/validate.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"150144af7b7246f14899d123b3c660c39d46dba5","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        l7policy.update({"},{"line_number":231,"context_line":"            \u0027action\u0027: constants.L7POLICY_ACTION_REDIRECT_PREFIX})"},{"line_number":232,"context_line":"        l7policy.update({\u0027redirect_pool_id\u0027: None})"},{"line_number":233,"context_line":"        l7policy.update({\u0027redirect_url\u0027: None})"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    # If we are creating, we need an action at this point"},{"line_number":236,"context_line":"    if create and \u0027action\u0027 not in l7policy.keys():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_940dae90","line":233,"updated":"2018-09-19 00:52:21.000000000","message":"I\u0027m not sure why exactly we were doing it above, but might be safe to do a `l7policy.pop(\u0027redirect_pool\u0027, None)` the same as in the rest (seems we pop anything not in use?) or we can just ignore it for now because honestly I couldn\u0027t tell you it\u0027s actually necessary for sure...","commit_id":"8d621b7606d07415a23dffc7c09567c791dc3d4a"}],"octavia/tests/unit/api/drivers/sample_data_models.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"150144af7b7246f14899d123b3c660c39d46dba5","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                                    \u0027action\u0027: \u0027go\u0027,"},{"line_number":302,"context_line":"                                    \u0027redirect_pool_id\u0027: self.pool1_id,"},{"line_number":303,"context_line":"                                    \u0027redirect_url\u0027: \u0027/index.html\u0027,"},{"line_number":304,"context_line":"                                    \u0027redirect_prefix\u0027: \u0027/index.html\u0027,"},{"line_number":305,"context_line":"                                    \u0027position\u0027: 1,"},{"line_number":306,"context_line":"                                    \u0027listener\u0027: None,"},{"line_number":307,"context_line":"                                    \u0027redirect_pool\u0027: None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_d47c86ec","line":304,"updated":"2018-09-19 00:52:21.000000000","message":"This is wrong? I think maybe you just did a copy/paste and forgot to fix it, but IIRC this should be like \u0027https://example.com\u0027?","commit_id":"8d621b7606d07415a23dffc7c09567c791dc3d4a"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"150144af7b7246f14899d123b3c660c39d46dba5","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                                        \u0027position\u0027: 1,"},{"line_number":334,"context_line":"                                        \u0027redirect_pool_id\u0027: self.pool1_id,"},{"line_number":335,"context_line":"                                        \u0027redirect_url\u0027: \u0027/index.html\u0027,"},{"line_number":336,"context_line":"                                        \u0027redirect_prefix\u0027: \u0027/index.html\u0027,"},{"line_number":337,"context_line":"                                        \u0027rules\u0027: self.provider_l7rules_dicts}"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        self.provider_l7policy2_dict \u003d copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_747d72e4","line":336,"updated":"2018-09-19 00:52:21.000000000","message":"Same","commit_id":"8d621b7606d07415a23dffc7c09567c791dc3d4a"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"469f3860fdad56cbef95ac8e00bead7802b833ca","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                                    \u0027action\u0027: \u0027go\u0027,"},{"line_number":302,"context_line":"                                    \u0027redirect_pool_id\u0027: self.pool1_id,"},{"line_number":303,"context_line":"                                    \u0027redirect_url\u0027: \u0027/index.html\u0027,"},{"line_number":304,"context_line":"                                    \u0027redirect_prefix\u0027: \u0027https:///example.com/\u0027,"},{"line_number":305,"context_line":"                                    \u0027position\u0027: 1,"},{"line_number":306,"context_line":"                                    \u0027listener\u0027: None,"},{"line_number":307,"context_line":"                                    \u0027redirect_pool\u0027: None,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_6fcb5f1c","line":304,"updated":"2018-09-19 02:05:29.000000000","message":"Is that an extra slash?","commit_id":"dd5ab8e47bea03455371e7ca9a6ffc44c75b4e24"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"469f3860fdad56cbef95ac8e00bead7802b833ca","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                                        \u0027position\u0027: 1,"},{"line_number":334,"context_line":"                                        \u0027redirect_pool_id\u0027: self.pool1_id,"},{"line_number":335,"context_line":"                                        \u0027redirect_url\u0027: \u0027/index.html\u0027,"},{"line_number":336,"context_line":"                                        \u0027redirect_prefix\u0027: \u0027https:///example.com/\u0027,"},{"line_number":337,"context_line":"                                        \u0027rules\u0027: self.provider_l7rules_dicts}"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        self.provider_l7policy2_dict \u003d copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_2fd9e7f2","line":336,"updated":"2018-09-19 02:05:29.000000000","message":"Same :P","commit_id":"dd5ab8e47bea03455371e7ca9a6ffc44c75b4e24"}],"octavia/tests/unit/common/jinja/haproxy/test_jinja_cfg.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"150144af7b7246f14899d123b3c660c39d46dba5","unresolved":false,"context_lines":[{"line_number":610,"context_line":"              \".example.com\\n\""},{"line_number":611,"context_line":"              \"    http-request deny if sample_l7rule_id_4 \""},{"line_number":612,"context_line":"              \"sample_l7rule_id_5\\n\""},{"line_number":613,"context_line":"              \"        acl sample_l7rule_id_2 req.hdr(Some-header) -m sub \""},{"line_number":614,"context_line":"              \"This\\\\ string\\\\\\\\\\\\ with\\\\ stuff\\n\""},{"line_number":615,"context_line":"              \"        acl sample_l7rule_id_3 req.cook(some-cookie) -m reg \""},{"line_number":616,"context_line":"              \"this.*|that\\n\""},{"line_number":617,"context_line":"              \"    redirect prefix https://example.com if \""},{"line_number":618,"context_line":"              \"!sample_l7rule_id_2 sample_l7rule_id_3\\n\""},{"line_number":619,"context_line":"              \"    default_backend sample_pool_id_1\\n\""},{"line_number":620,"context_line":"              \"    timeout client 50000\\n\\n\").format("},{"line_number":621,"context_line":"            maxconn\u003dconstants.HAPROXY_MAX_MAXCONN)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_f470a20b","line":618,"range":{"start_line":613,"start_character":14,"end_line":618,"end_character":56},"updated":"2018-09-19 00:52:21.000000000","message":"How is this related? Not sure how this was needed suddenly. I\u0027d like to understand if our tests were not working correctly before (or still aren\u0027t)?","commit_id":"8d621b7606d07415a23dffc7c09567c791dc3d4a"},{"author":{"_account_id":27488,"name":"sapd","email":"saphi070@gmail.com","username":"sapd"},"change_message_id":"ed8c1f4f069a3b8b8f2abd95e6a2f96b672cb2a4","unresolved":false,"context_lines":[{"line_number":610,"context_line":"              \".example.com\\n\""},{"line_number":611,"context_line":"              \"    http-request deny if sample_l7rule_id_4 \""},{"line_number":612,"context_line":"              \"sample_l7rule_id_5\\n\""},{"line_number":613,"context_line":"              \"        acl sample_l7rule_id_2 req.hdr(Some-header) -m sub \""},{"line_number":614,"context_line":"              \"This\\\\ string\\\\\\\\\\\\ with\\\\ stuff\\n\""},{"line_number":615,"context_line":"              \"        acl sample_l7rule_id_3 req.cook(some-cookie) -m reg \""},{"line_number":616,"context_line":"              \"this.*|that\\n\""},{"line_number":617,"context_line":"              \"    redirect prefix https://example.com if \""},{"line_number":618,"context_line":"              \"!sample_l7rule_id_2 sample_l7rule_id_3\\n\""},{"line_number":619,"context_line":"              \"    default_backend sample_pool_id_1\\n\""},{"line_number":620,"context_line":"              \"    timeout client 50000\\n\\n\").format("},{"line_number":621,"context_line":"            maxconn\u003dconstants.HAPROXY_MAX_MAXCONN)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_ef420fac","line":618,"range":{"start_line":613,"start_character":14,"end_line":618,"end_character":56},"in_reply_to":"3f79a3b5_f470a20b","updated":"2018-09-19 01:57:31.000000000","message":"Because I added a new l7 policy for this listener, So It will have to generate new block for that l7 policy.","commit_id":"8d621b7606d07415a23dffc7c09567c791dc3d4a"}],"octavia/tests/unit/common/sample_configs/sample_configs.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"150144af7b7246f14899d123b3c660c39d46dba5","unresolved":false,"context_lines":[{"line_number":754,"context_line":"                          enabled\u003dTrue, sample_policy\u003d1):"},{"line_number":755,"context_line":"    in_l7policy \u003d collections.namedtuple(\u0027l7policy\u0027,"},{"line_number":756,"context_line":"                                         \u0027id, action, redirect_pool, \u0027"},{"line_number":757,"context_line":"                                         \u0027redirect_prefix, \u0027"},{"line_number":758,"context_line":"                                         \u0027redirect_url, l7rules, enabled\u0027)"},{"line_number":759,"context_line":"    l7rules \u003d []"},{"line_number":760,"context_line":"    if sample_policy \u003d\u003d 1:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_945b6e84","line":757,"updated":"2018-09-19 00:52:21.000000000","message":"order matters in a namedtuple -- this doesn\u0027t look like the correct ordering, you inserted it one place early compared to how you use it below","commit_id":"8d621b7606d07415a23dffc7c09567c791dc3d4a"}]}