)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  description: |"},{"line_number":226,"context_line":"    The URI of the `key manager service"},{"line_number":227,"context_line":"    \u003chttps://docs.openstack.org/castellan/latest/\u003e`__ secret containing a"},{"line_number":228,"context_line":"    PKCS12 format CA certificate/key bundle for ``TERMINATED_TLS`` listeners."},{"line_number":229,"context_line":"  in: body"},{"line_number":230,"context_line":"  required: true"},{"line_number":231,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fdfeff1_337d10b2","line":228,"updated":"2019-02-12 04:17:34.000000000","message":"We only need the client CA cert right?","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  description: |"},{"line_number":226,"context_line":"    The URI of the `key manager service"},{"line_number":227,"context_line":"    \u003chttps://docs.openstack.org/castellan/latest/\u003e`__ secret containing a"},{"line_number":228,"context_line":"    PKCS12 format CA certificate/key bundle for ``TERMINATED_TLS`` listeners."},{"line_number":229,"context_line":"  in: body"},{"line_number":230,"context_line":"  required: true"},{"line_number":231,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fdfeff1_6e2078ad","line":228,"in_reply_to":"9fdfeff1_337d10b2","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  description: |"},{"line_number":226,"context_line":"    The URI of the `key manager service"},{"line_number":227,"context_line":"    \u003chttps://docs.openstack.org/castellan/latest/\u003e`__ secret containing a"},{"line_number":228,"context_line":"    PKCS12 format CA certificate/key bundle for ``TERMINATED_TLS`` listeners."},{"line_number":229,"context_line":"  in: body"},{"line_number":230,"context_line":"  required: true"},{"line_number":231,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fdfeff1_49b9eec9","line":228,"in_reply_to":"9fdfeff1_337d10b2","updated":"2019-02-13 02:33:30.000000000","message":"Yeah, but we need the p12 format cert with cmd \"\nopenssl pkcs12 -export -clcerts -inkey ca.key -in ca.crt -out ca.p12\" to use the existing p12 code.. So you suggest that we need a new one just accept the ca cert like the following crl file which is not encrpted? Right?","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":233,"context_line":"  description: |"},{"line_number":234,"context_line":"    The URI of the `key manager service"},{"line_number":235,"context_line":"    \u003chttps://docs.openstack.org/castellan/latest/\u003e`__ secret containing a"},{"line_number":236,"context_line":"    PKCS12 format CA certificate/key bundle for ``TERMINATED_TLS`` listeners."},{"line_number":237,"context_line":"  in: body"},{"line_number":238,"context_line":"  required: false"},{"line_number":239,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fdfeff1_537a14ba","line":236,"updated":"2019-02-12 04:17:34.000000000","message":"Same, don\u0027t think we need a key.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":233,"context_line":"  description: |"},{"line_number":234,"context_line":"    The URI of the `key manager service"},{"line_number":235,"context_line":"    \u003chttps://docs.openstack.org/castellan/latest/\u003e`__ secret containing a"},{"line_number":236,"context_line":"    PKCS12 format CA certificate/key bundle for ``TERMINATED_TLS`` listeners."},{"line_number":237,"context_line":"  in: body"},{"line_number":238,"context_line":"  required: false"},{"line_number":239,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fdfeff1_0e11ac5d","line":236,"in_reply_to":"9fdfeff1_537a14ba","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":233,"context_line":"  description: |"},{"line_number":234,"context_line":"    The URI of the `key manager service"},{"line_number":235,"context_line":"    \u003chttps://docs.openstack.org/castellan/latest/\u003e`__ secret containing a"},{"line_number":236,"context_line":"    PKCS12 format CA certificate/key bundle for ``TERMINATED_TLS`` listeners."},{"line_number":237,"context_line":"  in: body"},{"line_number":238,"context_line":"  required: false"},{"line_number":239,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fdfeff1_09af667d","line":236,"in_reply_to":"9fdfeff1_537a14ba","updated":"2019-02-13 02:33:30.000000000","message":"Seems need to discuss with you. ;-)","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"api-ref/source/v2/examples/loadbalancer-create-curl":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X POST -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"loadbalancer\": {\"description\": \"My favorite load balancer\", \"admin_state_up\": true, \"project_id\": \"e3cd678b11784734bc366148aa37580e\", \"flavor_id\": \"a7ae5d5a-d855-4f9a-b187-af66b53f4d04\", \"vip_subnet_id\": \"d4af86e1-0051-488c-b7a0-527f97490c9a\", \"vip_address\": \"203.0.113.50\", \"provider\": \"octavia\", \"name\": \"best_load_balancer\", \"vip_qos_policy_id\": \"ec4f78ca-8da8-4e99-8a1a-e3b94595a7a3\", \"tags\": [\"test_tag\"]}, \"client_ca_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/35649991-49f3-4625-81ce-2465fe8932e5\"}\u0027 http://198.51.100.10:9876/v2/lbaas/loadbalancers"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9fdfeff1_b310205b","line":1,"updated":"2019-02-12 04:17:34.000000000","message":"This is wrong. load balancer should not have a client CA cert.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X POST -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"loadbalancer\": {\"description\": \"My favorite load balancer\", \"admin_state_up\": true, \"project_id\": \"e3cd678b11784734bc366148aa37580e\", \"flavor_id\": \"a7ae5d5a-d855-4f9a-b187-af66b53f4d04\", \"vip_subnet_id\": \"d4af86e1-0051-488c-b7a0-527f97490c9a\", \"vip_address\": \"203.0.113.50\", \"provider\": \"octavia\", \"name\": \"best_load_balancer\", \"vip_qos_policy_id\": \"ec4f78ca-8da8-4e99-8a1a-e3b94595a7a3\", \"tags\": [\"test_tag\"]}, \"client_ca_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/35649991-49f3-4625-81ce-2465fe8932e5\"}\u0027 http://198.51.100.10:9876/v2/lbaas/loadbalancers"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9fdfeff1_ae018008","line":1,"in_reply_to":"9fdfeff1_b310205b","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X POST -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"loadbalancer\": {\"description\": \"My favorite load balancer\", \"admin_state_up\": true, \"project_id\": \"e3cd678b11784734bc366148aa37580e\", \"flavor_id\": \"a7ae5d5a-d855-4f9a-b187-af66b53f4d04\", \"vip_subnet_id\": \"d4af86e1-0051-488c-b7a0-527f97490c9a\", \"vip_address\": \"203.0.113.50\", \"provider\": \"octavia\", \"name\": \"best_load_balancer\", \"vip_qos_policy_id\": \"ec4f78ca-8da8-4e99-8a1a-e3b94595a7a3\", \"tags\": [\"test_tag\"]}, \"client_ca_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/35649991-49f3-4625-81ce-2465fe8932e5\"}\u0027 http://198.51.100.10:9876/v2/lbaas/loadbalancers"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9fdfeff1_c9ccfe6b","line":1,"in_reply_to":"9fdfeff1_b310205b","updated":"2019-02-13 02:33:30.000000000","message":"Yeah, Thanks for correct.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"octavia/amphorae/backends/agent/api_server/listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        stream \u003d Wrapped(flask.request.stream)"},{"line_number":428,"context_line":"        file \u003d self._cert_file_path(listener_id, filename)"},{"line_number":429,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":430,"context_line":"            if not os.path.exists(self._cert_ca_dir(listener_id)):"},{"line_number":431,"context_line":"                os.makedirs(self._cert_ca_dir(listener_id))"},{"line_number":432,"context_line":"            file \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":433,"context_line":"        flags \u003d os.O_WRONLY | os.O_CREAT"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_8e3e13b6","line":430,"updated":"2019-02-12 04:17:34.000000000","message":"Should just make the directory and try/catch if necessary.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        stream \u003d Wrapped(flask.request.stream)"},{"line_number":428,"context_line":"        file \u003d self._cert_file_path(listener_id, filename)"},{"line_number":429,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":430,"context_line":"            if not os.path.exists(self._cert_ca_dir(listener_id)):"},{"line_number":431,"context_line":"                os.makedirs(self._cert_ca_dir(listener_id))"},{"line_number":432,"context_line":"            file \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":433,"context_line":"        flags \u003d os.O_WRONLY | os.O_CREAT"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_69a152f8","line":430,"in_reply_to":"9fdfeff1_8e3e13b6","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        stream \u003d Wrapped(flask.request.stream)"},{"line_number":428,"context_line":"        file \u003d self._cert_file_path(listener_id, filename)"},{"line_number":429,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":430,"context_line":"            if not os.path.exists(self._cert_ca_dir(listener_id)):"},{"line_number":431,"context_line":"                os.makedirs(self._cert_ca_dir(listener_id))"},{"line_number":432,"context_line":"            file \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":433,"context_line":"        flags \u003d os.O_WRONLY | os.O_CREAT"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_89c27633","line":430,"in_reply_to":"9fdfeff1_8e3e13b6","updated":"2019-02-13 02:33:30.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        file \u003d self._cert_file_path(listener_id, filename)"},{"line_number":429,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":430,"context_line":"            if not os.path.exists(self._cert_ca_dir(listener_id)):"},{"line_number":431,"context_line":"                os.makedirs(self._cert_ca_dir(listener_id))"},{"line_number":432,"context_line":"            file \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":433,"context_line":"        flags \u003d os.O_WRONLY | os.O_CREAT"},{"line_number":434,"context_line":"        # mode 00600"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_0e7c6381","line":431,"updated":"2019-02-12 04:17:34.000000000","message":"Why can\u0027t we use the self._cert_dir directory? As long as we manage the filenames, we should be able to use the same directory.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        file \u003d self._cert_file_path(listener_id, filename)"},{"line_number":429,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":430,"context_line":"            if not os.path.exists(self._cert_ca_dir(listener_id)):"},{"line_number":431,"context_line":"                os.makedirs(self._cert_ca_dir(listener_id))"},{"line_number":432,"context_line":"            file \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":433,"context_line":"        flags \u003d os.O_WRONLY | os.O_CREAT"},{"line_number":434,"context_line":"        # mode 00600"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_891ef6b8","line":431,"in_reply_to":"9fdfeff1_0e7c6381","updated":"2019-02-13 02:33:30.000000000","message":"Because there are so many certs in the cert_dir, and in the following we will introduce the pool cert part, currently there will be multiple listener certs in the cert dir, and we store and named them with the base64 format name, it\u0027s hard to know which cert would be changed/deleted when we hit the error or check if there are any certs left after we delete something. So I introduce some new directories:\nlike \"listener_id/ca\" for client ca certification\n\"listener_id/crl\" for client ca certification revocation list\n\"listener_id/backend_certs\" for backend reencrption\n\"listener_id/backend_certs/pool_id/ca\" for backend server ca cert\n\"listener_id/backend_certs/pool_id/crl\" for backend server revocation list.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        file \u003d self._cert_file_path(listener_id, filename)"},{"line_number":429,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":430,"context_line":"            if not os.path.exists(self._cert_ca_dir(listener_id)):"},{"line_number":431,"context_line":"                os.makedirs(self._cert_ca_dir(listener_id))"},{"line_number":432,"context_line":"            file \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":433,"context_line":"        flags \u003d os.O_WRONLY | os.O_CREAT"},{"line_number":434,"context_line":"        # mode 00600"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_09a206fd","line":431,"in_reply_to":"9fdfeff1_0e7c6381","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        cert_path \u003d self._cert_file_path(listener_id, filename)"},{"line_number":450,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":451,"context_line":"            cert_path \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":452,"context_line":"        path_exists \u003d os.path.exists(cert_path)"},{"line_number":453,"context_line":"        if not path_exists:"},{"line_number":454,"context_line":"            return webob.Response(json\u003ddict("}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_8e67f3e9","line":451,"updated":"2019-02-12 04:17:34.000000000","message":"Same, here, if we just use the same directory, we don\u0027t need to make this method special.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        cert_path \u003d self._cert_file_path(listener_id, filename)"},{"line_number":450,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":451,"context_line":"            cert_path \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":452,"context_line":"        path_exists \u003d os.path.exists(cert_path)"},{"line_number":453,"context_line":"        if not path_exists:"},{"line_number":454,"context_line":"            return webob.Response(json\u003ddict("}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_e96a2218","line":451,"in_reply_to":"9fdfeff1_8e67f3e9","updated":"2019-02-13 02:33:30.000000000","message":"Considering","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        cert_path \u003d self._cert_file_path(listener_id, filename)"},{"line_number":450,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":451,"context_line":"            cert_path \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":452,"context_line":"        path_exists \u003d os.path.exists(cert_path)"},{"line_number":453,"context_line":"        if not path_exists:"},{"line_number":454,"context_line":"            return webob.Response(json\u003ddict("}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_29726aae","line":451,"in_reply_to":"9fdfeff1_8e67f3e9","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":470,"context_line":"            file_path \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":471,"context_line":"        if os.path.exists(file_path):"},{"line_number":472,"context_line":"            os.remove(file_path)"},{"line_number":473,"context_line":"        return webob.Response(json\u003ddict(message\u003d\u0027OK\u0027))"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def _check_listener_status(self, listener_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_ee9b1fc6","line":472,"updated":"2019-02-12 04:17:34.000000000","message":"Same, don\u0027t think we need this. Should just be able to make this a unique filename.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":470,"context_line":"            file_path \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":471,"context_line":"        if os.path.exists(file_path):"},{"line_number":472,"context_line":"            os.remove(file_path)"},{"line_number":473,"context_line":"        return webob.Response(json\u003ddict(message\u003d\u0027OK\u0027))"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def _check_listener_status(self, listener_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_89735616","line":472,"in_reply_to":"9fdfeff1_ee9b1fc6","updated":"2019-02-13 02:33:30.000000000","message":"Considering","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        if filename.startswith(\u0027client_ca\u0027):"},{"line_number":470,"context_line":"            file_path \u003d self._cert_ca_file_path(listener_id, filename)"},{"line_number":471,"context_line":"        if os.path.exists(file_path):"},{"line_number":472,"context_line":"            os.remove(file_path)"},{"line_number":473,"context_line":"        return webob.Response(json\u003ddict(message\u003d\u0027OK\u0027))"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def _check_listener_status(self, listener_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_096d26cb","line":472,"in_reply_to":"9fdfeff1_ee9b1fc6","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        return os.path.join(util.CONF.haproxy_amphora.base_cert_dir,"},{"line_number":533,"context_line":"                            listener_id)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def _cert_ca_dir(self, listener_id):"},{"line_number":536,"context_line":"        return os.path.join(util.CONF.haproxy_amphora.base_cert_dir,"},{"line_number":537,"context_line":"                            listener_id, \u0027ca\u0027)"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_ae7af773","line":535,"updated":"2019-02-12 04:17:34.000000000","message":"Should not need this.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        return os.path.join(util.CONF.haproxy_amphora.base_cert_dir,"},{"line_number":533,"context_line":"                            listener_id)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def _cert_ca_dir(self, listener_id):"},{"line_number":536,"context_line":"        return os.path.join(util.CONF.haproxy_amphora.base_cert_dir,"},{"line_number":537,"context_line":"                            listener_id, \u0027ca\u0027)"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_49632e43","line":535,"in_reply_to":"9fdfeff1_ae7af773","updated":"2019-02-13 02:33:30.000000000","message":"Considering","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        return os.path.join(util.CONF.haproxy_amphora.base_cert_dir,"},{"line_number":533,"context_line":"                            listener_id)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def _cert_ca_dir(self, listener_id):"},{"line_number":536,"context_line":"        return os.path.join(util.CONF.haproxy_amphora.base_cert_dir,"},{"line_number":537,"context_line":"                            listener_id, \u0027ca\u0027)"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_697cf282","line":535,"in_reply_to":"9fdfeff1_ae7af773","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":539,"context_line":"    def _cert_file_path(self, listener_id, filename):"},{"line_number":540,"context_line":"        return os.path.join(self._cert_dir(listener_id), filename)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def _cert_ca_file_path(self, listener_id, filename):"},{"line_number":543,"context_line":"        return os.path.join(self._cert_ca_dir(listener_id), filename)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    def vrrp_check_script_update(self, listener_id, action):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_ce7f3b64","line":542,"updated":"2019-02-12 04:17:34.000000000","message":"Should not need this.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":539,"context_line":"    def _cert_file_path(self, listener_id, filename):"},{"line_number":540,"context_line":"        return os.path.join(self._cert_dir(listener_id), filename)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def _cert_ca_file_path(self, listener_id, filename):"},{"line_number":543,"context_line":"        return os.path.join(self._cert_ca_dir(listener_id), filename)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    def vrrp_check_script_update(self, listener_id, action):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_6968721c","line":542,"in_reply_to":"9fdfeff1_ce7f3b64","updated":"2019-02-13 02:33:30.000000000","message":"Considering","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":539,"context_line":"    def _cert_file_path(self, listener_id, filename):"},{"line_number":540,"context_line":"        return os.path.join(self._cert_dir(listener_id), filename)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def _cert_ca_file_path(self, listener_id, filename):"},{"line_number":543,"context_line":"        return os.path.join(self._cert_ca_dir(listener_id), filename)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    def vrrp_check_script_update(self, listener_id, action):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_4977aea1","line":542,"in_reply_to":"9fdfeff1_ce7f3b64","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            md5 \u003d hashlib.md5(pem).hexdigest()  # nosec"},{"line_number":281,"context_line":"            name \u003d \u0027{id}.pem\u0027.format(id\u003dcert.id)"},{"line_number":282,"context_line":"            if index \u003e len(sni_certs) and client_ca_cert:"},{"line_number":283,"context_line":"                name \u003d \u0027client_ca_{id}.pem\u0027.format(id\u003dcert.id)"},{"line_number":284,"context_line":"            self._apply(self._upload_cert, listener, None, pem, md5, name)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return {\u0027tls_cert\u0027: tls_cert, \u0027sni_certs\u0027: sni_certs,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_cecdfbb7","line":283,"updated":"2019-02-12 04:17:34.000000000","message":"We should not need this prefix. The old way of naming the certs should be fine.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            md5 \u003d hashlib.md5(pem).hexdigest()  # nosec"},{"line_number":281,"context_line":"            name \u003d \u0027{id}.pem\u0027.format(id\u003dcert.id)"},{"line_number":282,"context_line":"            if index \u003e len(sni_certs) and client_ca_cert:"},{"line_number":283,"context_line":"                name \u003d \u0027client_ca_{id}.pem\u0027.format(id\u003dcert.id)"},{"line_number":284,"context_line":"            self._apply(self._upload_cert, listener, None, pem, md5, name)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return {\u0027tls_cert\u0027: tls_cert, \u0027sni_certs\u0027: sni_certs,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_898ef676","line":283,"in_reply_to":"9fdfeff1_cecdfbb7","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            md5 \u003d hashlib.md5(pem).hexdigest()  # nosec"},{"line_number":281,"context_line":"            name \u003d \u0027{id}.pem\u0027.format(id\u003dcert.id)"},{"line_number":282,"context_line":"            if index \u003e len(sni_certs) and client_ca_cert:"},{"line_number":283,"context_line":"                name \u003d \u0027client_ca_{id}.pem\u0027.format(id\u003dcert.id)"},{"line_number":284,"context_line":"            self._apply(self._upload_cert, listener, None, pem, md5, name)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return {\u0027tls_cert\u0027: tls_cert, \u0027sni_certs\u0027: sni_certs,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_e4100951","line":283,"in_reply_to":"9fdfeff1_cecdfbb7","updated":"2019-02-13 02:33:30.000000000","message":"This prefix is used by split the existing certs and the new client ca cert to different directories. Also genarate the haproxy conf file should be based on that..","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"octavia/api/drivers/utils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        listener_dict[\u0027sni_containers\u0027] \u003d listener_dict.pop("},{"line_number":167,"context_line":"            \u0027sni_container_refs\u0027)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    # TODO(bzhao) add these new fields into provider doc"},{"line_number":170,"context_line":"    if \u0027client_ca_tls_certificate_id\u0027 in new_listener_dict:"},{"line_number":171,"context_line":"        client_ca_tls_container_ref \u003d new_listener_dict.pop("},{"line_number":172,"context_line":"            \u0027client_ca_tls_certificate_id\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_0e3d438e","line":169,"updated":"2019-02-12 04:17:34.000000000","message":"yes, we should do that in this patch.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        listener_dict[\u0027sni_containers\u0027] \u003d listener_dict.pop("},{"line_number":167,"context_line":"            \u0027sni_container_refs\u0027)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    # TODO(bzhao) add these new fields into provider doc"},{"line_number":170,"context_line":"    if \u0027client_ca_tls_certificate_id\u0027 in new_listener_dict:"},{"line_number":171,"context_line":"        client_ca_tls_container_ref \u003d new_listener_dict.pop("},{"line_number":172,"context_line":"            \u0027client_ca_tls_certificate_id\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_492fae3e","line":169,"in_reply_to":"9fdfeff1_0e3d438e","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    if \u0027client_ca_tls_certificate_id\u0027 in new_listener_dict:"},{"line_number":171,"context_line":"        client_ca_tls_container_ref \u003d new_listener_dict.pop("},{"line_number":172,"context_line":"            \u0027client_ca_tls_certificate_id\u0027)"},{"line_number":173,"context_line":"        if isinstance(client_ca_tls_container_ref, dict):"},{"line_number":174,"context_line":"            client_ca_tls_container_ref \u003d client_ca_tls_container_ref.get("},{"line_number":175,"context_line":"                \u0027tls_container_id\u0027)"},{"line_number":176,"context_line":"            new_listener_dict["}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_904cdbc8","line":173,"updated":"2019-02-12 23:09:56.000000000","message":"Why would this ever be a dict?","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    if \u0027client_ca_tls_certificate_id\u0027 in new_listener_dict:"},{"line_number":171,"context_line":"        client_ca_tls_container_ref \u003d new_listener_dict.pop("},{"line_number":172,"context_line":"            \u0027client_ca_tls_certificate_id\u0027)"},{"line_number":173,"context_line":"        if isinstance(client_ca_tls_container_ref, dict):"},{"line_number":174,"context_line":"            client_ca_tls_container_ref \u003d client_ca_tls_container_ref.get("},{"line_number":175,"context_line":"                \u0027tls_container_id\u0027)"},{"line_number":176,"context_line":"            new_listener_dict["}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_8974b637","line":173,"in_reply_to":"9fdfeff1_904cdbc8","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                **listener_obj.client_ca_tls_certificate_id)"},{"line_number":206,"context_line":"        elif listener_obj.client_ca_tls_certificate_id and isinstance("},{"line_number":207,"context_line":"                listener_obj.client_ca_tls_certificate_id, six.string_types):"},{"line_number":208,"context_line":"            cert_obj \u003d data_models.Certification("},{"line_number":209,"context_line":"                listener_id\u003dlistener_obj.id,"},{"line_number":210,"context_line":"                tls_container_id\u003dlistener_obj.client_ca_tls_certificate_id)"},{"line_number":211,"context_line":"        listener_obj.client_ca_tls_certificate_id \u003d cert_obj"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_8e48532d","line":208,"range":{"start_line":208,"start_character":35,"end_line":208,"end_character":48},"updated":"2019-02-12 04:17:34.000000000","message":"We should re-word this. Maybe we don\u0027t need it, maybe we can use an existing model.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                **listener_obj.client_ca_tls_certificate_id)"},{"line_number":206,"context_line":"        elif listener_obj.client_ca_tls_certificate_id and isinstance("},{"line_number":207,"context_line":"                listener_obj.client_ca_tls_certificate_id, six.string_types):"},{"line_number":208,"context_line":"            cert_obj \u003d data_models.Certification("},{"line_number":209,"context_line":"                listener_id\u003dlistener_obj.id,"},{"line_number":210,"context_line":"                tls_container_id\u003dlistener_obj.client_ca_tls_certificate_id)"},{"line_number":211,"context_line":"        listener_obj.client_ca_tls_certificate_id \u003d cert_obj"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_a9717a46","line":208,"range":{"start_line":208,"start_character":35,"end_line":208,"end_character":48},"in_reply_to":"9fdfeff1_8e48532d","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"octavia/api/v2/controllers/listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        if bad_refs:"},{"line_number":141,"context_line":"            raise exceptions.CertificateRetrievalException(ref\u003dbad_refs)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _validate_create_listener(self, lock_session, listener_dict):"},{"line_number":144,"context_line":"        \"\"\"Validate listener for wrong protocol or duplicate listeners"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Update the load balancer db when provisioning status changes."}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_b316c948","line":143,"updated":"2019-02-12 23:09:56.000000000","message":"We need to validate that a main TLS cert is specified before accepting a client ca cert right?","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        if bad_refs:"},{"line_number":141,"context_line":"            raise exceptions.CertificateRetrievalException(ref\u003dbad_refs)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _validate_create_listener(self, lock_session, listener_dict):"},{"line_number":144,"context_line":"        \"\"\"Validate listener for wrong protocol or duplicate listeners"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Update the load balancer db when provisioning status changes."}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_494d6e98","line":143,"in_reply_to":"9fdfeff1_b316c948","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        if bad_refs:"},{"line_number":141,"context_line":"            raise exceptions.CertificateRetrievalException(ref\u003dbad_refs)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _validate_create_listener(self, lock_session, listener_dict):"},{"line_number":144,"context_line":"        \"\"\"Validate listener for wrong protocol or duplicate listeners"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Update the load balancer db when provisioning status changes."}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_49648e22","line":143,"in_reply_to":"9fdfeff1_b316c948","updated":"2019-02-13 02:33:30.000000000","message":"Yeah, make sense, this just available after setting TLS cert for https 2-side cert validation.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        tls_refs \u003d [sni for sni in sni_containers]"},{"line_number":346,"context_line":"        if listener.default_tls_container_ref:"},{"line_number":347,"context_line":"            tls_refs.append(listener.default_tls_container_ref)"},{"line_number":348,"context_line":"        if listener.client_ca_tls_container_ref:"},{"line_number":349,"context_line":"            tls_refs.append(listener.client_ca_tls_container_ref)"},{"line_number":350,"context_line":"        self._validate_tls_refs(tls_refs)"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_53299d87","line":348,"updated":"2019-02-12 23:09:56.000000000","message":"We need to validate that the listener has a TLS cert before allowing a client CA cert.\nSame, should check that the listener type is terminated TLS...","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        tls_refs \u003d [sni for sni in sni_containers]"},{"line_number":346,"context_line":"        if listener.default_tls_container_ref:"},{"line_number":347,"context_line":"            tls_refs.append(listener.default_tls_container_ref)"},{"line_number":348,"context_line":"        if listener.client_ca_tls_container_ref:"},{"line_number":349,"context_line":"            tls_refs.append(listener.client_ca_tls_container_ref)"},{"line_number":350,"context_line":"        self._validate_tls_refs(tls_refs)"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_696952f7","line":348,"in_reply_to":"9fdfeff1_53299d87","updated":"2019-02-13 02:33:30.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        tls_refs \u003d [sni for sni in sni_containers]"},{"line_number":346,"context_line":"        if listener.default_tls_container_ref:"},{"line_number":347,"context_line":"            tls_refs.append(listener.default_tls_container_ref)"},{"line_number":348,"context_line":"        if listener.client_ca_tls_container_ref:"},{"line_number":349,"context_line":"            tls_refs.append(listener.client_ca_tls_container_ref)"},{"line_number":350,"context_line":"        self._validate_tls_refs(tls_refs)"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_e43c8930","line":348,"in_reply_to":"9fdfeff1_53299d87","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1a8423030b71bfb8c07f9afed23931be8fece11c","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                \"be provided for %s protocol listeners.\") %"},{"line_number":195,"context_line":"                constants.PROTOCOL_TERMINATED_HTTPS)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # Make sure a base certificate exists if specifying a client ca"},{"line_number":198,"context_line":"        if (listener_dict.get(\u0027client_ca_tls_container_ref\u0027) and"},{"line_number":199,"context_line":"            not (listener_dict.get(\u0027tls_certificate_id\u0027) or"},{"line_number":200,"context_line":"                 listener_dict.get(\u0027sni_containers\u0027))):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_ac96353d","line":197,"updated":"2019-02-15 01:52:02.000000000","message":"unit test branch missing","commit_id":"717a5da04b160fce7c7caa6528ee6b883eab910e"}],"octavia/api/v2/types/listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            sni_c.tls_container_id for sni_c in data_model.sni_containers]"},{"line_number":67,"context_line":"        if data_model.client_ca_tls_certificate_id:"},{"line_number":68,"context_line":"            listener.client_ca_tls_container_ref \u003d ("},{"line_number":69,"context_line":"                data_model.client_ca_tls_certificate_id.tls_container_id)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            listener.client_ca_tls_container_ref \u003d None"},{"line_number":72,"context_line":"        if cls._full_response():"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_907dbbb3","line":69,"updated":"2019-02-12 23:09:56.000000000","message":"This should not be necessary since it is just an ID.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            sni_c.tls_container_id for sni_c in data_model.sni_containers]"},{"line_number":67,"context_line":"        if data_model.client_ca_tls_certificate_id:"},{"line_number":68,"context_line":"            listener.client_ca_tls_container_ref \u003d ("},{"line_number":69,"context_line":"                data_model.client_ca_tls_certificate_id.tls_container_id)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            listener.client_ca_tls_container_ref \u003d None"},{"line_number":72,"context_line":"        if cls._full_response():"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_ffef301a","line":69,"in_reply_to":"9fdfeff1_907dbbb3","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            sni_c.tls_container_id for sni_c in data_model.sni_containers]"},{"line_number":67,"context_line":"        if data_model.client_ca_tls_certificate_id:"},{"line_number":68,"context_line":"            listener.client_ca_tls_container_ref \u003d ("},{"line_number":69,"context_line":"                data_model.client_ca_tls_certificate_id.tls_container_id)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            listener.client_ca_tls_container_ref \u003d None"},{"line_number":72,"context_line":"        if cls._full_response():"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_49324e12","line":69,"in_reply_to":"9fdfeff1_907dbbb3","updated":"2019-02-13 02:33:30.000000000","message":"Yeah, that\u0027s just an ID, but for the whole encryption-reencyption function, they seem like the same functioon and models, so I introduce a new model for listener and pool for support this, not add many new columes(duplicated) in the existing db tables \"listeners\" and \"pools\". Ehhh, I don\u0027t want to make this difficult, but just feel if I do this way, our community experts can accept easier. ;P\nAlso the data model will be the same as the definition as the \"client_ca_tls_certificate_id\" is just a reference from table/model \"Certification\".","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"octavia/common/data_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3764da29efeb9f25932620106a2184069a0de5b8","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        self.tls_container_id \u003d tls_container_id"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"class Certification(BaseDataModel):"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def __init__(self, id\u003dNone, listener_id\u003dNone, pool_id\u003dNone,"},{"line_number":514,"context_line":"                 tls_container_id\u003dNone, listener\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_ae5677cd","line":511,"updated":"2019-02-12 04:17:34.000000000","message":"I think we should be able to use the TLSContainer type.\nWill comment when I finish the review.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        self.tls_container_id \u003d tls_container_id"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"class Certification(BaseDataModel):"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def __init__(self, id\u003dNone, listener_id\u003dNone, pool_id\u003dNone,"},{"line_number":514,"context_line":"                 tls_container_id\u003dNone, listener\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_337f27e0","line":511,"in_reply_to":"9fdfeff1_ae5677cd","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        self.tls_container_id \u003d tls_container_id"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"class Certification(BaseDataModel):"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def __init__(self, id\u003dNone, listener_id\u003dNone, pool_id\u003dNone,"},{"line_number":514,"context_line":"                 tls_container_id\u003dNone, listener\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_892b5693","line":511,"in_reply_to":"9fdfeff1_ae5677cd","updated":"2019-02-13 02:33:30.000000000","message":"Good name. ;-)","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"octavia/common/jinja/haproxy/jinja_cfg.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        if listener.sni_containers:"},{"line_number":237,"context_line":"            ret_value[\u0027crt_dir\u0027] \u003d os.path.join(self.base_crt_dir, listener.id)"},{"line_number":238,"context_line":"        if listener.client_ca_tls_certificate_id:"},{"line_number":239,"context_line":"            ret_value[\u0027client_ca_tls_path\u0027] \u003d \u0027%s/client_ca_%s.pem\u0027 % ("},{"line_number":240,"context_line":"                os.path.join(self.base_crt_dir, listener.id, \u0027ca\u0027),"},{"line_number":241,"context_line":"                client_ca_cert.id)"},{"line_number":242,"context_line":"        if listener.default_pool:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_f02207b9","line":239,"updated":"2019-02-12 23:09:56.000000000","message":"We need to fix this so it doesn\u0027t use a prefix.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        if listener.sni_containers:"},{"line_number":237,"context_line":"            ret_value[\u0027crt_dir\u0027] \u003d os.path.join(self.base_crt_dir, listener.id)"},{"line_number":238,"context_line":"        if listener.client_ca_tls_certificate_id:"},{"line_number":239,"context_line":"            ret_value[\u0027client_ca_tls_path\u0027] \u003d \u0027%s/client_ca_%s.pem\u0027 % ("},{"line_number":240,"context_line":"                os.path.join(self.base_crt_dir, listener.id, \u0027ca\u0027),"},{"line_number":241,"context_line":"                client_ca_cert.id)"},{"line_number":242,"context_line":"        if listener.default_pool:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_8419fd7a","line":239,"in_reply_to":"9fdfeff1_f02207b9","updated":"2019-02-13 02:33:30.000000000","message":"Considering","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"octavia/common/jinja/haproxy/templates/macros.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% macro bind_macro(constants, listener, lb_vip_address) %}"},{"line_number":30,"context_line":"    {% if listener.default_tls_path or listener.client_ca_tls_path %}"},{"line_number":31,"context_line":"        {% set def_opt_prefix \u003d \"ssl\" %}"},{"line_number":32,"context_line":"    {% else %}"},{"line_number":33,"context_line":"        {% set def_opt_prefix \u003d \"\" %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9fdfeff1_9004db19","line":30,"updated":"2019-02-12 23:09:56.000000000","message":"We can\u0027t really support having a client CA cert if we don\u0027t have a TLS cert can we? Does that make sense?","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% macro bind_macro(constants, listener, lb_vip_address) %}"},{"line_number":30,"context_line":"    {% if listener.default_tls_path or listener.client_ca_tls_path %}"},{"line_number":31,"context_line":"        {% set def_opt_prefix \u003d \"ssl\" %}"},{"line_number":32,"context_line":"    {% else %}"},{"line_number":33,"context_line":"        {% set def_opt_prefix \u003d \"\" %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9fdfeff1_937e13e2","line":30,"in_reply_to":"9fdfeff1_9004db19","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% macro bind_macro(constants, listener, lb_vip_address) %}"},{"line_number":30,"context_line":"    {% if listener.default_tls_path or listener.client_ca_tls_path %}"},{"line_number":31,"context_line":"        {% set def_opt_prefix \u003d \"ssl\" %}"},{"line_number":32,"context_line":"    {% else %}"},{"line_number":33,"context_line":"        {% set def_opt_prefix \u003d \"\" %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9fdfeff1_2424d1ae","line":30,"in_reply_to":"9fdfeff1_9004db19","updated":"2019-02-13 02:33:30.000000000","message":"Yeah, you are right. Enable Client ca cert must be after setting TLS cert","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"octavia/common/tls_utils/cert_parser.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1a8423030b71bfb8c07f9afed23931be8fece11c","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                                   check_only\u003dTrue))"},{"line_number":360,"context_line":"            sni_certs.append(cert_container)"},{"line_number":361,"context_line":"    client_ca_cert \u003d None"},{"line_number":362,"context_line":"    if listener.client_ca_tls_certificate_id:"},{"line_number":363,"context_line":"        client_ca_cert \u003d _map_cert_tls_container("},{"line_number":364,"context_line":"            cert_mngr.get_cert("},{"line_number":365,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_ccb299e5","line":362,"updated":"2019-02-15 01:52:02.000000000","message":"Unit test missing branch","commit_id":"717a5da04b160fce7c7caa6528ee6b883eab910e"}],"octavia/db/base_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    obj.listener_id + obj.tls_container_id)"},{"line_number":47,"context_line":"        elif obj.__class__.__name__ in [\u0027Quotas\u0027]:"},{"line_number":48,"context_line":"            return obj.__class__.__name__ + obj.project_id"},{"line_number":49,"context_line":"        elif obj.__class__.__name__ in [\u0027Certification\u0027]:"},{"line_number":50,"context_line":"            return obj.__class__.__name__ + str(obj.id)"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_33df393b","line":49,"updated":"2019-02-12 23:09:56.000000000","message":"I don\u0027t think we need this.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    obj.listener_id + obj.tls_container_id)"},{"line_number":47,"context_line":"        elif obj.__class__.__name__ in [\u0027Quotas\u0027]:"},{"line_number":48,"context_line":"            return obj.__class__.__name__ + obj.project_id"},{"line_number":49,"context_line":"        elif obj.__class__.__name__ in [\u0027Certification\u0027]:"},{"line_number":50,"context_line":"            return obj.__class__.__name__ + str(obj.id)"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_73792ffa","line":49,"in_reply_to":"9fdfeff1_33df393b","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    obj.listener_id + obj.tls_container_id)"},{"line_number":47,"context_line":"        elif obj.__class__.__name__ in [\u0027Quotas\u0027]:"},{"line_number":48,"context_line":"            return obj.__class__.__name__ + obj.project_id"},{"line_number":49,"context_line":"        elif obj.__class__.__name__ in [\u0027Certification\u0027]:"},{"line_number":50,"context_line":"            return obj.__class__.__name__ + str(obj.id)"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_04f0adfc","line":49,"in_reply_to":"9fdfeff1_33df393b","updated":"2019-02-13 02:33:30.000000000","message":"I remember if not do that, will hit error when \"create\" datamodel after post the info to db(calling to_data_model), if not do this, will raise L52...","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"octavia/db/migration/alembic_migrations/versions/2ad093f6353f_add_listener_client_ca_tls_certificate_.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0d575cb4dcfab69dc68c4c72441595b1b1a19a66","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# revision identifiers, used by Alembic."},{"line_number":28,"context_line":"revision \u003d \u00272ad093f6353f\u0027"},{"line_number":29,"context_line":"down_revision \u003d \u0027211982b05afc\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_683b4337","line":29,"updated":"2019-02-15 22:48:55.000000000","message":"This needs to be updated again","commit_id":"717a5da04b160fce7c7caa6528ee6b883eab910e"}],"octavia/db/migration/alembic_migrations/versions/f1ca45e2761c_support_client_certification_authorization.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# revision identifiers, used by Alembic."},{"line_number":29,"context_line":"revision \u003d \u0027f1ca45e2761c\u0027"},{"line_number":30,"context_line":"down_revision \u003d \u00274f65b4f91c39\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_93edc5f1","line":30,"updated":"2019-02-12 23:09:56.000000000","message":"We need to update this","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# revision identifiers, used by Alembic."},{"line_number":29,"context_line":"revision \u003d \u0027f1ca45e2761c\u0027"},{"line_number":30,"context_line":"down_revision \u003d \u00274f65b4f91c39\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_a4e0c127","line":30,"in_reply_to":"9fdfeff1_93edc5f1","updated":"2019-02-13 02:33:30.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# revision identifiers, used by Alembic."},{"line_number":29,"context_line":"revision \u003d \u0027f1ca45e2761c\u0027"},{"line_number":30,"context_line":"down_revision \u003d \u00274f65b4f91c39\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_b31d57bf","line":30,"in_reply_to":"9fdfeff1_93edc5f1","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.create_table("},{"line_number":35,"context_line":"        u\u0027certification\u0027,"},{"line_number":36,"context_line":"        sa.Column(u\u0027id\u0027, sa.Integer(), primary_key\u003dTrue, autoincrement\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(u\u0027listener_id\u0027, sa.String(36), nullable\u003dTrue),"},{"line_number":38,"context_line":"        sa.Column(u\u0027pool_id\u0027, sa.String(36), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_13b3150c","line":35,"updated":"2019-02-12 23:09:56.000000000","message":"Why do we need this?","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.create_table("},{"line_number":35,"context_line":"        u\u0027certification\u0027,"},{"line_number":36,"context_line":"        sa.Column(u\u0027id\u0027, sa.Integer(), primary_key\u003dTrue, autoincrement\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(u\u0027listener_id\u0027, sa.String(36), nullable\u003dTrue),"},{"line_number":38,"context_line":"        sa.Column(u\u0027pool_id\u0027, sa.String(36), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_13254309","line":35,"in_reply_to":"9fdfeff1_13b3150c","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.create_table("},{"line_number":35,"context_line":"        u\u0027certification\u0027,"},{"line_number":36,"context_line":"        sa.Column(u\u0027id\u0027, sa.Integer(), primary_key\u003dTrue, autoincrement\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(u\u0027listener_id\u0027, sa.String(36), nullable\u003dTrue),"},{"line_number":38,"context_line":"        sa.Column(u\u0027pool_id\u0027, sa.String(36), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_44d31561","line":35,"in_reply_to":"9fdfeff1_13b3150c","updated":"2019-02-13 02:33:30.000000000","message":"for the whole encryption-reencyption function, they seem like the same functioon and models, so I introduce a new model for listener and pool for support this, not add many new columes(duplicated) in the existing db tables \"listeners\" and \"pools\". Ehhh, I don\u0027t want to make this difficult, but just feel if I do this way, our community experts can accept easier. ;P","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"octavia/db/models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":491,"context_line":"    timeout_member_connect \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":492,"context_line":"    timeout_member_data \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":493,"context_line":"    timeout_tcp_inspect \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":494,"context_line":"    client_ca_tls_certificate_id \u003d orm.relationship("},{"line_number":495,"context_line":"        \u0027Certification\u0027, cascade\u003d\u0027delete\u0027, uselist\u003dFalse,"},{"line_number":496,"context_line":"        back_populates\u003d\u0027listener\u0027)"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_93c62568","line":494,"updated":"2019-02-12 23:09:56.000000000","message":"Why can\u0027t this just be a string like tls_certificate_id?","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":491,"context_line":"    timeout_member_connect \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":492,"context_line":"    timeout_member_data \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":493,"context_line":"    timeout_tcp_inspect \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":494,"context_line":"    client_ca_tls_certificate_id \u003d orm.relationship("},{"line_number":495,"context_line":"        \u0027Certification\u0027, cascade\u003d\u0027delete\u0027, uselist\u003dFalse,"},{"line_number":496,"context_line":"        back_populates\u003d\u0027listener\u0027)"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_137463ce","line":494,"in_reply_to":"9fdfeff1_93c62568","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    position \u003d sa.Column(sa.Integer(), nullable\u003dTrue)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"class Certification(base_models.BASE):"},{"line_number":545,"context_line":"    __data_model__ \u003d data_models.Certification"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    __tablename__ \u003d \"certification\""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_f3cd3185","line":544,"updated":"2019-02-12 23:09:56.000000000","message":"Why do we need this?","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    position \u003d sa.Column(sa.Integer(), nullable\u003dTrue)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"class Certification(base_models.BASE):"},{"line_number":545,"context_line":"    __data_model__ \u003d data_models.Certification"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    __tablename__ \u003d \"certification\""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_b37c77b6","line":544,"in_reply_to":"9fdfeff1_f3cd3185","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    position \u003d sa.Column(sa.Integer(), nullable\u003dTrue)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"class Certification(base_models.BASE):"},{"line_number":545,"context_line":"    __data_model__ \u003d data_models.Certification"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    __tablename__ \u003d \"certification\""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_24ce11b4","line":544,"in_reply_to":"9fdfeff1_f3cd3185","updated":"2019-02-13 02:33:30.000000000","message":"Please see comments in https://review.openstack.org/#/c/612267/11/octavia/db/migration/alembic_migrations/versions/f1ca45e2761c_support_client_certification_authorization.py L53","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}],"octavia/db/prepare.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1a8423030b71bfb8c07f9afed23931be8fece11c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                      for sni_container_id in sni_container_ids]"},{"line_number":106,"context_line":"    listener_dict[\u0027sni_containers\u0027] \u003d sni_containers"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if \u0027client_ca_tls_container_ref\u0027 in listener_dict:"},{"line_number":109,"context_line":"        listener_dict[\u0027client_ca_tls_certificate_id\u0027] \u003d listener_dict.pop("},{"line_number":110,"context_line":"            \u0027client_ca_tls_container_ref\u0027)"},{"line_number":111,"context_line":"    return listener_dict"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_2cc3253a","line":108,"updated":"2019-02-15 01:52:02.000000000","message":"Unit test branch miss","commit_id":"717a5da04b160fce7c7caa6528ee6b883eab910e"}],"octavia/db/repositories.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        self.amp_build_slots \u003d AmphoraBuildSlotsRepository()"},{"line_number":188,"context_line":"        self.amp_build_req \u003d AmphoraBuildReqRepository()"},{"line_number":189,"context_line":"        self.quotas \u003d QuotasRepository()"},{"line_number":190,"context_line":"        self.certification \u003d CertificationRepository()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def create_load_balancer_and_vip(self, session, lb_dict, vip_dict):"},{"line_number":193,"context_line":"        \"\"\"Inserts load balancer and vip entities into the database."}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_73a701bf","line":190,"updated":"2019-02-12 23:09:56.000000000","message":"I don\u0027t think we need this.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        self.amp_build_slots \u003d AmphoraBuildSlotsRepository()"},{"line_number":188,"context_line":"        self.amp_build_req \u003d AmphoraBuildReqRepository()"},{"line_number":189,"context_line":"        self.quotas \u003d QuotasRepository()"},{"line_number":190,"context_line":"        self.certification \u003d CertificationRepository()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def create_load_balancer_and_vip(self, session, lb_dict, vip_dict):"},{"line_number":193,"context_line":"        \"\"\"Inserts load balancer and vip entities into the database."}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_336967f7","line":190,"in_reply_to":"9fdfeff1_73a701bf","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"                sni \u003d models.SNI(listener_id\u003did,"},{"line_number":1012,"context_line":"                                 tls_certificate_id\u003dcontainer_ref)"},{"line_number":1013,"context_line":"                listener_db.sni_containers.append(sni)"},{"line_number":1014,"context_line":"            client_ca_tls_certificate_id \u003d model_kwargs.get("},{"line_number":1015,"context_line":"                \u0027client_ca_tls_container_ref\u0027)"},{"line_number":1016,"context_line":"            if client_ca_tls_certificate_id:"},{"line_number":1017,"context_line":"                cert_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_1381d5fb","line":1014,"updated":"2019-02-12 23:09:56.000000000","message":"I don\u0027t think we need these changes, the ID can just be a string.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"966de85ac05ae09b94d74fe837ecbf0a22b8772a","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"                sni \u003d models.SNI(listener_id\u003did,"},{"line_number":1012,"context_line":"                                 tls_certificate_id\u003dcontainer_ref)"},{"line_number":1013,"context_line":"                listener_db.sni_containers.append(sni)"},{"line_number":1014,"context_line":"            client_ca_tls_certificate_id \u003d model_kwargs.get("},{"line_number":1015,"context_line":"                \u0027client_ca_tls_container_ref\u0027)"},{"line_number":1016,"context_line":"            if client_ca_tls_certificate_id:"},{"line_number":1017,"context_line":"                cert_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_536e6b00","line":1014,"in_reply_to":"9fdfeff1_1381d5fb","updated":"2019-02-13 16:52:59.000000000","message":"Done","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"                sni \u003d models.SNI(listener_id\u003did,"},{"line_number":1012,"context_line":"                                 tls_certificate_id\u003dcontainer_ref)"},{"line_number":1013,"context_line":"                listener_db.sni_containers.append(sni)"},{"line_number":1014,"context_line":"            client_ca_tls_certificate_id \u003d model_kwargs.get("},{"line_number":1015,"context_line":"                \u0027client_ca_tls_container_ref\u0027)"},{"line_number":1016,"context_line":"            if client_ca_tls_certificate_id:"},{"line_number":1017,"context_line":"                cert_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_e4c32988","line":1014,"in_reply_to":"9fdfeff1_1381d5fb","updated":"2019-02-13 02:33:30.000000000","message":"Please see comments in https://review.openstack.org/#/c/612267/11/octavia/db/migration/alembic_migrations/versions/f1ca45e2761c_support_client_certification_authorization.py L53","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c5fe0b05662176b15efdf6a2b170582aaf82cda","unresolved":false,"context_lines":[{"line_number":1393,"context_line":"                    tls_container_id\u003dtls_container_id).update(model_kwargs)"},{"line_number":1394,"context_line":""},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"class CertificationRepository(BaseRepository):"},{"line_number":1397,"context_line":"    model_class \u003d models.Certification"},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"    def update(self, session, listener_id\u003dNone, pool_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_33adf99a","line":1396,"updated":"2019-02-12 23:09:56.000000000","message":"I don\u0027t think we need this.","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a80f5fa74fc2912c522b0bea4422348eb67d3bf4","unresolved":false,"context_lines":[{"line_number":1393,"context_line":"                    tls_container_id\u003dtls_container_id).update(model_kwargs)"},{"line_number":1394,"context_line":""},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"class CertificationRepository(BaseRepository):"},{"line_number":1397,"context_line":"    model_class \u003d models.Certification"},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"    def update(self, session, listener_id\u003dNone, pool_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_84bc9d06","line":1396,"in_reply_to":"9fdfeff1_33adf99a","updated":"2019-02-13 02:33:30.000000000","message":"ditto","commit_id":"77e2d333f641cdb954c7eec20a06ac1e76e311b8"}]}
