)]}'
{"octavia/controller/worker/flows/load_balancer_flows.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"c27c77a5a387bbccbf78e933bd8c346a42d68050","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        :returns: The flow for deleting a load balancer"},{"line_number":229,"context_line":"        \"\"\""},{"line_number":230,"context_line":"        (listeners_delete, store) \u003d self._get_delete_listeners_flow(lb)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        delete_LB_flow \u003d linear_flow.Flow(constants.DELETE_LOADBALANCER_FLOW)"},{"line_number":233,"context_line":"        delete_LB_flow.add(lifecycle_tasks.LoadBalancerToErrorOnRevertTask("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_0b0a2789","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":71},"updated":"2019-03-11 18:04:23.000000000","message":"leftover that can be removed","commit_id":"e6aa37947197a95c99ee3ce2468aaffeaaccfae8"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"67e842b97b07fe88bef6272a7fa2958c53bd17b2","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        :returns: The flow for deleting a load balancer"},{"line_number":229,"context_line":"        \"\"\""},{"line_number":230,"context_line":"        (listeners_delete, store) \u003d self._get_delete_listeners_flow(lb)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        delete_LB_flow \u003d linear_flow.Flow(constants.DELETE_LOADBALANCER_FLOW)"},{"line_number":233,"context_line":"        delete_LB_flow.add(lifecycle_tasks.LoadBalancerToErrorOnRevertTask("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_4e91014e","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":71},"in_reply_to":"5fc1f717_0691b04e","updated":"2019-03-12 20:26:55.000000000","message":"I am not disagreeing but (1) should we merge this patch as is and make another one addressing this problem or (2) I remove the line in question here.","commit_id":"e6aa37947197a95c99ee3ce2468aaffeaaccfae8"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"f01a8ca175a9279495817136730bd9c064aa7e55","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        :returns: The flow for deleting a load balancer"},{"line_number":229,"context_line":"        \"\"\""},{"line_number":230,"context_line":"        (listeners_delete, store) \u003d self._get_delete_listeners_flow(lb)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        delete_LB_flow \u003d linear_flow.Flow(constants.DELETE_LOADBALANCER_FLOW)"},{"line_number":233,"context_line":"        delete_LB_flow.add(lifecycle_tasks.LoadBalancerToErrorOnRevertTask("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_4b4b4faf","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":71},"in_reply_to":"5fc1f717_0b0a2789","updated":"2019-03-11 18:09:10.000000000","message":"If confirmed the delete LB flow shouldn\u0027t be deleting listeners, this is a bug and should be fixed in a separate change so that it could be backported.","commit_id":"e6aa37947197a95c99ee3ce2468aaffeaaccfae8"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"c0c078ab9a47a90ccb30d4d35cb5deae47d1e692","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        :returns: The flow for deleting a load balancer"},{"line_number":229,"context_line":"        \"\"\""},{"line_number":230,"context_line":"        (listeners_delete, store) \u003d self._get_delete_listeners_flow(lb)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        delete_LB_flow \u003d linear_flow.Flow(constants.DELETE_LOADBALANCER_FLOW)"},{"line_number":233,"context_line":"        delete_LB_flow.add(lifecycle_tasks.LoadBalancerToErrorOnRevertTask("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_7990604f","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":71},"in_reply_to":"5fc1f717_4b4b4faf","updated":"2019-03-12 00:59:50.000000000","message":"Yeah, it should not delete the listener BUT in the grand scheme of things the code will only get here if all listeners are deleted since the API enforces that this is only called when there is no listener left.","commit_id":"e6aa37947197a95c99ee3ce2468aaffeaaccfae8"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"bb1889e6d8dc3728beef6aa6f3e308ec8082221b","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        :returns: The flow for deleting a load balancer"},{"line_number":229,"context_line":"        \"\"\""},{"line_number":230,"context_line":"        (listeners_delete, store) \u003d self._get_delete_listeners_flow(lb)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        delete_LB_flow \u003d linear_flow.Flow(constants.DELETE_LOADBALANCER_FLOW)"},{"line_number":233,"context_line":"        delete_LB_flow.add(lifecycle_tasks.LoadBalancerToErrorOnRevertTask("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_b13d6ac5","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":71},"in_reply_to":"5fc1f717_4e91014e","updated":"2019-03-12 20:46:14.000000000","message":"A straight-forward backportable patch would require deleting this line and L239 (delete_LB_flow.add(listeners_delete)) in the original file. I\u0027m okay either way. This listener thingy doesn\u0027t impact users.\n\nAlso, don\u0027t forget my other comment below.","commit_id":"e6aa37947197a95c99ee3ce2468aaffeaaccfae8"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2d77e039e63e742f616608990adbdaac4ca9e013","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        :returns: The flow for deleting a load balancer"},{"line_number":229,"context_line":"        \"\"\""},{"line_number":230,"context_line":"        (listeners_delete, store) \u003d self._get_delete_listeners_flow(lb)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        delete_LB_flow \u003d linear_flow.Flow(constants.DELETE_LOADBALANCER_FLOW)"},{"line_number":233,"context_line":"        delete_LB_flow.add(lifecycle_tasks.LoadBalancerToErrorOnRevertTask("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_0691b04e","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":71},"in_reply_to":"5fc1f717_7990604f","updated":"2019-03-12 10:47:14.000000000","message":"+1. Still it should not be here. It consumes resources unnecessarily :)","commit_id":"e6aa37947197a95c99ee3ce2468aaffeaaccfae8"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"c27c77a5a387bbccbf78e933bd8c346a42d68050","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    pool_name))"},{"line_number":312,"context_line":"        return (pools_delete_flow, store)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def get_cascade_delete_load_balancer_flow(self, lb):"},{"line_number":315,"context_line":"        \"\"\"Creates a flow to delete a load balancer."},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        :returns: The flow for deleting a load balancer"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_8bf5b785","line":314,"updated":"2019-03-11 18:04:23.000000000","message":"I guess we\u0027d also need to refactor this too","commit_id":"e6aa37947197a95c99ee3ce2468aaffeaaccfae8"}]}