)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3cda4cb803dc8abf5216e8261b30ee950364c9ec","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if ! [ -f $OCTAVIA_AMP_IMAGE_FILE ]; then"},{"line_number":84,"context_line":"        local dib_logs\u003d/var/log/dib-build"},{"line_number":85,"context_line":"        if [[ -a ${dib_logs} ]]; then"},{"line_number":86,"context_line":"            rm -rf ${dib_logs}"},{"line_number":87,"context_line":"        fi"},{"line_number":88,"context_line":"        sudo mkdir -m755 ${dib_logs}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_92ae899f","line":85,"range":{"start_line":85,"start_character":14,"end_line":85,"end_character":16},"updated":"2018-11-18 10:26:23.000000000","message":"Please use -d (for directory)\n\n\"This is identical in effect to -e. It has been \"deprecated,\" [1] and its use is discouraged.\"\nhttps://www.tldp.org/LDP/abs/html/fto.html","commit_id":"6fa2475fb0db48bb8ad8665f71230285712e8222"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"41aaa7ac3d20db2a2b5b4bc987e38833689976d2","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if ! [ -f $OCTAVIA_AMP_IMAGE_FILE ]; then"},{"line_number":84,"context_line":"        local dib_logs\u003d/var/log/dib-build"},{"line_number":85,"context_line":"        if [[ -a ${dib_logs} ]]; then"},{"line_number":86,"context_line":"            rm -rf ${dib_logs}"},{"line_number":87,"context_line":"        fi"},{"line_number":88,"context_line":"        sudo mkdir -m755 ${dib_logs}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_8b264c6a","line":85,"range":{"start_line":85,"start_character":14,"end_line":85,"end_character":16},"in_reply_to":"3f79a3b5_92ae899f","updated":"2018-11-19 15:56:25.000000000","message":"Better -e. it could be that a regular file exists with that name in which case we wouldn\u0027t be deleting it and failing later on mkdir","commit_id":"6fa2475fb0db48bb8ad8665f71230285712e8222"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"f0d46fa39ccd7eb5ed60d711667b75e6c5edfa84","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    if ! [ -f $OCTAVIA_AMP_IMAGE_FILE ]; then"},{"line_number":84,"context_line":"        local dib_logs\u003d/var/log/dib-build"},{"line_number":85,"context_line":"        if [[ -e ${dib_logs} ]]; then"},{"line_number":86,"context_line":"            rm -rf ${dib_logs}"},{"line_number":87,"context_line":"        fi"},{"line_number":88,"context_line":"        sudo mkdir -m755 ${dib_logs}"},{"line_number":89,"context_line":"        sudo chown $STACK_USER ${dib_logs}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3f79a3b5_43bd57cf","line":86,"updated":"2018-11-21 07:34:52.000000000","message":"This does not look right, since the dir could be made with sudo below.\nThis should be sudo also, otherwise it would get a permission denied message.","commit_id":"60887614d2d50c369a4c0e90adf08c3074b9f3c3"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"6eabbcbbe6c79bbff7af4f3745a14cf18fa65632","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    if ! [ -f $OCTAVIA_AMP_IMAGE_FILE ]; then"},{"line_number":84,"context_line":"        local dib_logs\u003d/var/log/dib-build"},{"line_number":85,"context_line":"        if [[ -e ${dib_logs} ]]; then"},{"line_number":86,"context_line":"            rm -rf ${dib_logs}"},{"line_number":87,"context_line":"        fi"},{"line_number":88,"context_line":"        sudo mkdir -m755 ${dib_logs}"},{"line_number":89,"context_line":"        sudo chown $STACK_USER ${dib_logs}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3f79a3b5_8a2a9fe2","line":86,"in_reply_to":"3f79a3b5_43bd57cf","updated":"2018-11-21 11:46:17.000000000","message":"Ah, good one :)","commit_id":"60887614d2d50c369a4c0e90adf08c3074b9f3c3"}]}
