)]}'
{"octavia/api/drivers/amphora_driver/driver.py":[{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"02c612264f4a197ecec3100952c250412310e5d6","unresolved":false,"context_lines":[{"line_number":289,"context_line":"          one of the flavor settings."},{"line_number":290,"context_line":"        \"\"\""},{"line_number":291,"context_line":"        try:"},{"line_number":292,"context_line":"            validate(flavor, flavor_schema.SUPPORTED_FLAVOR_SCHEMA)"},{"line_number":293,"context_line":"        except js_exceptions.ValidationError as e:"},{"line_number":294,"context_line":"            error_object \u003d \u0027\u0027"},{"line_number":295,"context_line":"            if e.relative_path:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_0c605d9e","line":292,"range":{"start_line":292,"start_character":12,"end_line":292,"end_character":67},"updated":"2018-12-12 13:09:11.000000000","message":"This validate does not pass. \nThe log as below:\nhttp://paste.openstack.org/show/737127/\n\nBecause of the flavor type is str. I think we should convert it to dict at before code.","commit_id":"13d3160196f20477efb9fee2bf92248fcbf32606"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5dccd0401cc55398d9600e963c7790bf27e14f80","unresolved":false,"context_lines":[{"line_number":289,"context_line":"          one of the flavor settings."},{"line_number":290,"context_line":"        \"\"\""},{"line_number":291,"context_line":"        try:"},{"line_number":292,"context_line":"            validate(flavor, flavor_schema.SUPPORTED_FLAVOR_SCHEMA)"},{"line_number":293,"context_line":"        except js_exceptions.ValidationError as e:"},{"line_number":294,"context_line":"            error_object \u003d \u0027\u0027"},{"line_number":295,"context_line":"            if e.relative_path:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_5e7bbe7b","line":292,"range":{"start_line":292,"start_character":12,"end_line":292,"end_character":67},"in_reply_to":"3f79a3b5_0c605d9e","updated":"2018-12-20 05:48:34.000000000","message":"Yes, I can reproduce this. I am fixing it in the next version of the patch.","commit_id":"13d3160196f20477efb9fee2bf92248fcbf32606"}],"octavia/api/v2/controllers/load_balancer.py":[{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"698d5c773143d474198d98f945e7a46f1a710fda","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # Make sure the driver will still accept the flavor metadata"},{"line_number":283,"context_line":"        if flavor_dict:"},{"line_number":284,"context_line":"            flavor_json \u003d jsonutils.dumps(flavor_dict)"},{"line_number":285,"context_line":"            driver_utils.call_provider(driver.name, driver.validate_flavor,"},{"line_number":286,"context_line":"                                       flavor_json)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1f769fc5_fec0f52c","line":284,"range":{"start_line":284,"start_character":12,"end_line":284,"end_character":54},"updated":"2019-01-02 10:24:14.000000000","message":"I have a question here. Why do we need to turn \u0027flavor_dict\u0027 to json? I noticed the \u0027flavor_json\u0027 will be reversed to dict in \u0027validate_flavor\u0027 function. And I didn\u0027t find any other places to use \u0027flavor_json\u0027.","commit_id":"4624f267b6d85d01f182e8a380d386f145f677b0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b59a7d144138827c2d61228642e9cfb1791db171","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # Make sure the driver will still accept the flavor metadata"},{"line_number":283,"context_line":"        if flavor_dict:"},{"line_number":284,"context_line":"            flavor_json \u003d jsonutils.dumps(flavor_dict)"},{"line_number":285,"context_line":"            driver_utils.call_provider(driver.name, driver.validate_flavor,"},{"line_number":286,"context_line":"                                       flavor_json)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"dfd5e7cf_44d7f94c","line":284,"range":{"start_line":284,"start_character":12,"end_line":284,"end_character":54},"in_reply_to":"1f769fc5_fec0f52c","updated":"2019-01-08 23:23:23.000000000","message":"Yep, per the spec, this should be a dict. Fixed.","commit_id":"4624f267b6d85d01f182e8a380d386f145f677b0"}],"octavia/api/v2/types/load_balancer.py":[{"author":{"_account_id":29621,"name":"Rufei Xu","email":"891872629@qq.com"},"change_message_id":"f3f80ee3b674150f1751c130ddfdc9ee7774e5e9","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    pools \u003d wtypes.wsattr([pool.PoolSingleCreate], default\u003d[])"},{"line_number":124,"context_line":"    provider \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d64))"},{"line_number":125,"context_line":"    tags \u003d wtypes.wsattr(wtypes.ArrayType(wtypes.StringType(max_length\u003d255)))"},{"line_number":126,"context_line":"    flavor_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class LoadBalancerRootPOST(types.BaseType):"}],"source_content_type":"text/x-python","patch_set":18,"id":"dfd5e7cf_93aea02c","line":126,"range":{"start_line":126,"start_character":30,"end_line":126,"end_character":43},"updated":"2019-01-08 06:23:11.000000000","message":"in class LoadBalancerResponse line 55, you use wtypes.StringType()for flavor_id. Should it be wtypes.UuidType() there?","commit_id":"4624f267b6d85d01f182e8a380d386f145f677b0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b59a7d144138827c2d61228642e9cfb1791db171","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    pools \u003d wtypes.wsattr([pool.PoolSingleCreate], default\u003d[])"},{"line_number":124,"context_line":"    provider \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d64))"},{"line_number":125,"context_line":"    tags \u003d wtypes.wsattr(wtypes.ArrayType(wtypes.StringType(max_length\u003d255)))"},{"line_number":126,"context_line":"    flavor_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class LoadBalancerRootPOST(types.BaseType):"}],"source_content_type":"text/x-python","patch_set":18,"id":"dfd5e7cf_a4aee5e4","line":126,"range":{"start_line":126,"start_character":30,"end_line":126,"end_character":43},"in_reply_to":"dfd5e7cf_93aea02c","updated":"2019-01-08 23:23:23.000000000","message":"Yep, thanks, fixed.","commit_id":"4624f267b6d85d01f182e8a380d386f145f677b0"}],"octavia/common/exceptions.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e8d99c4f280f0c62f082bdc63f52e2cf994d1c5f","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"class ProviderFlavorMismatchError(APIException):"},{"line_number":383,"context_line":"    msg \u003d _(\"Flavor \u0027%(flav)s\u0027 is not compatible with provider \u0027%(prov)s\u0027\")"},{"line_number":384,"context_line":"    code \u003d 400"}],"source_content_type":"text/x-python","patch_set":31,"id":"9fdfeff1_6ea2b8ff","line":383,"updated":"2019-01-28 23:51:14.000000000","message":"We\u0027re really going to abbrev. words that are barely longer than their abbrev.? Isn\u0027t this just unnecessarily confusing?","commit_id":"0b1fe6a5266ef5869dc54d16feabef5741cc95cb"}],"octavia/db/migration/alembic_migrations/versions/211982b05afc_add_flavor_id_to_lb.py":[{"author":{"_account_id":29621,"name":"Rufei Xu","email":"891872629@qq.com"},"change_message_id":"8ededb0a98971cfe9046ff467baaf95f3790ce95","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def upgrade():"},{"line_number":31,"context_line":"    op.add_column(\u0027load_balancer\u0027,"},{"line_number":32,"context_line":"                  sa.Column(\u0027flavor_id\u0027, sa.String(36), nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":30,"id":"9fdfeff1_d5cfdead","line":32,"range":{"start_line":32,"start_character":29,"end_line":32,"end_character":38},"updated":"2019-01-25 09:19:18.000000000","message":"could you explain that why removed foreign key constraint here?","commit_id":"5c3323ae118b3b3c08b2c76c5ee95582c2f6de35"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fd158b2325507d382068635215d549a53f9c7a1f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def upgrade():"},{"line_number":31,"context_line":"    op.add_column(\u0027load_balancer\u0027,"},{"line_number":32,"context_line":"                  sa.Column(\u0027flavor_id\u0027, sa.String(36), nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":30,"id":"9fdfeff1_74094b2f","line":32,"range":{"start_line":32,"start_character":29,"end_line":32,"end_character":38},"in_reply_to":"9fdfeff1_d5cfdead","updated":"2019-01-25 20:33:43.000000000","message":"Yes, because load balancers go into a \"DELETED\" state and are not actually deleted from the database until the housekeeping timer expires, the foreign key would mean that a flavor could not be removed even if all of the load balancers using it were deleted.","commit_id":"5c3323ae118b3b3c08b2c76c5ee95582c2f6de35"}]}
