)]}'
{"devstack/etc/octavia/10-amphora.conf":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a0f4d4a33f6bd50649a5184b860fb3f30ab53ccd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# make it a+r so zuul can copy it in gate jobs"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"$FileCreateMode 0644"},{"line_number":8,"context_line":"if $fromhost-ip startswith \u0027192.168.0\u0027 then /var/log/octavia-amphora.log"},{"line_number":9,"context_line":"\u0026 ~"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# restore the default"}],"source_content_type":"text/plain","patch_set":10,"id":"1f769fc5_8d0a3588","line":8,"range":{"start_line":8,"start_character":28,"end_line":8,"end_character":37},"updated":"2018-12-23 15:52:29.000000000","message":"The assumption here is that lb-mgmt-subnet is configured on this subrange, but it might not be if user changes OCTAVIA_MGMT_SUBNET to something else. This needs to be parameterized/replaced like you\u0027re doing with TARGET_PORT.","commit_id":"dbdf71b708407b33ba5f83c72308f79e5958c688"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d7d00bea400b24f2277817efec217494f7349e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# make it a+r so zuul can copy it in gate jobs"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"$FileCreateMode 0644"},{"line_number":8,"context_line":"if $fromhost-ip startswith \u0027192.168.0\u0027 then /var/log/octavia-amphora.log"},{"line_number":9,"context_line":"\u0026 ~"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# restore the default"}],"source_content_type":"text/plain","patch_set":10,"id":"1f769fc5_46407708","line":8,"range":{"start_line":8,"start_character":28,"end_line":8,"end_character":37},"in_reply_to":"1f769fc5_8d0a3588","updated":"2018-12-24 17:38:53.000000000","message":"Done","commit_id":"dbdf71b708407b33ba5f83c72308f79e5958c688"}],"devstack/etc/octavia/10-octavia-log-offloading.conf":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8a9691a8524ade212ab5ee5d015c27f5d3985678","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"9fb8cfa7_fe05a914","updated":"2019-06-13 23:40:05.000000000","message":"Weird name for this file? Just reading the filename I thought this was like a post-install script or something.","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a324bc3c3853cf2c645491cd6c2195e8b173535d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"9fb8cfa7_e1d74e4a","in_reply_to":"9fb8cfa7_fe05a914","updated":"2019-06-14 15:13:38.000000000","message":"Done","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"}],"devstack/files/debs/octavia":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8a9691a8524ade212ab5ee5d015c27f5d3985678","unresolved":false,"context_lines":[{"line_number":1,"context_line":"golang"},{"line_number":2,"context_line":"debootstrap"},{"line_number":3,"context_line":"rsyslog"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"9fb8cfa7_81077218","line":3,"updated":"2019-06-13 23:40:05.000000000","message":"ugh, no syslog-ng T_T","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"}],"devstack/plugin.sh":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"14f0c2475a58c3982418ff29fc38c620347b4131","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        die \"Unknown network controller. Please define octavia_create_network_interface_device\""},{"line_number":372,"context_line":"    fi"},{"line_number":373,"context_line":"    sudo ip link set dev o-hm0 address $MGMT_PORT_MAC"},{"line_number":374,"context_line":"    sudo iptables -I INPUT -i o-hm0 -p udp --dport 5555 -j ACCEPT"},{"line_number":375,"context_line":"    sudo iptables -I INPUT -i o-hm0 -p udp --dport 10514 -j ACCEPT"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_9fc6b814","line":374,"range":{"start_line":374,"start_character":51,"end_line":374,"end_character":55},"updated":"2018-12-13 09:10:07.000000000","message":"$OCTAVIA_HM_LISTEN_PORT","commit_id":"0d166d03b8d5d81ce0915beee886ef108940d766"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"14f0c2475a58c3982418ff29fc38c620347b4131","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    fi"},{"line_number":373,"context_line":"    sudo ip link set dev o-hm0 address $MGMT_PORT_MAC"},{"line_number":374,"context_line":"    sudo iptables -I INPUT -i o-hm0 -p udp --dport 5555 -j ACCEPT"},{"line_number":375,"context_line":"    sudo iptables -I INPUT -i o-hm0 -p udp --dport 10514 -j ACCEPT"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    if [ $OCTAVIA_CONTROLLER_IP_PORT_LIST \u003d\u003d \u0027auto\u0027 ] ; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_dfbc3086","line":375,"range":{"start_line":375,"start_character":51,"end_line":375,"end_character":56},"updated":"2018-12-13 09:10:07.000000000","message":"Make it configurable","commit_id":"0d166d03b8d5d81ce0915beee886ef108940d766"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"14f0c2475a58c3982418ff29fc38c620347b4131","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    # Create security group and rules"},{"line_number":406,"context_line":"    openstack security group create lb-health-mgr-sec-grp"},{"line_number":407,"context_line":"    openstack security group rule create --protocol udp --dst-port $OCTAVIA_HM_LISTEN_PORT lb-health-mgr-sec-grp"},{"line_number":408,"context_line":"    openstack security group rule create --protocol udp --dst-port 10514 lb-health-mgr-sec-grp"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    if [ $IPV6_ENABLED \u003d\u003d \u0027true\u0027 ] ; then"},{"line_number":411,"context_line":"        openstack security group rule create --protocol udp --dst-port $OCTAVIA_HM_LISTEN_PORT --ethertype IPv6 --remote-ip ::/0 lb-health-mgr-sec-grp"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_5fd020c8","line":408,"range":{"start_line":408,"start_character":67,"end_line":408,"end_character":72},"updated":"2018-12-13 09:10:07.000000000","message":"ditto","commit_id":"0d166d03b8d5d81ce0915beee886ef108940d766"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a0f4d4a33f6bd50649a5184b860fb3f30ab53ccd","unresolved":false,"context_lines":[{"line_number":491,"context_line":"    run_process $OCTAVIA_HEALTHMANAGER  \"$OCTAVIA_HEALTHMANAGER_BINARY $OCTAVIA_HEALTHMANAGER_ARGS\""},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"     # TODO: check if that is correct"},{"line_number":494,"context_line":"     sudo systemctl restart rsyslog"},{"line_number":495,"context_line":"}"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"function octavia_stop {"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f769fc5_ed75e9cd","line":494,"range":{"start_line":494,"start_character":5,"end_line":494,"end_character":35},"updated":"2018-12-23 15:52:29.000000000","message":"Use function \"restart_service\":\n\n    restart_service rsyslog","commit_id":"dbdf71b708407b33ba5f83c72308f79e5958c688"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d7d00bea400b24f2277817efec217494f7349e","unresolved":false,"context_lines":[{"line_number":491,"context_line":"    run_process $OCTAVIA_HEALTHMANAGER  \"$OCTAVIA_HEALTHMANAGER_BINARY $OCTAVIA_HEALTHMANAGER_ARGS\""},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"     # TODO: check if that is correct"},{"line_number":494,"context_line":"     sudo systemctl restart rsyslog"},{"line_number":495,"context_line":"}"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"function octavia_stop {"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f769fc5_26477b20","line":494,"range":{"start_line":494,"start_character":5,"end_line":494,"end_character":35},"in_reply_to":"1f769fc5_ed75e9cd","updated":"2018-12-24 17:38:53.000000000","message":"Done","commit_id":"dbdf71b708407b33ba5f83c72308f79e5958c688"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a0f4d4a33f6bd50649a5184b860fb3f30ab53ccd","unresolved":false,"context_lines":[{"line_number":546,"context_line":"    if [[ \"$OCTAVIA_USE_MOD_WSGI\" \u003d\u003d \"True\" ]]; then"},{"line_number":547,"context_line":"        _cleanup_octavia_apache_wsgi"},{"line_number":548,"context_line":"    fi"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    sudo rm -rf $NOVA_STATE_PATH $NOVA_AUTH_CACHE_DIR"},{"line_number":551,"context_line":"}"},{"line_number":552,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f769fc5_add93123","line":549,"updated":"2018-12-23 15:52:29.000000000","message":"Delete /etc/rsyslog.d/10-amphora.conf and restart rsyslog.","commit_id":"dbdf71b708407b33ba5f83c72308f79e5958c688"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d7d00bea400b24f2277817efec217494f7349e","unresolved":false,"context_lines":[{"line_number":546,"context_line":"    if [[ \"$OCTAVIA_USE_MOD_WSGI\" \u003d\u003d \"True\" ]]; then"},{"line_number":547,"context_line":"        _cleanup_octavia_apache_wsgi"},{"line_number":548,"context_line":"    fi"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    sudo rm -rf $NOVA_STATE_PATH $NOVA_AUTH_CACHE_DIR"},{"line_number":551,"context_line":"}"},{"line_number":552,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f769fc5_e650a3d7","line":549,"in_reply_to":"1f769fc5_add93123","updated":"2018-12-24 17:38:53.000000000","message":"Done","commit_id":"dbdf71b708407b33ba5f83c72308f79e5958c688"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"bb8202cd470cf14a1fed51a1b2295b8d81257c0c","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    sudo cp ${OCTAVIA_DIR}/devstack/etc/octavia/10-amphora.conf /etc/rsyslog.d/"},{"line_number":470,"context_line":"    sudo sed -e \""},{"line_number":471,"context_line":"        s|%TARGET_PORT%|/${OCTAVIA_AMP_LOG_TARGET_PORT}|g;"},{"line_number":472,"context_line":"        s|%OCTAVIA_MGMT_SUBNET%|${OCTAVIA_MGMT_SUBNET}|g;"},{"line_number":473,"context_line":"    \" -i.bak /etc/rsyslog.d/10-amphora.conf"},{"line_number":474,"context_line":"    sudo sed -i.bak \"s/TARGET_PORT/${OCTAVIA_AMP_LOG_TARGET_PORT}/\"  /etc/rsyslog.d/10-amphora.conf"},{"line_number":475,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":11,"id":"1f769fc5_228f59cd","line":472,"range":{"start_line":472,"start_character":34,"end_line":472,"end_character":53},"updated":"2018-12-26 14:17:42.000000000","message":"You have to strip .0/24 out of 192.168.0.0/24.\n\nsed -e \"s/OCTAVIA_MGMT_SUBNET/$(echo $OCTAVIA_MGMT_SUBNET | cut -d . -f -3)/g;\" -i.bak /etc/rsyslog.d/10-amphora.conf","commit_id":"035b75d1eab5f12a9d2576718de17a121bcb1ea3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"81d19ad336d6264c79d0eeca85f40ec710dff699","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    sudo cp ${OCTAVIA_DIR}/devstack/etc/octavia/10-amphora.conf /etc/rsyslog.d/"},{"line_number":470,"context_line":"    sudo sed -e \""},{"line_number":471,"context_line":"        s|%TARGET_PORT%|/${OCTAVIA_AMP_LOG_TARGET_PORT}|g;"},{"line_number":472,"context_line":"        s|%OCTAVIA_MGMT_SUBNET%|${OCTAVIA_MGMT_SUBNET}|g;"},{"line_number":473,"context_line":"    \" -i.bak /etc/rsyslog.d/10-amphora.conf"},{"line_number":474,"context_line":"    sudo sed -i.bak \"s/TARGET_PORT/${OCTAVIA_AMP_LOG_TARGET_PORT}/\"  /etc/rsyslog.d/10-amphora.conf"},{"line_number":475,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":11,"id":"1f769fc5_3ac6709c","line":472,"range":{"start_line":472,"start_character":34,"end_line":472,"end_character":53},"in_reply_to":"1f769fc5_228f59cd","updated":"2019-01-02 18:25:26.000000000","message":"Done","commit_id":"035b75d1eab5f12a9d2576718de17a121bcb1ea3"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8a9691a8524ade212ab5ee5d015c27f5d3985678","unresolved":false,"context_lines":[{"line_number":429,"context_line":"    openstack security group create lb-health-mgr-sec-grp"},{"line_number":430,"context_line":"    openstack security group rule create --protocol udp --dst-port $OCTAVIA_HM_LISTEN_PORT lb-health-mgr-sec-grp"},{"line_number":431,"context_line":"    openstack security group rule create --protocol udp --dst-port $OCTAVIA_AMP_LOG_ADMIN_PORT lb-health-mgr-sec-grp"},{"line_number":432,"context_line":"    openstack security group rule create --protocol udp --dst-port $OCTAVIA_AMP_LOG_TENANT_PORT lb-health-mgr-sec-grp"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    if [ $IPV6_ENABLED \u003d\u003d \u0027true\u0027 ] ; then"},{"line_number":435,"context_line":"        openstack security group rule create --protocol udp --dst-port $OCTAVIA_HM_LISTEN_PORT --ethertype IPv6 --remote-ip ::/0 lb-health-mgr-sec-grp"}],"source_content_type":"text/x-sh","patch_set":22,"id":"9fb8cfa7_4115fa3e","line":432,"updated":"2019-06-13 23:40:05.000000000","message":"Missing the ipv6 versions below?","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a85a077c3b9966bdd25cdb460f41105bb6216f2c","unresolved":false,"context_lines":[{"line_number":429,"context_line":"    openstack security group create lb-health-mgr-sec-grp"},{"line_number":430,"context_line":"    openstack security group rule create --protocol udp --dst-port $OCTAVIA_HM_LISTEN_PORT lb-health-mgr-sec-grp"},{"line_number":431,"context_line":"    openstack security group rule create --protocol udp --dst-port $OCTAVIA_AMP_LOG_ADMIN_PORT lb-health-mgr-sec-grp"},{"line_number":432,"context_line":"    openstack security group rule create --protocol udp --dst-port $OCTAVIA_AMP_LOG_TENANT_PORT lb-health-mgr-sec-grp"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    if [ $IPV6_ENABLED \u003d\u003d \u0027true\u0027 ] ; then"},{"line_number":435,"context_line":"        openstack security group rule create --protocol udp --dst-port $OCTAVIA_HM_LISTEN_PORT --ethertype IPv6 --remote-ip ::/0 lb-health-mgr-sec-grp"}],"source_content_type":"text/x-sh","patch_set":22,"id":"9fb8cfa7_ddc30237","line":432,"in_reply_to":"9fb8cfa7_4115fa3e","updated":"2019-06-14 12:32:06.000000000","message":"+1","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8a9691a8524ade212ab5ee5d015c27f5d3985678","unresolved":false,"context_lines":[{"line_number":468,"context_line":"}"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"function configure_rsyslog {"},{"line_number":471,"context_line":"    sudo cp ${OCTAVIA_DIR}/devstack/etc/octavia/10-octavia-log-offloading.conf /etc/rsyslog.d/"},{"line_number":472,"context_line":"    sudo sed -e \""},{"line_number":473,"context_line":"        s|%ADMIN_PORT%|${OCTAVIA_AMP_LOG_ADMIN_PORT}|g;"},{"line_number":474,"context_line":"        s|%TENANT_PORT%|${OCTAVIA_AMP_LOG_TENANT_PORT}|g;"}],"source_content_type":"text/x-sh","patch_set":22,"id":"9fb8cfa7_011b8272","line":471,"updated":"2019-06-13 23:40:05.000000000","message":"So we put the file in the octavia config dir, but it really ends up in rsyslog\u0027s config dir? Is that why the funny name?","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a324bc3c3853cf2c645491cd6c2195e8b173535d","unresolved":false,"context_lines":[{"line_number":468,"context_line":"}"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"function configure_rsyslog {"},{"line_number":471,"context_line":"    sudo cp ${OCTAVIA_DIR}/devstack/etc/octavia/10-octavia-log-offloading.conf /etc/rsyslog.d/"},{"line_number":472,"context_line":"    sudo sed -e \""},{"line_number":473,"context_line":"        s|%ADMIN_PORT%|${OCTAVIA_AMP_LOG_ADMIN_PORT}|g;"},{"line_number":474,"context_line":"        s|%TENANT_PORT%|${OCTAVIA_AMP_LOG_TENANT_PORT}|g;"}],"source_content_type":"text/x-sh","patch_set":22,"id":"9fb8cfa7_81ca129e","line":471,"in_reply_to":"9fb8cfa7_011b8272","updated":"2019-06-14 15:13:38.000000000","message":"Done","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a85a077c3b9966bdd25cdb460f41105bb6216f2c","unresolved":false,"context_lines":[{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    sudo rm -rf $NOVA_STATE_PATH $NOVA_AUTH_CACHE_DIR"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    sudo rm /etc/rsyslog.d/10-octavia-log-offloading.conf"},{"line_number":562,"context_line":"    restart_service rsyslog"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":23,"id":"9fb8cfa7_9d8caa36","line":561,"range":{"start_line":561,"start_character":9,"end_line":561,"end_character":12},"updated":"2019-06-14 12:32:06.000000000","message":"File may not exist in which case this command would exit with error and thus also devstack. Better \u0027rf -f\u0027","commit_id":"646b4f190a5d89c283b287d749678809fe0e15d3"}],"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"bb8202cd470cf14a1fed51a1b2295b8d81257c0c","unresolved":false,"context_lines":[{"line_number":379,"context_line":"fi"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"# Add syslog-ng"},{"line_number":382,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence syslog-ng\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"# Allow full elements override"},{"line_number":385,"context_line":"if [ \"$DIB_ELEMENTS\" ]; then"}],"source_content_type":"text/x-sh","patch_set":11,"id":"1f769fc5_c29465eb","line":382,"range":{"start_line":382,"start_character":0,"end_line":382,"end_character":54},"updated":"2018-12-26 14:17:42.000000000","message":"No? :/","commit_id":"035b75d1eab5f12a9d2576718de17a121bcb1ea3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"81d19ad336d6264c79d0eeca85f40ec710dff699","unresolved":false,"context_lines":[{"line_number":379,"context_line":"fi"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"# Add syslog-ng"},{"line_number":382,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence syslog-ng\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"# Allow full elements override"},{"line_number":385,"context_line":"if [ \"$DIB_ELEMENTS\" ]; then"}],"source_content_type":"text/x-sh","patch_set":11,"id":"1f769fc5_daec1c2b","line":382,"range":{"start_line":382,"start_character":0,"end_line":382,"end_character":54},"in_reply_to":"1f769fc5_c29465eb","updated":"2019-01-02 18:25:26.000000000","message":"Done","commit_id":"035b75d1eab5f12a9d2576718de17a121bcb1ea3"}],"doc/source/admin/log-offloading.rst":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c468579a1b9362937a9d9edca5c38402d2858581","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Octavia Amphorae can offload their log files via the syslog protocol to syslog"},{"line_number":21,"context_line":"receivers via the load balancer management network(lb-mgmt-net). This allows"},{"line_number":22,"context_line":"log aggregation of both administrative logs but also tenant traffic flow logs."},{"line_number":23,"context_line":"The syslog receivers can either be local to the load balancer management"},{"line_number":24,"context_line":"network or routable via the load balancer management network."},{"line_number":25,"context_line":"By default any syslog receiver that supports UDP or TCP syslog protocol can"}],"source_content_type":"text/x-rst","patch_set":22,"id":"9fb8cfa7_816e92c6","line":22,"range":{"start_line":22,"start_character":44,"end_line":22,"end_character":47},"updated":"2019-06-13 23:50:33.000000000","message":"and","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c468579a1b9362937a9d9edca5c38402d2858581","unresolved":false,"context_lines":[{"line_number":25,"context_line":"By default any syslog receiver that supports UDP or TCP syslog protocol can"},{"line_number":26,"context_line":"be used, however the operator also has the option to create an override"},{"line_number":27,"context_line":"rsyslog configuration template to enable other features or protocols their"},{"line_number":28,"context_line":"amphroa image may support."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The default logging configuration will store the logs locally, on the amphora"},{"line_number":31,"context_line":"filesystem with file rotation."}],"source_content_type":"text/x-rst","patch_set":22,"id":"9fb8cfa7_416c1acd","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":7},"updated":"2019-06-13 23:50:33.000000000","message":"amphora","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c468579a1b9362937a9d9edca5c38402d2858581","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    [amphora_agent]"},{"line_number":91,"context_line":"    administrative_log_facility \u003d 1"},{"line_number":92,"context_line":" "},{"line_number":93,"context_line":"Forwarding All Administrative Logs"},{"line_number":94,"context_line":"----------------------------------"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"9fb8cfa7_0162a2d8","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":1},"updated":"2019-06-13 23:50:33.000000000","message":"assume you fixed this","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c468579a1b9362937a9d9edca5c38402d2858581","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"One or more syslog receiver endpoints must be configured in the Octavia"},{"line_number":123,"context_line":"configuration file to enable tenant flow log offloading. The first endpoint"},{"line_number":124,"context_line":"will be the primary endpoint to recieve the syslog packets. Should the first"},{"line_number":125,"context_line":"endpoint become unavailable, the additional endpoints listed will be tried"},{"line_number":126,"context_line":"one at a time. The endpoints configured for tenant flow log offloading may be"},{"line_number":127,"context_line":"the same endpoints as the administrative log offloading configuration."}],"source_content_type":"text/x-rst","patch_set":22,"id":"9fb8cfa7_215d6614","line":124,"range":{"start_line":124,"start_character":32,"end_line":124,"end_character":39},"updated":"2019-06-13 23:50:33.000000000","message":"receive","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c468579a1b9362937a9d9edca5c38402d2858581","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    Tenant flow logging can produce a large number of syslog messages"},{"line_number":132,"context_line":"    depending on how many connections the load balancers are receiving."},{"line_number":133,"context_line":"    Tenant flow logging produces one log entry per connection to the"},{"line_number":134,"context_line":"    load balancer. We recommend you monitor, size, and configure  your syslog"},{"line_number":135,"context_line":"    receivers appropriately based on the expected number of connections your"},{"line_number":136,"context_line":"    load balancers will be handling."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"9fb8cfa7_c19d6abc","line":134,"range":{"start_line":134,"start_character":65,"end_line":134,"end_character":66},"updated":"2019-06-13 23:50:33.000000000","message":"double-space","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c468579a1b9362937a9d9edca5c38402d2858581","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    pool_id member_id processing_time(ms) termination_state"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Any field that is unknown or not applicable to the connection will have a \u0027-\u0027"},{"line_number":187,"context_line":"character in it\u0027s place."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Disabling Logging"},{"line_number":190,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"9fb8cfa7_41b17a46","line":187,"range":{"start_line":187,"start_character":13,"end_line":187,"end_character":17},"updated":"2019-06-13 23:50:33.000000000","message":"its","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c468579a1b9362937a9d9edca5c38402d2858581","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":".. note::"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    If you enable this setting and are not using Amphroa log offloading,"},{"line_number":212,"context_line":"    we recommend you also `Disable Tenant Flow Logging`_ to improve load"},{"line_number":213,"context_line":"    balancing performance."},{"line_number":214,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"9fb8cfa7_e1898e74","line":211,"range":{"start_line":211,"start_character":49,"end_line":211,"end_character":56},"updated":"2019-06-13 23:50:33.000000000","message":"Amphora","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c468579a1b9362937a9d9edca5c38402d2858581","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    we recommend you also `Disable Tenant Flow Logging`_ to improve load"},{"line_number":213,"context_line":"    balancing performance."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"To disable local log storage in the amphora, set the following setting in your"},{"line_number":216,"context_line":"Octavia configuration file for all of the controllers and restart them:"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":22,"id":"9fb8cfa7_21b2464a","line":215,"range":{"start_line":215,"start_character":36,"end_line":215,"end_character":37},"updated":"2019-06-13 23:50:33.000000000","message":"You switch back and forth a lot between capitalizing all instances of Amphora and not. Which did we generally agree is correct?","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c468579a1b9362937a9d9edca5c38402d2858581","unresolved":false,"context_lines":[{"line_number":223,"context_line":"Disable Tenant Flow Logging"},{"line_number":224,"context_line":"---------------------------"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"This setting allows you to disable tenant flow logging irregardless of the"},{"line_number":227,"context_line":"other logging configuration settings. It will take precident over the other"},{"line_number":228,"context_line":"settings. When this setting is enabled, no tenant flow (connection) logs will"},{"line_number":229,"context_line":"be written to the disk inside the amphora or be sent via the Amphora log"}],"source_content_type":"text/x-rst","patch_set":22,"id":"9fb8cfa7_817c5272","line":226,"range":{"start_line":226,"start_character":55,"end_line":226,"end_character":67},"updated":"2019-06-13 23:50:33.000000000","message":"this is not a word","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c468579a1b9362937a9d9edca5c38402d2858581","unresolved":false,"context_lines":[{"line_number":224,"context_line":"---------------------------"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"This setting allows you to disable tenant flow logging irregardless of the"},{"line_number":227,"context_line":"other logging configuration settings. It will take precident over the other"},{"line_number":228,"context_line":"settings. When this setting is enabled, no tenant flow (connection) logs will"},{"line_number":229,"context_line":"be written to the disk inside the amphora or be sent via the Amphora log"},{"line_number":230,"context_line":"offloading."}],"source_content_type":"text/x-rst","patch_set":22,"id":"9fb8cfa7_61959e86","line":227,"range":{"start_line":227,"start_character":51,"end_line":227,"end_character":60},"updated":"2019-06-13 23:50:33.000000000","message":"precedent","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a85a077c3b9966bdd25cdb460f41105bb6216f2c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Octavia Amphorae can offload their log files via the syslog protocol to syslog"},{"line_number":21,"context_line":"receivers via the load balancer management network(lb-mgmt-net). This allows"},{"line_number":22,"context_line":"log aggregation of both administrative logs and also tenant traffic flow logs."},{"line_number":23,"context_line":"The syslog receivers can either be local to the load balancer management"},{"line_number":24,"context_line":"network or routable via the load balancer management network."}],"source_content_type":"text/x-rst","patch_set":23,"id":"9fb8cfa7_e7c75963","line":21,"updated":"2019-06-14 12:32:06.000000000","message":"nit: add whitespace","commit_id":"646b4f190a5d89c283b287d749678809fe0e15d3"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a85a077c3b9966bdd25cdb460f41105bb6216f2c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"rsyslog configuration template to enable other features or protocols their"},{"line_number":28,"context_line":"Amphora image may support."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The default logging configuration will store the logs locally, on the amphora"},{"line_number":31,"context_line":"filesystem with file rotation."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This guide will discuss the features of Amphora log offloading and how to"}],"source_content_type":"text/x-rst","patch_set":23,"id":"9fb8cfa7_278011f5","line":30,"updated":"2019-06-14 12:32:06.000000000","message":"I got a bit confused when I reached this sentence. In the paragraph above, it talks about offloading while on this one says the default is local, and then the next paragraph (L33) continues on offloading. How about moving this sentence to the very beginning of the section?","commit_id":"646b4f190a5d89c283b287d749678809fe0e15d3"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a85a077c3b9966bdd25cdb460f41105bb6216f2c","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":".. note::"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    Secondary syslog endpoints will only be used if the log_protocol is"},{"line_number":59,"context_line":"    configured for TCP. With the UDP syslog protocol, rsyslog is unable"},{"line_number":60,"context_line":"    to detect if the primary endpoint has failed."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"9fb8cfa7_a7c081e2","line":58,"updated":"2019-06-14 12:32:06.000000000","message":"Nice touch!","commit_id":"646b4f190a5d89c283b287d749678809fe0e15d3"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a85a077c3b9966bdd25cdb460f41105bb6216f2c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    Tenant flow logging can produce a large number of syslog messages"},{"line_number":132,"context_line":"    depending on how many connections the load balancers are receiving."},{"line_number":133,"context_line":"    Tenant flow logging produces one log entry per connection to the"},{"line_number":134,"context_line":"    load balancer. We recommend you monitor, size, and configure your syslog"},{"line_number":135,"context_line":"    receivers appropriately based on the expected number of connections your"},{"line_number":136,"context_line":"    load balancers will be handling."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"9fb8cfa7_bdd88e52","line":134,"range":{"start_line":134,"start_character":43,"end_line":134,"end_character":44},"updated":"2019-06-14 12:32:06.000000000","message":"nit: remove comma","commit_id":"646b4f190a5d89c283b287d749678809fe0e15d3"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f3d61aae643fbeb6e6d271598b68570268af6027","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    we recommend you also `Disable Tenant Flow Logging`_ to improve load"},{"line_number":244,"context_line":"    balancing performance."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"To disable local log storage in the amphora, set the following setting in your"},{"line_number":247,"context_line":"Octavia configuration file for all of the controllers and restart them:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":23,"id":"9fb8cfa7_81b0d2de","line":246,"range":{"start_line":246,"start_character":36,"end_line":246,"end_character":37},"updated":"2019-06-14 00:32:07.000000000","message":"looks like you got most of them EXCEPT this one, which is hilarious :D but I also don\u0027t care so much that I need another patch at the moment","commit_id":"646b4f190a5d89c283b287d749678809fe0e15d3"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f3d61aae643fbeb6e6d271598b68570268af6027","unresolved":false,"context_lines":[{"line_number":254,"context_line":"Disable Tenant Flow Logging"},{"line_number":255,"context_line":"---------------------------"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"This setting allows you to disable tenant flow logging irrespective of the"},{"line_number":258,"context_line":"other logging configuration settings. It will take precedent over the other"},{"line_number":259,"context_line":"settings. When this setting is enabled, no tenant flow (connection) logs will"},{"line_number":260,"context_line":"be written to the disk inside the Amphora or be sent via the Amphora log"}],"source_content_type":"text/x-rst","patch_set":23,"id":"9fb8cfa7_41ce5a63","line":257,"range":{"start_line":257,"start_character":55,"end_line":257,"end_character":67},"updated":"2019-06-14 00:32:07.000000000","message":"you could also have just said \"regardless\", I didn\u0027t mean you had to find a synonym :D","commit_id":"646b4f190a5d89c283b287d749678809fe0e15d3"}],"octavia/amphorae/backends/logging/logging_jinja_cfg.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"14f0c2475a58c3982418ff29fc38c620347b4131","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_df57505c","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":58},"updated":"2018-12-13 09:10:07.000000000","message":"Time traveler? :)","commit_id":"0d166d03b8d5d81ce0915beee886ef108940d766"}],"octavia/amphorae/backends/logging/templates/10-rsyslog.conf.template":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a0f4d4a33f6bd50649a5184b860fb3f30ab53ccd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u0026~ # don\u0027t store haproxy logs locally (GDPR)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# forward keepalived"},{"line_number":18,"context_line":"if $programname startswith \u0027Keepalived_vrrp\u0027 then action(type\u003d\"omfwd\" target\u003d\"{{ target_host }}\" port\u003d\"{{ port }}\" protocol\u003d\"{{ protocol }}\""},{"line_number":19,"context_line":"            action.resumeRetryCount\u003d\"{{ retry_count }}\""},{"line_number":20,"context_line":"            queue.type\u003d\"linkedList\" queue.size\u003d\"{{ queue_size }}\")"},{"line_number":21,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"1f769fc5_2db76189","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":43},"updated":"2018-12-23 15:52:29.000000000","message":"There are other keepalived messages (Keepalived_healthcheckers and Keepalived). Better forward those too, so \"startswith \u0027Keepalived\u0027 [...]\"","commit_id":"dbdf71b708407b33ba5f83c72308f79e5958c688"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d7d00bea400b24f2277817efec217494f7349e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u0026~ # don\u0027t store haproxy logs locally (GDPR)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# forward keepalived"},{"line_number":18,"context_line":"if $programname startswith \u0027Keepalived_vrrp\u0027 then action(type\u003d\"omfwd\" target\u003d\"{{ target_host }}\" port\u003d\"{{ port }}\" protocol\u003d\"{{ protocol }}\""},{"line_number":19,"context_line":"            action.resumeRetryCount\u003d\"{{ retry_count }}\""},{"line_number":20,"context_line":"            queue.type\u003d\"linkedList\" queue.size\u003d\"{{ queue_size }}\")"},{"line_number":21,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"1f769fc5_c66c879e","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":43},"in_reply_to":"1f769fc5_2db76189","updated":"2018-12-24 17:38:53.000000000","message":"Done","commit_id":"dbdf71b708407b33ba5f83c72308f79e5958c688"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a0f4d4a33f6bd50649a5184b860fb3f30ab53ccd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"if $programname startswith \u0027Keepalived_vrrp\u0027 then action(type\u003d\"omfwd\" target\u003d\"{{ target_host }}\" port\u003d\"{{ port }}\" protocol\u003d\"{{ protocol }}\""},{"line_number":19,"context_line":"            action.resumeRetryCount\u003d\"{{ retry_count }}\""},{"line_number":20,"context_line":"            queue.type\u003d\"linkedList\" queue.size\u003d\"{{ queue_size }}\")"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# forward amphora-agent"},{"line_number":23,"context_line":"if $programname startswith \u0027amphora-agent\u0027  then action(type\u003d\"omfwd\" target\u003d\"{{ target_host }}\" port\u003d\"{{ port }}\" protocol\u003d\"{{ protocol }}\""},{"line_number":24,"context_line":"            action.resumeRetryCount\u003d\"{{ retry_count }}\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"1f769fc5_cd034d0f","line":21,"updated":"2018-12-23 15:52:29.000000000","message":"There are other relevant messages not being logged. For example: cloud-init, dhcplient, ec2, ip, awk.\n\nWhy not just forward all messages?\n\nOutput examples:\n\nDec 23 15:39:52 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: Cloud-init v. 18.2 running \u0027init\u0027 at Sun, 23 Dec 2018 15:39:50 +0000. Up 194.87 seconds.\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: ++++++++++++++++++++++++++++++Net device info+++++++++++++++++++++++++++++++\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: +--------+------+--------------+---------------+-------+-------------------+\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: | Device |  Up  |   Address    |      Mask     | Scope |     Hw-Address    |\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: +--------+------+--------------+---------------+-------+-------------------+\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: | eth0:  | True | 192.168.0.35 | 255.255.255.0 |   .   | fa:16:3e:3f:60:f1 |\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: | eth0:  | True |      .       |       .       |   d   | fa:16:3e:3f:60:f1 |\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: |  lo:   | True |  127.0.0.1   |   255.0.0.0   |   .   |         .         |\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: |  lo:   | True |      .       |       .       |   d   |         .         |\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: +--------+------+--------------+---------------+-------+-------------------+\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: +++++++++++++++++++++++++++++Route IPv4 info+++++++++++++++++++++++++++++\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: +-------+-------------+-------------+---------------+-----------+-------+\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: | Route | Destination |   Gateway   |    Genmask    | Interface | Flags |\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: +-------+-------------+-------------+---------------+-----------+-------+\nDec 23 15:39:54 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: |   0   |   0.0.0.0   | 192.168.0.1 |    0.0.0.0    |    eth0   |   UG  |\nDec 23 15:39:55 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: |   1   | 169.254.0.0 |   0.0.0.0   |  255.255.0.0  |    eth0   |   U   |\nDec 23 15:39:55 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: |   2   | 192.168.0.0 |   0.0.0.0   | 255.255.255.0 |    eth0   |   U   |\nDec 23 15:39:55 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal cloud-init[1845]: ci-info: +-------+-------------+-------------+---------------+-----------+-------+\n\n\nDec 23 15:41:23 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ec2[2299]: #############################################################\nDec 23 15:41:23 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ec2[2299]: -----BEGIN SSH HOST KEY FINGERPRINTS-----\nDec 23 15:41:23 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ec2[2299]: 256 SHA256:mycEF3q/KzSos6yTGYZRpe4fPJ8jvltqg1AMHh1oP4k no comment (ECDSA)\nDec 23 15:41:23 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ec2[2299]: 256 SHA256:0eRQHXt7GlP1wujx2OfrMxwEn63uerFTE4CZy5G2G6I no comment (ED25519)\nDec 23 15:41:24 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ec2[2299]: 2048 SHA256:A+3YJe3zGuyXc62eXPKpMWLAH6LsaKk4fSZymy2sEgU no comment (RSA)\nDec 23 15:41:24 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ec2[2299]: -----END SSH HOST KEY FINGERPRINTS-----\nDec 23 15:41:24 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ec2[2299]: #############################################################\n\n\nDec 23 15:42:52 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ip[2592]: sysctl: setting key \"net.netfilter.nf_conntrack_buckets\": No such file or directory\nDec 23 15:42:52 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ip[2592]: * Applying /etc/sysctl.conf ...\nDec 23 15:42:53 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ip[2596]: net.ipv4.ip_forward \u003d 1\nDec 23 15:42:53 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ip[2597]: net.ipv4.vs.conntrack \u003d 1\nDec 23 15:42:53 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal ip[2599]: net.ipv6.conf.all.forwarding \u003d 1\nDec 23 15:42:57 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal awk[2613]: RTNETLINK answers: File exists\nDec 23 15:42:58 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal awk[2613]: ERROR     : [/etc/sysconfig/network-scripts/ifup-ipv6] Global IPv6 forwarding is disabled in configuration, but not currently disabled in kernel\nDec 23 15:42:58 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal /etc/sysconfig/network-scripts/ifup-ipv6[2660]: Global IPv6 forwarding is disabled in configuration, but not currently disabled in kernel\nDec 23 15:42:58 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal awk[2613]: ERROR     : [/etc/sysconfig/network-scripts/ifup-ipv6] Please restart network with \u0027/sbin/service network restart\u0027\nDec 23 15:42:58 amphora-2f2c9ee8-6769-4d89-9fea-ab8ab3817735.novalocal /etc/sysconfig/network-scripts/ifup-ipv6[2661]: Please restart network with \u0027/sbin/service network restart\u0027","commit_id":"dbdf71b708407b33ba5f83c72308f79e5958c688"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2421a72a68bc63d7461089342a5b239a010fa92c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"if $programname startswith \u0027Keepalived_vrrp\u0027 then action(type\u003d\"omfwd\" target\u003d\"{{ target_host }}\" port\u003d\"{{ port }}\" protocol\u003d\"{{ protocol }}\""},{"line_number":19,"context_line":"            action.resumeRetryCount\u003d\"{{ retry_count }}\""},{"line_number":20,"context_line":"            queue.type\u003d\"linkedList\" queue.size\u003d\"{{ queue_size }}\")"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# forward amphora-agent"},{"line_number":23,"context_line":"if $programname startswith \u0027amphora-agent\u0027  then action(type\u003d\"omfwd\" target\u003d\"{{ target_host }}\" port\u003d\"{{ port }}\" protocol\u003d\"{{ protocol }}\""},{"line_number":24,"context_line":"            action.resumeRetryCount\u003d\"{{ retry_count }}\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"1f769fc5_e6fe63ad","line":21,"in_reply_to":"1f769fc5_86044fc8","updated":"2018-12-24 17:51:47.000000000","message":"I\u0027d argue that cloud-init, dhclient, ec2, ip and awk would be good to include by default because they\u0027re tools used to set up amphorae and logged only once at boot.\n\nKeepalived on the other hand will log GARP messages every 2 seconds.","commit_id":"dbdf71b708407b33ba5f83c72308f79e5958c688"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d7d00bea400b24f2277817efec217494f7349e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"if $programname startswith \u0027Keepalived_vrrp\u0027 then action(type\u003d\"omfwd\" target\u003d\"{{ target_host }}\" port\u003d\"{{ port }}\" protocol\u003d\"{{ protocol }}\""},{"line_number":19,"context_line":"            action.resumeRetryCount\u003d\"{{ retry_count }}\""},{"line_number":20,"context_line":"            queue.type\u003d\"linkedList\" queue.size\u003d\"{{ queue_size }}\")"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# forward amphora-agent"},{"line_number":23,"context_line":"if $programname startswith \u0027amphora-agent\u0027  then action(type\u003d\"omfwd\" target\u003d\"{{ target_host }}\" port\u003d\"{{ port }}\" protocol\u003d\"{{ protocol }}\""},{"line_number":24,"context_line":"            action.resumeRetryCount\u003d\"{{ retry_count }}\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"1f769fc5_86044fc8","line":21,"in_reply_to":"1f769fc5_cd034d0f","updated":"2018-12-24 17:38:53.000000000","message":"I had that and found it too verbose. But I also make the template configurable (aka you can put in your own). Not sure if we should have our default be as verbose as possible or more restrained and people add to it as needed.","commit_id":"dbdf71b708407b33ba5f83c72308f79e5958c688"}],"octavia/common/config.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"14f0c2475a58c3982418ff29fc38c620347b4131","unresolved":false,"context_lines":[{"line_number":600,"context_line":"cfg.CONF.register_opts(core_opts)"},{"line_number":601,"context_line":"cfg.CONF.register_opts(api_opts, group\u003d\u0027api_settings\u0027)"},{"line_number":602,"context_line":"cfg.CONF.register_opts(amphora_agent_opts, group\u003d\u0027amphora_agent\u0027)"},{"line_number":603,"context_line":"cfg.CONF.register_opts(amphora_logging_opts, group\u003d\u0027amphora_logging\u0027)"},{"line_number":604,"context_line":"cfg.CONF.register_opts(networking_opts, group\u003d\u0027networking\u0027)"},{"line_number":605,"context_line":"cfg.CONF.register_opts(oslo_messaging_opts, group\u003d\u0027oslo_messaging\u0027)"},{"line_number":606,"context_line":"cfg.CONF.register_opts(haproxy_amphora_opts, group\u003d\u0027haproxy_amphora\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_df8af0c1","line":603,"range":{"start_line":603,"start_character":0,"end_line":603,"end_character":69},"updated":"2018-12-13 09:10:07.000000000","message":"Perhaps these new opts would fit better in the amphora_agent group. Else we might end up sooner or later with too many amphora driver specific config groups.","commit_id":"0d166d03b8d5d81ce0915beee886ef108940d766"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a85a077c3b9966bdd25cdb460f41105bb6216f2c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"               help\u003d_(\u0027LOG_LOCAL facility number to use for amphora processes \u0027"},{"line_number":140,"context_line":"                      \u0027logs.\u0027)),"},{"line_number":141,"context_line":"    cfg.StrOpt(\u0027log_protocol\u0027, default\u003d\u0027udp\u0027,"},{"line_number":142,"context_line":"               help\u003d_(\"The log forwarding transport protocol. One of udp or \""},{"line_number":143,"context_line":"                      \"tcp.\")),"},{"line_number":144,"context_line":"    cfg.IntOpt(\u0027log_retry_count\u0027, default\u003d5,"},{"line_number":145,"context_line":"               help\u003d_(\u0027The maximum attempts to retry connecting to the \u0027"},{"line_number":146,"context_line":"                      \u0027logging host.\u0027)),"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_fd704642","line":143,"range":{"start_line":142,"start_character":62,"end_line":143,"end_character":27},"updated":"2019-06-14 12:32:06.000000000","message":"We could use \u0027choices\u0027 from oslo opts.\n\nhttps://docs.openstack.org/oslo.config/latest/reference/opts.html","commit_id":"646b4f190a5d89c283b287d749678809fe0e15d3"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a85a077c3b9966bdd25cdb460f41105bb6216f2c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"               help\u003d_(\u0027The time, in seconds, to wait between retries \u0027"},{"line_number":149,"context_line":"                      \u0027connecting to the logging host.\u0027)),"},{"line_number":150,"context_line":"    cfg.IntOpt(\u0027log_queue_size\u0027, default\u003d10000,"},{"line_number":151,"context_line":"               help\u003d_(\u0027The queue size to buffer log messages.\u0027)),"},{"line_number":152,"context_line":"    cfg.StrOpt(\u0027logging_template_override\u0027,"},{"line_number":153,"context_line":"               help\u003d_(\u0027Custom logging configuration template.\u0027)),"},{"line_number":154,"context_line":"    cfg.BoolOpt(\u0027forward_all_logs\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_5d97123b","line":151,"range":{"start_line":151,"start_character":33,"end_line":151,"end_character":37},"updated":"2019-06-14 12:32:06.000000000","message":"in bytes?","commit_id":"646b4f190a5d89c283b287d749678809fe0e15d3"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a85a077c3b9966bdd25cdb460f41105bb6216f2c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"               help\u003d_(\u0027Custom logging configuration template.\u0027)),"},{"line_number":154,"context_line":"    cfg.BoolOpt(\u0027forward_all_logs\u0027, default\u003dFalse,"},{"line_number":155,"context_line":"                help\u003d_(\u0027When True, the amphora will forward all of the \u0027"},{"line_number":156,"context_line":"                       \u0027system logs(except tenant traffic logs) to the \u0027"},{"line_number":157,"context_line":"                       \u0027admin log target(s). When False, \u0027"},{"line_number":158,"context_line":"                       \u0027only amphora specific admin logs will be forwarded.\u0027)),"},{"line_number":159,"context_line":"    cfg.BoolOpt(\u0027disable_local_log_storage\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_3da01e90","line":156,"range":{"start_line":156,"start_character":31,"end_line":156,"end_character":42},"updated":"2019-06-14 12:32:06.000000000","message":"nit: add whitespace","commit_id":"646b4f190a5d89c283b287d749678809fe0e15d3"}],"octavia/common/jinja/logging/logging_jinja_cfg.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0886eea05377ef87800097611f65df0f401ce6a5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def build_logging_config(self):"},{"line_number":39,"context_line":"        admin_log_hosts \u003d []"},{"line_number":40,"context_line":"        for server in CONF.amphora_agent.admin_log_targets or []:"},{"line_number":41,"context_line":"            (host, port) \u003d server.split(\u0027:\u0027)"},{"line_number":42,"context_line":"            admin_log_hosts.append({"},{"line_number":43,"context_line":"                \u0027host\u0027: host,"},{"line_number":44,"context_line":"                \u0027port\u0027: port,"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fb8cfa7_e5be88d3","line":41,"updated":"2019-06-13 12:02:58.000000000","message":"I think we should make this part IPv6 compatible","commit_id":"d61f422bccbe2b28290f438e757b88e478c820ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9dce2aeecad1dd3fc6e8ec499de481ffb67a9b13","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def build_logging_config(self):"},{"line_number":39,"context_line":"        admin_log_hosts \u003d []"},{"line_number":40,"context_line":"        for server in CONF.amphora_agent.admin_log_targets or []:"},{"line_number":41,"context_line":"            (host, port) \u003d server.split(\u0027:\u0027)"},{"line_number":42,"context_line":"            admin_log_hosts.append({"},{"line_number":43,"context_line":"                \u0027host\u0027: host,"},{"line_number":44,"context_line":"                \u0027port\u0027: port,"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fb8cfa7_6e16f04b","line":41,"in_reply_to":"9fb8cfa7_e5be88d3","updated":"2019-06-13 17:26:32.000000000","message":"100% correct!  Thank you.","commit_id":"d61f422bccbe2b28290f438e757b88e478c820ec"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0886eea05377ef87800097611f65df0f401ce6a5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            })"},{"line_number":46,"context_line":"        tenant_log_hosts \u003d []"},{"line_number":47,"context_line":"        for server in CONF.amphora_agent.tenant_log_targets or []:"},{"line_number":48,"context_line":"            (host, port) \u003d server.split(\u0027:\u0027)"},{"line_number":49,"context_line":"            tenant_log_hosts.append({"},{"line_number":50,"context_line":"                \u0027host\u0027: host,"},{"line_number":51,"context_line":"                \u0027port\u0027: port,"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fb8cfa7_05c2bc59","line":48,"updated":"2019-06-13 12:02:58.000000000","message":"same here","commit_id":"d61f422bccbe2b28290f438e757b88e478c820ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9dce2aeecad1dd3fc6e8ec499de481ffb67a9b13","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            })"},{"line_number":46,"context_line":"        tenant_log_hosts \u003d []"},{"line_number":47,"context_line":"        for server in CONF.amphora_agent.tenant_log_targets or []:"},{"line_number":48,"context_line":"            (host, port) \u003d server.split(\u0027:\u0027)"},{"line_number":49,"context_line":"            tenant_log_hosts.append({"},{"line_number":50,"context_line":"                \u0027host\u0027: host,"},{"line_number":51,"context_line":"                \u0027port\u0027: port,"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fb8cfa7_ce203c9e","line":48,"in_reply_to":"9fb8cfa7_05c2bc59","updated":"2019-06-13 17:26:32.000000000","message":"Done","commit_id":"d61f422bccbe2b28290f438e757b88e478c820ec"}],"releasenotes/notes/Add-log-offloading-233cd8612c0dd2b5.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a85a077c3b9966bdd25cdb460f41105bb6216f2c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    balancer flow logs."},{"line_number":7,"context_line":"issues:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Amphora are unable to provide tenant flow logs for UDP listeners."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    To enable log offloading, the amphora image needs to be updated."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9fb8cfa7_bde2ced3","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":11},"updated":"2019-06-14 12:32:06.000000000","message":"nit: Amphorae","commit_id":"646b4f190a5d89c283b287d749678809fe0e15d3"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8a9691a8524ade212ab5ee5d015c27f5d3985678","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      zuul_copy_output:"},{"line_number":22,"context_line":"        \u0027/var/log/dib-build/\u0027: \u0027logs\u0027"},{"line_number":23,"context_line":"        \u0027/var/log/octavia-tenant-traffic.log\u0027: \u0027logs\u0027"},{"line_number":24,"context_line":"        \u0027/var/log/octavia-amphora.log\u0027: \u0027logs\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- job:"},{"line_number":27,"context_line":"    name: publish-openstack-octavia-amphora-image"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9fb8cfa7_413e5ac1","line":24,"updated":"2019-06-13 23:40:05.000000000","message":"Ahh, this is how you do this! Hadn\u0027t noticed before. Useful.","commit_id":"16bc8adb502e18c8b7fd2bef24f5468878b1c951"}]}
