)]}'
{"octavia/db/migration/alembic_migrations/versions/9bf4d21caaea_adding_amphora_id_to_listener_.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d004be68371d112df78e0f1d1b4ae3fc6160454c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    op.drop_constraint(\u0027fk_listener_statistics_listener_id\u0027,"},{"line_number":38,"context_line":"                       \u0027listener_statistics\u0027,"},{"line_number":39,"context_line":"                       type_\u003d\u0027foreignkey\u0027)"},{"line_number":40,"context_line":"    op.drop_constraint(\u0027listener_statistics_pkey\u0027,"},{"line_number":41,"context_line":"                       \u0027listener_statistics\u0027,"},{"line_number":42,"context_line":"                       type_\u003d\u0027primary\u0027)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_cc41aca8","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":50},"updated":"2019-02-22 09:24:54.000000000","message":"Actually it is better to lookup names of constraints names using sqlachemy Inspector if it was not set from the beginning as they can be different on different backends.\nSome similar examples from Neutron https://github.com/openstack/neutron/blob/master/neutron/db/migration/__init__.py#L265\nShould be something like:\n\n   inspector \u003d reflection.Inspector.from_engine(op.get_bind())\n   pk \u003d inspector.get_pk_constraint(\u0027listener_statistics\u0027)\n   op.drop_constraint(pk.name,\u0027listener_statistics\u0027,type_\u003d\u0027primary\u0027)","commit_id":"e5bfc113385dcc943c69e99d036eb42e5575eaef"},{"author":{"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},"change_message_id":"7d6b32d109aa71493eb86cb7e39eb5b53a95a57d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    op.drop_constraint(\u0027fk_listener_statistics_listener_id\u0027,"},{"line_number":38,"context_line":"                       \u0027listener_statistics\u0027,"},{"line_number":39,"context_line":"                       type_\u003d\u0027foreignkey\u0027)"},{"line_number":40,"context_line":"    op.drop_constraint(\u0027listener_statistics_pkey\u0027,"},{"line_number":41,"context_line":"                       \u0027listener_statistics\u0027,"},{"line_number":42,"context_line":"                       type_\u003d\u0027primary\u0027)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_cc00cc05","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":50},"in_reply_to":"9fdfeff1_cc41aca8","updated":"2019-02-22 09:47:18.000000000","message":"I\u0027ll take a look.","commit_id":"e5bfc113385dcc943c69e99d036eb42e5575eaef"}],"octavia/db/migration/alembic_migrations/versions/fac584114642_.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"482ba0bae4bd147040c61618ab409b377b45fc54","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    op.execute(\"UPDATE health_monitor SET id \u003d pool_id\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op.alter_column(\"health_monitor\", \"id\","},{"line_number":47,"context_line":"                    existing_type\u003dsa.String(length\u003d36), nullable\u003dFalse)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    op.drop_constraint(\"health_monitor_pkey\", \"health_monitor\","},{"line_number":50,"context_line":"                       type_\u003d\"primary\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_d50cf1ed","line":47,"range":{"start_line":47,"start_character":20,"end_line":47,"end_character":33},"updated":"2019-02-20 22:35:47.000000000","message":"This will not change the column type/size.\nI need to research if this should be the other keyword.","commit_id":"e5bfc113385dcc943c69e99d036eb42e5575eaef"},{"author":{"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},"change_message_id":"7d6b32d109aa71493eb86cb7e39eb5b53a95a57d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    op.execute(\"UPDATE health_monitor SET id \u003d pool_id\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op.alter_column(\"health_monitor\", \"id\","},{"line_number":47,"context_line":"                    existing_type\u003dsa.String(length\u003d36), nullable\u003dFalse)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    op.drop_constraint(\"health_monitor_pkey\", \"health_monitor\","},{"line_number":50,"context_line":"                       type_\u003d\"primary\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_2ce8787a","line":47,"range":{"start_line":47,"start_character":20,"end_line":47,"end_character":33},"in_reply_to":"9fdfeff1_2c8158c4","updated":"2019-02-22 09:47:18.000000000","message":"We don\u0027t want to change the type, we only want to change the nullable attribute.\nThe existing_type parameter is required for MySQL because it requires the full type to be specified when changing type attributes.","commit_id":"e5bfc113385dcc943c69e99d036eb42e5575eaef"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d004be68371d112df78e0f1d1b4ae3fc6160454c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    op.execute(\"UPDATE health_monitor SET id \u003d pool_id\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op.alter_column(\"health_monitor\", \"id\","},{"line_number":47,"context_line":"                    existing_type\u003dsa.String(length\u003d36), nullable\u003dFalse)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    op.drop_constraint(\"health_monitor_pkey\", \"health_monitor\","},{"line_number":50,"context_line":"                       type_\u003d\"primary\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_2c8158c4","line":47,"range":{"start_line":47,"start_character":20,"end_line":47,"end_character":33},"in_reply_to":"9fdfeff1_d50cf1ed","updated":"2019-02-22 09:24:54.000000000","message":"To modify type use type_ https://alembic.sqlalchemy.org/en/latest/ops.html?highlight\u003dunique#alembic.operations.Operations.alter_column.params.type_\nexisting_type - used to save existing type.","commit_id":"e5bfc113385dcc943c69e99d036eb42e5575eaef"}]}
