)]}'
{"octavia/api/common/pagination.py":[{"author":{"_account_id":29621,"name":"Rufei Xu","email":"891872629@qq.com"},"change_message_id":"4a385ae81f129d02468bd89118ad1e7c6f311973","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                query \u003d query.join(tag_alias, model._tags)"},{"line_number":199,"context_line":"                query \u003d query.filter(tag_alias.tag \u003d\u003d tag)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        if \u0027tags-any\u0027 in params:"},{"line_number":202,"context_line":"            tags \u003d params.pop(\u0027tags-any\u0027)"},{"line_number":203,"context_line":"            if not isinstance(tags, list):"},{"line_number":204,"context_line":"                tags \u003d [tags]"},{"line_number":205,"context_line":"            query \u003d query.join(tag_alias, model._tags)"},{"line_number":206,"context_line":"            query \u003d query.filter(tag_alias.tag.in_(tags))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        if \u0027not-tags\u0027 in params:"},{"line_number":209,"context_line":"            tags \u003d params.pop(\u0027not-tags\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_19f75d8d","line":206,"range":{"start_line":201,"start_character":0,"end_line":206,"end_character":57},"updated":"2019-02-02 07:53:56.000000000","message":"Seeems a resource with tags \"a\" and \"b\" not appears in the response when request \"tags-any\u003da,b\"","commit_id":"5df9ad49b3414d10b69d431763697a785d89e0ac"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"092503e6d451faba3db7f2e6fc089e9f88cc34e9","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                query \u003d query.join(tag_alias, model._tags)"},{"line_number":199,"context_line":"                query \u003d query.filter(tag_alias.tag \u003d\u003d tag)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        if \u0027tags-any\u0027 in params:"},{"line_number":202,"context_line":"            tags \u003d params.pop(\u0027tags-any\u0027)"},{"line_number":203,"context_line":"            if not isinstance(tags, list):"},{"line_number":204,"context_line":"                tags \u003d [tags]"},{"line_number":205,"context_line":"            query \u003d query.join(tag_alias, model._tags)"},{"line_number":206,"context_line":"            query \u003d query.filter(tag_alias.tag.in_(tags))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        if \u0027not-tags\u0027 in params:"},{"line_number":209,"context_line":"            tags \u003d params.pop(\u0027not-tags\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_99510d39","line":206,"range":{"start_line":201,"start_character":0,"end_line":206,"end_character":57},"in_reply_to":"9fdfeff1_19f75d8d","updated":"2019-02-02 09:57:38.000000000","message":"Could you please paste your command and result?","commit_id":"5df9ad49b3414d10b69d431763697a785d89e0ac"},{"author":{"_account_id":29621,"name":"Rufei Xu","email":"891872629@qq.com"},"change_message_id":"b61c607cfab1eeaf6b23fb9ad5b79dba4d5aa7fc","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                query \u003d query.join(tag_alias, model._tags)"},{"line_number":199,"context_line":"                query \u003d query.filter(tag_alias.tag \u003d\u003d tag)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        if \u0027tags-any\u0027 in params:"},{"line_number":202,"context_line":"            tags \u003d params.pop(\u0027tags-any\u0027)"},{"line_number":203,"context_line":"            if not isinstance(tags, list):"},{"line_number":204,"context_line":"                tags \u003d [tags]"},{"line_number":205,"context_line":"            query \u003d query.join(tag_alias, model._tags)"},{"line_number":206,"context_line":"            query \u003d query.filter(tag_alias.tag.in_(tags))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        if \u0027not-tags\u0027 in params:"},{"line_number":209,"context_line":"            tags \u003d params.pop(\u0027not-tags\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_55df6ed5","line":206,"range":{"start_line":201,"start_character":0,"end_line":206,"end_character":57},"in_reply_to":"9fdfeff1_99510d39","updated":"2019-02-11 08:59:03.000000000","message":"I use Postman to test. I have a loadbalancer like this:\n\"GET http://172.18.211.29:9876/v2/lbaas/loadbalancers/f2d10381-40af-421b-b109-e66e4c67f668\" response:\n{\n    \"loadbalancer\": {\n        \"provider\": \"amphora\",\n        \"description\": \"\",\n        \"admin_state_up\": true,\n        \"pools\": [\n            {\n                \"id\": \"193adc1f-dcb2-4f06-bc21-574f453280d0\"\n            },\n            {\n                \"id\": \"1e22660b-883a-4f48-8f48-07821cce56ca\"\n            },\n            {\n                \"id\": \"23e1768c-96b5-4bb6-a9ed-acf0e7585be5\"\n            },\n            {\n                \"id\": \"3a8729b2-7306-4552-8a7c-3f546abc455b\"\n            },\n            {\n                \"id\": \"94de419b-6858-44eb-b364-8c0101be3364\"\n            },\n            {\n                \"id\": \"c6c08292-7e27-46db-981b-1c404155fb9e\"\n            }\n        ],\n        \"created_at\": \"2018-12-10T05:25:44\",\n        \"provisioning_status\": \"ACTIVE\",\n        \"updated_at\": \"2019-02-02T06:46:44\",\n        \"vip_qos_policy_id\": null,\n        \"vip_network_id\": \"cbda175d-872d-4e79-8107-6320b8c9cf1a\",\n        \"listeners\": [\n            {\n                \"id\": \"00569188-057b-4bee-a487-ad45c4bd9bd4\"\n            },\n            {\n                \"id\": \"407d3197-edf7-4cca-8736-d53165d37204\"\n            },\n            {\n                \"id\": \"7d915e4b-381b-4892-a4f0-589464f53897\"\n            },\n            {\n                \"id\": \"db6bfffc-20b4-4e6d-b018-e03bcee9e4a7\"\n            }\n        ],\n        \"tags\": [\n            \"a\",\n            \"b\"\n        ],\n        \"vip_port_id\": \"5b5a13c1-bfdf-4e8b-bbed-53634fc6c63a\",\n        \"flavor_id\": null,\n        \"tenant_id\": \"5d01173ec14a48d8bfb482a5e0fed2f0\",\n        \"vip_address\": \"1.2.3.20\",\n        \"vip_subnet_id\": \"3053111e-2462-4692-b451-c4414f46d07a\",\n        \"project_id\": \"5d01173ec14a48d8bfb482a5e0fed2f0\",\n        \"id\": \"f2d10381-40af-421b-b109-e66e4c67f668\",\n        \"operating_status\": \"ONLINE\",\n        \"name\": \"xrf-lb\"\n    }\n}\n\nWhen \"GET http://172.18.211.29:9876/v2/lbaas/loadbalancers?tags-any\u003da,b\", response:\n{\n    \"loadbalancers\": [],\n    \"loadbalancers_links\": []\n}\n\nIn DB:\nMariaDB [octavia_rocky]\u003e select * from tags;\n+--------------------------------------+-----+\n| resource_id                          | tag |\n+--------------------------------------+-----+\n| f2d10381-40af-421b-b109-e66e4c67f668 | a   |\n| f2d10381-40af-421b-b109-e66e4c67f668 | b   |\n+--------------------------------------+-----+","commit_id":"5df9ad49b3414d10b69d431763697a785d89e0ac"},{"author":{"_account_id":29621,"name":"Rufei Xu","email":"891872629@qq.com"},"change_message_id":"5c50694e148cbb589686212628a38ed82caca465","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            query \u003d query.join(tag_alias, model._tags)"},{"line_number":206,"context_line":"            query \u003d query.filter(tag_alias.tag.in_(tags))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        if \u0027not-tags\u0027 in params:"},{"line_number":209,"context_line":"            tags \u003d params.pop(\u0027not-tags\u0027)"},{"line_number":210,"context_line":"            if not isinstance(tags, list):"},{"line_number":211,"context_line":"                tags \u003d [tags]"},{"line_number":212,"context_line":"            first_tag \u003d tags.pop(0)"},{"line_number":213,"context_line":"            subq \u003d query.session.query(base_models.Tags.resource_id)"},{"line_number":214,"context_line":"            subq \u003d subq.join(model._tags)"},{"line_number":215,"context_line":"            subq \u003d subq.filter(base_models.Tags.tag \u003d\u003d first_tag)"},{"line_number":216,"context_line":"            for tag in tags:"},{"line_number":217,"context_line":"                subq \u003d subq.join(tag_alias, model._tags)"},{"line_number":218,"context_line":"                subq \u003d subq.filter(tag_alias.tag \u003d\u003d tag)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"            query \u003d query.filter(~model.id.in_(subq))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if \u0027not-tags-any\u0027 in params:"},{"line_number":223,"context_line":"            tags \u003d params.pop(\u0027not-tags-any\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_59e885b1","line":220,"range":{"start_line":208,"start_character":0,"end_line":220,"end_character":53},"updated":"2019-02-02 07:44:22.000000000","message":"Seems a resource with tags \"a\" and \"b\" appears in the response when request \"not-tags\u003da,b\"","commit_id":"5df9ad49b3414d10b69d431763697a785d89e0ac"},{"author":{"_account_id":29621,"name":"Rufei Xu","email":"891872629@qq.com"},"change_message_id":"5c50694e148cbb589686212628a38ed82caca465","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"            query \u003d query.filter(~model.id.in_(subq))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if \u0027not-tags-any\u0027 in params:"},{"line_number":223,"context_line":"            tags \u003d params.pop(\u0027not-tags-any\u0027)"},{"line_number":224,"context_line":"            if not isinstance(tags, list):"},{"line_number":225,"context_line":"                tags \u003d [tags]"},{"line_number":226,"context_line":"            query \u003d query.filter("},{"line_number":227,"context_line":"                ~model._tags.any(base_models.Tags.tag.in_(tags)))"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        return query"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_39e581dc","line":227,"range":{"start_line":222,"start_character":0,"end_line":227,"end_character":65},"updated":"2019-02-02 07:44:22.000000000","message":"Seems a resource with tags \"a\" and \"b\" appears in the response when request \"not-tags-any\u003da,b\"","commit_id":"5df9ad49b3414d10b69d431763697a785d89e0ac"}],"octavia/tests/functional/api/v2/test_load_balancer.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9d8300218a154d0711dfb0f5491e28be49ab0389","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        ).json.get(self.root_tag_list)"},{"line_number":1206,"context_line":"        self.assertIsInstance(lbs, list)"},{"line_number":1207,"context_line":"        self.assertEqual(0, len(lbs))"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"    def test_get_all_hides_deleted(self):"},{"line_number":1210,"context_line":"        api_lb \u003d self.create_load_balancer("},{"line_number":1211,"context_line":"            uuidutils.generate_uuid()).get(self.root_tag)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_314facbe","line":1208,"updated":"2019-01-21 23:59:38.000000000","message":"I would like to see two more tests based on the api-wg specification.\nCan we have a test that combines two or more of the tags params? Like \"tags\" test_tag2 and not-tags test_tag1?\nThe spec example is: \"GET /servers?tags\u003dred,blue\u0026tags-any\u003dgreen,orange\"\nAlso one that tests the last part of the spec, that if we create a contradictory set of parameters, that we don\u0027t error, but return nothing?\nThe spec example is: \"GET /servers?tags\u003dred\u0026not-tags\u003dred\"","commit_id":"1a5229bb99e26cc9ebef90667acb68d5d6dc389b"}]}
