)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f17fb7d1c599c7e9d28529840c0a36898f9e0151","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    sudo mkdir -m 700 -p $OCTAVIA_RUN_DIR"},{"line_number":222,"context_line":"    safe_chown $STACK_USER $OCTAVIA_RUN_DIR"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    cp $OCTAVIA_DIR/etc/octavia.conf $OCTAVIA_CONF"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    if ! [ -e $OCTAVIA_AUDIT_MAP ] ; then"},{"line_number":227,"context_line":"        cp $OCTAVIA_DIR/etc/audit/octavia_api_audit_map.conf.sample $OCTAVIA_AUDIT_MAP"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_f19c520f","line":224,"updated":"2019-03-12 21:21:21.000000000","message":"Why is this needed? This means we are blindly overwriting previously pre-configured octavia.conf.\nRestacks already get cleaned up on line 536.","commit_id":"26e9c3a7c7d703cee5214899dd53b99a70ffe956"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"168427e2948190599a03bbf20033bc5d130e857d","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    cp $OCTAVIA_DIR/etc/octavia.conf $OCTAVIA_CONF"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    if ! [ -e $OCTAVIA_AUDIT_MAP ] ; then"},{"line_number":227,"context_line":"        cp $OCTAVIA_DIR/etc/audit/octavia_api_audit_map.conf.sample $OCTAVIA_AUDIT_MAP"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    # Use devstack logging configuration"},{"line_number":231,"context_line":"    setup_logging $OCTAVIA_CONF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_8320324a","line":228,"range":{"start_line":226,"start_character":0,"end_line":228,"end_character":6},"updated":"2019-03-12 09:56:52.000000000","message":"Should we do the same with this config file?","commit_id":"26e9c3a7c7d703cee5214899dd53b99a70ffe956"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ddbfef14811d8c19d557057b282796e620d64314","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    cp $OCTAVIA_DIR/etc/octavia.conf $OCTAVIA_CONF"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    if ! [ -e $OCTAVIA_AUDIT_MAP ] ; then"},{"line_number":227,"context_line":"        cp $OCTAVIA_DIR/etc/audit/octavia_api_audit_map.conf.sample $OCTAVIA_AUDIT_MAP"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    # Use devstack logging configuration"},{"line_number":231,"context_line":"    setup_logging $OCTAVIA_CONF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_ecdec30f","line":228,"range":{"start_line":226,"start_character":0,"end_line":228,"end_character":6},"in_reply_to":"5fc1f717_43724a4b","updated":"2019-03-12 12:39:16.000000000","message":"I think you\u0027re just copying a sample generated by `tox -e genconfig` here, but obviously I\u0027m not sure, I don\u0027t know the project well enough. :)","commit_id":"26e9c3a7c7d703cee5214899dd53b99a70ffe956"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"d5477864972ab2704f5780e90f69552fb5ff6fb5","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    cp $OCTAVIA_DIR/etc/octavia.conf $OCTAVIA_CONF"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    if ! [ -e $OCTAVIA_AUDIT_MAP ] ; then"},{"line_number":227,"context_line":"        cp $OCTAVIA_DIR/etc/audit/octavia_api_audit_map.conf.sample $OCTAVIA_AUDIT_MAP"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    # Use devstack logging configuration"},{"line_number":231,"context_line":"    setup_logging $OCTAVIA_CONF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_43724a4b","line":228,"range":{"start_line":226,"start_character":0,"end_line":228,"end_character":6},"in_reply_to":"5fc1f717_8320324a","updated":"2019-03-12 10:01:19.000000000","message":"I think this one should get a different treatment. It is explicit in its file name it is a sample and users changing the installed file are expected to be more advanced users. In any case, if others agree with always installing it fresh we can do that, sure.","commit_id":"26e9c3a7c7d703cee5214899dd53b99a70ffe956"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f17fb7d1c599c7e9d28529840c0a36898f9e0151","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    cp $OCTAVIA_DIR/etc/octavia.conf $OCTAVIA_CONF"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    if ! [ -e $OCTAVIA_AUDIT_MAP ] ; then"},{"line_number":227,"context_line":"        cp $OCTAVIA_DIR/etc/audit/octavia_api_audit_map.conf.sample $OCTAVIA_AUDIT_MAP"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    # Use devstack logging configuration"},{"line_number":231,"context_line":"    setup_logging $OCTAVIA_CONF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_11bb1e72","line":228,"range":{"start_line":226,"start_character":0,"end_line":228,"end_character":6},"in_reply_to":"5fc1f717_ecdec30f","updated":"2019-03-12 21:21:21.000000000","message":"This is the CADF audit map and not an oslo config file. It cannot be auto-generated.","commit_id":"26e9c3a7c7d703cee5214899dd53b99a70ffe956"}]}