)]}'
{"octavia/amphorae/drivers/health/heartbeat_udp.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"cc674ee9969c6f7edf6646f44b8a9beea96a7d5e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Return the current health futures executor.\"\"\""},{"line_number":35,"context_line":"    global _HEALTH_EXECUTOR"},{"line_number":36,"context_line":"    if _HEALTH_EXECUTOR is None:"},{"line_number":37,"context_line":"        _HEALTH_EXECUTOR \u003d futurist.ThreadPoolExecutor("},{"line_number":38,"context_line":"            max_workers\u003dCONF.health_manager.health_update_threads)"},{"line_number":39,"context_line":"    return _HEALTH_EXECUTOR"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_66414639","line":37,"updated":"2019-04-10 04:05:07.000000000","message":"GreenThreadPoolExecutor might be better here","commit_id":"404bed50516af432309e0525786f4866833c6d35"}],"octavia/cmd/health_manager.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"cc674ee9969c6f7edf6646f44b8a9beea96a7d5e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    CONF.mutate_config_files()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def create_udp_socket(ip, port):"},{"line_number":42,"context_line":"    sock \u003d None"},{"line_number":43,"context_line":"    for addrinfo in socket.getaddrinfo(ip, port, 0, socket.SOCK_DGRAM):"},{"line_number":44,"context_line":"        ai_family \u003d addrinfo[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_2647be4e","line":41,"updated":"2019-04-10 04:05:07.000000000","message":"Should this be moved somewhere else?","commit_id":"404bed50516af432309e0525786f4866833c6d35"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"cc674ee9969c6f7edf6646f44b8a9beea96a7d5e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if sock is not None:"},{"line_number":47,"context_line":"            sock.close()"},{"line_number":48,"context_line":"        sock \u003d socket.socket(ai_family, socket.SOCK_DGRAM)"},{"line_number":49,"context_line":"        sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT, 1)"},{"line_number":50,"context_line":"        sock.settimeout(1)"},{"line_number":51,"context_line":"        sock.bind(sockaddr)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_e67696a4","line":49,"updated":"2019-04-10 04:05:07.000000000","message":"This isn\u0027t really needed.","commit_id":"404bed50516af432309e0525786f4866833c6d35"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"cc674ee9969c6f7edf6646f44b8a9beea96a7d5e","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    workers \u003d CONF.health_manager.workers"},{"line_number":127,"context_line":"    if workers is None:"},{"line_number":128,"context_line":"        workers \u003d multiprocessing.cpu_count()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    hm_listener_procs \u003d []"},{"line_number":131,"context_line":"    for index in range(workers):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_067ac286","line":128,"updated":"2019-04-10 04:05:07.000000000","message":"With threads being set to two by default, we could potentially divide this by two.","commit_id":"404bed50516af432309e0525786f4866833c6d35"}],"octavia/common/config.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"cc674ee9969c6f7edf6646f44b8a9beea96a7d5e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"               help\u003d_(\u0027Number of processes for handling udp updates.\u0027)),"},{"line_number":174,"context_line":"    cfg.IntOpt(\u0027health_update_threads\u0027,"},{"line_number":175,"context_line":"               default\u003d2,"},{"line_number":176,"context_line":"               help\u003d_(\u0027Number of threads for amphora health update.\u0027)),"},{"line_number":177,"context_line":"    cfg.IntOpt(\u0027stats_update_threads\u0027,"},{"line_number":178,"context_line":"               default\u003d2,"},{"line_number":179,"context_line":"               help\u003d_(\u0027Number of threads for amphora stats update.\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_a66c0ed0","line":176,"updated":"2019-04-10 04:05:07.000000000","message":"*Number of threads PER process.","commit_id":"404bed50516af432309e0525786f4866833c6d35"}],"octavia/controller/healthmanager/health_manager.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"cc674ee9969c6f7edf6646f44b8a9beea96a7d5e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Return the current health futures executor.\"\"\""},{"line_number":36,"context_line":"    global _FAILOVER_EXECUTOR"},{"line_number":37,"context_line":"    if _FAILOVER_EXECUTOR is None:"},{"line_number":38,"context_line":"        _FAILOVER_EXECUTOR \u003d futures.ThreadPoolExecutor("},{"line_number":39,"context_line":"            max_workers\u003dCONF.health_manager.failover_threads)"},{"line_number":40,"context_line":"    return _FAILOVER_EXECUTOR"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_c66fdac1","line":38,"updated":"2019-04-10 04:05:07.000000000","message":"This could also be GreenThreadPoolExecutor\u0027s.","commit_id":"404bed50516af432309e0525786f4866833c6d35"}]}