)]}'
{"diskimage-create/README.rst":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"c1d7e569641f739ed71179115e2f3692744d406b","unresolved":false,"context_lines":[{"line_number":91,"context_line":".. line-block::"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    $ diskimage-create.sh"},{"line_number":94,"context_line":"            [-a i386 | **amd64** | armhf ]"},{"line_number":95,"context_line":"            [-b **haproxy** ]"},{"line_number":96,"context_line":"            [-c **~/.cache/image-create** | \u003ccache directory\u003e ]"},{"line_number":97,"context_line":"            [-d **xenial**/**7** | trusty | \u003cother release id\u003e ]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_f000d803","line":94,"updated":"2019-04-17 21:52:00.000000000","message":"need to add ppc64le here","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"b015cc2fa71416b43a006838acd9fbe0f92bf256","unresolved":false,"context_lines":[{"line_number":91,"context_line":".. line-block::"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    $ diskimage-create.sh"},{"line_number":94,"context_line":"            [-a i386 | **amd64** | armhf ]"},{"line_number":95,"context_line":"            [-b **haproxy** ]"},{"line_number":96,"context_line":"            [-c **~/.cache/image-create** | \u003ccache directory\u003e ]"},{"line_number":97,"context_line":"            [-d **xenial**/**7** | trusty | \u003cother release id\u003e ]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_71a94022","line":94,"in_reply_to":"3fce034c_f000d803","updated":"2019-04-18 14:10:33.000000000","message":"Done","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a6162e73c0b1358f6cb0a802fe23195244b9675a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        \u0027-c\u0027 is the path to the cache directory (default: ~/.cache/image-create)"},{"line_number":116,"context_line":"        \u0027-d\u0027 distribution release id (default on ubuntu: xenial)"},{"line_number":117,"context_line":"        \u0027-e\u0027 enable complete mandatory access control systems when available (default: permissive)"},{"line_number":118,"context_line":"        \u0027-f\u0027 disable temporary file system for build"},{"line_number":119,"context_line":"        \u0027-h\u0027 display help message"},{"line_number":120,"context_line":"        \u0027-i\u0027 is the base OS (default: ubuntu)"},{"line_number":121,"context_line":"        \u0027-l\u0027 is output logfile (default: none)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fce034c_5480b2c0","line":118,"updated":"2019-04-18 14:48:39.000000000","message":"I am still going to request we clarify this to tmpfs which is a specific type of \"temporary file system\"","commit_id":"b236fdb71271726bffc14400d4ce854df71d1e18"}],"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2cdc08d2b917b3895367229f49d2c4a5322c87b2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    echo \"        \u0027-c\u0027 is the path to the cache directory (default: ~/.cache/image-create)\""},{"line_number":45,"context_line":"    echo \"        \u0027-d\u0027 distribution release id (default on ubuntu: xenial)\""},{"line_number":46,"context_line":"    echo \"        \u0027-e\u0027 enable complete mandatory access control systems when available (default: permissive)\""},{"line_number":47,"context_line":"    echo \"        \u0027-f\u0027 disable temporary file system\""},{"line_number":48,"context_line":"    echo \"        \u0027-h\u0027 display this help message\""},{"line_number":49,"context_line":"    echo \"        \u0027-i\u0027 is the base OS (default: ubuntu)\""},{"line_number":50,"context_line":"    echo \"        \u0027-l\u0027 is output logfile (default: none)\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fce034c_eb2eb4f8","line":47,"updated":"2019-04-17 17:23:05.000000000","message":"Can we word this better? \"disable tmpfs for the build\" maybe?\nOtherwise this is confusing with /tmp","commit_id":"c52ce929d6df1770f171310251d30e2d1940a63e"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"329e78b8b89787859a7468a8a9babd2718d305f8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    echo \"        \u0027-c\u0027 is the path to the cache directory (default: ~/.cache/image-create)\""},{"line_number":45,"context_line":"    echo \"        \u0027-d\u0027 distribution release id (default on ubuntu: xenial)\""},{"line_number":46,"context_line":"    echo \"        \u0027-e\u0027 enable complete mandatory access control systems when available (default: permissive)\""},{"line_number":47,"context_line":"    echo \"        \u0027-f\u0027 disable temporary file system\""},{"line_number":48,"context_line":"    echo \"        \u0027-h\u0027 display this help message\""},{"line_number":49,"context_line":"    echo \"        \u0027-i\u0027 is the base OS (default: ubuntu)\""},{"line_number":50,"context_line":"    echo \"        \u0027-l\u0027 is output logfile (default: none)\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fce034c_cb63b819","line":47,"in_reply_to":"3fce034c_eb2eb4f8","updated":"2019-04-17 17:42:52.000000000","message":"Done.","commit_id":"c52ce929d6df1770f171310251d30e2d1940a63e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2cdc08d2b917b3895367229f49d2c4a5322c87b2","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    dib_trace_arg\u003d\"-x\""},{"line_number":414,"context_line":"fi"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"disk-image-create $AMP_LOGFILE $dib_trace_arg -a $AMP_ARCH -o $AMP_OUTPUTFILENAME -t $AMP_IMAGETYPE --image-size $AMP_IMAGESIZE --image-cache $AMP_CACHEDIR $AMP_element_sequence $AMP_DISABLE_TMP_FS"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"popd \u003e /dev/null # out of $TEMP"},{"line_number":419,"context_line":"rm -rf $TEMP"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fce034c_2b44bcb6","line":416,"updated":"2019-04-17 17:23:05.000000000","message":"For easier debugging, it would be best to move this before $AMP_element_sequence","commit_id":"c52ce929d6df1770f171310251d30e2d1940a63e"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"329e78b8b89787859a7468a8a9babd2718d305f8","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    dib_trace_arg\u003d\"-x\""},{"line_number":414,"context_line":"fi"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"disk-image-create $AMP_LOGFILE $dib_trace_arg -a $AMP_ARCH -o $AMP_OUTPUTFILENAME -t $AMP_IMAGETYPE --image-size $AMP_IMAGESIZE --image-cache $AMP_CACHEDIR $AMP_element_sequence $AMP_DISABLE_TMP_FS"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"popd \u003e /dev/null # out of $TEMP"},{"line_number":419,"context_line":"rm -rf $TEMP"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fce034c_2b7cbcb3","line":416,"in_reply_to":"3fce034c_2b44bcb6","updated":"2019-04-17 17:42:52.000000000","message":"Done","commit_id":"c52ce929d6df1770f171310251d30e2d1940a63e"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"c1d7e569641f739ed71179115e2f3692744d406b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    echo \"        \u0027-c\u0027 is the path to the cache directory (default: ~/.cache/image-create)\""},{"line_number":45,"context_line":"    echo \"        \u0027-d\u0027 distribution release id (default on ubuntu: xenial)\""},{"line_number":46,"context_line":"    echo \"        \u0027-e\u0027 enable complete mandatory access control systems when available (default: permissive)\""},{"line_number":47,"context_line":"    echo \"        \u0027-f\u0027 disable temporary file system for build\""},{"line_number":48,"context_line":"    echo \"        \u0027-h\u0027 display this help message\""},{"line_number":49,"context_line":"    echo \"        \u0027-i\u0027 is the base OS (default: ubuntu)\""},{"line_number":50,"context_line":"    echo \"        \u0027-l\u0027 is output logfile (default: none)\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fce034c_30b66040","line":47,"updated":"2019-04-17 21:52:00.000000000","message":"What is the problem with having tmpfs enabled? When would we recommend disabling it? Only specific to a subset of architectures?","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"19b133ac7ebe21eaf6e5d0f307eac7b2f9d43a9c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    echo \"        \u0027-c\u0027 is the path to the cache directory (default: ~/.cache/image-create)\""},{"line_number":45,"context_line":"    echo \"        \u0027-d\u0027 distribution release id (default on ubuntu: xenial)\""},{"line_number":46,"context_line":"    echo \"        \u0027-e\u0027 enable complete mandatory access control systems when available (default: permissive)\""},{"line_number":47,"context_line":"    echo \"        \u0027-f\u0027 disable temporary file system for build\""},{"line_number":48,"context_line":"    echo \"        \u0027-h\u0027 display this help message\""},{"line_number":49,"context_line":"    echo \"        \u0027-i\u0027 is the base OS (default: ubuntu)\""},{"line_number":50,"context_line":"    echo \"        \u0027-l\u0027 is output logfile (default: none)\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fce034c_ebb9cdcb","line":47,"in_reply_to":"3fce034c_30b66040","updated":"2019-04-17 22:35:49.000000000","message":"Yeah, I\u0027m actually very curious why this is a problem. I admittedly have not used ppc in a while, but to my knowledge ppc of all varieties should have perfect support for tmpfs. I assume the real issue is because PPC hardware has a tendency to be used in embedded systems and may be more likely to be RAM constrained, and therefore not be able to support a large enough tmpfs for these builds?","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e12d0420a6a0ebf807a743aeedfd8a051044a33f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    echo \"        \u0027-c\u0027 is the path to the cache directory (default: ~/.cache/image-create)\""},{"line_number":45,"context_line":"    echo \"        \u0027-d\u0027 distribution release id (default on ubuntu: xenial)\""},{"line_number":46,"context_line":"    echo \"        \u0027-e\u0027 enable complete mandatory access control systems when available (default: permissive)\""},{"line_number":47,"context_line":"    echo \"        \u0027-f\u0027 disable temporary file system for build\""},{"line_number":48,"context_line":"    echo \"        \u0027-h\u0027 display this help message\""},{"line_number":49,"context_line":"    echo \"        \u0027-i\u0027 is the base OS (default: ubuntu)\""},{"line_number":50,"context_line":"    echo \"        \u0027-l\u0027 is output logfile (default: none)\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fce034c_d96f04fa","line":47,"in_reply_to":"3fce034c_ebb9cdcb","updated":"2019-04-18 07:12:18.000000000","message":"I think it\u0027s something like that.  tmpfs works just fine but the smaller systems may not have enough RAM to handle this.\n\nI guess it\u0027s a logically separate change and should perhaps be handled as such.","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e12d0420a6a0ebf807a743aeedfd8a051044a33f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        ;;"},{"line_number":145,"context_line":"        o)"},{"line_number":146,"context_line":"            AMP_OUTPUTFILENAME\u003d$(readlink -f $OPTARG)"},{"line_number":147,"context_line":"            amp_dir\u003d$(dirname $AMP_OUTPUTFILENAME)"},{"line_number":148,"context_line":"            if [ ! -d $amp_dir ]; then"},{"line_number":149,"context_line":"                echo \"Error: Directory $amp_dir does not exist\""},{"line_number":150,"context_line":"                exit 3"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fce034c_797850c3","line":147,"updated":"2019-04-18 07:12:18.000000000","message":"nit: I feel like this should be a trivial separate patch","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e12d0420a6a0ebf807a743aeedfd8a051044a33f","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":297,"context_line":"        if ! dpkg --get-selections | grep -q \"^$pkg[[:space:]]*install$\" \u003e/dev/null; then"},{"line_number":298,"context_line":"            echo \"Required package \" $pkg \" is not installed.  Exiting.\""},{"line_number":299,"context_line":"            echo \"Binary dependencies on this platform are: ${PKG_LIST}\""},{"line_number":300,"context_line":"            exit 1"},{"line_number":301,"context_line":"        fi"},{"line_number":302,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fce034c_397e48af","line":299,"updated":"2019-04-18 07:12:18.000000000","message":"nit: I feel like this should be a trivial separate patch","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e12d0420a6a0ebf807a743aeedfd8a051044a33f","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":317,"context_line":"        if ! rpm -q $pkg \u0026\u003e /dev/null; then"},{"line_number":318,"context_line":"            echo \"Required package \" ${pkg/\\*} \" is not installed.  Exiting.\""},{"line_number":319,"context_line":"            echo \"Binary dependencies on this platform are: ${PKG_LIST}\""},{"line_number":320,"context_line":"            exit 1"},{"line_number":321,"context_line":"        fi"},{"line_number":322,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fce034c_597b14bd","line":319,"updated":"2019-04-18 07:12:18.000000000","message":"nit: I feel like this should be a trivial separate patch","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e12d0420a6a0ebf807a743aeedfd8a051044a33f","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":329,"context_line":"        if ! rpm -qa $pkg ; then"},{"line_number":330,"context_line":"            echo \"Required package \" ${pkg/\\*} \" is not installed.  Exiting.\""},{"line_number":331,"context_line":"            echo \"Binary dependencies on this platform are: ${PKG_LIST}\""},{"line_number":332,"context_line":"            exit 1"},{"line_number":333,"context_line":"        fi"},{"line_number":334,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fce034c_f94d209a","line":331,"updated":"2019-04-18 07:12:18.000000000","message":"nit: I feel like this should be a trivial separate patch","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"74fb954640b8f66a9c7978a5312a48cfea58c76c","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":329,"context_line":"        if ! rpm -qa $pkg ; then"},{"line_number":330,"context_line":"            echo \"Required package \" ${pkg/\\*} \" is not installed.  Exiting.\""},{"line_number":331,"context_line":"            echo \"Binary dependencies on this platform are: ${PKG_LIST}\""},{"line_number":332,"context_line":"            exit 1"},{"line_number":333,"context_line":"        fi"},{"line_number":334,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fce034c_2b87c011","line":331,"in_reply_to":"3fce034c_31917848","updated":"2019-04-18 21:31:04.000000000","message":"Ah, that\u0027s correct. Didn\u0027t pay close enough attention here. I\u0027d still like to see that, but yeah, this is just a whitespace change, not worth another patch. :thumbsup:","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"b015cc2fa71416b43a006838acd9fbe0f92bf256","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":329,"context_line":"        if ! rpm -qa $pkg ; then"},{"line_number":330,"context_line":"            echo \"Required package \" ${pkg/\\*} \" is not installed.  Exiting.\""},{"line_number":331,"context_line":"            echo \"Binary dependencies on this platform are: ${PKG_LIST}\""},{"line_number":332,"context_line":"            exit 1"},{"line_number":333,"context_line":"        fi"},{"line_number":334,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fce034c_31917848","line":331,"in_reply_to":"3fce034c_92b07145","updated":"2019-04-18 14:10:33.000000000","message":"The only changes across these \"nits\" are changing tab characters to spaces... These logging lines were present before I touched the file... My IDE just marked the tab characters, and I thought \"why not touch it up while I\u0027m already updating the file?\"","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a0fdd4f37002e1434ae24552a3948cf34468b359","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":329,"context_line":"        if ! rpm -qa $pkg ; then"},{"line_number":330,"context_line":"            echo \"Required package \" ${pkg/\\*} \" is not installed.  Exiting.\""},{"line_number":331,"context_line":"            echo \"Binary dependencies on this platform are: ${PKG_LIST}\""},{"line_number":332,"context_line":"            exit 1"},{"line_number":333,"context_line":"        fi"},{"line_number":334,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fce034c_92b07145","line":331,"in_reply_to":"3fce034c_f94d209a","updated":"2019-04-18 09:30:13.000000000","message":"eh, I\u0027m less inclined to be pedantic about this, since honestly this is just logging. all of the echo commands -- whatever. You\u0027re not wrong, but I\u0027d probably be fine merging this with these included. /shrug\nThough, it\u0027d be nice if it says *which* platform? Is that here somewhere?\n\n\"Binary dependencies for ${AMP_ARCH} are: ${PKG_LIST}\"","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a6162e73c0b1358f6cb0a802fe23195244b9675a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    echo \"        \u0027-c\u0027 is the path to the cache directory (default: ~/.cache/image-create)\""},{"line_number":45,"context_line":"    echo \"        \u0027-d\u0027 distribution release id (default on ubuntu: xenial)\""},{"line_number":46,"context_line":"    echo \"        \u0027-e\u0027 enable complete mandatory access control systems when available (default: permissive)\""},{"line_number":47,"context_line":"    echo \"        \u0027-f\u0027 disable temporary file system for build\""},{"line_number":48,"context_line":"    echo \"        \u0027-h\u0027 display this help message\""},{"line_number":49,"context_line":"    echo \"        \u0027-i\u0027 is the base OS (default: ubuntu)\""},{"line_number":50,"context_line":"    echo \"        \u0027-l\u0027 is output logfile (default: none)\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fce034c_744daec2","line":47,"updated":"2019-04-18 14:48:39.000000000","message":"I am still going to request we clarify this to tmpfs which is a specific type of \"temporary file system\"","commit_id":"b236fdb71271726bffc14400d4ce854df71d1e18"}],"elements/haproxy-octavia/pre-install.d/01-backports":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2cdc08d2b917b3895367229f49d2c4a5322c87b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"if [ \"$DISTRO_NAME\" \u003d\u003d \"ubuntu\" ] \u0026\u0026 [ \"$DIB_RELEASE\" \u003d\u003d \"trusty\" ]; then"},{"line_number":8,"context_line":"    echo deb http://archive.ubuntu.com/ubuntu trusty-backports main restricted universe multiverse \u003e /etc/apt/sources.list.d/backports.list"},{"line_number":9,"context_line":"elif [ \"$DISTRO_NAME\" \u003d\u003d \"centos7\" ]; then"},{"line_number":10,"context_line":"    case \"$(uname -m)\" in"},{"line_number":11,"context_line":"    x86_64|amd64)"},{"line_number":12,"context_line":"        BASEURL\u003dhttp://mirror.centos.org/\\$contentdir/\\$releasever/paas/\\$basearch/openshift-origin/"},{"line_number":13,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fce034c_6b90844f","line":10,"updated":"2019-04-17 17:23:05.000000000","message":"This will get the architecture of the build host, not what the image will be run on. Probably not what you want.","commit_id":"c52ce929d6df1770f171310251d30e2d1940a63e"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"eb6e4bd6aeead4ad14f6bb762e9659e711865abe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"if [ \"$DISTRO_NAME\" \u003d\u003d \"ubuntu\" ] \u0026\u0026 [ \"$DIB_RELEASE\" \u003d\u003d \"trusty\" ]; then"},{"line_number":8,"context_line":"    echo deb http://archive.ubuntu.com/ubuntu trusty-backports main restricted universe multiverse \u003e /etc/apt/sources.list.d/backports.list"},{"line_number":9,"context_line":"elif [ \"$DISTRO_NAME\" \u003d\u003d \"centos7\" ]; then"},{"line_number":10,"context_line":"    case \"$(uname -m)\" in"},{"line_number":11,"context_line":"    x86_64|amd64)"},{"line_number":12,"context_line":"        BASEURL\u003dhttp://mirror.centos.org/\\$contentdir/\\$releasever/paas/\\$basearch/openshift-origin/"},{"line_number":13,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fce034c_8526f814","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":21},"updated":"2019-04-17 21:20:00.000000000","message":"this should be $ARCH, as that\u0027s the DIB variable for the target architectire","commit_id":"c52ce929d6df1770f171310251d30e2d1940a63e"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"329e78b8b89787859a7468a8a9babd2718d305f8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"if [ \"$DISTRO_NAME\" \u003d\u003d \"ubuntu\" ] \u0026\u0026 [ \"$DIB_RELEASE\" \u003d\u003d \"trusty\" ]; then"},{"line_number":8,"context_line":"    echo deb http://archive.ubuntu.com/ubuntu trusty-backports main restricted universe multiverse \u003e /etc/apt/sources.list.d/backports.list"},{"line_number":9,"context_line":"elif [ \"$DISTRO_NAME\" \u003d\u003d \"centos7\" ]; then"},{"line_number":10,"context_line":"    case \"$(uname -m)\" in"},{"line_number":11,"context_line":"    x86_64|amd64)"},{"line_number":12,"context_line":"        BASEURL\u003dhttp://mirror.centos.org/\\$contentdir/\\$releasever/paas/\\$basearch/openshift-origin/"},{"line_number":13,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fce034c_8b3b70e9","line":10,"in_reply_to":"3fce034c_6b90844f","updated":"2019-04-17 17:42:52.000000000","message":"Honest question, can the build host be x86_64 and still build a ppc64le image?  Is there another command I should use to detect a build being targeted for the ppc64le architecture versus another?","commit_id":"c52ce929d6df1770f171310251d30e2d1940a63e"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"eb6e4bd6aeead4ad14f6bb762e9659e711865abe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"if [ \"$DISTRO_NAME\" \u003d\u003d \"ubuntu\" ] \u0026\u0026 [ \"$DIB_RELEASE\" \u003d\u003d \"trusty\" ]; then"},{"line_number":8,"context_line":"    echo deb http://archive.ubuntu.com/ubuntu trusty-backports main restricted universe multiverse \u003e /etc/apt/sources.list.d/backports.list"},{"line_number":9,"context_line":"elif [ \"$DISTRO_NAME\" \u003d\u003d \"centos7\" ]; then"},{"line_number":10,"context_line":"    case \"$(uname -m)\" in"},{"line_number":11,"context_line":"    x86_64|amd64)"},{"line_number":12,"context_line":"        BASEURL\u003dhttp://mirror.centos.org/\\$contentdir/\\$releasever/paas/\\$basearch/openshift-origin/"},{"line_number":13,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fce034c_a580d4c0","line":10,"in_reply_to":"3fce034c_8b3b70e9","updated":"2019-04-17 21:20:00.000000000","message":"Currently no the host and target must be the same architecture.  That will probably change in the future so best to avoid shelling out to uname","commit_id":"c52ce929d6df1770f171310251d30e2d1940a63e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2cdc08d2b917b3895367229f49d2c4a5322c87b2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"baseurl\u003d$BASEURL"},{"line_number":22,"context_line":"gpgcheck\u003d0"},{"line_number":23,"context_line":"enabled\u003d1"},{"line_number":24,"context_line":"includepkgs\u003dhaproxy*"},{"line_number":25,"context_line":"EOF"},{"line_number":26,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fce034c_ab9c2c5d","line":24,"updated":"2019-04-17 17:23:05.000000000","message":"It doesn\u0027t have any dependencies?","commit_id":"c52ce929d6df1770f171310251d30e2d1940a63e"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"329e78b8b89787859a7468a8a9babd2718d305f8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"baseurl\u003d$BASEURL"},{"line_number":22,"context_line":"gpgcheck\u003d0"},{"line_number":23,"context_line":"enabled\u003d1"},{"line_number":24,"context_line":"includepkgs\u003dhaproxy*"},{"line_number":25,"context_line":"EOF"},{"line_number":26,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fce034c_c6ff2dff","line":24,"in_reply_to":"3fce034c_ab9c2c5d","updated":"2019-04-17 17:42:52.000000000","message":"I believe it does, but when building with the BASEURL set in the ppc64le case above there are errors pulling those dependencies... namely in referencing a non-existant ppc64le build location.  Side note, those dependencies are supplied in other repositories, and don\u0027t necessarily need to come from the PaaS repo.","commit_id":"c52ce929d6df1770f171310251d30e2d1940a63e"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"c1d7e569641f739ed71179115e2f3692744d406b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        # Note: the following repository location has an issue with the dependent package definitions, namely pointing"},{"line_number":16,"context_line":"        # to an invalid repository.  Marking to only retrieve haproxy from this repo and gathering the dependencies from"},{"line_number":17,"context_line":"        # other repositories"},{"line_number":18,"context_line":"        BASEURL\u003dhttps://cbs.centos.org/kojifiles/repos/paas7-openshift-multiarch-el7-build/latest/\\$basearch/"},{"line_number":19,"context_line":"        INCLUDEPKGS\u003d\u0027includepkgs\u003dhaproxy*\u0027"},{"line_number":20,"context_line":"        ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fce034c_30e4203c","line":18,"updated":"2019-04-17 21:52:00.000000000","message":"I didn\u0027t (and still don\u0027t) like installing haproxy from the openshift-origin repo, even more now knowing about https://storyboard.openstack.org/#!/story/2005412\n\nInstalling for ppc64le from a repository in koji even less. Can\u0027t we install haproxy 1.5 provided in the official CentOS repository channel?","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"19b133ac7ebe21eaf6e5d0f307eac7b2f9d43a9c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        # Note: the following repository location has an issue with the dependent package definitions, namely pointing"},{"line_number":16,"context_line":"        # to an invalid repository.  Marking to only retrieve haproxy from this repo and gathering the dependencies from"},{"line_number":17,"context_line":"        # other repositories"},{"line_number":18,"context_line":"        BASEURL\u003dhttps://cbs.centos.org/kojifiles/repos/paas7-openshift-multiarch-el7-build/latest/\\$basearch/"},{"line_number":19,"context_line":"        INCLUDEPKGS\u003d\u0027includepkgs\u003dhaproxy*\u0027"},{"line_number":20,"context_line":"        ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fce034c_8ba12997","line":18,"in_reply_to":"3fce034c_30e4203c","updated":"2019-04-17 22:35:49.000000000","message":"I have an idea! Why doesn\u0027t RedHat release an official HAProxy package that was built since the turn of the century? (But seriously, 1.5 is 4 years old, in computer-time that\u0027s not yet pre-historic but is getting there...)\nIt doesn\u0027t have to be 1.8, though that would be ideal.","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e12d0420a6a0ebf807a743aeedfd8a051044a33f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        # Note: the following repository location has an issue with the dependent package definitions, namely pointing"},{"line_number":16,"context_line":"        # to an invalid repository.  Marking to only retrieve haproxy from this repo and gathering the dependencies from"},{"line_number":17,"context_line":"        # other repositories"},{"line_number":18,"context_line":"        BASEURL\u003dhttps://cbs.centos.org/kojifiles/repos/paas7-openshift-multiarch-el7-build/latest/\\$basearch/"},{"line_number":19,"context_line":"        INCLUDEPKGS\u003d\u0027includepkgs\u003dhaproxy*\u0027"},{"line_number":20,"context_line":"        ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fce034c_f9320010","line":18,"in_reply_to":"3fce034c_30e4203c","updated":"2019-04-18 07:12:18.000000000","message":"the element specifically asks for haproxy18 so I guess 1.5 wont work.\n\nIt isn\u0027t clear but using the buildroot is a tempfix until we can get the multiarch origin stuff published.\n\nThat doesn\u0027t address your request to get it into CentOS-7 updates but that\u0027s against the CentOS philosophy and wont ever happen","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e12d0420a6a0ebf807a743aeedfd8a051044a33f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        # Note: the following repository location has an issue with the dependent package definitions, namely pointing"},{"line_number":16,"context_line":"        # to an invalid repository.  Marking to only retrieve haproxy from this repo and gathering the dependencies from"},{"line_number":17,"context_line":"        # other repositories"},{"line_number":18,"context_line":"        BASEURL\u003dhttps://cbs.centos.org/kojifiles/repos/paas7-openshift-multiarch-el7-build/latest/\\$basearch/"},{"line_number":19,"context_line":"        INCLUDEPKGS\u003d\u0027includepkgs\u003dhaproxy*\u0027"},{"line_number":20,"context_line":"        ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fce034c_b938f8ed","line":18,"in_reply_to":"3fce034c_8ba12997","updated":"2019-04-18 07:12:18.000000000","message":"I think that\u0027s CentOS-8 material.","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a0fdd4f37002e1434ae24552a3948cf34468b359","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        # Note: the following repository location has an issue with the dependent package definitions, namely pointing"},{"line_number":16,"context_line":"        # to an invalid repository.  Marking to only retrieve haproxy from this repo and gathering the dependencies from"},{"line_number":17,"context_line":"        # other repositories"},{"line_number":18,"context_line":"        BASEURL\u003dhttps://cbs.centos.org/kojifiles/repos/paas7-openshift-multiarch-el7-build/latest/\\$basearch/"},{"line_number":19,"context_line":"        INCLUDEPKGS\u003d\u0027includepkgs\u003dhaproxy*\u0027"},{"line_number":20,"context_line":"        ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fce034c_d2f03900","line":18,"in_reply_to":"3fce034c_f9320010","updated":"2019-04-18 09:30:13.000000000","message":"Yeah, I believe I have harangued various people at summits/PTGs for the past three years and every single time I\u0027ve been told \"it\u0027s not going to happen\"... However, I\u0027m really stubborn and this situation strikes me as really dumb, so I always repeat that line whenever there\u0027s a good opportunity (like above). :D","commit_id":"a525a469ca35334c66cea7d8590995187588edac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a6162e73c0b1358f6cb0a802fe23195244b9675a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        # to an invalid repository.  Marking to only retrieve haproxy from this repo and gathering the dependencies from"},{"line_number":17,"context_line":"        # other repositories"},{"line_number":18,"context_line":"        BASEURL\u003dhttps://cbs.centos.org/kojifiles/repos/paas7-openshift-multiarch-el7-build/latest/\\$basearch/"},{"line_number":19,"context_line":"        INCLUDEPKGS\u003d\u0027includepkgs\u003dhaproxy*\u0027"},{"line_number":20,"context_line":"        ;;"},{"line_number":21,"context_line":"    esac"},{"line_number":22,"context_line":"    cat \u003e /etc/yum.repos.d/CentOS-PaaS.repo \u003c\u003cEOF"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fce034c_14ed4a8a","line":19,"updated":"2019-04-18 14:48:39.000000000","message":"I still don\u0027t think this is necessary, nor a good idea, but now at least it is isolated to only break the ppc64le builds.","commit_id":"b236fdb71271726bffc14400d4ce854df71d1e18"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"bded0f08575c0d24fa1cc17d9519967468d01c9b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"if [ \"$DISTRO_NAME\" \u003d\u003d \"ubuntu\" ] \u0026\u0026 [ \"$DIB_RELEASE\" \u003d\u003d \"trusty\" ]; then"},{"line_number":8,"context_line":"    echo deb http://archive.ubuntu.com/ubuntu trusty-backports main restricted universe multiverse \u003e /etc/apt/sources.list.d/backports.list"},{"line_number":9,"context_line":"elif [ \"$DISTRO_NAME\" \u003d\u003d \"centos7\" ]; then"},{"line_number":10,"context_line":"    case $ARCH in  ## Change this to an environment variable from DIB?!"},{"line_number":11,"context_line":"    x86_64|amd64)"},{"line_number":12,"context_line":"        BASEURL\u003dhttp://mirror.centos.org/\\$contentdir/\\$releasever/paas/\\$basearch/openshift-origin/"},{"line_number":13,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1fcbff3d_91b79c3b","line":10,"updated":"2019-04-20 13:53:53.000000000","message":"$ARCH is the environment variable from DIB\n\nhttps://github.com/openstack/diskimage-builder/blob/0be0a827f735bccf07767871481dde491b7278cc/diskimage_builder/lib/common-defaults#L17-L35","commit_id":"4c9097c681c937531132456a5f7443175b591b17"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a09aa8034b063c8aab2461d18b6386cc06fb284d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        #  *only* `haproxy18` is retrieved from this repo, the explicit limit"},{"line_number":21,"context_line":"        #  for that package can be used.  This should be fine for now since"},{"line_number":22,"context_line":"        #  haproxy18\u0027s dependencies are available outside this repo.  If things"},{"line_number":23,"context_line":"        #  change, the includepkgs line can be expanded as needed."},{"line_number":24,"context_line":"        BASEURL\u003dhttps://cbs.centos.org/kojifiles/repos/paas7-openshift-multiarch-el7-build/latest/\\$basearch/"},{"line_number":25,"context_line":"        INCLUDEPKGS\u003d\u0027includepkgs\u003dhaproxy*\u0027"},{"line_number":26,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fce034c_6b962842","line":23,"updated":"2019-04-18 21:34:56.000000000","message":"I am ... tentatively OK with this logic. As Michael said, it is limited to only ppc64le right now, so I\u0027m less worried about it -- I assume people who are building on this niche architecture can probably figure out any breakages on their own.","commit_id":"4c9097c681c937531132456a5f7443175b591b17"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"bded0f08575c0d24fa1cc17d9519967468d01c9b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        #  *only* `haproxy18` is retrieved from this repo, the explicit limit"},{"line_number":21,"context_line":"        #  for that package can be used.  This should be fine for now since"},{"line_number":22,"context_line":"        #  haproxy18\u0027s dependencies are available outside this repo.  If things"},{"line_number":23,"context_line":"        #  change, the includepkgs line can be expanded as needed."},{"line_number":24,"context_line":"        BASEURL\u003dhttps://cbs.centos.org/kojifiles/repos/paas7-openshift-multiarch-el7-build/latest/\\$basearch/"},{"line_number":25,"context_line":"        INCLUDEPKGS\u003d\u0027includepkgs\u003dhaproxy*\u0027"},{"line_number":26,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1fcbff3d_b1b41837","line":23,"in_reply_to":"3fce034c_6b962842","updated":"2019-04-20 13:53:53.000000000","message":"+1. I don\u0027t like this either but I don\u0027t have a better alternative (other than suggesting going for the official haproxy 1.5) and is contained to pppc64le","commit_id":"4c9097c681c937531132456a5f7443175b591b17"}]}