)]}'
{"etc/octavia.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fbfefcd20b7f5c3f7b8a905c801f5aa8897639ee","unresolved":false,"context_lines":[{"line_number":132,"context_line":"# ca_private_key_passphrase \u003d"},{"line_number":133,"context_line":"# server_certs_key_passphrase \u003d insecure-key-do-not-use-this-key"},{"line_number":134,"context_line":"# signing_digest \u003d sha256"},{"line_number":135,"context_line":"# cert_validity_time \u003d 2592000"},{"line_number":136,"context_line":"# storage_path \u003d /var/lib/octavia/certificates/"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# For the TLS management"}],"source_content_type":"text/plain","patch_set":1,"id":"ffb9cba7_d389f7c9","line":135,"updated":"2019-04-30 16:04:18.000000000","message":"nit: It would be nice to expand this in a comment so it\u0027s easy at a glance to see the human readable time.","commit_id":"eac3d5919022db3c77290db3b8043c331c1fdd38"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8c16922b28bd337c31d38fe142c3525ba50a8576","unresolved":false,"context_lines":[{"line_number":132,"context_line":"# ca_private_key_passphrase \u003d"},{"line_number":133,"context_line":"# server_certs_key_passphrase \u003d insecure-key-do-not-use-this-key"},{"line_number":134,"context_line":"# signing_digest \u003d sha256"},{"line_number":135,"context_line":"# cert_validity_time \u003d 2592000"},{"line_number":136,"context_line":"# storage_path \u003d /var/lib/octavia/certificates/"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# For the TLS management"}],"source_content_type":"text/plain","patch_set":1,"id":"ffb9cba7_047e60ae","line":135,"in_reply_to":"ffb9cba7_d389f7c9","updated":"2019-04-30 22:27:44.000000000","message":"Done","commit_id":"eac3d5919022db3c77290db3b8043c331c1fdd38"}],"octavia/certificates/common/local.py":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"efa3bf9b149d97491f46e43426c07e3bdb74c865","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               help\u003d\u0027Certificate signing digest. Defaults\u0027"},{"line_number":62,"context_line":"                    \u0027 to env[OS_OCTAVIA_CA_SIGNING_DIGEST] or \"sha256\".\u0027),"},{"line_number":63,"context_line":"    cfg.IntOpt(\u0027cert_validity_time\u0027,"},{"line_number":64,"context_line":"               default\u003d30 * 24 * 60 * 60,"},{"line_number":65,"context_line":"               help\u003d\"The validity time to request for generated Amphora \""},{"line_number":66,"context_line":"                    \"certificates (in seconds).\"),"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_33597334","line":64,"range":{"start_line":64,"start_character":23,"end_line":64,"end_character":40},"updated":"2019-04-30 14:24:26.000000000","message":"we change the default from this CERT_VALIDITY \u003d 2 * 365 * 24 * 60 * 60 to a lower number, why?\n\nNot saying it is a bad idea, just wish to know.\nAlso, changing the default should also be documented in the release note.","commit_id":"eac3d5919022db3c77290db3b8043c331c1fdd38"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8c16922b28bd337c31d38fe142c3525ba50a8576","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               help\u003d\u0027Certificate signing digest. Defaults\u0027"},{"line_number":62,"context_line":"                    \u0027 to env[OS_OCTAVIA_CA_SIGNING_DIGEST] or \"sha256\".\u0027),"},{"line_number":63,"context_line":"    cfg.IntOpt(\u0027cert_validity_time\u0027,"},{"line_number":64,"context_line":"               default\u003d30 * 24 * 60 * 60,"},{"line_number":65,"context_line":"               help\u003d\"The validity time to request for generated Amphora \""},{"line_number":66,"context_line":"                    \"certificates (in seconds).\"),"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_a46f54fa","line":64,"range":{"start_line":64,"start_character":23,"end_line":64,"end_character":40},"in_reply_to":"ffb9cba7_33597334","updated":"2019-04-30 22:27:44.000000000","message":"It is already documented in the release note. ;)","commit_id":"eac3d5919022db3c77290db3b8043c331c1fdd38"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"eda8f6e6e93011305e487084fa83a1be1a2be8f2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               help\u003d\u0027Certificate signing digest. Defaults\u0027"},{"line_number":62,"context_line":"                    \u0027 to env[OS_OCTAVIA_CA_SIGNING_DIGEST] or \"sha256\".\u0027),"},{"line_number":63,"context_line":"    cfg.IntOpt(\u0027cert_validity_time\u0027,"},{"line_number":64,"context_line":"               default\u003d30 * 24 * 60 * 60,"},{"line_number":65,"context_line":"               help\u003d\"The validity time to request for generated Amphora \""},{"line_number":66,"context_line":"                    \"certificates (in seconds).\"),"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_b88bf71c","line":64,"range":{"start_line":64,"start_character":23,"end_line":64,"end_character":40},"in_reply_to":"ffb9cba7_a46f54fa","updated":"2019-05-01 07:50:37.000000000","message":"not sure why I missed that. You\u0027re right.","commit_id":"eac3d5919022db3c77290db3b8043c331c1fdd38"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fbfefcd20b7f5c3f7b8a905c801f5aa8897639ee","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027 to env[OS_OCTAVIA_CA_SIGNING_DIGEST] or \"sha256\".\u0027),"},{"line_number":63,"context_line":"    cfg.IntOpt(\u0027cert_validity_time\u0027,"},{"line_number":64,"context_line":"               default\u003d30 * 24 * 60 * 60,"},{"line_number":65,"context_line":"               help\u003d\"The validity time to request for generated Amphora \""},{"line_number":66,"context_line":"                    \"certificates (in seconds).\"),"},{"line_number":67,"context_line":"]"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_53bf4760","line":65,"updated":"2019-04-30 16:04:18.000000000","message":"This is a bit confusing.\nMaybe \"The validity time for the amphora agent certificates (in seconds).","commit_id":"eac3d5919022db3c77290db3b8043c331c1fdd38"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8c16922b28bd337c31d38fe142c3525ba50a8576","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027 to env[OS_OCTAVIA_CA_SIGNING_DIGEST] or \"sha256\".\u0027),"},{"line_number":63,"context_line":"    cfg.IntOpt(\u0027cert_validity_time\u0027,"},{"line_number":64,"context_line":"               default\u003d30 * 24 * 60 * 60,"},{"line_number":65,"context_line":"               help\u003d\"The validity time to request for generated Amphora \""},{"line_number":66,"context_line":"                    \"certificates (in seconds).\"),"},{"line_number":67,"context_line":"]"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_6475dcca","line":65,"in_reply_to":"ffb9cba7_53bf4760","updated":"2019-04-30 22:27:44.000000000","message":"k sure","commit_id":"eac3d5919022db3c77290db3b8043c331c1fdd38"}]}