)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d3f769204f2aae4cbe63a1855c8168dd9172ebc1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"0b468090e6eef1483f6f7c53708f500802a57d51, the db migration script still"},{"line_number":13,"context_line":"fails for some database backend such as MariaDB 5.5 which doesn\u0027t"},{"line_number":14,"context_line":"support `DATETIME DEFAULT CURRENT_TIMESTAMP`[1][2]. What\u0027s more, the"},{"line_number":15,"context_line":"`server_default` is actually doing nothing during the db migration."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch removes `server_default` in the migration script."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_df98761c","line":15,"range":{"start_line":15,"start_character":1,"end_line":15,"end_character":67},"updated":"2019-05-08 07:04:07.000000000","message":"If you only remove `server_default` from original migration you end up with inconsistent state of db - already deployed clouds will have it.\n\n`server_default` is setting default value for columns values in db, so it makes sense for migration scripts, unlike `default` witch makes sense only in models.","commit_id":"0c65d1663fd8682469874acdfc1e240ee799bbf8"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"1f8c5a2715b42b219a9bcd0c6dd5b20d81db8e57","unresolved":false,"context_lines":[{"line_number":12,"context_line":"0b468090e6eef1483f6f7c53708f500802a57d51, the db migration script still"},{"line_number":13,"context_line":"fails for some database backend such as MariaDB 5.5 which doesn\u0027t"},{"line_number":14,"context_line":"support `DATETIME DEFAULT CURRENT_TIMESTAMP`[1][2]. What\u0027s more, the"},{"line_number":15,"context_line":"`server_default` is actually doing nothing during the db migration."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch removes `server_default` in the migration script."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_53d31e39","line":15,"range":{"start_line":15,"start_character":1,"end_line":15,"end_character":67},"in_reply_to":"dfbec78f_059ebc53","updated":"2019-05-08 13:50:28.000000000","message":"Because you remove it only for new deployments. And db schema should be the same for new deployments and for the old ones. So, the proper way to remove it will be to also add migration script witch reset of server_default for this column.","commit_id":"0c65d1663fd8682469874acdfc1e240ee799bbf8"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"4c6321b14b2f0f8aac0e77dd3f505c674f7af524","unresolved":false,"context_lines":[{"line_number":12,"context_line":"0b468090e6eef1483f6f7c53708f500802a57d51, the db migration script still"},{"line_number":13,"context_line":"fails for some database backend such as MariaDB 5.5 which doesn\u0027t"},{"line_number":14,"context_line":"support `DATETIME DEFAULT CURRENT_TIMESTAMP`[1][2]. What\u0027s more, the"},{"line_number":15,"context_line":"`server_default` is actually doing nothing during the db migration."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch removes `server_default` in the migration script."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_5cb566cc","line":15,"range":{"start_line":15,"start_character":1,"end_line":15,"end_character":67},"in_reply_to":"dfbec78f_53d31e39","updated":"2019-05-08 21:44:12.000000000","message":"This patch doesn\u0027t affect the deployment which already applied the db migration (with no error). Adding a higher revision migration script can\u0027t solve the problem.","commit_id":"0c65d1663fd8682469874acdfc1e240ee799bbf8"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"b29da0b02ad807b45b3668c410a370e63945ced9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"0b468090e6eef1483f6f7c53708f500802a57d51, the db migration script still"},{"line_number":13,"context_line":"fails for some database backend such as MariaDB 5.5 which doesn\u0027t"},{"line_number":14,"context_line":"support `DATETIME DEFAULT CURRENT_TIMESTAMP`[1][2]. What\u0027s more, the"},{"line_number":15,"context_line":"`server_default` is actually doing nothing during the db migration."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch removes `server_default` in the migration script."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_e2e6fe16","line":15,"range":{"start_line":15,"start_character":1,"end_line":15,"end_character":67},"in_reply_to":"dfbec78f_5fe9e517","updated":"2019-05-08 09:58:21.000000000","message":"commit 0b468090e6eef1483f6f7c53708f500802a57d51 does not remove this field it just insert values there, for that was used temporary model of table.\n\nmysql\u003e describe spares_pool;                                                                                                                                           \n+------------+----------+------+-----+-------------------+-------+\n| Field      | Type     | Null | Key | Default           | Extra |\n+------------+----------+------+-----+-------------------+-------+\n| updated_at | datetime | YES  |     | CURRENT_TIMESTAMP |       |\n+------------+----------+------+-----+-------------------+-------+\n1 row in set (0.00 sec)\n\nI understand that it fails, we just need to find better variant to fix this. Ideal is to check if backend is mariadb and use syntax that will work for it, for other cases leave as it is.","commit_id":"0c65d1663fd8682469874acdfc1e240ee799bbf8"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"ca11620cd4623c327d64907ad0cbab2ba2177480","unresolved":false,"context_lines":[{"line_number":12,"context_line":"0b468090e6eef1483f6f7c53708f500802a57d51, the db migration script still"},{"line_number":13,"context_line":"fails for some database backend such as MariaDB 5.5 which doesn\u0027t"},{"line_number":14,"context_line":"support `DATETIME DEFAULT CURRENT_TIMESTAMP`[1][2]. What\u0027s more, the"},{"line_number":15,"context_line":"`server_default` is actually doing nothing during the db migration."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch removes `server_default` in the migration script."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_5fe9e517","line":15,"range":{"start_line":15,"start_character":1,"end_line":15,"end_character":67},"in_reply_to":"dfbec78f_df98761c","updated":"2019-05-08 07:49:48.000000000","message":"I wonder why removing the field will end up with inconsistent state in db, given that field was removed in 0b468090e6eef1483f6f7c53708f500802a57d51? I totally understand what server_default does, but it fails the mariadb 5.5.","commit_id":"0c65d1663fd8682469874acdfc1e240ee799bbf8"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"d24cae97b7a646785cf7a8f1f8ea322a1d5e6eff","unresolved":false,"context_lines":[{"line_number":12,"context_line":"0b468090e6eef1483f6f7c53708f500802a57d51, the db migration script still"},{"line_number":13,"context_line":"fails for some database backend such as MariaDB 5.5 which doesn\u0027t"},{"line_number":14,"context_line":"support `DATETIME DEFAULT CURRENT_TIMESTAMP`[1][2]. What\u0027s more, the"},{"line_number":15,"context_line":"`server_default` is actually doing nothing during the db migration."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch removes `server_default` in the migration script."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_059ebc53","line":15,"range":{"start_line":15,"start_character":1,"end_line":15,"end_character":67},"in_reply_to":"dfbec78f_e2e6fe16","updated":"2019-05-08 11:56:48.000000000","message":"Yeah, it was wrong to say that default value was removed, 0b468090e6eef1483f6f7c53708f500802a57d51 was just resetting the default value for `updated_at` column.\n\nI still didn\u0027t get your point why we shouldn\u0027t do this change, given 0b468090e6eef1483f6f7c53708f500802a57d51 is doing the right to set the default value, removing `server_default` here is not harmful to anything.","commit_id":"0c65d1663fd8682469874acdfc1e240ee799bbf8"}]}