)]}'
{"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"2ae87beccb2ddf2adf779bb4c7c30027db824080","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                     self).cert_verify(conn, url, verify, cert)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    def init_poolmanager(self, *pool_args, **pool_kwargs):"},{"line_number":409,"context_line":"        pool_kwargs[\u0027ssl_version\u0027] \u003d ssl.PROTOCOL_TLSv1_2"},{"line_number":410,"context_line":"        return super(CustomHostNameCheckingAdapter,"},{"line_number":411,"context_line":"                     self).init_poolmanager(*pool_args, **pool_kwargs)"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_7262d340","line":409,"updated":"2019-05-09 02:06:11.000000000","message":"can that be made configurable so future enhancements can be without a code change?","commit_id":"95435c8819f25dfb9201944e155004bfe3a2d5d9"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"51037f82a9ec5257909e79f64615d8a05ac8ba13","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                     self).cert_verify(conn, url, verify, cert)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    def init_poolmanager(self, *pool_args, **pool_kwargs):"},{"line_number":409,"context_line":"        pool_kwargs[\u0027ssl_version\u0027] \u003d ssl.PROTOCOL_TLSv1_2"},{"line_number":410,"context_line":"        return super(CustomHostNameCheckingAdapter,"},{"line_number":411,"context_line":"                     self).init_poolmanager(*pool_args, **pool_kwargs)"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_c00e3731","line":409,"in_reply_to":"dfbec78f_7262d340","updated":"2019-05-09 18:45:26.000000000","message":"Yes, this could be done as configuration, though it\u0027s an internal ID from the ssl lib that\u0027s used here, so I\u0027d have to expose the options as our own defined enum and then translate. Guess that\u0027d be ok. That\u0027s similar to what we\u0027re going to have to do to expose these options for Listeners.","commit_id":"95435c8819f25dfb9201944e155004bfe3a2d5d9"}],"octavia/common/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"11f99fb2f3b1c78cc53238d2b35ccd6b2f67addb","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    cfg.IntOpt(\u0027agent_request_read_timeout\u0027, default\u003d180,"},{"line_number":121,"context_line":"               help\u003d_(\"The time in seconds to allow a request from the \""},{"line_number":122,"context_line":"                      \"controller to run before terminating the socket.\")),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027agent_tls_protocol\u0027, default\u003d\u0027TLSv1.2\u0027,"},{"line_number":124,"context_line":"               help\u003d_(\"Minimum TLS protocol for communication with the \""},{"line_number":125,"context_line":"                      \"amphora agent.\"),"},{"line_number":126,"context_line":"               choices\u003dTLS_PROTOCOL_CHOICES),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_40967995","line":123,"updated":"2019-05-14 20:40:29.000000000","message":"FYI, as this is coded, the value in the amphora-agent will always be this default value. You have to update the jinja to have a octavia.conf setting pushed to the amphora-agent config file.\nhttps://github.com/openstack/octavia/blob/master/octavia/amphorae/backends/agent/templates/amphora_agent_conf.template","commit_id":"e40a3d96e9816aa057ec877903fdd09b6cdf6490"}]}