)]}'
{"octavia/api/common/types.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a116502a9a69d9f707f9e44cc10c8bda6ab1c201","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            if (isinstance(self.project_id, wtypes.UnsetType) and"},{"line_number":138,"context_line":"                    not isinstance(self.tenant_id, wtypes.UnsetType)):"},{"line_number":139,"context_line":"                self.project_id \u003d self.tenant_id"},{"line_number":140,"context_line":"        if hasattr(self, \u0027admin_state_up\u0027) and getattr("},{"line_number":141,"context_line":"                self, \u0027admin_state_up\u0027) is None:"},{"line_number":142,"context_line":"            # This situation will be hit during request with"},{"line_number":143,"context_line":"            # admin_state_up is null. If users specify this field to null,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_4b6863f4","line":140,"updated":"2019-05-21 05:50:23.000000000","message":"This could just be\n\u003e if getattr(self, \u0027admin_state_up\u0027, None):\n\nhasattr just calls getattr internally anyway","commit_id":"c09da20054dc374714ef90ff72ad720daf8c01f3"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"9329b4dc83a4e47493833aae0634971d63434c04","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            if (isinstance(self.project_id, wtypes.UnsetType) and"},{"line_number":138,"context_line":"                    not isinstance(self.tenant_id, wtypes.UnsetType)):"},{"line_number":139,"context_line":"                self.project_id \u003d self.tenant_id"},{"line_number":140,"context_line":"        if hasattr(self, \u0027admin_state_up\u0027) and getattr("},{"line_number":141,"context_line":"                self, \u0027admin_state_up\u0027) is None:"},{"line_number":142,"context_line":"            # This situation will be hit during request with"},{"line_number":143,"context_line":"            # admin_state_up is null. If users specify this field to null,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_6b2e87a6","line":140,"in_reply_to":"bfb3d3c7_4b6863f4","updated":"2019-05-21 05:56:46.000000000","message":"Sorry meant\n\u003e if getattr(self, \u0027admin_state_up\u0027, None) is None:","commit_id":"c09da20054dc374714ef90ff72ad720daf8c01f3"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"88cf315ce21adeb8abc353e1782fcfc1813d0897","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            if (isinstance(self.project_id, wtypes.UnsetType) and"},{"line_number":138,"context_line":"                    not isinstance(self.tenant_id, wtypes.UnsetType)):"},{"line_number":139,"context_line":"                self.project_id \u003d self.tenant_id"},{"line_number":140,"context_line":"        if hasattr(self, \u0027admin_state_up\u0027) and getattr("},{"line_number":141,"context_line":"                self, \u0027admin_state_up\u0027) is None:"},{"line_number":142,"context_line":"            # This situation will be hit during request with"},{"line_number":143,"context_line":"            # admin_state_up is null. If users specify this field to null,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_2bccf3ba","line":140,"in_reply_to":"bfb3d3c7_6b2e87a6","updated":"2019-05-22 09:29:00.000000000","message":"Eric, I agree with you but note this is a backport. I\u0027d suggest we don\u0027t deviate from the original patch. If we want, we can improve that in master and then also backport.","commit_id":"c09da20054dc374714ef90ff72ad720daf8c01f3"}]}