)]}'
{"devstack/settings":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3fb3ccfd51e4d59bb650e8a0bace64f2e35475e0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"OCTAVIA_DHCLIENT_CONF\u003d${OCTAVIA_DHCLIENT_CONF:-${OCTAVIA_DHCLIENT_DIR}/dhclient.conf}"},{"line_number":16,"context_line":"OCTAVIA_CONF\u003d${OCTAVIA_CONF:-${OCTAVIA_CONF_DIR}/octavia.conf}"},{"line_number":17,"context_line":"OCTAVIA_AUDIT_MAP\u003d${OCTAVIA_AUDIT_MAP:-${OCTAVIA_CONF_DIR}/octavia_api_audit_map.conf}"},{"line_number":18,"context_line":"OCTAVIA_TEMPEST_DIR\u003d${OCTAVIA_TEMPEST_DIR:-${OCTAVIA_DIR}/octavia/tests/tempest}"},{"line_number":19,"context_line":"OCTAVIA_RUN_DIR\u003d${OCTAVIA_RUN_DIR:-\"/var/run/octavia\"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"OCTAVIA_AMPHORA_DRIVER\u003d${OCTAVIA_AMPHORA_DRIVER:-\"amphora_haproxy_rest_driver\"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dfbec78f_9b7a9bb7","side":"PARENT","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":19},"updated":"2019-05-15 12:42:24.000000000","message":"This var is still in use in devstack/plugin.sh. We could delete also:\n\nhttps://github.com/openstack/octavia/blob/29d4340e9fd0c93595183ce16110198fef58c86b/devstack/plugin.sh#L601-L604\n\nhttps://github.com/openstack/octavia/blob/29d4340e9fd0c93595183ce16110198fef58c86b/devstack/plugin.sh#L610-L613","commit_id":"0573d2c609378e206db932b78fb54cd9d7384332"},{"author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"change_message_id":"55d7b3f0b5a82e6ff9eee71e8ca09174c241fc8a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"OCTAVIA_DHCLIENT_CONF\u003d${OCTAVIA_DHCLIENT_CONF:-${OCTAVIA_DHCLIENT_DIR}/dhclient.conf}"},{"line_number":16,"context_line":"OCTAVIA_CONF\u003d${OCTAVIA_CONF:-${OCTAVIA_CONF_DIR}/octavia.conf}"},{"line_number":17,"context_line":"OCTAVIA_AUDIT_MAP\u003d${OCTAVIA_AUDIT_MAP:-${OCTAVIA_CONF_DIR}/octavia_api_audit_map.conf}"},{"line_number":18,"context_line":"OCTAVIA_TEMPEST_DIR\u003d${OCTAVIA_TEMPEST_DIR:-${OCTAVIA_DIR}/octavia/tests/tempest}"},{"line_number":19,"context_line":"OCTAVIA_RUN_DIR\u003d${OCTAVIA_RUN_DIR:-\"/var/run/octavia\"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"OCTAVIA_AMPHORA_DRIVER\u003d${OCTAVIA_AMPHORA_DRIVER:-\"amphora_haproxy_rest_driver\"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dfbec78f_4d2ea4fb","side":"PARENT","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":19},"in_reply_to":"dfbec78f_9b7a9bb7","updated":"2019-05-15 14:52:30.000000000","message":"Done","commit_id":"0573d2c609378e206db932b78fb54cd9d7384332"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3fb3ccfd51e4d59bb650e8a0bace64f2e35475e0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"OCTAVIA_HEALTHMANAGER_ARGS\u003d${OCTAVIA_HEALTHMANAGER_ARGS:-\" --config-file $OCTAVIA_CONF\"}"},{"line_number":71,"context_line":"OCTAVIA_DRIVER_AGENT_ARGS\u003d${OCTAVIA_DRIVER_AGENT_ARGS:-\" --config-file $OCTAVIA_CONF\"}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"OCTAVIA_TEMPEST\u003d${OCTAVIA_TEMPEST:-\"disabled\"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"OCTAVIA_API\u003d\"o-api\""},{"line_number":76,"context_line":"OCTAVIA_CONSUMER\u003d\"o-cw\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dfbec78f_7b7fa7aa","side":"PARENT","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":15},"updated":"2019-05-15 12:42:24.000000000","message":"ditto","commit_id":"0573d2c609378e206db932b78fb54cd9d7384332"},{"author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"change_message_id":"55d7b3f0b5a82e6ff9eee71e8ca09174c241fc8a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"OCTAVIA_HEALTHMANAGER_ARGS\u003d${OCTAVIA_HEALTHMANAGER_ARGS:-\" --config-file $OCTAVIA_CONF\"}"},{"line_number":71,"context_line":"OCTAVIA_DRIVER_AGENT_ARGS\u003d${OCTAVIA_DRIVER_AGENT_ARGS:-\" --config-file $OCTAVIA_CONF\"}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"OCTAVIA_TEMPEST\u003d${OCTAVIA_TEMPEST:-\"disabled\"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"OCTAVIA_API\u003d\"o-api\""},{"line_number":76,"context_line":"OCTAVIA_CONSUMER\u003d\"o-cw\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dfbec78f_6d31285a","side":"PARENT","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":15},"in_reply_to":"dfbec78f_7b7fa7aa","updated":"2019-05-15 14:52:30.000000000","message":"Done","commit_id":"0573d2c609378e206db932b78fb54cd9d7384332"}]}