)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":157,"context_line":"  type: array"},{"line_number":158,"context_line":"allowed_cidr-optional:"},{"line_number":159,"context_line":"  description: |"},{"line_number":160,"context_line":"    A list of IPv4, IPv6 or mix of both CIDRs."},{"line_number":161,"context_line":"  in: body"},{"line_number":162,"context_line":"  required: false"},{"line_number":163,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_1a389fd2","line":160,"updated":"2019-08-23 00:26:39.000000000","message":"We should comment on the default is all allowed, when specified the default will switch to deny all.","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":157,"context_line":"  type: array"},{"line_number":158,"context_line":"allowed_cidr-optional:"},{"line_number":159,"context_line":"  description: |"},{"line_number":160,"context_line":"    A list of IPv4, IPv6 or mix of both CIDRs."},{"line_number":161,"context_line":"  in: body"},{"line_number":162,"context_line":"  required: false"},{"line_number":163,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_febb300c","line":160,"in_reply_to":"7faddb67_1a389fd2","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"51ace954f24b430b80c97e437be377ba01bf2326","unresolved":false,"context_lines":[{"line_number":149,"context_line":"  in: body"},{"line_number":150,"context_line":"  required: false"},{"line_number":151,"context_line":"  type: boolean"},{"line_number":152,"context_line":"allowed_cidr:"},{"line_number":153,"context_line":"  description: |"},{"line_number":154,"context_line":"    A list of IPv4, IPv6 or mix of both CIDRs."},{"line_number":155,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_e84587b5","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":12},"updated":"2019-08-27 09:01:52.000000000","message":"we should use the plural form \"allowed_cidrs\".","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2e4a464385d473d1881668c1ec91d459439627e9","unresolved":false,"context_lines":[{"line_number":149,"context_line":"  in: body"},{"line_number":150,"context_line":"  required: false"},{"line_number":151,"context_line":"  type: boolean"},{"line_number":152,"context_line":"allowed_cidr:"},{"line_number":153,"context_line":"  description: |"},{"line_number":154,"context_line":"    A list of IPv4, IPv6 or mix of both CIDRs."},{"line_number":155,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_035c8417","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":12},"in_reply_to":"7faddb67_e84587b5","updated":"2019-08-27 09:05:14.000000000","message":"Done","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"51ace954f24b430b80c97e437be377ba01bf2326","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  in: body"},{"line_number":156,"context_line":"  required: true"},{"line_number":157,"context_line":"  type: array"},{"line_number":158,"context_line":"allowed_cidr-optional:"},{"line_number":159,"context_line":"  description: |"},{"line_number":160,"context_line":"    A list of IPv4, IPv6 or mix of both CIDRs. The default is all allowed."},{"line_number":161,"context_line":"    When a list of CIDRs is provided, the default switches to deny all."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_084103a7","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":12},"updated":"2019-08-27 09:01:52.000000000","message":"same here","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2e4a464385d473d1881668c1ec91d459439627e9","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  in: body"},{"line_number":156,"context_line":"  required: true"},{"line_number":157,"context_line":"  type: array"},{"line_number":158,"context_line":"allowed_cidr-optional:"},{"line_number":159,"context_line":"  description: |"},{"line_number":160,"context_line":"    A list of IPv4, IPv6 or mix of both CIDRs. The default is all allowed."},{"line_number":161,"context_line":"    When a list of CIDRs is provided, the default switches to deny all."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_e36048d2","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":12},"in_reply_to":"7faddb67_084103a7","updated":"2019-08-27 09:05:14.000000000","message":"Done","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"}],"api-ref/source/v2/examples/listener-create-curl":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X POST -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"listener\": {\"protocol\": \"TERMINATED_HTTPS\", \"description\": \"A great TLS listener\", \"admin_state_up\": true, \"connection_limit\": 200, \"protocol_port\": \"443\", \"loadbalancer_id\": \"607226db-27ef-4d41-ae89-f2a800e9c2db\", \"name\": \"great_tls_listener\", \"insert_headers\": {\"X-Forwarded-For\": \"true\", \"X-Forwarded-Port\": \"true\"}, \"default_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"sni_container_refs\": [\"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"http://198.51.100.10:9311/v1/containers/aaebb31e-7761-4826-8cb4-2b829caca3ee\"], \"timeout_client_data\": 50000, \"timeout_member_connect\": 5000, \"timeout_member_data\": 50000, \"timeout_tcp_inspect\": 0, \"tags\": [\"test_tag\"], \"client_ca_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/35649991-49f3-4625-81ce-2465fe8932e5\", \"client_authentication\": \"MANDATORY\", \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\", \"allowed_cidrs\": [\"10.0.1.0/24\", \"10.0.2.0/4\"]}}\u0027 http://198.51.100.10:9876/v2/lbaas/listeners"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"7faddb67_f7527c35","line":1,"range":{"start_line":1,"start_character":1110,"end_line":1,"end_character":1137},"updated":"2019-08-23 00:26:39.000000000","message":"Please use one of the \"documentation\" IP address ranges:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X POST -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"listener\": {\"protocol\": \"TERMINATED_HTTPS\", \"description\": \"A great TLS listener\", \"admin_state_up\": true, \"connection_limit\": 200, \"protocol_port\": \"443\", \"loadbalancer_id\": \"607226db-27ef-4d41-ae89-f2a800e9c2db\", \"name\": \"great_tls_listener\", \"insert_headers\": {\"X-Forwarded-For\": \"true\", \"X-Forwarded-Port\": \"true\"}, \"default_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"sni_container_refs\": [\"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"http://198.51.100.10:9311/v1/containers/aaebb31e-7761-4826-8cb4-2b829caca3ee\"], \"timeout_client_data\": 50000, \"timeout_member_connect\": 5000, \"timeout_member_data\": 50000, \"timeout_tcp_inspect\": 0, \"tags\": [\"test_tag\"], \"client_ca_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/35649991-49f3-4625-81ce-2465fe8932e5\", \"client_authentication\": \"MANDATORY\", \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\", \"allowed_cidrs\": [\"10.0.1.0/24\", \"10.0.2.0/4\"]}}\u0027 http://198.51.100.10:9876/v2/lbaas/listeners"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"7faddb67_fe69f08b","line":1,"range":{"start_line":1,"start_character":1110,"end_line":1,"end_character":1137},"in_reply_to":"7faddb67_f7527c35","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"api-ref/source/v2/examples/listener-create-request.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        \"client_authentication\": \"MANDATORY\","},{"line_number":26,"context_line":"        \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\","},{"line_number":27,"context_line":"        \"allowed_cidrs\": ["},{"line_number":28,"context_line":"            \"10.0.1.0/24\","},{"line_number":29,"context_line":"            \"10.0.2.0/24\""},{"line_number":30,"context_line":"        ]"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_972d48b0","line":30,"range":{"start_line":28,"start_character":12,"end_line":30,"end_character":9},"updated":"2019-08-23 00:26:39.000000000","message":"Please use one of the \"documentation\" IP address ranges:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        \"client_authentication\": \"MANDATORY\","},{"line_number":26,"context_line":"        \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\","},{"line_number":27,"context_line":"        \"allowed_cidrs\": ["},{"line_number":28,"context_line":"            \"10.0.1.0/24\","},{"line_number":29,"context_line":"            \"10.0.2.0/24\""},{"line_number":30,"context_line":"        ]"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_fefed0ad","line":30,"range":{"start_line":28,"start_character":12,"end_line":30,"end_character":9},"in_reply_to":"7faddb67_972d48b0","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"api-ref/source/v2/examples/listener-create-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \"client_authentication\": \"MANDATORY\","},{"line_number":41,"context_line":"        \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\","},{"line_number":42,"context_line":"        \"allowed_cidrs\": ["},{"line_number":43,"context_line":"            \"10.0.1.0/24\","},{"line_number":44,"context_line":"            \"10.0.2.0/24\""},{"line_number":45,"context_line":"        ]"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_b71ba47e","line":44,"range":{"start_line":43,"start_character":12,"end_line":44,"end_character":25},"updated":"2019-08-23 00:26:39.000000000","message":"Please use one of the \"documentation\" IP address ranges:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \"client_authentication\": \"MANDATORY\","},{"line_number":41,"context_line":"        \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\","},{"line_number":42,"context_line":"        \"allowed_cidrs\": ["},{"line_number":43,"context_line":"            \"10.0.1.0/24\","},{"line_number":44,"context_line":"            \"10.0.2.0/24\""},{"line_number":45,"context_line":"        ]"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_1efc0cb4","line":44,"range":{"start_line":43,"start_character":12,"end_line":44,"end_character":25},"in_reply_to":"7faddb67_b71ba47e","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"api-ref/source/v2/examples/listener-show-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \"client_authentication\": \"MANDATORY\","},{"line_number":41,"context_line":"        \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\","},{"line_number":42,"context_line":"        \"allowed_cidrs\": ["},{"line_number":43,"context_line":"            \"10.0.1.0/24\","},{"line_number":44,"context_line":"            \"10.0.2.0/24\""},{"line_number":45,"context_line":"        ]"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_5710305a","line":44,"range":{"start_line":43,"start_character":12,"end_line":44,"end_character":25},"updated":"2019-08-23 00:26:39.000000000","message":"Please use one of the \"documentation\" IP address ranges:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \"client_authentication\": \"MANDATORY\","},{"line_number":41,"context_line":"        \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\","},{"line_number":42,"context_line":"        \"allowed_cidrs\": ["},{"line_number":43,"context_line":"            \"10.0.1.0/24\","},{"line_number":44,"context_line":"            \"10.0.2.0/24\""},{"line_number":45,"context_line":"        ]"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_be2a982c","line":44,"range":{"start_line":43,"start_character":12,"end_line":44,"end_character":25},"in_reply_to":"7faddb67_5710305a","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"api-ref/source/v2/examples/listener-update-curl":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X PUT -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"listener\": {\"description\": \"An updated great TLS listener\", \"admin_state_up\": true, \"connection_limit\": 200, \"name\": \"great_updated_tls_listener\", \"insert_headers\": {\"X-Forwarded-For\": \"false\", \"X-Forwarded-Port\": \"true\"}, \"default_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"sni_container_refs\": [\"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"http://198.51.100.10:9311/v1/containers/aaebb31e-7761-4826-8cb4-2b829caca3ee\"], \"timeout_client_data\": 100000, \"timeout_member_connect\": 1000, \"timeout_member_data\": 100000, \"timeout_tcp_inspect\": 5, \"tags\": [\"updated_tag\"], \"client_ca_tls_container_ref\": null, \"allowed_cidrs\": [\"10.0.1.0/24\", \"10.0.2.0/4\"]}}\u0027 http://198.51.100.10:9876/v2/lbaas/listeners/023f2e34-7806-443b-bfae-16c324569a3d"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"7faddb67_d703c00f","line":1,"range":{"start_line":1,"start_character":798,"end_line":1,"end_character":824},"updated":"2019-08-23 00:26:39.000000000","message":"Please use one of the \"documentation\" IP address ranges:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X PUT -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"listener\": {\"description\": \"An updated great TLS listener\", \"admin_state_up\": true, \"connection_limit\": 200, \"name\": \"great_updated_tls_listener\", \"insert_headers\": {\"X-Forwarded-For\": \"false\", \"X-Forwarded-Port\": \"true\"}, \"default_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"sni_container_refs\": [\"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"http://198.51.100.10:9311/v1/containers/aaebb31e-7761-4826-8cb4-2b829caca3ee\"], \"timeout_client_data\": 100000, \"timeout_member_connect\": 1000, \"timeout_member_data\": 100000, \"timeout_tcp_inspect\": 5, \"tags\": [\"updated_tag\"], \"client_ca_tls_container_ref\": null, \"allowed_cidrs\": [\"10.0.1.0/24\", \"10.0.2.0/4\"]}}\u0027 http://198.51.100.10:9876/v2/lbaas/listeners/023f2e34-7806-443b-bfae-16c324569a3d"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"7faddb67_9e29dc38","line":1,"range":{"start_line":1,"start_character":798,"end_line":1,"end_character":824},"in_reply_to":"7faddb67_d703c00f","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"api-ref/source/v2/examples/listener-update-request.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        \"tags\": [\"updated_tag\"],"},{"line_number":22,"context_line":"        \"client_ca_tls_container_ref\": null,"},{"line_number":23,"context_line":"        \"allowed_cidrs\": ["},{"line_number":24,"context_line":"            \"10.0.1.0/24\","},{"line_number":25,"context_line":"            \"10.0.2.0/24\""},{"line_number":26,"context_line":"        ]"},{"line_number":27,"context_line":"    }"},{"line_number":28,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_f7003c05","line":25,"range":{"start_line":24,"start_character":12,"end_line":25,"end_character":25},"updated":"2019-08-23 00:26:39.000000000","message":"Please use one of the \"documentation\" IP address ranges:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        \"tags\": [\"updated_tag\"],"},{"line_number":22,"context_line":"        \"client_ca_tls_container_ref\": null,"},{"line_number":23,"context_line":"        \"allowed_cidrs\": ["},{"line_number":24,"context_line":"            \"10.0.1.0/24\","},{"line_number":25,"context_line":"            \"10.0.2.0/24\""},{"line_number":26,"context_line":"        ]"},{"line_number":27,"context_line":"    }"},{"line_number":28,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_3e1ea80d","line":25,"range":{"start_line":24,"start_character":12,"end_line":25,"end_character":25},"in_reply_to":"7faddb67_f7003c05","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"api-ref/source/v2/examples/listener-update-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \"client_authentication\": \"NONE\","},{"line_number":41,"context_line":"        \"client_crl_container_ref\": null,"},{"line_number":42,"context_line":"        \"allowed_cidrs\": ["},{"line_number":43,"context_line":"            \"10.0.1.0/24\","},{"line_number":44,"context_line":"            \"10.0.2.0/24\""},{"line_number":45,"context_line":"        ]"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_9afb2f14","line":44,"range":{"start_line":43,"start_character":12,"end_line":44,"end_character":25},"updated":"2019-08-23 00:26:39.000000000","message":"Please use one of the \"documentation\" IP address ranges:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \"client_authentication\": \"NONE\","},{"line_number":41,"context_line":"        \"client_crl_container_ref\": null,"},{"line_number":42,"context_line":"        \"allowed_cidrs\": ["},{"line_number":43,"context_line":"            \"10.0.1.0/24\","},{"line_number":44,"context_line":"            \"10.0.2.0/24\""},{"line_number":45,"context_line":"        ]"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_5e1b641b","line":44,"range":{"start_line":43,"start_character":12,"end_line":44,"end_character":25},"in_reply_to":"7faddb67_9afb2f14","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"api-ref/source/v2/examples/listeners-list-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \"client_authentication\": \"NONE\","},{"line_number":43,"context_line":"            \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\","},{"line_number":44,"context_line":"            \"allowed_cidrs\": ["},{"line_number":45,"context_line":"                \"10.0.1.0/24\","},{"line_number":46,"context_line":"                \"10.0.2.0/24\""},{"line_number":47,"context_line":"            ]"},{"line_number":48,"context_line":"        }"},{"line_number":49,"context_line":"    ]"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_ba006b02","line":46,"range":{"start_line":45,"start_character":16,"end_line":46,"end_character":29},"updated":"2019-08-23 00:26:39.000000000","message":"Please use one of the \"documentation\" IP address ranges:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \"client_authentication\": \"NONE\","},{"line_number":43,"context_line":"            \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\","},{"line_number":44,"context_line":"            \"allowed_cidrs\": ["},{"line_number":45,"context_line":"                \"10.0.1.0/24\","},{"line_number":46,"context_line":"                \"10.0.2.0/24\""},{"line_number":47,"context_line":"            ]"},{"line_number":48,"context_line":"        }"},{"line_number":49,"context_line":"    ]"}],"source_content_type":"application/json","patch_set":7,"id":"7faddb67_1e15ece5","line":46,"range":{"start_line":45,"start_character":16,"end_line":46,"end_character":29},"in_reply_to":"7faddb67_ba006b02","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"api-ref/source/v2/listener.inc":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"51ace954f24b430b80c97e437be377ba01bf2326","unresolved":false,"context_lines":[{"line_number":46,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":49,"context_line":"   - allowed_cidr: allowed_cidr"},{"line_number":50,"context_line":"   - client_authentication: client_authentication"},{"line_number":51,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref"},{"line_number":52,"context_line":"   - client_crl_container_ref: client_crl_container_ref"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_a811cfb1","line":49,"range":{"start_line":49,"start_character":5,"end_line":49,"end_character":31},"updated":"2019-08-27 09:01:52.000000000","message":"same here","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2e4a464385d473d1881668c1ec91d459439627e9","unresolved":false,"context_lines":[{"line_number":46,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":49,"context_line":"   - allowed_cidr: allowed_cidr"},{"line_number":50,"context_line":"   - client_authentication: client_authentication"},{"line_number":51,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref"},{"line_number":52,"context_line":"   - client_crl_container_ref: client_crl_container_ref"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_a39810cc","line":49,"range":{"start_line":49,"start_character":5,"end_line":49,"end_character":31},"in_reply_to":"7faddb67_a811cfb1","updated":"2019-08-27 09:05:14.000000000","message":"Done","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"51ace954f24b430b80c97e437be377ba01bf2326","unresolved":false,"context_lines":[{"line_number":140,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   - admin_state_up: admin_state_up-default-optional"},{"line_number":143,"context_line":"   - allowed_cidr: allowed_cidr-optional"},{"line_number":144,"context_line":"   - client_authentication: client_authentication-optional"},{"line_number":145,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref-optional"},{"line_number":146,"context_line":"   - client_crl_container_ref: client_crl_container_ref-optional"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_c8144ba2","line":143,"range":{"start_line":143,"start_character":5,"end_line":143,"end_character":31},"updated":"2019-08-27 09:01:52.000000000","message":"same here","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2e4a464385d473d1881668c1ec91d459439627e9","unresolved":false,"context_lines":[{"line_number":140,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   - admin_state_up: admin_state_up-default-optional"},{"line_number":143,"context_line":"   - allowed_cidr: allowed_cidr-optional"},{"line_number":144,"context_line":"   - client_authentication: client_authentication-optional"},{"line_number":145,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref-optional"},{"line_number":146,"context_line":"   - client_crl_container_ref: client_crl_container_ref-optional"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_c39bccc5","line":143,"range":{"start_line":143,"start_character":5,"end_line":143,"end_character":31},"in_reply_to":"7faddb67_c8144ba2","updated":"2019-08-27 09:05:14.000000000","message":"Done","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"51ace954f24b430b80c97e437be377ba01bf2326","unresolved":false,"context_lines":[{"line_number":261,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":264,"context_line":"   - allowed_cidr: allowed_cidr"},{"line_number":265,"context_line":"   - client_authentication: client_authentication"},{"line_number":266,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref"},{"line_number":267,"context_line":"   - client_crl_container_ref: client_crl_container_ref"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_680bd77c","line":264,"range":{"start_line":264,"start_character":9,"end_line":264,"end_character":27},"updated":"2019-08-27 09:01:52.000000000","message":"same","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2e4a464385d473d1881668c1ec91d459439627e9","unresolved":false,"context_lines":[{"line_number":261,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":264,"context_line":"   - allowed_cidr: allowed_cidr"},{"line_number":265,"context_line":"   - client_authentication: client_authentication"},{"line_number":266,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref"},{"line_number":267,"context_line":"   - client_crl_container_ref: client_crl_container_ref"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_63a218ff","line":264,"range":{"start_line":264,"start_character":9,"end_line":264,"end_character":27},"in_reply_to":"7faddb67_680bd77c","updated":"2019-08-27 09:05:14.000000000","message":"Done","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"51ace954f24b430b80c97e437be377ba01bf2326","unresolved":false,"context_lines":[{"line_number":339,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":342,"context_line":"   - allowed_cidr: allowed_cidr"},{"line_number":343,"context_line":"   - client_authentication: client_authentication"},{"line_number":344,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref"},{"line_number":345,"context_line":"   - client_crl_container_ref: client_crl_container_ref"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_880e538a","line":342,"updated":"2019-08-27 09:01:52.000000000","message":"same","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2e4a464385d473d1881668c1ec91d459439627e9","unresolved":false,"context_lines":[{"line_number":339,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":342,"context_line":"   - allowed_cidr: allowed_cidr"},{"line_number":343,"context_line":"   - client_authentication: client_authentication"},{"line_number":344,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref"},{"line_number":345,"context_line":"   - client_crl_container_ref: client_crl_container_ref"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_83a5d405","line":342,"in_reply_to":"7faddb67_880e538a","updated":"2019-08-27 09:05:14.000000000","message":"Done","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"51ace954f24b430b80c97e437be377ba01bf2326","unresolved":false,"context_lines":[{"line_number":407,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"   - admin_state_up: admin_state_up-default-optional"},{"line_number":410,"context_line":"   - allowed_cidr: allowed_cidr-optional"},{"line_number":411,"context_line":"   - client_authentication: client_authentication-optional"},{"line_number":412,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref-optional"},{"line_number":413,"context_line":"   - client_crl_container_ref: client_crl_container_ref-optional"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_2825df0a","line":410,"updated":"2019-08-27 09:01:52.000000000","message":"same","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2e4a464385d473d1881668c1ec91d459439627e9","unresolved":false,"context_lines":[{"line_number":407,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"   - admin_state_up: admin_state_up-default-optional"},{"line_number":410,"context_line":"   - allowed_cidr: allowed_cidr-optional"},{"line_number":411,"context_line":"   - client_authentication: client_authentication-optional"},{"line_number":412,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref-optional"},{"line_number":413,"context_line":"   - client_crl_container_ref: client_crl_container_ref-optional"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_23ac20ed","line":410,"in_reply_to":"7faddb67_2825df0a","updated":"2019-08-27 09:05:14.000000000","message":"Done","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"51ace954f24b430b80c97e437be377ba01bf2326","unresolved":false,"context_lines":[{"line_number":443,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":446,"context_line":"   - allowed_cidr: allowed_cidr"},{"line_number":447,"context_line":"   - client_authentication: client_authentication"},{"line_number":448,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref"},{"line_number":449,"context_line":"   - client_crl_container_ref: client_crl_container_ref"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_48205bf9","line":446,"updated":"2019-08-27 09:01:52.000000000","message":"same","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2e4a464385d473d1881668c1ec91d459439627e9","unresolved":false,"context_lines":[{"line_number":443,"context_line":".. rest_parameters:: ../parameters.yaml"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":446,"context_line":"   - allowed_cidr: allowed_cidr"},{"line_number":447,"context_line":"   - client_authentication: client_authentication"},{"line_number":448,"context_line":"   - client_ca_tls_container_ref: client_ca_tls_container_ref"},{"line_number":449,"context_line":"   - client_crl_container_ref: client_crl_container_ref"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7faddb67_e3b5a833","line":446,"in_reply_to":"7faddb67_48205bf9","updated":"2019-08-27 09:05:14.000000000","message":"Done","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"}],"doc/source/user/guides/basic-cookbook.rst":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":319,"context_line":"* We want to configure a basic load balancer that is accessible from the"},{"line_number":320,"context_line":"  internet, which distributes requests to the back-end servers."},{"line_number":321,"context_line":"* The application on TCP port 23456 is accessible to a limited source IP"},{"line_number":322,"context_line":"  addresses (10.0.0.0/24 and 172.16.0.0/16)."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"**Solution**:"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_da31a7ef","line":322,"range":{"start_line":322,"start_character":13,"end_line":322,"end_character":42},"updated":"2019-08-23 00:26:39.000000000","message":"Please use one of the \"documentation\" IP address ranges:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":319,"context_line":"* We want to configure a basic load balancer that is accessible from the"},{"line_number":320,"context_line":"  internet, which distributes requests to the back-end servers."},{"line_number":321,"context_line":"* The application on TCP port 23456 is accessible to a limited source IP"},{"line_number":322,"context_line":"  addresses (10.0.0.0/24 and 172.16.0.0/16)."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"**Solution**:"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_9edebc3c","line":322,"range":{"start_line":322,"start_character":13,"end_line":322,"end_character":42},"in_reply_to":"7faddb67_da31a7ef","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":324,"context_line":"**Solution**:"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"1. Create load balancer *lb1* on subnet *public-subnet*."},{"line_number":327,"context_line":"2. Create listener *listener1*."},{"line_number":328,"context_line":"3. Create pool *pool1* as *listener1*\u0027s default pool."},{"line_number":329,"context_line":"4. Add members 192.0.2.10 and 192.0.2.11 on *private-subnet* to *pool1*."},{"line_number":330,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_9a49ef67","line":327,"updated":"2019-08-23 00:26:39.000000000","message":"Create listener with allowed CIDRs.","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":324,"context_line":"**Solution**:"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"1. Create load balancer *lb1* on subnet *public-subnet*."},{"line_number":327,"context_line":"2. Create listener *listener1*."},{"line_number":328,"context_line":"3. Create pool *pool1* as *listener1*\u0027s default pool."},{"line_number":329,"context_line":"4. Add members 192.0.2.10 and 192.0.2.11 on *private-subnet* to *pool1*."},{"line_number":330,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_5ee044f9","line":327,"in_reply_to":"7faddb67_9a49ef67","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    openstack loadbalancer create --name lb1 --vip-subnet-id public-subnet"},{"line_number":336,"context_line":"    # Re-run the following until lb1 shows ACTIVE and ONLINE statuses:"},{"line_number":337,"context_line":"    openstack loadbalancer show lb1"},{"line_number":338,"context_line":"    openstack loadbalancer listener create --name listener1 --protocol TCP --protocol-port 23456 --allowed-cidr 10.0.0.0/24 --allowed-cidr 172.16.0.0/16 lb1"},{"line_number":339,"context_line":"    openstack loadbalancer pool create --name pool1 --lb-algorithm ROUND_ROBIN --listener listener1 --protocol TCP"},{"line_number":340,"context_line":"    openstack loadbalancer member create --subnet-id private-subnet --address 192.0.2.10 --protocol-port 80 pool1"},{"line_number":341,"context_line":"    openstack loadbalancer member create --subnet-id private-subnet --address 192.0.2.11 --protocol-port 80 pool1"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_ba4e2b6c","line":338,"range":{"start_line":338,"start_character":112,"end_line":338,"end_character":152},"updated":"2019-08-23 00:26:39.000000000","message":"Please use one of the \"documentation\" IP address ranges:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    openstack loadbalancer create --name lb1 --vip-subnet-id public-subnet"},{"line_number":336,"context_line":"    # Re-run the following until lb1 shows ACTIVE and ONLINE statuses:"},{"line_number":337,"context_line":"    openstack loadbalancer show lb1"},{"line_number":338,"context_line":"    openstack loadbalancer listener create --name listener1 --protocol TCP --protocol-port 23456 --allowed-cidr 10.0.0.0/24 --allowed-cidr 172.16.0.0/16 lb1"},{"line_number":339,"context_line":"    openstack loadbalancer pool create --name pool1 --lb-algorithm ROUND_ROBIN --listener listener1 --protocol TCP"},{"line_number":340,"context_line":"    openstack loadbalancer member create --subnet-id private-subnet --address 192.0.2.10 --protocol-port 80 pool1"},{"line_number":341,"context_line":"    openstack loadbalancer member create --subnet-id private-subnet --address 192.0.2.11 --protocol-port 80 pool1"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_feec90f5","line":338,"range":{"start_line":338,"start_character":112,"end_line":338,"end_character":152},"in_reply_to":"7faddb67_ba4e2b6c","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"octavia/api/common/types.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"824dee2feef91cf12185c85fafad4fb09b844e00","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def validate(value):"},{"line_number":53,"context_line":"        \"\"\"Validates whether value is an IPv4 or IPv6 CIDR.\"\"\""},{"line_number":54,"context_line":"        try:"},{"line_number":55,"context_line":"            return str(netaddr.IPNetwork(value).cidr)"},{"line_number":56,"context_line":"        except (ValueError, netaddr.core.AddrFormatError):"},{"line_number":57,"context_line":"            error \u003d \u0027Value should be IPv4 or IPv6 CIDR format\u0027"},{"line_number":58,"context_line":"            raise ValueError(error)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_afebc2d9","line":55,"updated":"2019-09-13 07:50:34.000000000","message":"Usually we just return the value again directly -- I don\u0027t know if it\u0027s actually USED or if that has just been our convention? This *could* theoretically mutate the value? Though it *shouldn\u0027t*. It\u0027s just different.","commit_id":"d14f85eaac742ca35f85cb03c20ae0430f09484a"}],"octavia/api/drivers/utils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            provider_l7policies.append(provider_l7policy)"},{"line_number":263,"context_line":"        new_listener_dict[\u0027l7policies\u0027] \u003d provider_l7policies"},{"line_number":264,"context_line":"    if \u0027allowed_cidrs\u0027 in listener_dict:"},{"line_number":265,"context_line":"        new_listener_dict[\u0027allowed_cidrs\u0027] \u003d listener_dict.pop(\u0027allowed_cidrs\u0027)"},{"line_number":266,"context_line":"    return new_listener_dict"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_ba85cb5b","line":265,"updated":"2019-08-23 00:26:39.000000000","message":"Why is this necessary? Shouldn\u0027t it already be in the new_listener_dict from the original copy if listener_dict?\n\nUsually we only have to do this if the key name changes.","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            provider_l7policies.append(provider_l7policy)"},{"line_number":263,"context_line":"        new_listener_dict[\u0027l7policies\u0027] \u003d provider_l7policies"},{"line_number":264,"context_line":"    if \u0027allowed_cidrs\u0027 in listener_dict:"},{"line_number":265,"context_line":"        new_listener_dict[\u0027allowed_cidrs\u0027] \u003d listener_dict.pop(\u0027allowed_cidrs\u0027)"},{"line_number":266,"context_line":"    return new_listener_dict"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_efe29830","line":265,"in_reply_to":"7faddb67_ba85cb5b","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"octavia/api/v2/controllers/listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        lb_id \u003d listener_dict.get(\u0027load_balancer_id\u0027)"},{"line_number":245,"context_line":"        vip_db \u003d self.repositories.vip.get("},{"line_number":246,"context_line":"            lock_session, load_balancer_id\u003dlb_id)"},{"line_number":247,"context_line":"        vip \u003d vip_db.ip_address"},{"line_number":248,"context_line":"        self._validate_cidr_compatible_with_vip(vip, allowed_cidrs)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_3ad6bb55","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":11},"updated":"2019-08-23 00:26:39.000000000","message":"nit: It would be more clear to say vip_address since we have other \"vip\" objects around here.","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        lb_id \u003d listener_dict.get(\u0027load_balancer_id\u0027)"},{"line_number":245,"context_line":"        vip_db \u003d self.repositories.vip.get("},{"line_number":246,"context_line":"            lock_session, load_balancer_id\u003dlb_id)"},{"line_number":247,"context_line":"        vip \u003d vip_db.ip_address"},{"line_number":248,"context_line":"        self._validate_cidr_compatible_with_vip(vip, allowed_cidrs)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_117abdb9","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":11},"in_reply_to":"7faddb67_3ad6bb55","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        # Validate allowed CIDRs"},{"line_number":448,"context_line":"        if (listener.allowed_cidrs and listener.allowed_cidrs !\u003d wtypes.Unset):"},{"line_number":449,"context_line":"            vip \u003d db_listener.load_balancer.vip.ip_address"},{"line_number":450,"context_line":"            self._validate_cidr_compatible_with_vip("},{"line_number":451,"context_line":"                vip, listener.allowed_cidrs)"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_9a01efb8","line":449,"range":{"start_line":449,"start_character":12,"end_line":449,"end_character":15},"updated":"2019-08-23 00:26:39.000000000","message":"nit: same, vip_address?","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        # Validate allowed CIDRs"},{"line_number":448,"context_line":"        if (listener.allowed_cidrs and listener.allowed_cidrs !\u003d wtypes.Unset):"},{"line_number":449,"context_line":"            vip \u003d db_listener.load_balancer.vip.ip_address"},{"line_number":450,"context_line":"            self._validate_cidr_compatible_with_vip("},{"line_number":451,"context_line":"                vip, listener.allowed_cidrs)"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_b148898a","line":449,"range":{"start_line":449,"start_character":12,"end_line":449,"end_character":15},"in_reply_to":"7faddb67_9a01efb8","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":515,"context_line":"            db_listener \u003d self.repositories.listener.get("},{"line_number":516,"context_line":"                lock_session, id\u003ddb_listener.id)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"            allowed_cidrs \u003d listener_dict.pop(\u0027allowed_cidrs\u0027, [])"},{"line_number":519,"context_line":"            self.repositories.listener_cidr.update("},{"line_number":520,"context_line":"                lock_session, id, allowed_cidrs)"},{"line_number":521,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_fafb43bb","line":518,"updated":"2019-08-23 00:26:39.000000000","message":"Does this work correctly with listener_dict[\u0027allowed_cidrs\u0027] \u003d wtypes.Unset?","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":515,"context_line":"            db_listener \u003d self.repositories.listener.get("},{"line_number":516,"context_line":"                lock_session, id\u003ddb_listener.id)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"            allowed_cidrs \u003d listener_dict.pop(\u0027allowed_cidrs\u0027, [])"},{"line_number":519,"context_line":"            self.repositories.listener_cidr.update("},{"line_number":520,"context_line":"                lock_session, id, allowed_cidrs)"},{"line_number":521,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_6f58e889","line":518,"in_reply_to":"7faddb67_fafb43bb","updated":"2019-08-26 13:04:28.000000000","message":"listener_dict is rendered without Unsets (L512)","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"824dee2feef91cf12185c85fafad4fb09b844e00","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                                    \u0027tls_container_id\u0027)}"},{"line_number":292,"context_line":"                    self.repositories.sni.create(lock_session, **sni_dict)"},{"line_number":293,"context_line":"                # DB listener needs to be refreshed"},{"line_number":294,"context_line":"                db_listener \u003d self.repositories.listener.get(lock_session,"},{"line_number":295,"context_line":"                                                             id\u003ddb_listener.id)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"            return db_listener"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_4fa32eb3","line":294,"updated":"2019-09-13 07:50:34.000000000","message":"Why did you reformat this? I liked it the old way! :D","commit_id":"d14f85eaac742ca35f85cb03c20ae0430f09484a"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"832db701241370047480981cd683f81a2b8d05d6","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                                    \u0027tls_container_id\u0027)}"},{"line_number":292,"context_line":"                    self.repositories.sni.create(lock_session, **sni_dict)"},{"line_number":293,"context_line":"                # DB listener needs to be refreshed"},{"line_number":294,"context_line":"                db_listener \u003d self.repositories.listener.get(lock_session,"},{"line_number":295,"context_line":"                                                             id\u003ddb_listener.id)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"            return db_listener"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_4f648e4a","line":294,"in_reply_to":"5faad753_4fa32eb3","updated":"2019-09-13 08:09:51.000000000","message":"Ah, this is because I had made changes around this code in a previous patch set but later reverted. Forgot to revert this line. Fixed.","commit_id":"d14f85eaac742ca35f85cb03c20ae0430f09484a"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"824dee2feef91cf12185c85fafad4fb09b844e00","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            listener_dict[\u0027id\u0027] \u003d id"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"            db_listener \u003d self.repositories.listener.get("},{"line_number":544,"context_line":"                lock_session, id\u003ddb_listener.id)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"            provider_listener_dict \u003d ("},{"line_number":547,"context_line":"                driver_utils.listener_dict_to_provider_dict(listener_dict))"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_af72e247","line":544,"updated":"2019-09-13 07:50:34.000000000","message":"We\u0027re re-fetching this here? Why? What changed in the last 27 or so lines / what new thing happens after this that would require a version from within a lock session?","commit_id":"d14f85eaac742ca35f85cb03c20ae0430f09484a"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"05d31cc306e6062166b0d0a376ca90403894b313","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            listener_dict[\u0027id\u0027] \u003d id"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"            db_listener \u003d self.repositories.listener.get("},{"line_number":544,"context_line":"                lock_session, id\u003ddb_listener.id)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"            provider_listener_dict \u003d ("},{"line_number":547,"context_line":"                driver_utils.listener_dict_to_provider_dict(listener_dict))"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_0f6bf6f0","line":544,"in_reply_to":"5faad753_af72e247","updated":"2019-09-13 08:07:07.000000000","message":"Eh, if it\u0027s a problem we can fix it later, but guessing there\u0027s a reason I\u0027m not catching because it\u0027s late. :D","commit_id":"d14f85eaac742ca35f85cb03c20ae0430f09484a"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"832db701241370047480981cd683f81a2b8d05d6","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            listener_dict[\u0027id\u0027] \u003d id"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"            db_listener \u003d self.repositories.listener.get("},{"line_number":544,"context_line":"                lock_session, id\u003ddb_listener.id)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"            provider_listener_dict \u003d ("},{"line_number":547,"context_line":"                driver_utils.listener_dict_to_provider_dict(listener_dict))"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_2f7032dc","line":544,"in_reply_to":"5faad753_af72e247","updated":"2019-09-13 08:09:51.000000000","message":"Oops! This line was added in a previous patch set when the CIDR DB records were being created explicitly by the API (similar to sni_containers), hence the db_listener had to be refreshed here.","commit_id":"d14f85eaac742ca35f85cb03c20ae0430f09484a"}],"octavia/common/data_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            return obj.__class__.__name__ + obj.pool_id"},{"line_number":101,"context_line":"        if obj.__class__.__name__ in [\u0027ListenerStatistics\u0027]:"},{"line_number":102,"context_line":"            return obj.__class__.__name__ + obj.listener_id + obj.amphora_id"},{"line_number":103,"context_line":"        if obj.__class__.__name__ in [\u0027ListenerCidr\u0027]:"},{"line_number":104,"context_line":"            return obj.__class__.__name__ + obj.listener_id + obj.cidr"},{"line_number":105,"context_line":"        if obj.__class__.__name__ in [\u0027VRRPGroup\u0027, \u0027Vip\u0027]:"},{"line_number":106,"context_line":"            return obj.__class__.__name__ + obj.load_balancer_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_fad34300","line":103,"updated":"2019-08-23 00:26:39.000000000","message":"This is missing coverage.","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            return obj.__class__.__name__ + obj.pool_id"},{"line_number":101,"context_line":"        if obj.__class__.__name__ in [\u0027ListenerStatistics\u0027]:"},{"line_number":102,"context_line":"            return obj.__class__.__name__ + obj.listener_id + obj.amphora_id"},{"line_number":103,"context_line":"        if obj.__class__.__name__ in [\u0027ListenerCidr\u0027]:"},{"line_number":104,"context_line":"            return obj.__class__.__name__ + obj.listener_id + obj.cidr"},{"line_number":105,"context_line":"        if obj.__class__.__name__ in [\u0027VRRPGroup\u0027, \u0027Vip\u0027]:"},{"line_number":106,"context_line":"            return obj.__class__.__name__ + obj.load_balancer_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_803c11e2","line":103,"in_reply_to":"7faddb67_fad34300","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"octavia/common/utils.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"51ace954f24b430b80c97e437be377ba01bf2326","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def is_cidr_ipv6(cidr):"},{"line_number":68,"context_line":"    \"\"\"Check if ip address is IPv6 address.\"\"\""},{"line_number":69,"context_line":"    ip \u003d netaddr.IPNetwork(cidr)"},{"line_number":70,"context_line":"    return ip.version \u003d\u003d 6"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_c8f0cb69","line":68,"range":{"start_line":68,"start_character":7,"end_line":68,"end_character":42},"updated":"2019-08-27 09:01:52.000000000","message":"Would be better with \"Check if cidr is IPv6 address with subnet prefix\"","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2e4a464385d473d1881668c1ec91d459439627e9","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def is_cidr_ipv6(cidr):"},{"line_number":68,"context_line":"    \"\"\"Check if ip address is IPv6 address.\"\"\""},{"line_number":69,"context_line":"    ip \u003d netaddr.IPNetwork(cidr)"},{"line_number":70,"context_line":"    return ip.version \u003d\u003d 6"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_837e3468","line":68,"range":{"start_line":68,"start_character":7,"end_line":68,"end_character":42},"in_reply_to":"7faddb67_c8f0cb69","updated":"2019-08-27 09:05:14.000000000","message":"Done","commit_id":"fa4e8738e0ce086caf0030e9371c007f4e69363d"}],"octavia/db/models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        sa.String(36),"},{"line_number":809,"context_line":"        sa.ForeignKey(\"listener.id\", name\u003d\"fk_listener_cidr_listener_id\"),"},{"line_number":810,"context_line":"        nullable\u003dFalse)"},{"line_number":811,"context_line":"    cidr \u003d sa.Column(sa.String(36), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_fa97c344","line":811,"range":{"start_line":811,"start_character":31,"end_line":811,"end_character":33},"updated":"2019-08-23 00:26:39.000000000","message":"64","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74a870fb2292a0bf20a122e36a582b9403e3d8f9","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        sa.String(36),"},{"line_number":809,"context_line":"        sa.ForeignKey(\"listener.id\", name\u003d\"fk_listener_cidr_listener_id\"),"},{"line_number":810,"context_line":"        nullable\u003dFalse)"},{"line_number":811,"context_line":"    cidr \u003d sa.Column(sa.String(36), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_832b8331","line":811,"range":{"start_line":811,"start_character":31,"end_line":811,"end_character":33},"in_reply_to":"7faddb67_086fc328","updated":"2019-08-27 21:57:29.000000000","message":"Well, it would be 44 or 64 (note that your example uses a compressed address \":db8:\" uncompresses to \":0db8:\"). We have been using 64, so I would continue that tradition.","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"8fcea278caca4c527fe6222b39f6c263846398f2","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        sa.String(36),"},{"line_number":809,"context_line":"        sa.ForeignKey(\"listener.id\", name\u003d\"fk_listener_cidr_listener_id\"),"},{"line_number":810,"context_line":"        nullable\u003dFalse)"},{"line_number":811,"context_line":"    cidr \u003d sa.Column(sa.String(36), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_086fc328","line":811,"range":{"start_line":811,"start_character":31,"end_line":811,"end_character":33},"in_reply_to":"7faddb67_935c514d","updated":"2019-08-27 08:35:49.000000000","message":"Oops! Should it be updated to 43 or left at 64? Do we care if it takes a few extra bytes of DB storage?","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3703e16d3c934a93da80a005b5da8f3aba9fc115","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        sa.String(36),"},{"line_number":809,"context_line":"        sa.ForeignKey(\"listener.id\", name\u003d\"fk_listener_cidr_listener_id\"),"},{"line_number":810,"context_line":"        nullable\u003dFalse)"},{"line_number":811,"context_line":"    cidr \u003d sa.Column(sa.String(36), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_935c514d","line":811,"range":{"start_line":811,"start_character":31,"end_line":811,"end_character":33},"in_reply_to":"7faddb67_b497179d","updated":"2019-08-26 17:27:32.000000000","message":"64 is what you put in your alembic migration.","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        sa.String(36),"},{"line_number":809,"context_line":"        sa.ForeignKey(\"listener.id\", name\u003d\"fk_listener_cidr_listener_id\"),"},{"line_number":810,"context_line":"        nullable\u003dFalse)"},{"line_number":811,"context_line":"    cidr \u003d sa.Column(sa.String(36), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_b497179d","line":811,"range":{"start_line":811,"start_character":31,"end_line":811,"end_character":33},"in_reply_to":"7faddb67_fa97c344","updated":"2019-08-26 13:04:28.000000000","message":"Right, 36 is too short for IPv6 but why 64? 43 would be enough, no?\n\n2001:db8:0000:0000:0000:0000:0000:0001/128","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"octavia/db/repositories.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"                listener_db.allowed_cidrs.append(cidr)"},{"line_number":1082,"context_line":"            listener_db.update(model_kwargs)"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"    def create(self, session, **model_kwargs):"},{"line_number":1085,"context_line":"        \"\"\"Creates a new Listener with some validation.\"\"\""},{"line_number":1086,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":1087,"context_line":"            model \u003d self.model_class(**model_kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_5aae1782","line":1084,"updated":"2019-08-23 00:26:39.000000000","message":"Doesn\u0027t this also need to handle \u0027allowed_cidrs\u0027 since it is a param in the model?\nI know the API is splitting this off now, but not handling this on a listener create call could cause problems down the road.","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"                listener_db.allowed_cidrs.append(cidr)"},{"line_number":1082,"context_line":"            listener_db.update(model_kwargs)"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"    def create(self, session, **model_kwargs):"},{"line_number":1085,"context_line":"        \"\"\"Creates a new Listener with some validation.\"\"\""},{"line_number":1086,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":1087,"context_line":"            model \u003d self.model_class(**model_kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_ad47af1e","line":1084,"in_reply_to":"7faddb67_5aae1782","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}],"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2b10e9ec95dbf361d75913e36de6cc9ca1c8dff","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            if l.protocol \u003d\u003d constants.PROTOCOL_UDP:"},{"line_number":145,"context_line":"                protocol \u003d constants.PROTOCOL_UDP.lower()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            if l.allowed_cidrs:"},{"line_number":148,"context_line":"                for ac in l.allowed_cidrs:"},{"line_number":149,"context_line":"                    port \u003d (l.protocol_port, protocol, ac.cidr)"},{"line_number":150,"context_line":"                    updated_ports.append(port)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_5afcd771","line":147,"updated":"2019-08-23 00:26:39.000000000","message":"Missing test coverage.","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74c26af3eeb5b4181d57a5e94536d428fed00ea4","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            if l.protocol \u003d\u003d constants.PROTOCOL_UDP:"},{"line_number":145,"context_line":"                protocol \u003d constants.PROTOCOL_UDP.lower()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            if l.allowed_cidrs:"},{"line_number":148,"context_line":"                for ac in l.allowed_cidrs:"},{"line_number":149,"context_line":"                    port \u003d (l.protocol_port, protocol, ac.cidr)"},{"line_number":150,"context_line":"                    updated_ports.append(port)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_3eed2f8e","line":147,"in_reply_to":"7faddb67_5afcd771","updated":"2019-08-26 13:04:28.000000000","message":"Done","commit_id":"1946bd182008eead62d9786bc9f52fc6fbd24f47"}]}