)]}'
{"octavia/api/drivers/amphora_driver/v2/driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d3edff355f364019863579c905a9ffdf1862e6fd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        super(AmphoraProviderDriver, self).__init__()"},{"line_number":45,"context_line":"        self.target \u003d messaging.Target("},{"line_number":46,"context_line":"            namespace\u003dconsts.RPC_NAMESPACE_CONTROLLER_AGENT,"},{"line_number":47,"context_line":"            topic\u003dconsts.TOPIC_AMPHORA_V2, version\u003d\"1.0\", fanout\u003dFalse)"},{"line_number":48,"context_line":"        self.client \u003d rpc.get_client(self.target)"},{"line_number":49,"context_line":"        self.repositories \u003d repositories.Repositories()"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_f7792a2f","line":47,"range":{"start_line":47,"start_character":52,"end_line":47,"end_character":55},"updated":"2019-05-16 23:38:07.000000000","message":"Fixed this already","commit_id":"cbf5ecc90acbc1fddfaf38f34d358b62e2f8ffbe"}],"octavia/cmd/octavia_worker.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"266d82408ee902986ac75a1adc354a76e4873a1f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    sm.add(consumer.ConsumerService, workers\u003dCONF.controller_worker.workers,"},{"line_number":36,"context_line":"           args\u003d(CONF,))"},{"line_number":37,"context_line":"    sm.add(consumer.ConsumerServiceV2, workers\u003dCONF.controller_worker.workers,"},{"line_number":38,"context_line":"           args\u003d(CONF,))"},{"line_number":39,"context_line":"    oslo_config_glue.setup(sm, CONF, reload_method\u003d\"mutate\")"},{"line_number":40,"context_line":"    sm.run()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_425b962d","line":38,"updated":"2019-05-17 00:52:01.000000000","message":"does this mean that both will run at the same time, and both will have config-max workers?","commit_id":"cbf5ecc90acbc1fddfaf38f34d358b62e2f8ffbe"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"60775b950b61503b859da7c1bf91571002b24f20","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    sm.add(consumer.ConsumerService, workers\u003dCONF.controller_worker.workers,"},{"line_number":36,"context_line":"           args\u003d(CONF,))"},{"line_number":37,"context_line":"    sm.add(consumer.ConsumerServiceV2, workers\u003dCONF.controller_worker.workers,"},{"line_number":38,"context_line":"           args\u003d(CONF,))"},{"line_number":39,"context_line":"    oslo_config_glue.setup(sm, CONF, reload_method\u003d\"mutate\")"},{"line_number":40,"context_line":"    sm.run()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_dd4e7dc0","line":38,"in_reply_to":"bfb3d3c7_425b962d","updated":"2019-05-17 18:17:06.000000000","message":"That is my intention, yes.","commit_id":"cbf5ecc90acbc1fddfaf38f34d358b62e2f8ffbe"}],"octavia/common/constants.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7194c598518ffa2995133d430a0b2a53558677cc","unresolved":false,"context_lines":[{"line_number":657,"context_line":"SUPPORTED_CLIENT_AUTH_MODES \u003d [CLIENT_AUTH_NONE, CLIENT_AUTH_OPTIONAL,"},{"line_number":658,"context_line":"                               CLIENT_AUTH_MANDATORY]"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"TOPIC_AMPHORA_V2 \u003d \u0027octavia_provisioning_v2\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_5dd6cec5","line":660,"updated":"2019-06-05 21:00:07.000000000","message":"Why don\u0027t we have a TOPIC_AMPHORA_V1?\nThat\u0027s a little rhetorical, because the topic for the v1 driver is from config. So, really, why isn\u0027t this the same as that? Is it because you plan to swap them at some point and for now this shouldn\u0027t be visible to users?","commit_id":"841cd348a444af66ad1953ed1fa8e3d17aebdfaf"}],"octavia/controller/queue/consumer.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"266d82408ee902986ac75a1adc354a76e4873a1f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        super(ConsumerService, self).terminate()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class ConsumerServiceV2(cotyledon.Service):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def __init__(self, worker_id, conf):"},{"line_number":71,"context_line":"        super(ConsumerServiceV2, self).__init__(worker_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_c246a650","line":68,"updated":"2019-05-17 00:52:01.000000000","message":"This is in the same file, but the other worker is in a different file?\nI\u0027m not sure if I like the inconsistency -- this should probably be its own file as well (though Im not sure if I agree exactly with the current naming scheme, ala \"v2_worker.py\" / \"v2_consumer.py\").","commit_id":"cbf5ecc90acbc1fddfaf38f34d358b62e2f8ffbe"}],"octavia/controller/queue/v1/consumer.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7194c598518ffa2995133d430a0b2a53558677cc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_messaging.rpc import dispatcher"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from octavia.common import rpc"},{"line_number":21,"context_line":"from octavia.controller.queue.v1 import endpoints"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_9ded268d","line":21,"updated":"2019-06-05 21:00:07.000000000","message":"Why exactly did this pluralize? There\u0027s still only one Endpoint class in there, and it\u0027s not importing v1 AND v2 (which would then be plural), just v1. Is the \"Endpoint\" class logically exposing multiple Endpoints? In that case wouldn\u0027t we also rename that?","commit_id":"841cd348a444af66ad1953ed1fa8e3d17aebdfaf"}],"setup.cfg":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"266d82408ee902986ac75a1adc354a76e4873a1f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"octavia.api.drivers \u003d"},{"line_number":57,"context_line":"    noop_driver \u003d octavia.api.drivers.noop_driver.driver:NoopProviderDriver"},{"line_number":58,"context_line":"    noop_driver-alt \u003d octavia.api.drivers.noop_driver.driver:NoopProviderDriver"},{"line_number":59,"context_line":"    amphora \u003d octavia.api.drivers.amphora_driver.driver:AmphoraProviderDriver"},{"line_number":60,"context_line":"    # octavia is an alias for backward compatibility"},{"line_number":61,"context_line":"    octavia \u003d octavia.api.drivers.amphora_driver.driver:AmphoraProviderDriver"},{"line_number":62,"context_line":"    amphorav2 \u003d octavia.api.drivers.amphora_driver.v2.driver:AmphoraV2ProviderDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"bfb3d3c7_4274f699","line":59,"updated":"2019-05-17 00:52:01.000000000","message":"I would think we could move files around and change this to `octavia.api.drivers.amphora_driver.v1.driver` without breaking anything right? Since it\u0027d all be within the same commit.","commit_id":"cbf5ecc90acbc1fddfaf38f34d358b62e2f8ffbe"}]}