)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9725df8a265f186e7c4b0fe750d072d7cc6e6ab6","unresolved":false,"context_lines":[{"line_number":339,"context_line":"else"},{"line_number":340,"context_line":"    if [ \"${AMP_BASEOS}\" \u003d \"rhel\" ] \u0026\u0026 [ \"${DIB_RELEASE}\" \u003d \"8\" ]; then"},{"line_number":341,"context_line":"        export DIB_INSTALLTYPE_pip_and_virtualenv\u003dpackage"},{"line_number":342,"context_line":"        export FS_TYPE\u003dxfs"},{"line_number":343,"context_line":"    fi"},{"line_number":344,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence ${AMP_BASEOS}\""},{"line_number":345,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"bfb3d3c7_dad81f7c","line":342,"updated":"2019-05-28 17:56:51.000000000","message":"This should be handled by DIB and the rhel elements.","commit_id":"ead14e7256426acd7d325815b79ab6419be60006"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"74a01abfc4fd6f6e06b15778705af1df78b3a42a","unresolved":false,"context_lines":[{"line_number":339,"context_line":"else"},{"line_number":340,"context_line":"    if [ \"${AMP_BASEOS}\" \u003d \"rhel\" ] \u0026\u0026 [ \"${DIB_RELEASE}\" \u003d \"8\" ]; then"},{"line_number":341,"context_line":"        export DIB_INSTALLTYPE_pip_and_virtualenv\u003dpackage"},{"line_number":342,"context_line":"        export FS_TYPE\u003dxfs"},{"line_number":343,"context_line":"    fi"},{"line_number":344,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence ${AMP_BASEOS}\""},{"line_number":345,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"bfb3d3c7_00ce3eb3","line":342,"in_reply_to":"bfb3d3c7_dad81f7c","updated":"2019-05-29 09:40:56.000000000","message":"the problem is that the rhel element gets called much after https://opendev.org/openstack/diskimage-builder/src/branch/master/diskimage_builder/lib/img-defaults#L20\n\nwhich basically set \u0027ext4\u0027 and ends up producing a non-bootalble image.\nI\u0027m going to followup on this patch with a different approach.","commit_id":"ead14e7256426acd7d325815b79ab6419be60006"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"eb1d0938742e440ada4fa2f04cf1162619b96422","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            usage"},{"line_number":124,"context_line":"        ;;"},{"line_number":125,"context_line":"        i)"},{"line_number":126,"context_line":"            export DISTRO_NAME\u003d$OPTARG"},{"line_number":127,"context_line":"            if [ \"${DISTRO_NAME}\" !\u003d \"ubuntu\" ] \u0026\u0026 \\"},{"line_number":128,"context_line":"                [ \"${DISTRO_NAME}\" !\u003d \"ubuntu-minimal\" ] \u0026\u0026 \\"},{"line_number":129,"context_line":"                [ \"${DISTRO_NAME}\" !\u003d \"fedora\" ] \u0026\u0026 \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bfb3d3c7_920b5228","line":126,"updated":"2019-05-29 22:58:52.000000000","message":"So AMP_BASEOS was an internal variable name and not published as far as I see, so this is probably fine.","commit_id":"5ef8f478469b4fa163ac88c04b583f4cf6b1b368"}]}