)]}'
{"octavia/api/v2/controllers/flavor_profiles.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"f53fa9842df7d9f48bd0eb19788e3038750a5bba","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return profile_types.FlavorProfileRootResponse(flavorprofile\u003dresult)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def _validate_update_fp(self, context, id, flavorprofile):"},{"line_number":115,"context_line":"        if flavorprofile.name is None:"},{"line_number":116,"context_line":"            raise exceptions.InvalidOption(value\u003dNone, option\u003dconstants.NAME)"},{"line_number":117,"context_line":"        if flavorprofile.provider_name is None:"},{"line_number":118,"context_line":"            raise exceptions.InvalidOption(value\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_0ba6da54","line":115,"updated":"2019-07-25 16:36:16.000000000","message":"Couldn\u0027t this validation be done in WSME by defining a min_length? Same for other fields.\n\nname \u003d wtypes.wsattr(wtypes.StringType(min_length\u003d1, max_length\u003d255))","commit_id":"8bdce107f8d7aae2d05363fab87c5db30f7bae57"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d6a4f5ad00b5a734e7fdbefe7321baaad716fef3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return profile_types.FlavorProfileRootResponse(flavorprofile\u003dresult)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def _validate_update_fp(self, context, id, flavorprofile):"},{"line_number":115,"context_line":"        if flavorprofile.name is None:"},{"line_number":116,"context_line":"            raise exceptions.InvalidOption(value\u003dNone, option\u003dconstants.NAME)"},{"line_number":117,"context_line":"        if flavorprofile.provider_name is None:"},{"line_number":118,"context_line":"            raise exceptions.InvalidOption(value\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_b2f92481","line":115,"in_reply_to":"7faddb67_0ba6da54","updated":"2019-07-26 22:05:51.000000000","message":"That would make \"name\" mandatory for all update calls, which we don\u0027t want if you are only updating the description.\nI.e. we want to accept/have UnSet or something, but not None.","commit_id":"8bdce107f8d7aae2d05363fab87c5db30f7bae57"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"bf68415c9fe9a57ef7cf775519e2e8ca9b6825af","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return profile_types.FlavorProfileRootResponse(flavorprofile\u003dresult)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def _validate_update_fp(self, context, id, flavorprofile):"},{"line_number":115,"context_line":"        if flavorprofile.name is None:"},{"line_number":116,"context_line":"            raise exceptions.InvalidOption(value\u003dNone, option\u003dconstants.NAME)"},{"line_number":117,"context_line":"        if flavorprofile.provider_name is None:"},{"line_number":118,"context_line":"            raise exceptions.InvalidOption(value\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_275acc29","line":115,"in_reply_to":"7faddb67_b2f92481","updated":"2019-07-27 21:59:33.000000000","message":"D\u0027oh! it was a silly question, wasn\u0027t it?! :D","commit_id":"8bdce107f8d7aae2d05363fab87c5db30f7bae57"}]}
