)]}'
{"id":"openstack%2Foctavia~663258","triplet_id":"openstack%2Foctavia~master~I01c343466913abda9b0ac0c1cd9746430eb78dd4","project":"openstack/octavia","branch":"master","topic":"neutron-security-groups","hashtags":[],"change_id":"I01c343466913abda9b0ac0c1cd9746430eb78dd4","subject":"neutron: Update security groups","status":"ABANDONED","created":"2019-06-05 07:26:26.000000000","updated":"2019-06-05 08:56:57.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b2ed94b3641b978a72b05ef3adc3058b8ce4b49a","_number":663258,"virtual_id_number":663258,"owner":{"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},{"value":-1,"date":"2019-06-05 07:44:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},"all":[{"value":-1,"date":"2019-06-05 07:26:39.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-05 07:44:00.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"}],"messages":[{"id":"b7a5a2ac4b4484c05e3964fca23e05e3f7d23613","author":{"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},"date":"2019-06-05 07:26:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"028160d197575e4ff8a7b468368d70b5ffb088bf","author":{"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},"date":"2019-06-05 07:26:39.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"9d7362fe1533a37001972a62429ead47fb8278dc","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2019-06-05 07:44:00.000000000","message":"Patch Set 1: Code-Review-1\n\nThanks for the patch, Sven! \n\nLuis, from Kuryr team, proposed a very similar patch before: https://review.opendev.org/#/q/I2346c8a3f2fa4b4eb8a004b4aaab93986228c371\n\nThe community discussed this topic on multiple occasions already (weekly meetings, PTGs, Storyboard).\n\nStory: https://storyboard.openstack.org/#!/story/2003686\nPTG: https://etherpad.openstack.org/p/octavia-train-ptg (line 300-309)\n\nThe reached understanding was to pursue with a new VIP access control list API. That effort is already in progress and planned for Train release. You can track it at  https://review.opendev.org/#/q/topic:vip-acl","accounts_in_message":[],"_revision_number":1},{"id":"ec6e3b097456e157f1bf27facfcabb9bfbe61fe1","author":{"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},"date":"2019-06-05 07:59:57.000000000","message":"Abandoned\n\nok, thanks for the links. i\u0027ve had this setting in my queue for some time, because we needed it on our installation.","accounts_in_message":[],"_revision_number":1},{"id":"f452040e0ef5b104164079e6afcd71148448a703","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2019-06-05 08:56:57.000000000","message":"Patch Set 1:\n\nJFYI, if you decide to use Luis\u0027 patch (Red Hat OpenStack Platform offer includes with it) and you use puppet and/or TripleO, these two patches might also be of interest:\n\npuppet-octavia: https://review.opendev.org/#/q/I2dbca4bb778dcd1132946641eb304194b279a8ea\n\ntripleo-heat-templates: https://review.opendev.org/#/q/Ib6d2e19febdff00fb1a92302e2777948332dfa42","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"86acb3546a72cbf3ee934fcb7dc6c54886f2e15b","revisions":{"86acb3546a72cbf3ee934fcb7dc6c54886f2e15b":{"kind":"REWORK","_number":1,"created":"2019-06-05 07:26:26.000000000","uploader":{"_account_id":27056,"name":"Sven Wegener","email":"sven.wegener@stealer.net","username":"swegener"},"ref":"refs/changes/58/663258/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/58/663258/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/58/663258/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/58/663258/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/58/663258/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/58/663258/1"}}},"commit":{"parents":[{"commit":"59660fb3650d3729375571afc2b85cf9074bca9e","subject":"Merge \"Force amp-agent communication to TLSv1.2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/59660fb3650d3729375571afc2b85cf9074bca9e"}]}],"author":{"name":"Sven Wegener","email":"sven.wegener@inovex.de","date":"2018-12-19 12:09:56.000000000","tz":60},"committer":{"name":"Sven Wegener","email":"sven.wegener@inovex.de","date":"2019-06-05 07:25:57.000000000","tz":120},"subject":"neutron: Update security groups","message":"neutron: Update security groups\n\nThe security group can be used to give the loadbalancer access to the\nconfigured members. The security group is only usable for the tenant if\nit is placed into the tenant project. The port already exists in the\ntenant project and you can extract the security group id from it.\n\nAlso we should restrict loadbalancer-internal communication (e.g. VRRP)\nto the loadbalancer security to avoid any other traffic from influencing\nthe failover.\n\nChange-Id: I01c343466913abda9b0ac0c1cd9746430eb78dd4\nSigned-off-by: Sven Wegener \u003csven.wegener@inovex.de\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/86acb3546a72cbf3ee934fcb7dc6c54886f2e15b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/86acb3546a72cbf3ee934fcb7dc6c54886f2e15b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}