)]}'
{"octavia/api/drivers/amphora_driver/v2/driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e9c020cc97ccb31aeec446fb9c1eb7973348b844","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        if new_pool.lb_algorithm:"},{"line_number":184,"context_line":"            self._validate_pool_algorithm(new_pool)"},{"line_number":185,"context_line":"        pool_dict \u003d self._pool_convert_to_dict(new_pool)"},{"line_number":186,"context_line":"        pool_dict.pop(\u0027pool_id\u0027)"},{"line_number":187,"context_line":"        payload \u003d {consts.ORIGINAL_POOL: old_pool.to_dict(),"},{"line_number":188,"context_line":"                   consts.POOL_UPDATES: pool_dict}"},{"line_number":189,"context_line":"        self.client.cast({}, \u0027update_pool\u0027, **payload)"}],"source_content_type":"text/x-python","patch_set":26,"id":"3fa7e38b_70b5e431","line":186,"updated":"2019-12-03 16:59:05.000000000","message":"Why are we popping out the ID?","commit_id":"3c6cbc8b2643751385b937464961cec5e5ff4481"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"aa28d80c2d1f5a03ce3133edacee43035dfe22f4","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        if new_pool.lb_algorithm:"},{"line_number":184,"context_line":"            self._validate_pool_algorithm(new_pool)"},{"line_number":185,"context_line":"        pool_dict \u003d self._pool_convert_to_dict(new_pool)"},{"line_number":186,"context_line":"        pool_dict.pop(\u0027pool_id\u0027)"},{"line_number":187,"context_line":"        payload \u003d {consts.ORIGINAL_POOL: old_pool.to_dict(),"},{"line_number":188,"context_line":"                   consts.POOL_UPDATES: pool_dict}"},{"line_number":189,"context_line":"        self.client.cast({}, \u0027update_pool\u0027, **payload)"}],"source_content_type":"text/x-python","patch_set":26,"id":"3fa7e38b_339e9669","line":186,"in_reply_to":"3fa7e38b_70b5e431","updated":"2019-12-03 18:05:11.000000000","message":"OK I get it, thanks :D\nIt\u0027s in here as pool_id but it\u0027d really just be \"id\", so \"pool_id\" is wrong here, and we get the ID from the updates dict anyway.","commit_id":"3c6cbc8b2643751385b937464961cec5e5ff4481"}],"octavia/controller/worker/v2/controller_worker.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"468a4ab030276598a7b4870d271dc47cb1b7e40d","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    def update_pool(self, origin_pool, pool_updates):"},{"line_number":610,"context_line":"        \"\"\"Updates a node pool."},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        :param pool: Provider pool dict to update"},{"line_number":613,"context_line":"        :param pool_updates: Dict containing updated pool attributes"},{"line_number":614,"context_line":"        :returns: None"},{"line_number":615,"context_line":"        :raises PoolNotFound: The referenced pool was not found"}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_09abe2d5","line":612,"range":{"start_line":612,"start_character":15,"end_line":612,"end_character":19},"updated":"2019-10-29 18:24:14.000000000","message":"s/origin_pool, or can just change name of arg to pool?","commit_id":"04f3936cf6a28eecd19f5c3dab9f48f6f102724d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"23b3a685d0fa7cf0d46209e742f2f4b858744bb3","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    def update_pool(self, origin_pool, pool_updates):"},{"line_number":610,"context_line":"        \"\"\"Updates a node pool."},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        :param pool: Provider pool dict to update"},{"line_number":613,"context_line":"        :param pool_updates: Dict containing updated pool attributes"},{"line_number":614,"context_line":"        :returns: None"},{"line_number":615,"context_line":"        :raises PoolNotFound: The referenced pool was not found"}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_598e6c2e","line":612,"range":{"start_line":612,"start_character":15,"end_line":612,"end_character":19},"in_reply_to":"3fa7e38b_09abe2d5","updated":"2019-10-31 10:37:06.000000000","message":"Done","commit_id":"04f3936cf6a28eecd19f5c3dab9f48f6f102724d"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"727825c484dcf466863c773f995cba2879a5b5ec","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        # TODO(ataraday) It seems we need to get db pool here anyway to get"},{"line_number":536,"context_line":"        # proper listeners"},{"line_number":537,"context_line":"        db_pool \u003d self._pool_repo.get(db_apis.get_session(),"},{"line_number":538,"context_line":"                                      id\u003dpool[\u0027pool_id\u0027])"},{"line_number":539,"context_line":"        if not db_pool:"},{"line_number":540,"context_line":"            LOG.warning(\u0027Failed to fetch %s %s from DB. Retrying for up to \u0027"},{"line_number":541,"context_line":"                        \u002760 seconds.\u0027, \u0027pool\u0027, pool[\u0027pool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_c7751502","line":538,"range":{"start_line":538,"start_character":46,"end_line":538,"end_character":55},"updated":"2019-12-02 17:35:50.000000000","message":"constant?","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5e0552f8c7d8b986c9dad747744596060ec0895f","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        # TODO(ataraday) It seems we need to get db pool here anyway to get"},{"line_number":536,"context_line":"        # proper listeners"},{"line_number":537,"context_line":"        db_pool \u003d self._pool_repo.get(db_apis.get_session(),"},{"line_number":538,"context_line":"                                      id\u003dpool[\u0027pool_id\u0027])"},{"line_number":539,"context_line":"        if not db_pool:"},{"line_number":540,"context_line":"            LOG.warning(\u0027Failed to fetch %s %s from DB. Retrying for up to \u0027"},{"line_number":541,"context_line":"                        \u002760 seconds.\u0027, \u0027pool\u0027, pool[\u0027pool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_c1641eb6","line":538,"range":{"start_line":538,"start_character":46,"end_line":538,"end_character":55},"in_reply_to":"3fa7e38b_c7751502","updated":"2019-12-02 22:04:38.000000000","message":"Done","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"727825c484dcf466863c773f995cba2879a5b5ec","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                                      id\u003dpool[\u0027pool_id\u0027])"},{"line_number":539,"context_line":"        if not db_pool:"},{"line_number":540,"context_line":"            LOG.warning(\u0027Failed to fetch %s %s from DB. Retrying for up to \u0027"},{"line_number":541,"context_line":"                        \u002760 seconds.\u0027, \u0027pool\u0027, pool[\u0027pool_id\u0027])"},{"line_number":542,"context_line":"            raise db_exceptions.NoResultFound"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        load_balancer \u003d db_pool.load_balancer"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_877f1dde","line":541,"range":{"start_line":541,"start_character":52,"end_line":541,"end_character":61},"updated":"2019-12-02 17:35:50.000000000","message":"constant?","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5e0552f8c7d8b986c9dad747744596060ec0895f","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                                      id\u003dpool[\u0027pool_id\u0027])"},{"line_number":539,"context_line":"        if not db_pool:"},{"line_number":540,"context_line":"            LOG.warning(\u0027Failed to fetch %s %s from DB. Retrying for up to \u0027"},{"line_number":541,"context_line":"                        \u002760 seconds.\u0027, \u0027pool\u0027, pool[\u0027pool_id\u0027])"},{"line_number":542,"context_line":"            raise db_exceptions.NoResultFound"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        load_balancer \u003d db_pool.load_balancer"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_6101aab5","line":541,"range":{"start_line":541,"start_character":52,"end_line":541,"end_character":61},"in_reply_to":"3fa7e38b_877f1dde","updated":"2019-12-02 22:04:38.000000000","message":"Done","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"727825c484dcf466863c773f995cba2879a5b5ec","unresolved":false,"context_lines":[{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        create_pool_tf \u003d self._taskflow_load("},{"line_number":550,"context_line":"            self._pool_flows.get_create_pool_flow(),"},{"line_number":551,"context_line":"            store\u003d{constants.POOL_ID: pool[\u0027pool_id\u0027],"},{"line_number":552,"context_line":"                   constants.LISTENERS: listeners_dicts,"},{"line_number":553,"context_line":"                   constants.LOADBALANCER_ID: load_balancer.id,"},{"line_number":554,"context_line":"                   constants.LOADBALANCER: load_balancer})"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_47692524","line":551,"range":{"start_line":551,"start_character":43,"end_line":551,"end_character":52},"updated":"2019-12-02 17:35:50.000000000","message":"constant?","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5e0552f8c7d8b986c9dad747744596060ec0895f","unresolved":false,"context_lines":[{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        create_pool_tf \u003d self._taskflow_load("},{"line_number":550,"context_line":"            self._pool_flows.get_create_pool_flow(),"},{"line_number":551,"context_line":"            store\u003d{constants.POOL_ID: pool[\u0027pool_id\u0027],"},{"line_number":552,"context_line":"                   constants.LISTENERS: listeners_dicts,"},{"line_number":553,"context_line":"                   constants.LOADBALANCER_ID: load_balancer.id,"},{"line_number":554,"context_line":"                   constants.LOADBALANCER: load_balancer})"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_8104e6c6","line":551,"range":{"start_line":551,"start_character":43,"end_line":551,"end_character":52},"in_reply_to":"3fa7e38b_47692524","updated":"2019-12-02 22:04:38.000000000","message":"Done","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"727825c484dcf466863c773f995cba2879a5b5ec","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        :raises PoolNotFound: The referenced pool was not found"},{"line_number":565,"context_line":"        \"\"\""},{"line_number":566,"context_line":"        db_pool \u003d self._pool_repo.get(db_apis.get_session(),"},{"line_number":567,"context_line":"                                      id\u003dpool[\u0027pool_id\u0027])"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        listeners_dicts \u003d provider_utils.db_listeners_to_provider_dict_list("},{"line_number":570,"context_line":"            db_pool.listeners)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_6764614e","line":567,"range":{"start_line":567,"start_character":46,"end_line":567,"end_character":55},"updated":"2019-12-02 17:35:50.000000000","message":"constant?","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5e0552f8c7d8b986c9dad747744596060ec0895f","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        :raises PoolNotFound: The referenced pool was not found"},{"line_number":565,"context_line":"        \"\"\""},{"line_number":566,"context_line":"        db_pool \u003d self._pool_repo.get(db_apis.get_session(),"},{"line_number":567,"context_line":"                                      id\u003dpool[\u0027pool_id\u0027])"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        listeners_dicts \u003d provider_utils.db_listeners_to_provider_dict_list("},{"line_number":570,"context_line":"            db_pool.listeners)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_210bb2d5","line":567,"range":{"start_line":567,"start_character":46,"end_line":567,"end_character":55},"in_reply_to":"3fa7e38b_6764614e","updated":"2019-12-02 22:04:38.000000000","message":"Done","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"727825c484dcf466863c773f995cba2879a5b5ec","unresolved":false,"context_lines":[{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        delete_pool_tf \u003d self._taskflow_load("},{"line_number":574,"context_line":"            self._pool_flows.get_delete_pool_flow(),"},{"line_number":575,"context_line":"            store\u003d{constants.POOL_ID: pool[\u0027pool_id\u0027],"},{"line_number":576,"context_line":"                   constants.LISTENERS: listeners_dicts,"},{"line_number":577,"context_line":"                   constants.LOADBALANCER: load_balancer,"},{"line_number":578,"context_line":"                   constants.LOADBALANCER_ID: load_balancer.id,"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_07732d18","line":575,"range":{"start_line":575,"start_character":43,"end_line":575,"end_character":52},"updated":"2019-12-02 17:35:50.000000000","message":"constant?","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5e0552f8c7d8b986c9dad747744596060ec0895f","unresolved":false,"context_lines":[{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        delete_pool_tf \u003d self._taskflow_load("},{"line_number":574,"context_line":"            self._pool_flows.get_delete_pool_flow(),"},{"line_number":575,"context_line":"            store\u003d{constants.POOL_ID: pool[\u0027pool_id\u0027],"},{"line_number":576,"context_line":"                   constants.LISTENERS: listeners_dicts,"},{"line_number":577,"context_line":"                   constants.LOADBALANCER: load_balancer,"},{"line_number":578,"context_line":"                   constants.LOADBALANCER_ID: load_balancer.id,"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_410eeee4","line":575,"range":{"start_line":575,"start_character":43,"end_line":575,"end_character":52},"in_reply_to":"3fa7e38b_07732d18","updated":"2019-12-02 22:04:38.000000000","message":"Done","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"727825c484dcf466863c773f995cba2879a5b5ec","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        \"\"\""},{"line_number":592,"context_line":"        try:"},{"line_number":593,"context_line":"            db_pool \u003d self._get_db_obj_until_pending_update("},{"line_number":594,"context_line":"                self._pool_repo, origin_pool[\u0027pool_id\u0027])"},{"line_number":595,"context_line":"        except tenacity.RetryError as e:"},{"line_number":596,"context_line":"            LOG.warning(\u0027Pool did not go into %s in 60 seconds. \u0027"},{"line_number":597,"context_line":"                        \u0027This either due to an in-progress Octavia upgrade \u0027"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_c75e7578","line":594,"range":{"start_line":594,"start_character":45,"end_line":594,"end_character":54},"updated":"2019-12-02 17:35:50.000000000","message":"constant?","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5e0552f8c7d8b986c9dad747744596060ec0895f","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        \"\"\""},{"line_number":592,"context_line":"        try:"},{"line_number":593,"context_line":"            db_pool \u003d self._get_db_obj_until_pending_update("},{"line_number":594,"context_line":"                self._pool_repo, origin_pool[\u0027pool_id\u0027])"},{"line_number":595,"context_line":"        except tenacity.RetryError as e:"},{"line_number":596,"context_line":"            LOG.warning(\u0027Pool did not go into %s in 60 seconds. \u0027"},{"line_number":597,"context_line":"                        \u0027This either due to an in-progress Octavia upgrade \u0027"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_e1f4bad2","line":594,"range":{"start_line":594,"start_character":45,"end_line":594,"end_character":54},"in_reply_to":"3fa7e38b_c75e7578","updated":"2019-12-02 22:04:38.000000000","message":"Done","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4b66524fcc6781592e2fa3eaa8f7c8e952e7a8a0","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        :raises NoResultFound: Unable to find the object"},{"line_number":540,"context_line":"        \"\"\""},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        # TODO(ataraday) It seems we need to get db pool here anyway to get"},{"line_number":543,"context_line":"        # proper listeners"},{"line_number":544,"context_line":"        db_pool \u003d self._pool_repo.get(db_apis.get_session(),"},{"line_number":545,"context_line":"                                      id\u003dpool[constants.POOL_ID])"}],"source_content_type":"text/x-python","patch_set":27,"id":"3fa7e38b_9f6e6b2a","line":542,"updated":"2019-12-03 22:29:58.000000000","message":"nit: This comment can probably be removed, I think it is true.","commit_id":"b9e74630a6c3ee31f072928e7cb56e8203f60012"}],"octavia/controller/worker/v2/tasks/database_tasks.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"468a4ab030276598a7b4870d271dc47cb1b7e40d","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    def execute(self, pool_id):"},{"line_number":276,"context_line":"        \"\"\"Delete the pool in DB"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        :param pool: The pool to be deleted"},{"line_number":279,"context_line":"        :returns: None"},{"line_number":280,"context_line":"        \"\"\""},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_a9688e87","line":278,"range":{"start_line":278,"start_character":15,"end_line":278,"end_character":19},"updated":"2019-10-29 18:24:14.000000000","message":"a/pool_id\n\nsame below in a number of places","commit_id":"04f3936cf6a28eecd19f5c3dab9f48f6f102724d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"23b3a685d0fa7cf0d46209e742f2f4b858744bb3","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    def execute(self, pool_id):"},{"line_number":276,"context_line":"        \"\"\"Delete the pool in DB"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        :param pool: The pool to be deleted"},{"line_number":279,"context_line":"        :returns: None"},{"line_number":280,"context_line":"        \"\"\""},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_592f4cf5","line":278,"range":{"start_line":278,"start_character":15,"end_line":278,"end_character":19},"in_reply_to":"3fa7e38b_a9688e87","updated":"2019-10-31 10:37:06.000000000","message":"Done","commit_id":"04f3936cf6a28eecd19f5c3dab9f48f6f102724d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"468a4ab030276598a7b4870d271dc47cb1b7e40d","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            self.pool_repo.update(db_apis.get_session(), pool_id,"},{"line_number":295,"context_line":"                                  provisioning_status\u003dconstants.ERROR)"},{"line_number":296,"context_line":"        except Exception as e:"},{"line_number":297,"context_line":"            LOG.error(\"Failed to update pool %(pool)s \""},{"line_number":298,"context_line":"                      \"provisioning_status to ERROR due to: %(except)s\","},{"line_number":299,"context_line":"                      {\u0027pool\u0027: pool_id, \u0027except\u0027: e})"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_490f9adf","line":297,"range":{"start_line":297,"start_character":40,"end_line":297,"end_character":44},"updated":"2019-10-29 18:24:14.000000000","message":"nit: s/pool id","commit_id":"04f3936cf6a28eecd19f5c3dab9f48f6f102724d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"23b3a685d0fa7cf0d46209e742f2f4b858744bb3","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            self.pool_repo.update(db_apis.get_session(), pool_id,"},{"line_number":295,"context_line":"                                  provisioning_status\u003dconstants.ERROR)"},{"line_number":296,"context_line":"        except Exception as e:"},{"line_number":297,"context_line":"            LOG.error(\"Failed to update pool %(pool)s \""},{"line_number":298,"context_line":"                      \"provisioning_status to ERROR due to: %(except)s\","},{"line_number":299,"context_line":"                      {\u0027pool\u0027: pool_id, \u0027except\u0027: e})"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_f931585a","line":297,"range":{"start_line":297,"start_character":40,"end_line":297,"end_character":44},"in_reply_to":"3fa7e38b_490f9adf","updated":"2019-10-31 10:37:06.000000000","message":"Done","commit_id":"04f3936cf6a28eecd19f5c3dab9f48f6f102724d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"468a4ab030276598a7b4870d271dc47cb1b7e40d","unresolved":false,"context_lines":[{"line_number":1516,"context_line":"                db_apis.get_session(), pool_id,"},{"line_number":1517,"context_line":"                dict(provisioning_status\u003dconstants.ERROR))"},{"line_number":1518,"context_line":"        except Exception as e:"},{"line_number":1519,"context_line":"            LOG.error(\"Failed to update pool %(pool)s provisioning_status to \""},{"line_number":1520,"context_line":"                      \"ERROR due to: %(except)s\", {\u0027pool\u0027: pool_id,"},{"line_number":1521,"context_line":"                                                   \u0027except\u0027: e})"},{"line_number":1522,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_29233e5a","line":1519,"range":{"start_line":1519,"start_character":40,"end_line":1519,"end_character":44},"updated":"2019-10-29 18:24:14.000000000","message":"nit: s/pool id","commit_id":"04f3936cf6a28eecd19f5c3dab9f48f6f102724d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"468a4ab030276598a7b4870d271dc47cb1b7e40d","unresolved":false,"context_lines":[{"line_number":2627,"context_line":"    def execute(self, project_id, pool_child_count):"},{"line_number":2628,"context_line":"        \"\"\"Decrements the pool quota."},{"line_number":2629,"context_line":""},{"line_number":2630,"context_line":"        :param pool: The pool to decrement the quota on"},{"line_number":2631,"context_line":"        :returns: None"},{"line_number":2632,"context_line":"        \"\"\""},{"line_number":2633,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_e920c64b","line":2630,"range":{"start_line":2630,"start_character":15,"end_line":2630,"end_character":19},"updated":"2019-10-29 18:24:14.000000000","message":"s/project_id","commit_id":"04f3936cf6a28eecd19f5c3dab9f48f6f102724d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"23b3a685d0fa7cf0d46209e742f2f4b858744bb3","unresolved":false,"context_lines":[{"line_number":2627,"context_line":"    def execute(self, project_id, pool_child_count):"},{"line_number":2628,"context_line":"        \"\"\"Decrements the pool quota."},{"line_number":2629,"context_line":""},{"line_number":2630,"context_line":"        :param pool: The pool to decrement the quota on"},{"line_number":2631,"context_line":"        :returns: None"},{"line_number":2632,"context_line":"        \"\"\""},{"line_number":2633,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_f97f18dc","line":2630,"range":{"start_line":2630,"start_character":15,"end_line":2630,"end_character":19},"in_reply_to":"3fa7e38b_e920c64b","updated":"2019-10-31 10:37:06.000000000","message":"Done","commit_id":"04f3936cf6a28eecd19f5c3dab9f48f6f102724d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0dfba162b870aaa283a08ab528f4917bb1b42e96","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        :returns: None"},{"line_number":281,"context_line":"        \"\"\""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        LOG.debug(\"Delete in DB for pool id: %s \", pool_id)"},{"line_number":284,"context_line":"        self.pool_repo.delete(db_apis.get_session(), id\u003dpool_id)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def revert(self, pool_id, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":26,"id":"3fa7e38b_e765aae3","line":283,"range":{"start_line":283,"start_character":47,"end_line":283,"end_character":48},"updated":"2019-12-03 01:12:09.000000000","message":"super nit: blank space","commit_id":"3c6cbc8b2643751385b937464961cec5e5ff4481"}],"octavia/tests/unit/controller/queue/v2/test_endpoints.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"727825c484dcf466863c773f995cba2879a5b5ec","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.context \u003d {}"},{"line_number":38,"context_line":"        self.resource_updates \u003d {}"},{"line_number":39,"context_line":"        self.resource_id \u003d 1234"},{"line_number":40,"context_line":"        self.resource \u003d {\u0027id\u0027: self.resource_id}"},{"line_number":41,"context_line":"        self.server_group_id \u003d 3456"},{"line_number":42,"context_line":"        self.listener_dict \u003d {\u0027id\u0027: uuidutils.generate_uuid()}"},{"line_number":43,"context_line":"        self.flavor_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_6780e19d","line":40,"range":{"start_line":40,"start_character":25,"end_line":40,"end_character":29},"updated":"2019-12-02 17:35:50.000000000","message":"... technically could be a constant :D","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5e0552f8c7d8b986c9dad747744596060ec0895f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.context \u003d {}"},{"line_number":38,"context_line":"        self.resource_updates \u003d {}"},{"line_number":39,"context_line":"        self.resource_id \u003d 1234"},{"line_number":40,"context_line":"        self.resource \u003d {\u0027id\u0027: self.resource_id}"},{"line_number":41,"context_line":"        self.server_group_id \u003d 3456"},{"line_number":42,"context_line":"        self.listener_dict \u003d {\u0027id\u0027: uuidutils.generate_uuid()}"},{"line_number":43,"context_line":"        self.flavor_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_0119d621","line":40,"range":{"start_line":40,"start_character":25,"end_line":40,"end_character":29},"in_reply_to":"3fa7e38b_6780e19d","updated":"2019-12-02 22:04:38.000000000","message":"Hm... actually there is a lot of places where we have \u0027id\u0027...Will rereview plevious change for this as well","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"727825c484dcf466863c773f995cba2879a5b5ec","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.resource_id \u003d 1234"},{"line_number":40,"context_line":"        self.resource \u003d {\u0027id\u0027: self.resource_id}"},{"line_number":41,"context_line":"        self.server_group_id \u003d 3456"},{"line_number":42,"context_line":"        self.listener_dict \u003d {\u0027id\u0027: uuidutils.generate_uuid()}"},{"line_number":43,"context_line":"        self.flavor_id \u003d uuidutils.generate_uuid()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_create_load_balancer(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_278ae9bb","line":42,"updated":"2019-12-02 17:35:50.000000000","message":"though we didn\u0027t do it here, but they both could","commit_id":"09e01e8f60509a57b18f1ad09542767587bc9f41"}]}