)]}'
{"octavia/controller/worker/v1/controller_worker.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9ebdfb3a67c24dad5e8d15e412a50fc237b68da7","unresolved":false,"context_lines":[{"line_number":803,"context_line":"                         constants.BUILD_TYPE_PRIORITY: priority, }"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        LOG.info(\"Perform failover for an amphora: %s\","},{"line_number":806,"context_line":"                 {\"id\": amp.id,"},{"line_number":807,"context_line":"                  \"load_balancer_id\": amp.load_balancer_id,"},{"line_number":808,"context_line":"                  \"lb_network_ip\": amp.lb_network_ip,"},{"line_number":809,"context_line":"                  \"compute_id\": amp.compute_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_594cd3c6","line":806,"updated":"2019-07-05 17:34:07.000000000","message":"Nit: maybe we want to log additional info debug to not burden the logging system?","commit_id":"b90a1aa36368031bac77e748b1224b753aba2035"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"56f2e35aa814112a4d496f438e197aafa08e680a","unresolved":false,"context_lines":[{"line_number":803,"context_line":"                         constants.BUILD_TYPE_PRIORITY: priority, }"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        LOG.info(\"Perform failover for an amphora: %s\","},{"line_number":806,"context_line":"                 {\"id\": amp.id,"},{"line_number":807,"context_line":"                  \"load_balancer_id\": amp.load_balancer_id,"},{"line_number":808,"context_line":"                  \"lb_network_ip\": amp.lb_network_ip,"},{"line_number":809,"context_line":"                  \"compute_id\": amp.compute_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_1cd8547d","line":806,"in_reply_to":"7faddb67_594cd3c6","updated":"2019-07-10 06:36:14.000000000","message":"+1","commit_id":"b90a1aa36368031bac77e748b1224b753aba2035"}],"octavia/controller/worker/v2/controller_worker.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"597148b9e290d2180351214c3582188187683626","unresolved":false,"context_lines":[{"line_number":807,"context_line":"                  \"load_balancer_id\": amp.load_balancer_id,"},{"line_number":808,"context_line":"                  \"lb_network_ip\": amp.lb_network_ip,"},{"line_number":809,"context_line":"                  \"compute_id\": amp.compute_id,"},{"line_number":810,"context_line":"                  \"role\": amp.role})"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"        if amp.status \u003d\u003d constants.DELETED:"},{"line_number":813,"context_line":"            LOG.warning(\u0027Amphora %s is marked DELETED in the database but \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_6185d159","line":810,"updated":"2019-07-15 16:05:39.000000000","message":"Role should be removed. This is a configuration setting and not a status field. It has zero reflection on what status the amphora was/is in at the time of failover.","commit_id":"10f7b1eda2954a8cb39e848e67e146abf2722fd0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d1e590b04537433429773f99bda69a4341076c39","unresolved":false,"context_lines":[{"line_number":807,"context_line":"                  \"load_balancer_id\": amp.load_balancer_id,"},{"line_number":808,"context_line":"                  \"lb_network_ip\": amp.lb_network_ip,"},{"line_number":809,"context_line":"                  \"compute_id\": amp.compute_id,"},{"line_number":810,"context_line":"                  \"role\": amp.role})"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"        if amp.status \u003d\u003d constants.DELETED:"},{"line_number":813,"context_line":"            LOG.warning(\u0027Amphora %s is marked DELETED in the database but \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_9e0c7c3c","line":810,"in_reply_to":"7faddb67_6185d159","updated":"2019-07-23 08:16:00.000000000","message":"Eh, not *exactly*? I mean, at least it\u0027s a nice shortcut to know what topo it was, and which of the two amps supposedly went down. So, for scanning, you can see \"ah, the BACKUP is consistently recycling\". I don\u0027t think it\u0027s especially harmful at least.","commit_id":"10f7b1eda2954a8cb39e848e67e146abf2722fd0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"96e8cd3a7cc0c1cef4b29a134354de6c76a56de8","unresolved":false,"context_lines":[{"line_number":807,"context_line":"                  \"load_balancer_id\": amp.load_balancer_id,"},{"line_number":808,"context_line":"                  \"lb_network_ip\": amp.lb_network_ip,"},{"line_number":809,"context_line":"                  \"compute_id\": amp.compute_id,"},{"line_number":810,"context_line":"                  \"role\": amp.role})"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"        if amp.status \u003d\u003d constants.DELETED:"},{"line_number":813,"context_line":"            LOG.warning(\u0027Amphora %s is marked DELETED in the database but \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_94253bae","line":810,"in_reply_to":"7faddb67_9e0c7c3c","updated":"2019-07-23 10:17:15.000000000","message":"I agree with Michael -- it does not necessarily reflect the status of the amps, and perhaps ROLE data is also misleading Noboru into thinking it reflects the actual status of the amp. Slipping the DB role in this log message would only make it worst to mortal operators :)","commit_id":"10f7b1eda2954a8cb39e848e67e146abf2722fd0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"597148b9e290d2180351214c3582188187683626","unresolved":false,"context_lines":[{"line_number":850,"context_line":"                  \"load_balancer_id\": amp.load_balancer_id,"},{"line_number":851,"context_line":"                  \"lb_network_ip\": amp.lb_network_ip,"},{"line_number":852,"context_line":"                  \"compute_id\": amp.compute_id,"},{"line_number":853,"context_line":"                  \"role\": amp.role})"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    def failover_amphora(self, amphora_id):"},{"line_number":856,"context_line":"        \"\"\"Perform failover operations for an amphora."}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_818a4d67","line":853,"updated":"2019-07-15 16:05:39.000000000","message":"Role should be removed. This is a configuration setting and not a status field. It has zero reflection on what status the amphora was/is in at the time of failover.","commit_id":"10f7b1eda2954a8cb39e848e67e146abf2722fd0"}]}